@growthagent/ci 0.3.0 → 0.5.0

package/dist/cli.js

@@ -2,8 +2,8 @@
 
 // src/cli.ts
 import { execFileSync, spawnSync } from "node:child_process";
-import { cpSync, existsSync as existsSync2, mkdirSync, readFileSync, writeFileSync } from "node:fs";
-import path4 from "node:path";
+import { cpSync, existsSync as existsSync2, mkdirSync, readFileSync, writeFileSync as writeFileSync2 } from "node:fs";
+import path5 from "node:path";
 import { fileURLToPath } from "node:url";
 
 // ../github/src/app.ts
@@ -100,6 +100,7 @@ var FORBIDDEN_PATTERNS = [
   { pattern: /^\.github\//i, why: "workflow and CI configuration" },
   { pattern: /^\.git(\/|$)/i, why: "git internals" },
   { pattern: /(^|\/)\.env(\.|$)/i, why: "environment files" },
+  // except the examples below
   { pattern: /(^|\/)\.npmrc$|(^|\/)\.yarnrc(\.yml)?$|(^|\/)\.pypirc$/i, why: "registry credentials" },
   { pattern: /(^|\/)(package-lock\.json|pnpm-lock\.yaml|yarn\.lock|bun\.lockb?|Cargo\.lock|poetry\.lock|Gemfile\.lock|composer\.lock)$/i, why: "dependency lockfiles" },
   { pattern: /(^|\/)(Dockerfile|docker-compose\.ya?ml|Procfile)$/i, why: "build and deployment configuration" },
@@ -111,6 +112,44 @@ var FORBIDDEN_PATTERNS = [
   { pattern: /\.(pem|p12|pfx|key|keystore|jks)$/i, why: "key material" },
   { pattern: /(^|\/)node_modules\//i, why: "installed dependencies" }
 ];
+var EXAMPLE_ENV = /(^|\/)\.env(\.[\w-]+)*\.(example|sample|template)$/i;
+var CREDENTIAL_PREFIXES = [
+  "sk-",
+  "sk_live",
+  "sk_test",
+  "pk_live",
+  "rk_live",
+  "whsec_",
+  "phc_",
+  "ghp_",
+  "gho_",
+  "ghs_",
+  "github_pat_",
+  "AKIA",
+  "AIza",
+  "xox",
+  "eyJ",
+  "-----BEGIN"
+];
+function secretishEnvLine(line) {
+  const text = line.trim();
+  if (!text || text.startsWith("#")) return null;
+  const eq = text.indexOf("=");
+  if (eq < 0) return null;
+  const key = text.slice(0, eq).replace(/^export\s+/, "").trim();
+  const value = text.slice(eq + 1).trim().replace(/^["']|["']$/g, "").trim();
+  if (!value) return null;
+  if (/^https?:\/\//i.test(value)) return null;
+  for (const prefix of CREDENTIAL_PREFIXES) {
+    if (value.startsWith(prefix)) {
+      return `${key} carries what looks like a real credential`;
+    }
+  }
+  if (value.length >= 20 && /^[A-Za-z0-9_\-.]+$/.test(value)) {
+    return `${key} carries a ${value.length}-character opaque value, not a placeholder`;
+  }
+  return null;
+}
 var SYMLINK_MODE = "120000";
 var EXECUTABLE_MODE = "100755";
 function parsePatch(patch) {
@@ -183,6 +222,7 @@ function forbiddenReason(filePath) {
     return "an absolute path";
   }
   if (normalised.split("/").includes("..")) return "a parent-directory escape";
+  if (EXAMPLE_ENV.test(normalised)) return null;
   for (const { pattern, why } of FORBIDDEN_PATTERNS) {
     if (pattern.test(normalised)) return why;
   }
@@ -210,6 +250,20 @@ function validatePatch(patch, limits = DEFAULT_PATCH_LIMITS) {
         return { ok: false, reason: `the patch changes ${candidate}, which is ${why} \u2014 never modifiable by the agent` };
       }
     }
+    if (EXAMPLE_ENV.test(file.path)) {
+      if (file.addedLines > file.added.length) {
+        return {
+          ok: false,
+          reason: `the patch adds ${file.addedLines} lines to ${file.path}, more than can be checked for credentials`
+        };
+      }
+      for (const line of file.added) {
+        const why = secretishEnvLine(line);
+        if (why) {
+          return { ok: false, reason: `the patch writes a secret into ${file.path}: ${why}` };
+        }
+      }
+    }
     if (/(^|\/)package\.json$/i.test(file.path)) {
       const why = manifestChangeReason(file);
       if (why) {
@@ -235,6 +289,28 @@ function validatePatch(patch, limits = DEFAULT_PATCH_LIMITS) {
   return { ok: true, report: { files, bytes, addedLines } };
 }
 
+// src/provider-config.ts
+import { mkdtempSync as mkdtempSync2, writeFileSync } from "node:fs";
+import { tmpdir as tmpdir3 } from "node:os";
+import path4 from "node:path";
+var RUN_TOKEN_ENV = "GX_RUN_TOKEN";
+function writeGoogleProviderConfig(model) {
+  const gateway = (process.env.GX_GATEWAY_URL ?? "").replace(/\/$/, "");
+  const dir = mkdtempSync2(path4.join(tmpdir3(), "growth-agent-pi-"));
+  const config = {
+    providers: {
+      "growthagent-google": {
+        baseUrl: `${gateway}/v1beta`,
+        api: "google-generative-ai",
+        apiKey: `$${RUN_TOKEN_ENV}`,
+        models: [{ id: model, name: model, input: ["text"], contextWindow: 1e6 }]
+      }
+    }
+  };
+  writeFileSync(path4.join(dir, "models.json"), JSON.stringify(config, null, 2));
+  return dir;
+}
+
 // src/trust.ts
 var TRUSTED_APP_LOGIN = "growth-agent[bot]";
 function authorIsTrusted(issue, extraLogins = []) {
@@ -340,11 +416,11 @@ function buildPrompt(fields, briefing) {
 }
 
 // src/cli.ts
-var HERE = path4.dirname(fileURLToPath(import.meta.url));
+var HERE = path5.dirname(fileURLToPath(import.meta.url));
 var PATCH_FILE = "growth-agent.patch";
 function assetsDir() {
-  const packaged = path4.join(HERE, "assets", "skills");
-  return existsSync2(packaged) ? packaged : path4.join(HERE, "..", "assets", "skills");
+  const packaged = path5.join(HERE, "assets", "skills");
+  return existsSync2(packaged) ? packaged : path5.join(HERE, "..", "assets", "skills");
 }
 function sh(cmd, args, opts = {}) {
   const r = spawnSync(cmd, args, { encoding: "utf8", stdio: ["inherit", "pipe", "inherit"] });
@@ -452,20 +528,6 @@ async function openSession() {
     };
   }
 }
-function writeGoogleProviderConfig(piDir, model, runToken) {
-  const gateway = (process.env.GX_GATEWAY_URL ?? "").replace(/\/$/, "");
-  const config = {
-    providers: {
-      "growthagent-google": {
-        baseUrl: `${gateway}/v1beta`,
-        api: "google-generative-ai",
-        apiKey: runToken,
-        models: [{ id: model, name: model, input: ["text"], contextWindow: 1e6 }]
-      }
-    }
-  };
-  writeFileSync(path4.join(piDir, "..", "models.json"), JSON.stringify(config, null, 2));
-}
 async function implement() {
   const issue = readIssue();
   const refusal = refuseUntrustedAuthor(issue);
@@ -485,7 +547,7 @@ async function implement() {
   console.log(
     meta.kind === "instrumentation" ? `\u25B8 instrumentation request #${issue.number}` : `\u25B8 change request #${issue.number} \u2014 flag ${meta.flagKey} on ${meta.surface}`
   );
-  const skillsDir = path4.resolve(process.cwd(), ".pi", "skills");
+  const skillsDir = path5.resolve(process.cwd(), ".pi", "skills");
   mkdirSync(skillsDir, { recursive: true });
   cpSync(assetsDir(), skillsDir, { recursive: true });
   const prompt = buildPrompt(meta, extractBriefing(issue.body));
@@ -497,9 +559,7 @@ async function implement() {
     return 1;
   }
   const piProvider = provider === "google" ? "growthagent-google" : provider;
-  if (provider === "google") {
-    writeGoogleProviderConfig(skillsDir, model, session.token);
-  }
+  const piConfigDir = provider === "google" ? writeGoogleProviderConfig(model) : null;
   console.log(`\u25B8 running pi (${piProvider}/${model})`);
   let piStatus;
   try {
@@ -517,7 +577,9 @@ async function implement() {
           // environment, whatever else it might read there. Nor may a raw
           // provider key: everything is spent through the run token.
           GROWTH_AGENT_TOKEN: "",
-          GEMINI_API_KEY: ""
+          GEMINI_API_KEY: "",
+          // Only set for the Google path; pi keeps its own default otherwise.
+          ...piConfigDir ? { PI_CODING_AGENT_DIR: piConfigDir, [RUN_TOKEN_ENV]: session.token } : {}
         }
       }
     );
@@ -529,15 +591,16 @@ async function implement() {
     console.error("pi exited non-zero \u2014 no patch produced");
     return 1;
   }
-  sh("git", ["checkout", "--", ".pi"], { allowFail: true });
-  sh("git", ["clean", "-fd", ".pi"], { allowFail: true });
+  const piTracked = sh("git", ["ls-files", "--", ".pi"], { allowFail: true });
+  if (piTracked) sh("git", ["checkout", "--", ".pi"], { allowFail: true });
+  sh("git", ["clean", "-fdq", ".pi"], { allowFail: true });
   sh("git", ["add", "-A"]);
   const patch = sh("git", ["diff", "--staged"]);
   if (!patch.trim()) {
     console.error("pi made no changes \u2014 nothing to open a PR for");
     return 2;
   }
-  writeFileSync(PATCH_FILE, patch + "\n", "utf8");
+  writeFileSync2(PATCH_FILE, patch + "\n", "utf8");
   const verdict = validatePatch(patch);
   if (!verdict.ok) {
     console.error(`The produced patch was refused: ${verdict.reason}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@growthagent/ci",
-  "version": "0.3.0",
+  "version": "0.5.0",
   "private": false,
   "type": "module",
   "bin": {