@growth-labs/cms 0.4.0 → 0.5.0

package/src/routes/content.ts

@@ -22,6 +22,7 @@ import {
 	applyFoundryCallback,
 	type DispatchResult,
 	dispatchToFoundry,
+	FoundryDispatchPrerequisiteError,
 	type ProcessingState,
 	verifyHmac,
 } from '../engine/foundry-dispatch.js'
@@ -37,6 +38,7 @@ import {
 	scheduleContent,
 	unpublishContent,
 	updateContentItem,
+	VerifiedMediaDurationConflictError,
 } from '../engine/publisher.js'
 import {
 	createRevisionWithDelta,
@@ -55,6 +57,24 @@ import type { DispatchWebhookHook } from './webhooks.js'
 
 export type { DispatchWebhookHook }
 
+type PodcastFoundryReason = 'missing_duration' | 'dispatch_failed' | null
+
+interface PodcastFoundryAttempt {
+	result: DispatchResult | null
+	reason: PodcastFoundryReason
+}
+
+function verifiedMediaDurationConflictResponse(error: unknown): Response | null {
+	if (!(error instanceof VerifiedMediaDurationConflictError)) return null
+	return json(
+		{
+			error: 'Media duration conflicts with verified upload metadata',
+			reason: error.code,
+		},
+		409,
+	)
+}
+
 /**
  * Optional injected hook to dispatch article-takeaways generation to Foundry
  * (Hermes). The package never imports the Foundry glue — the site supplies this
@@ -260,7 +280,7 @@ function buildSchemas(resolved: ReturnType<typeof resolveConfig>) {
 			content: z.object({
 				script: z.string().default(''),
 				videoId: z.string().min(1),
-				durationSeconds: z.number().int().optional().nullable(),
+				durationSeconds: z.number().int().positive().optional().nullable(),
 				thumbnailImageId: z.string().optional().nullable(),
 				processingSourceUrl: z.string().url().optional().nullable(),
 				processingSourceKind: z.string().min(1).optional().nullable(),
@@ -275,7 +295,7 @@ function buildSchemas(resolved: ReturnType<typeof resolveConfig>) {
 				// the video `script` default-empty pattern above.
 				transcript: z.string().default(''),
 				audioR2Key: z.string().min(1),
-				durationSeconds: z.number().int().optional().nullable(),
+				durationSeconds: z.number().int().positive().optional().nullable(),
 			}),
 		}),
 		BaseSchema.extend({
@@ -334,7 +354,7 @@ const ArticleContentUpdateSchema = z.object({
 const VideoContentUpdateSchema = z.object({
 	script: z.string().optional(),
 	videoId: z.string().optional(),
-	durationSeconds: z.number().int().optional().nullable(),
+	durationSeconds: z.number().int().positive().optional().nullable(),
 	thumbnailImageId: z.string().optional().nullable(),
 	processingSourceUrl: z.string().url().optional().nullable(),
 	processingSourceKind: z.string().min(1).optional().nullable(),
@@ -343,7 +363,7 @@ const VideoContentUpdateSchema = z.object({
 const PodcastContentUpdateSchema = z.object({
 	transcript: z.string().optional(),
 	audioR2Key: z.string().optional(),
-	durationSeconds: z.number().int().optional().nullable(),
+	durationSeconds: z.number().int().positive().optional().nullable(),
 })
 
 function getContentUpdateSchema(type: string) {
@@ -692,6 +712,35 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 		return dispatchToFoundry(ctx.db, contentId, resolved.hooks.foundryVideo)
 	}
 
+	async function dispatchPodcastAfterSave(
+		ctx: RouteContext,
+		contentId: string,
+	): Promise<PodcastFoundryAttempt> {
+		try {
+			return {
+				result: await maybeDispatchPodcastToFoundry(ctx, contentId),
+				reason: null,
+			}
+		} catch (error) {
+			if (error instanceof FoundryDispatchPrerequisiteError) {
+				return { result: null, reason: 'missing_duration' }
+			}
+			console.error('Podcast Foundry dispatch failed after content save', error)
+			return { result: null, reason: 'dispatch_failed' }
+		}
+	}
+
+	function missingDurationResponse(): Response {
+		return json(
+			{
+				error: 'Content requires a positive finite duration before dispatch',
+				processingQueued: false,
+				reason: 'missing_duration',
+			},
+			409,
+		)
+	}
+
 	/**
 	 * Fire the optional dispatchWebhook hook for a lifecycle transition.
 	 *
@@ -973,9 +1022,18 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 				return json({ error: 'Invalid request', details: parsed.error.flatten() }, 400)
 			}
 
-			const created = await createContent(ctx.db, parsed.data)
-			const podcastDispatch =
-				parsed.data.type === 'podcast' ? await maybeDispatchPodcastToFoundry(ctx, created.id) : null
+			let created: Awaited<ReturnType<typeof createContent>>
+			try {
+				created = await createContent(ctx.db, parsed.data)
+			} catch (error) {
+				const conflict = verifiedMediaDurationConflictResponse(error)
+				if (conflict) return conflict
+				throw error
+			}
+			const podcastAttempt: PodcastFoundryAttempt =
+				parsed.data.type === 'podcast'
+					? await dispatchPodcastAfterSave(ctx, created.id)
+					: { result: null, reason: null }
 
 			// Fire content.created webhook (lifecycle transition).
 			await fireWebhook(ctx, 'content.created', {
@@ -988,8 +1046,9 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 				{
 					id: created.id,
 					slug: created.slug,
-					podcastFoundryQueued: Boolean(podcastDispatch),
-					podcastFoundryCorrelationId: podcastDispatch?.correlationId ?? null,
+					podcastFoundryQueued: Boolean(podcastAttempt.result),
+					podcastFoundryCorrelationId: podcastAttempt.result?.correlationId ?? null,
+					podcastFoundryReason: podcastAttempt.reason,
 				},
 				201,
 			)
@@ -1118,10 +1177,19 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 			}
 
 			const priorSlug = existing.slug
-			const updated = await updateContentItem(ctx.db, id, parsed.data)
+			let updated: Awaited<ReturnType<typeof updateContentItem>>
+			try {
+				updated = await updateContentItem(ctx.db, id, parsed.data)
+			} catch (error) {
+				const conflict = verifiedMediaDurationConflictResponse(error)
+				if (conflict) return conflict
+				throw error
+			}
 			if (!updated) return json({ error: 'Not found' }, 404)
-			const podcastDispatch =
-				existing.type === 'podcast' ? await maybeDispatchPodcastToFoundry(ctx, id) : null
+			const podcastAttempt: PodcastFoundryAttempt =
+				existing.type === 'podcast'
+					? await dispatchPodcastAfterSave(ctx, id)
+					: { result: null, reason: null }
 
 			// If the slug changed, record the old slug as a redirect (spec §8)
 			// and drop any stale redirect row for the now-live slug — atomically,
@@ -1133,8 +1201,9 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 			return json({
 				id,
 				slug: updated.slug,
-				podcastFoundryQueued: Boolean(podcastDispatch),
-				podcastFoundryCorrelationId: podcastDispatch?.correlationId ?? null,
+				podcastFoundryQueued: Boolean(podcastAttempt.result),
+				podcastFoundryCorrelationId: podcastAttempt.result?.correlationId ?? null,
+				podcastFoundryReason: podcastAttempt.reason,
 			})
 		},
 
@@ -1206,6 +1275,9 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 					try {
 						podcastDispatch = await maybeDispatchPodcastToFoundry(ctx, id)
 					} catch (error) {
+						if (error instanceof FoundryDispatchPrerequisiteError) {
+							return missingDurationResponse()
+						}
 						console.error('Podcast Foundry dispatch failed before publish', error)
 						return json({ error: 'Foundry dispatch failed' }, 502)
 					}
@@ -1488,6 +1560,9 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 						202,
 					)
 				} catch (error) {
+					if (error instanceof FoundryDispatchPrerequisiteError) {
+						return missingDurationResponse()
+					}
 					console.error('Foundry dispatch failed', error)
 					return json({ error: 'Foundry dispatch failed' }, 502)
 				}
@@ -1587,9 +1662,9 @@ export function createContentRoutes(config: ContentRouteConfig): ContentRouteHan
 			})
 
 			// Fire video.processed / video.failed webhook on terminal Foundry states.
-			if (nextState === 'ready') {
+			if (ok && nextState === 'ready') {
 				await fireWebhook(ctx, 'video.processed', { correlationId, eventId, eventKind })
-			} else if (nextState === 'failed') {
+			} else if (ok && nextState === 'failed') {
 				await fireWebhook(ctx, 'video.failed', {
 					correlationId,
 					eventId,

package/src/routes/context.ts

@@ -64,6 +64,7 @@ export interface R2MultipartUpload {
 
 export interface R2HeadResult {
 	size: number
+	customMetadata?: Record<string, string>
 }
 
 export interface R2BucketLike {

package/src/routes/media.ts

@@ -116,6 +116,7 @@ const initVideoUploadSchema = z.object({
 	fileName: z.string().min(1),
 	contentType: z.string().optional().nullable(),
 	sizeBytes: z.number().int().positive().max(MAX_EDITOR_VIDEO_SOURCE_BYTES),
+	durationSeconds: z.number().int().positive(),
 })
 
 const uploadedPartSchema = z.object({
@@ -130,6 +131,7 @@ const completeVideoUploadSchema = z.object({
 	fileName: z.string().min(1),
 	contentType: z.string().optional().nullable(),
 	sizeBytes: z.number().int().positive().max(MAX_EDITOR_VIDEO_SOURCE_BYTES),
+	durationSeconds: z.number().int().positive(),
 	parts: z.array(uploadedPartSchema).min(1).max(10_000),
 })
 
@@ -143,6 +145,7 @@ const initPodcastUploadSchema = z.object({
 	fileName: z.string().min(1),
 	contentType: z.string().optional().nullable(),
 	sizeBytes: z.number().int().positive().max(MAX_EDITOR_AUDIO_SOURCE_BYTES),
+	durationSeconds: z.number().int().positive(),
 })
 
 const completePodcastUploadSchema = z.object({
@@ -152,6 +155,7 @@ const completePodcastUploadSchema = z.object({
 	fileName: z.string().min(1),
 	contentType: z.string().optional().nullable(),
 	sizeBytes: z.number().int().positive().max(MAX_EDITOR_AUDIO_SOURCE_BYTES),
+	durationSeconds: z.number().int().positive(),
 	parts: z.array(uploadedPartSchema).min(1).max(10_000),
 })
 
@@ -490,6 +494,7 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 					cacheControl: 'public, max-age=31536000, immutable',
 				},
 				customMetadata: {
+					durationSeconds: String(parsed.data.durationSeconds),
 					originalFilename: parsed.data.fileName,
 					sizeBytes: String(parsed.data.sizeBytes),
 					source: 'cms',
@@ -555,6 +560,9 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 			if (typeof bucket.resumeMultipartUpload !== 'function') {
 				return json({ error: 'Missing configuration' }, 500)
 			}
+			if (typeof bucket.head !== 'function') {
+				return json({ error: 'R2 metadata verification is unavailable' }, 500)
+			}
 
 			const parsed = completePodcastUploadSchema.safeParse(await readJson(ctx))
 			if (!parsed.success) return json({ error: 'Invalid podcast upload completion request' }, 400)
@@ -599,25 +607,26 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 			const upload = bucket.resumeMultipartUpload(parsed.data.key, parsed.data.uploadId)
 			await upload.complete(parts)
 
-			let sizeVerification: 'verified' | 'unsupported' = 'unsupported'
-			if (typeof bucket.head === 'function') {
-				const object = await bucket.head(parsed.data.key)
-				if (
-					!object ||
-					object.size !== parsed.data.sizeBytes ||
-					object.size > MAX_EDITOR_AUDIO_SOURCE_BYTES
-				) {
-					await deletePodcastAudioAsset(ctx, bucket, parsed.data.key)
-					return json(
-						{
-							error: 'Uploaded podcast audio size did not match the expected size',
-							expectedSizeBytes: parsed.data.sizeBytes,
-							actualSizeBytes: object?.size ?? null,
-						},
-						400,
-					)
-				}
-				sizeVerification = 'verified'
+			const object = await bucket.head(parsed.data.key)
+			if (
+				!object ||
+				object.size !== parsed.data.sizeBytes ||
+				object.customMetadata?.sizeBytes !== String(parsed.data.sizeBytes) ||
+				object.size > MAX_EDITOR_AUDIO_SOURCE_BYTES
+			) {
+				await deletePodcastAudioAsset(ctx, bucket, parsed.data.key)
+				return json(
+					{
+						error: 'Uploaded podcast audio size did not match the expected size',
+						expectedSizeBytes: parsed.data.sizeBytes,
+						actualSizeBytes: object?.size ?? null,
+					},
+					400,
+				)
+			}
+			if (object.customMetadata?.durationSeconds !== String(parsed.data.durationSeconds)) {
+				await deletePodcastAudioAsset(ctx, bucket, parsed.data.key)
+				return json({ error: 'Uploaded podcast duration did not match the multipart upload' }, 400)
 			}
 
 			try {
@@ -635,6 +644,7 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 					height: null,
 					variantsJson: JSON.stringify({
 						contentType,
+						durationSeconds: parsed.data.durationSeconds,
 						sizeBytes: parsed.data.sizeBytes,
 						slug: slugify(parsed.data.slug) || 'podcast',
 					}),
@@ -655,8 +665,9 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 				key: parsed.data.key,
 				publicUrl,
 				url: publicUrl,
-				sizeVerification,
+				sizeVerification: 'verified',
 				sizeBytes: parsed.data.sizeBytes,
+				durationSeconds: parsed.data.durationSeconds,
 			})
 		},
 
@@ -720,6 +731,7 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 			const upload = await bucket.createMultipartUpload(key, {
 				httpMetadata: { contentType, cacheControl: 'public, max-age=3600' },
 				customMetadata: {
+					durationSeconds: String(parsed.data.durationSeconds),
 					originalFilename: parsed.data.fileName,
 					sizeBytes: String(parsed.data.sizeBytes),
 					source: 'cms',
@@ -786,6 +798,9 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 			if (typeof bucket.resumeMultipartUpload !== 'function') {
 				return json({ error: 'Missing configuration' }, 500)
 			}
+			if (typeof bucket.head !== 'function') {
+				return json({ error: 'R2 metadata verification is unavailable' }, 500)
+			}
 
 			const parsed = completeVideoUploadSchema.safeParse(await readJson(ctx))
 			if (!parsed.success) return json({ error: 'Invalid video upload completion request' }, 400)
@@ -844,25 +859,26 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 				publicDomain: domain,
 			})
 
-			let sizeVerification: 'verified' | 'unsupported' = 'unsupported'
-			if (typeof bucket.head === 'function') {
-				const object = await bucket.head(parsed.data.key)
-				if (
-					!object ||
-					object.size !== parsed.data.sizeBytes ||
-					object.size > MAX_EDITOR_VIDEO_SOURCE_BYTES
-				) {
-					await deleteStagedVideoSource(ctx.db, bucket, sourceUrl, domain)
-					return json(
-						{
-							error: 'Uploaded video source size did not match the expected size',
-							expectedSizeBytes: parsed.data.sizeBytes,
-							actualSizeBytes: object?.size ?? null,
-						},
-						400,
-					)
-				}
-				sizeVerification = 'verified'
+			const object = await bucket.head(parsed.data.key)
+			if (
+				!object ||
+				object.size !== parsed.data.sizeBytes ||
+				object.customMetadata?.sizeBytes !== String(parsed.data.sizeBytes) ||
+				object.size > MAX_EDITOR_VIDEO_SOURCE_BYTES
+			) {
+				await deleteStagedVideoSource(ctx.db, bucket, sourceUrl, domain)
+				return json(
+					{
+						error: 'Uploaded video source size did not match the expected size',
+						expectedSizeBytes: parsed.data.sizeBytes,
+						actualSizeBytes: object?.size ?? null,
+					},
+					400,
+				)
+			}
+			if (object.customMetadata?.durationSeconds !== String(parsed.data.durationSeconds)) {
+				await deleteStagedVideoSource(ctx.db, bucket, sourceUrl, domain)
+				return json({ error: 'Uploaded video duration did not match the multipart upload' }, 400)
 			}
 
 			try {
@@ -878,7 +894,12 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 					url: sourceUrl,
 					width: null,
 					height: null,
-					variantsJson: JSON.stringify({ contentType, sizeBytes: parsed.data.sizeBytes, videoId }),
+					variantsJson: JSON.stringify({
+						contentType,
+						durationSeconds: parsed.data.durationSeconds,
+						sizeBytes: parsed.data.sizeBytes,
+						videoId,
+					}),
 					r2Binding: mediaR2Binding,
 				})
 			} catch (error) {
@@ -898,9 +919,10 @@ export function createMediaRoutes(config: CmsRouteConfig): MediaRouteHandlers {
 				processingStatus: 'processing',
 				sourceUrl,
 				sourceKind: 'http_url',
-				sizeVerification,
+				sizeVerification: 'verified',
 				videoId,
 				sizeBytes: parsed.data.sizeBytes,
+				durationSeconds: parsed.data.durationSeconds,
 			})
 		},