@groma/scanner-csharp 0.2.0 → 0.2.2

package/README.md

@@ -5,7 +5,7 @@ platform. Install the scanner and scan source without a project SDK, NuGet resto
 or application build. `global.json` does not select the scanner's runtime.
 
 ```sh
-groma scanner add @groma/scanner-csharp
+groma plugin add @groma/scanner-csharp
 groma scan
 ```
 
@@ -110,6 +110,14 @@ expression tree. Implicit calls, initializers, generated operations,
 receiver/delegate value flow, dependency injection and network protocols are
 not resolved.
 
+A file that several projects compile is analyzed once, and another of those
+projects can parse it differently, for example under other `DefineConstants`.
+A call from such a project to a method it declares with a body in that file
+names its target when the analyzed file declares a member written with the same
+name at the same position, however each project binds the member's types. When
+the analyzed file declares another member there, or none, that call alone is
+reported as unresolved, without a target.
+
 Solutions and projects supply source roots and file membership. They are not
 C4 components or proof of business collaborations. Core owns curated membership
 and relationship selection; ordinary Markdown readers see the existing OKF

package/dist/index.js

@@ -120,13 +120,13 @@ function compare(...values) {
 }
 function uniqueBy(values, key, label) {
   const seen = new Set;
-  for (const value of values) {
-    const id = key(value);
+  const keyed = values.map((value) => ({ id: key(value), value }));
+  for (const { id } of keyed) {
     if (seen.has(id))
       throw new Error(`duplicate ${label}: ${id}`);
     seen.add(id);
   }
-  return [...values].sort((left, right) => key(left).localeCompare(key(right)));
+  return keyed.sort((left, right) => left.id.localeCompare(right.id)).map((entry) => entry.value);
 }
 function createScanObservation(input) {
   const roots = validateRoots(input.roots);
@@ -137,9 +137,7 @@ function createScanObservation(input) {
     symbols: [...new Map(file.symbols.map((symbol) => [
       compare(symbol.id, symbol.kind),
       symbol
-    ])).values()].sort((left, right) => {
-      return compare(left.id, left.kind).localeCompare(compare(right.id, right.kind));
-    })
+    ]))].sort(([left], [right]) => left.localeCompare(right)).map(([, symbol]) => symbol)
   })), (file) => file.file, "file path");
   const filePaths = new Set(files.map((file) => file.file));
   for (const file of files) {
@@ -150,8 +148,6 @@ function createScanObservation(input) {
         throw new Error(`file references unknown root: ${root}`);
     }
   }
-  for (const diagnostic of input.diagnostics)
-    diagnosticLocation(diagnostic);
   return {
     schemaVersion: 1,
     scanner: input.scanner,
@@ -161,14 +157,14 @@ function createScanObservation(input) {
     ...entryPoints(input.entryPoints, filePaths),
     ...operationEvidence(input, filePaths),
     ...httpEvidence(input.httpEndpoints, input.httpRequests, input.operations && new Set(input.operations.map((operation) => operation.id))),
-    diagnostics: [...new Map(input.diagnostics.map((diagnostic) => [
-      diagnosticKey(diagnostic),
-      diagnostic
-    ])).values()].sort((left, right) => {
-      return diagnosticKey(left).localeCompare(diagnosticKey(right));
-    })
+    diagnostics: normalizeScanDiagnostics(input.diagnostics)
   };
 }
+function normalizeScanDiagnostics(diagnostics) {
+  for (const diagnostic of diagnostics)
+    diagnosticLocation(diagnostic);
+  return [...new Map(diagnostics.map((diagnostic) => [diagnosticKey(diagnostic), diagnostic]))].sort(([left], [right]) => left.localeCompare(right)).map(([, diagnostic]) => diagnostic);
+}
 function entryPoints(input, paths) {
   if (input === undefined)
     return {};
@@ -367,10 +363,14 @@ function operationTokens(operation) {
   const endLine = Number(operation.endLine);
   if (endLine < startLine)
     throw new Error("operation.endLine must be at or after startLine");
+  const tokens = array(operation.tokens, "operation.tokens");
+  tokens.forEach((token) => {
+    string(token, "operation.token");
+  });
   return {
     startLine,
     endLine,
-    tokens: array(operation.tokens, "operation.tokens").map((token) => string(token, "operation.token"))
+    tokens
   };
 }
 function validateOperationTokens(operation) {

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@groma/scanner-csharp",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "private": false,
   "type": "module",
   "license": "MIT",
   "repository": {
     "type": "git",
-    "url": "https://github.com/MrLesk/Groma.md.git"
+    "url": "https://github.com/MrLesk/groma.md.git"
   },
   "description": "C# project evidence through Roslyn.",
   "publishConfig": {
@@ -28,11 +28,11 @@
     "x64"
   ],
   "optionalDependencies": {
-    "@groma/scanner-csharp-darwin-arm64": "0.2.0",
-    "@groma/scanner-csharp-linux-arm64": "0.2.0",
-    "@groma/scanner-csharp-linux-x64": "0.2.0",
-    "@groma/scanner-csharp-win32-arm64": "0.2.0",
-    "@groma/scanner-csharp-win32-x64": "0.2.0"
+    "@groma/scanner-csharp-darwin-arm64": "0.2.2",
+    "@groma/scanner-csharp-linux-arm64": "0.2.2",
+    "@groma/scanner-csharp-linux-x64": "0.2.2",
+    "@groma/scanner-csharp-win32-arm64": "0.2.2",
+    "@groma/scanner-csharp-win32-x64": "0.2.2"
   },
   "groma": {
     "scanner": {