@groeponline/pi-wishcraft 1.0.5 → 1.1.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## [Unreleased]
 
+## [1.1.0] - 2026-08-23
+
+### Security
+- Skills manager refuses to delete skill files or directories that resolve (through symlinks) outside the canonical skill roots.
+- Skills editor command validates `EDITOR` before use, falling back to `nvim` for unsafe values.
+- Open-ports overlay reuses the shared `sshCommand` helper and fails explicitly on an invalid host instead of falling back to a local probe.
+
 ## [1.0.5] - 2026-08-23
 
 ## [1.0.4] - 2026-08-23

package/README.md

@@ -1,5 +1,12 @@
 <p>
-  <img src="banner.png" alt="pi-wishcraft" width="1100">
+  <img src="https://raw.githubusercontent.com/GroepOnline/pi-wishcraft/main/banner.png" alt="pi-wishcraft" width="1100">
+</p>
+
+<p>
+  <a href="https://www.npmjs.com/package/@groeponline/pi-wishcraft"><img src="https://img.shields.io/npm/v/@groeponline/pi-wishcraft.svg" alt="npm version"></a>
+  <a href="https://www.npmjs.com/package/@groeponline/pi-wishcraft"><img src="https://img.shields.io/npm/dm/@groeponline/pi-wishcraft.svg?label=downloads" alt="npm downloads"></a>
+  <a href="https://pi.dev/packages/@groeponline/pi-wishcraft"><img src="https://img.shields.io/badge/Pi-package-9b59b6.svg" alt="Pi package"></a>
+  <a href="LICENSE"><img src="https://img.shields.io/badge/license-MIT-555.svg" alt="MIT license"></a>
 </p>
 
 # pi-wishcraft
@@ -26,7 +33,7 @@ Ephemeral VMs / CI:
 curl -fsSL https://raw.githubusercontent.com/GroepOnline/pi-wishcraft/main/scripts/install.sh | bash
 ```
 
-Then restart pi or `/reload`. Peer range is `@earendil-works/pi-coding-agent` `>=0.81.0 <0.85.0`.
+Then restart pi or `/reload`. Pi host packages are declared as `peerDependencies: "*"`, matching the Pi package contract.
 
 ## What you get
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@groeponline/pi-wishcraft",
-  "version": "1.0.5",
-  "description": "Wishcraft cockpit for the pi coding agent — powerline status, vibes, idea inbox, bash mode, and full customization.",
+  "version": "1.1.0",
+  "description": "Operator cockpit for Pi: live powerline status, searchable skills, idea queue, sticky Bash, hooks, policy controls, and session UX.",
   "type": "module",
   "files": [
     "*.ts",
@@ -25,7 +25,12 @@
     "powerline",
     "status-bar",
     "extension",
-    "groeponline"
+    "groeponline",
+    "terminal-ui",
+    "developer-tools",
+    "agent-ui",
+    "productivity",
+    "hooks"
   ],
   "publishConfig": {
     "access": "public",
@@ -45,14 +50,15 @@
     "typecheck": "tsc --noEmit",
     "test": "node --experimental-strip-types --test tests/**/*.test.ts",
     "release": "node scripts/release.mjs",
-    "prepublishOnly": "tsc --noEmit && node scripts/verify-package.mjs",
-    "verify:package": "node scripts/verify-package.mjs",
-    "circular": "madge --circular src index.ts bash-mode queue"
+    "prepublishOnly": "tsc --noEmit && node scripts/verify-package.mjs && npm run verify:pi-package",
+    "verify:package": "node scripts/verify-package.mjs && node scripts/verify-pi-package-contract.mjs",
+    "circular": "madge --circular src index.ts bash-mode queue",
+    "verify:pi-package": "node scripts/verify-pi-package-contract.mjs"
   },
   "peerDependencies": {
-    "@earendil-works/pi-ai": ">=0.81.0 <0.85.0",
-    "@earendil-works/pi-coding-agent": ">=0.81.0 <0.85.0",
-    "@earendil-works/pi-tui": ">=0.81.0 <0.85.0"
+    "@earendil-works/pi-ai": "*",
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*"
   },
   "devDependencies": {
     "@earendil-works/pi-ai": "^0.84.0",

package/src/extension/skills/skill-manager.ts

@@ -13,8 +13,10 @@
 
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
-import { rmSync } from "node:fs";
+import { realpathSync, rmSync } from "node:fs";
+import { join, relative } from "node:path";
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { getAgentDir } from "../../paths/agent-dirs.ts";
 import type { RuntimeState } from "../core/types.ts";
 import {
   applySkillFilter,
@@ -84,9 +86,49 @@ function shellQuote(value: string): string {
   return `'${value.replace(/'/g, `'"'"'`)}'`;
 }
 
+/**
+ * Resolve `target` through symlinks and confirm it stays within one of the
+ * canonical skill roots (agent skills dir, `<cwd>/.pi/skills`, `<cwd>/skills`).
+ * Guards the recursive delete against catalog paths that a cloned/untrusted
+ * repo could point outside the expected trees. Returns false when the path
+ * cannot be resolved (e.g. already removed) so callers fail closed.
+ */
+export function isContainedInSkillRoots(target: string, cwd: string): boolean {
+  const roots = [
+    join(getAgentDir(), "skills"),
+    join(cwd, ".pi", "skills"),
+    join(cwd, "skills"),
+  ];
+  let real: string;
+  try {
+    real = realpathSync(target);
+  } catch {
+    return false;
+  }
+  return roots.some((root) => {
+    let realRoot: string;
+    try {
+      realRoot = realpathSync(root);
+    } catch {
+      return false;
+    }
+    const rel = relative(realRoot, real);
+    return rel !== "" && !rel.startsWith("..") && !rel.startsWith("/");
+  });
+}
+
+/**
+ * Only allow a bare, path-like editor invocation (no arguments, no shell
+ * metacharacters) so a hostile `EDITOR` value cannot inject into the `!` flow.
+ * Falls back to `nvim` when the value is unusable.
+ */
+export function safeEditor(): string {
+  const ed = process.env.EDITOR?.trim();
+  return ed && /^[\w./-]+$/.test(ed) ? ed : "nvim";
+}
+
 function editorCommand(path: string): string {
-  const ed = process.env.EDITOR?.trim() || "nvim";
-  return `!${ed} ${shellQuote(path)}`;
+  return `!${safeEditor()} ${shellQuote(path)}`;
 }
 
 export async function showSkillManager(ctx: any): Promise<"new" | null> {
@@ -137,11 +179,18 @@ export async function showSkillManager(ctx: any): Promise<"new" | null> {
       const close = () => done(null);
 
       const doDelete = (entry: SkillEntry) => {
+        const cwd = ctx.cwd ?? process.cwd();
         try {
           if (entry.isDirectorySkill && entry.filePath.endsWith("SKILL.md") &&
               (entry.category === "global" || entry.category === "project")) {
+            if (!isContainedInSkillRoots(entry.baseDir, cwd)) {
+              throw new Error(`refusing to delete outside skill roots: ${entry.baseDir}`);
+            }
             rmSync(entry.baseDir, { recursive: true, force: true });
           } else {
+            if (!isContainedInSkillRoots(entry.filePath, cwd)) {
+              throw new Error(`refusing to delete outside skill roots: ${entry.filePath}`);
+            }
             rmSync(entry.filePath, { force: true });
           }
           ctx.ui.notify(`Skill deleted: ${entry.name}`, "info");

package/src/extension/ui/custom-editor.ts

@@ -21,7 +21,7 @@ import {
   passAutocompleteProviderThroughPreviousEditor,
 } from "../../editor/autocomplete-chain.ts";
 import { subscribeGitUpdates } from "../../git/status.ts";
-import { ansi, getFgAnsiCode } from "../../theme/colors.ts";
+import { ansi, colorEnabled, getFgAnsiCode } from "../../theme/colors.ts";
 import {
   restorePromptHistory,
   snapshotPromptHistory,
@@ -320,7 +320,8 @@ export function setupCustomEditor(
         return originalRender(width);
       }
 
-      const bc = (s: string) => `${getFgAnsiCode("sep")}${s}${ansi.reset}`;
+      const bc = (s: string) =>
+          `${getFgAnsiCode("sep")}${s}${colorEnabled() ? ansi.reset : ""}`;
       const captureDraft =
         !rt.bashModeActive && isSigilIdeaDraft(editor.getExpandedText());
       const promptGlyph = rt.bashModeActive
@@ -330,8 +331,10 @@ export function setupCustomEditor(
           : ">";
       const promptColor = captureDraft
         ? getFgAnsiCode("queue")
-        : ansi.getFgAnsi(200, 200, 200);
-      const prompt = `${promptColor}${promptGlyph}${ansi.reset}`;
+        : colorEnabled()
+          ? ansi.getFgAnsi(200, 200, 200)
+          : "";
+      const prompt = `${promptColor}${promptGlyph}${colorEnabled() ? ansi.reset : ""}`;
       const promptPrefix = ` ${prompt} `;
       const contPrefix = "   ";
       const contentWidth = Math.max(1, width - 3);

package/src/extension/ui/layout.ts

@@ -9,7 +9,7 @@ import { getPreset } from "../../config/presets.ts";
 import { mergeSegmentsWithCustomItems } from "../../config/powerline-config.ts";
 import { getSeparator } from "../../theme/separators.ts";
 import { renderSegment } from "../../segments/index.ts";
-import { ansi, getFgAnsiCode } from "../../theme/colors.ts";
+import { ansi, colorEnabled, getFgAnsiCode } from "../../theme/colors.ts";
 import { config } from "../core/state.ts";
 
 // ═══════════════════════════════════════════════════════════════════════════
@@ -41,7 +41,8 @@ export function buildContentFromParts(
   const separatorDef = getSeparator(separatorStyle);
   const sepAnsi = getFgAnsiCode("sep");
   const sep = separatorDef.left;
-  return " " + parts.join(` ${sepAnsi}${sep}${ansi.reset} `) + ansi.reset + " ";
+  const reset = colorEnabled() ? ansi.reset : "";
+  return " " + parts.join(` ${sepAnsi}${sep}${reset} `) + reset + " ";
 }
 
 /**

package/src/extension/ui/menu-views.ts

@@ -18,6 +18,7 @@ import {
   countListeningPorts,
   listOpenPortProcesses,
   sanitizeSshHost,
+  sshCommand,
 } from "../../segments/system.ts";
 import {
   writePowerlineCustomPresetSetting,
@@ -63,8 +64,12 @@ export async function showOpenPortsList(ctx: any): Promise<void> {
     }
     const proto = includeUdp ? "-tulnp" : "-tlnp";
     const command = host
-      ? `ssh -o ConnectTimeout=3 -o BatchMode=yes ${host} "ss ${proto} 2>/dev/null" 2>/dev/null`
+      ? sshCommand(host, `ss ${proto} 2>/dev/null`)
       : `ss ${proto} 2>/dev/null`;
+    if (!command) {
+      ctx.ui.notify(`Invalid open-ports host: ${host}`, "error");
+      return;
+    }
     const stdout = execSync(command, { encoding: "utf8" });
     publishPowerlineStatuses(ctx, {
       ports: formatPortsStatusValue(countListeningPorts(includeUdp, host)),

package/src/extension/ui/status-line-renderers.ts

@@ -7,7 +7,7 @@ import {
   collectHiddenExtensionStatusKeys,
   getNotificationExtensionStatuses,
 } from "../../config/powerline-config.ts";
-import { ansi, getFgAnsiCode } from "../../theme/colors.ts";
+import { ansi, colorEnabled, getFgAnsiCode } from "../../theme/colors.ts";
 
 import { computeResponsiveLayout } from "./layout.ts";
 import { getQueueContext } from "../queue/queue-context.ts";
@@ -210,7 +210,8 @@ export function renderLastPromptLines(
 ): string[] {
   if (rt.bashModeActive || !rt.showLastPrompt || !rt.lastUserPrompt) return [];
 
-  const prefix = ` ${getFgAnsiCode("sep")}↳${ansi.reset} `;
+  const reset = colorEnabled() ? ansi.reset : "";
+  const prefix = ` ${getFgAnsiCode("sep")}↳${reset} `;
   const availableWidth = width - visibleWidth(prefix);
   if (availableWidth < 10) return [];
 
@@ -219,7 +220,7 @@ export function renderLastPromptLines(
 
   promptText = truncateToWidth(promptText, availableWidth, "…");
 
-  const styledPrompt = `${getFgAnsiCode("sep")}${promptText}${ansi.reset}`;
+  const styledPrompt = `${getFgAnsiCode("sep")}${promptText}${reset}`;
   const line = `${prefix}${styledPrompt}`;
   return [truncateToWidth(line, width, "…")];
 }

package/src/segments/registry.ts

@@ -135,6 +135,9 @@ export function applySegmentDecoration(
   return { content, visible: true };
 }
 
+const SEGMENT_ERROR_LOG_INTERVAL_MS = 10_000;
+const lastSegmentErrorLog = new Map<StatusLineSegmentId, number>();
+
 export const SEGMENTS: Record<BuiltinStatusLineSegmentId, StatusLineSegment> = {
   model: modelSegment,
   shell_mode: shellModeSegment,
@@ -177,11 +180,20 @@ export function renderSegment(
       rendered = segment ? segment.render(ctx) : { content: "", visible: false };
     }
     return applySegmentDecoration(id, ctx, rendered);
-  } catch {
-    // ponytail: per-segment fault isolation. A throwing segment (most often a
-    // user `command` custom segment with a failing script) must not blank the
-    // whole footer; surface a visible `!id` marker so the operator sees
-    // which segment broke. No per-render log: the bar repaints ~30/s.
-    return { content: `!${id}`, visible: true };
+  } catch (err) {
+    // Per-segment fault isolation: keep the footer alive and identify the
+    // segment that failed. Log at most once every 10 seconds per segment.
+    const now = Date.now();
+    const lastLogged = lastSegmentErrorLog.get(id) ?? 0;
+    if (now - lastLogged >= SEGMENT_ERROR_LOG_INTERVAL_MS) {
+      lastSegmentErrorLog.set(id, now);
+      const detail = err instanceof Error ? (err.stack ?? err.message) : String(err);
+      console.warn(`[wishcraft] segment "${id}" failed: ${detail}`);
+    }
+    return applySegmentDecoration(id, ctx, {
+      content: `!${id}`,
+      visible: true,
+    });
+
   }
 }

package/src/segments/system.ts

@@ -137,7 +137,7 @@ export function sanitizeSshHost(value: string | undefined): string | null {
  * inner `2>/dev/null`; `BatchMode` fails fast (no password prompt) on hosts
  * that require interactive auth or an unknown host key.
  */
-function sshCommand(
+export function sshCommand(
   host: string | undefined,
   remoteCmd: string,
 ): string | null {

package/src/theme/colors.ts

@@ -12,6 +12,18 @@ export const ansi: AnsiColors = {
   reset: "\x1b[0m",
 };
 
+// ponytail: NO_COLOR (de-facto standard — present and non-empty) disables all
+// wishcraft color so the status bar stays plain text in no-color terminals
+// and color-blind pipelines. Computed lazily so test env changes take effect.
+let _colorEnabled: boolean | undefined;
+export function colorEnabled(): boolean {
+  if (_colorEnabled === undefined) {
+    const v = process.env.NO_COLOR;
+    _colorEnabled = !(v != null && v !== "");
+  }
+  return _colorEnabled;
+}
+
 function hexToRgb(hex: string): [number, number, number] {
   const cleanHex = hex.startsWith("#") ? hex.slice(1) : hex;
   if (!/^[0-9A-Fa-f]{6}$/.test(cleanHex)) {
@@ -51,10 +63,12 @@ for (const key of Object.keys(PALETTE)) {
 }
 
 export function fgOnly(color: ColorName, text: string): string {
+  if (!colorEnabled()) return text;
   const code = ansiCodeCache.get(color as string) ?? "";
   return code ? `${code}${text}` : text;
 }
 
 export function getFgAnsiCode(color: ColorName): string {
+  if (!colorEnabled()) return "";
   return ansiCodeCache.get(color as string) ?? "";
 }

package/src/welcome/renderer.ts

@@ -1,5 +1,5 @@
 import { visibleWidth } from "@earendil-works/pi-tui";
-import { ansi, fgOnly, getFgAnsiCode } from "../theme/colors.ts";
+import { ansi, colorEnabled, fgOnly, getFgAnsiCode } from "../theme/colors.ts";
 import { centerText, fitToWidth, getBoxLayout } from "./layout.ts";
 import type { WelcomeData, WelcomeWidget, WidgetRenderContext } from "./types.ts";
 
@@ -32,7 +32,7 @@ function bold(text: string): string {
 }
 
 export function dim(text: string): string {
-  return getFgAnsiCode("sep") + text + ansi.reset;
+  return getFgAnsiCode("sep") + text + (colorEnabled() ? ansi.reset : "");
 }
 
 function gradientLine(line: string): string {

package/src/welcome/whats-new.ts

@@ -16,6 +16,9 @@ import { getAgentPath } from "../paths/agent-dirs.ts";
 
 const MAX_WHATSNEW_LINES = 8;
 const WHATS_NEW_STATE_FILE = "whats-new.json";
+// First GroepOnline release. On a first run (no stored version) the welcome
+// panel shows history from here forward, never the pre-1.0 `0.x` prehistory.
+const FIRST_OWN_RELEASE = "1.0.0";
 
 const PACKAGE_ROOT = join(dirname(fileURLToPath(import.meta.url)), "..", "..");
 
@@ -37,38 +40,71 @@ function isVersionNewer(version: string, lastSeen: string | null): boolean {
   return false;
 }
 
+function isVersionAtOrNewer(version: string, floor: string): boolean {
+  const next = parseVersion(version);
+  const min = parseVersion(floor);
+  if (!next || !min) return false;
+  for (let i = 0; i < 3; i++) {
+    if (next[i] > min[i]) return true;
+    if (next[i] < min[i]) return false;
+  }
+  return true;
+}
+
 /**
  * Extract the bullet lines from released changelog sections whose version is
- * strictly newer than `lastSeenVersion` (null = first run, so the newest
- * sections win). Markdown bold markers are stripped; backticks are kept so
- * commands like `/powerline doctor` stay readable in the terminal.
+ * strictly newer than `lastSeenVersion`. On a first run (`lastSeenVersion` is
+ * null) `floorVersion` becomes the lower bound, so the panel shows history from
+ * the first own release forward and skips the pre-1.0 prehistory. Sections are
+ * returned oldest-first (chronological "since your last version") and capped at
+ * `maxLines`. Markdown bold markers are stripped; backticks are kept so commands
+ * like `/powerline doctor` stay readable in the terminal.
  */
 export function parseChangelogDelta(
   changelog: string,
   lastSeenVersion: string | null,
   maxLines: number = MAX_WHATSNEW_LINES,
+  floorVersion: string | null = FIRST_OWN_RELEASE,
 ): string[] {
-  const entries: string[] = [];
-  let includeSection = false;
+  // The changelog is newest-first; collect per section, then reverse to read
+  // oldest-first before capping.
+  const sections: string[][] = [];
+  let current: string[] | null = null;
+  // A stored last-seen version is a strict lower bound (only strictly newer
+  // sections). On a first run the floor is inclusive, so the first own release
+  // itself is shown while the pre-1.0 prehistory is skipped.
+  const matchesBound =
+    lastSeenVersion !== null
+      ? (version: string) => isVersionNewer(version, lastSeenVersion)
+      : floorVersion !== null
+        ? (version: string) => isVersionAtOrNewer(version, floorVersion)
+        : () => true;
 
   for (const rawLine of changelog.split("\n")) {
     const line = rawLine.trimEnd();
     const versionMatch = line.match(/^##\s+\[([^\]]+)\]/);
     if (versionMatch) {
       const version = versionMatch[1].trim();
-      includeSection =
-        version !== "Unreleased" && isVersionNewer(version, lastSeenVersion);
+      const include = version !== "Unreleased" && matchesBound(version);
+      current = include ? [] : null;
+      if (current) sections.push(current);
       continue;
     }
-    if (!includeSection) continue;
+    if (!current) continue;
     if (!line.startsWith("- ")) continue;
 
     const cleaned = line.slice(2).trim().replace(/\*\*/g, "").trim();
     if (!cleaned) continue;
-    entries.push(cleaned);
-    if (entries.length >= maxLines) break;
+    current.push(cleaned);
   }
 
+  const entries: string[] = [];
+  for (const section of sections.reverse()) {
+    for (const entry of section) {
+      entries.push(entry);
+      if (entries.length >= maxLines) return entries;
+    }
+  }
   return entries;
 }