@groeponline/pi-wishcraft 0.25.0 → 0.26.0

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## [Unreleased]
 
+## [0.26.0] - 2026-08-20
+
+### Added
+- `/skills new <name> [template]` writes a SKILL.md from standard, browser-workflow, CLI-workflow, or review-checklist. `ctrl+n` opens the template picker.
+
 ## [0.25.0] - 2026-08-20
 
 ## [0.24.0] - 2026-08-20

package/docs/index.md

@@ -8,7 +8,7 @@ The README is the public landing page (`banner.png` only). Everything below live
 - [Configuration](./configuration.md) — custom items, hooks, repairs, token budget, labels, templates, layout, cost alert, and display formats.
 - [Bash mode](./bash-mode.md) — sticky shell, ghost suggestions, and shell config.
 - [Stash & shortcuts](./stash-and-shortcuts.md) — editor stash, prompt history, clipboard/navigation shortcuts, and shortcut config.
-- [Skill manager](./skill-manager.md) — browsing and inserting installed skills, `/skills doctor` health table.
+- [Skill manager](./skill-manager.md) — browsing, inserting, `/skills doctor`, and `/skills new` templates.
 - [Working vibes](./working-vibes.md) — themed loading messages, modes, and configuration.
 - [Segments & theming](./segments.md) — segment reference, separators, thinking/path/git options, and theme overrides.
 

package/docs/skill-manager.md

@@ -4,5 +4,6 @@ Browse and insert your installed skills (`SKILL.md` files and `*.md`/`*.txt` pro
 
 - **`/skills`** — open the skill manager. Filter with plain typing, `↑↓` to move, `enter` to open a skill's detail body, `↑↓` in the detail to scroll, `enter`/`tab` to insert the skill content into your prompt, `esc` to go back/close.
 - **`/skills doctor`** — health table (not an essay): broken or missing frontmatter, descriptions over 240 characters, the same name in global and project, unused skills (usage ledger count 0). `↑↓` navigate, `enter` copies a row, `esc` closes.
+- **`/skills new <name> [template]`** — write `~/.pi/agent/skills/<name>/SKILL.md` from a template (`standard`, `browser-workflow`, `CLI-workflow`, `review-checklist`), then drop an `$EDITOR` command in the prompt. `/skills new` or `ctrl+n` in the manager opens the template picker. Names reject empty values, `..`, and path separators. No GitHub/npm install.
 
 The manager reuses the same skill discovery as inline `/command`/`$skill` triggers, so anything you can inline you can also browse and insert manually.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groeponline/pi-wishcraft",
-  "version": "0.25.0",
+  "version": "0.26.0",
   "description": "Wishcraft cockpit for the pi coding agent — powerline status, vibes, idea inbox, bash mode, and full customization.",
   "type": "module",
   "files": [

package/src/extension/skills/skill-manager.ts

@@ -14,10 +14,8 @@
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { rmSync } from "node:fs";
-import { join } from "node:path";
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import type { RuntimeState } from "../core/types.ts";
-import { getAgentPath } from "../../paths/agent-dirs.ts";
 import {
   applySkillFilter,
   getSkillUsage,
@@ -29,6 +27,7 @@ import {
   type SkillEntry,
 } from "./skill-registry.ts";
 import { runSkillDoctor } from "./skill-doctor.ts";
+import { runSkillsNew } from "./skill-templates.ts";
 
 const CATEGORY_LABELS: Record<SkillCategory | "all", string> = {
   all: "alles",
@@ -90,21 +89,20 @@ function editorCommand(path: string): string {
   return `!${ed} ${shellQuote(path)}`;
 }
 
-export async function showSkillManager(ctx: any): Promise<void> {
+export async function showSkillManager(ctx: any): Promise<"new" | null> {
   invalidateSkillCache();
   let entries = loadSkillCatalog(ctx.cwd ?? process.cwd());
   const usage = getSkillUsage();
   if (entries.length === 0) {
     ctx.ui.notify("No skills found", "info");
-    return;
   }
 
-  await ctx.ui.custom(
+  return ctx.ui.custom(
     (
       tui: any,
       theme: Theme,
       _keybindings: any,
-      done: (result: null) => void,
+      done: (result: "new" | null) => void,
     ) => {
       const border = (text: string) => theme.fg("dim", text);
       const wrapRow = (text: string, innerWidth: number): string =>
@@ -183,11 +181,12 @@ export async function showSkillManager(ctx: any): Promise<void> {
             lines.push(border(`├${"─".repeat(innerWidth)}┤`));
 
             if (f.length === 0) {
+              const emptyMsg =
+                entries.length === 0 && !query
+                  ? "No skills installed — ctrl+n to create one"
+                  : `Geen skills voor "${query}"`;
               lines.push(
-                wrapRow(
-                  theme.fg("warning", `Geen skills voor "${query}"`),
-                  innerWidth,
-                ),
+                wrapRow(theme.fg("warning", emptyMsg), innerWidth),
               );
             } else {
               // scroll-window rondom de selectie
@@ -396,13 +395,8 @@ export async function showSkillManager(ctx: any): Promise<void> {
                 return;
               }
             } else if (data === "\x0e") {
-              // ctrl+n = nieuwe skill
-              appendToEditor(
-                ctx,
-                `!mkdir -p ${shellQuote(join(getAgentPath("skills"), "<naam>"))} && ${editorCommand(join(getAgentPath("skills"), "<naam>", "SKILL.md")).slice(1)}`,
-                "Nieuwe skill: vervang <naam>, enter draait 'm",
-              );
-              close();
+              // ctrl+n = new skill from a template
+              done("new");
               return;
             } else if (data === "\x04") {
               // ctrl+d = verwijderen (met confirm)
@@ -482,7 +476,7 @@ export function registerSkillManagerCommand(
 ): void {
   const runDoctor = deps.runDoctor ?? runSkillDoctor;
   pi.registerCommand("skills", {
-    description: "Browse installed skills, or `doctor` for a health table",
+    description: "Browse installed skills, or `doctor` / `new [template]`",
     handler: async (args: string, ctx: any) => {
       if (!rt.enabled || !ctx.hasUI) {
         ctx.ui.notify("Powerline UI is disabled", "info");
@@ -493,7 +487,12 @@ export function registerSkillManagerCommand(
         await runDoctor(ctx);
         return;
       }
-      await showSkillManager(ctx);
+      if (sub === "new") {
+        await runSkillsNew(ctx, args);
+        return;
+      }
+      const result = await showSkillManager(ctx);
+      if (result === "new") await runSkillsNew(ctx, "");
     },
   });
 }

package/src/extension/skills/skill-templates.ts

@@ -0,0 +1,267 @@
+/**
+ * `/skills new` templates. No marketplace, no GitHub/npm install.
+ * Writes `~/.pi/agent/skills/<name>/SKILL.md` then opens $EDITOR.
+ */
+
+import { existsSync, mkdirSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import type { SelectItem } from "@earendil-works/pi-tui";
+
+import { getAgentPath } from "../../paths/agent-dirs.ts";
+import { showSelectOverlay } from "../ui/overlay-chrome.ts";
+import { invalidateSkillCache } from "./skill-registry.ts";
+
+export const SKILL_TEMPLATE_IDS = [
+  "standard",
+  "browser-workflow",
+  "cli-workflow",
+  "review-checklist",
+] as const;
+
+export type SkillTemplateId = (typeof SKILL_TEMPLATE_IDS)[number];
+
+export class SkillNameError extends Error {
+  constructor(message: string) {
+    super(message);
+    this.name = "SkillNameError";
+  }
+}
+
+const TEMPLATE_META: Record<
+  SkillTemplateId,
+  { label: string; description: string }
+> = {
+  standard: {
+    label: "standard",
+    description: "Name, description, and a short body",
+  },
+  "browser-workflow": {
+    label: "browser-workflow",
+    description: "UI verify with screenshots, no profile wipe",
+  },
+  "cli-workflow": {
+    label: "CLI-workflow",
+    description: "Command, flags, and expected output",
+  },
+  "review-checklist": {
+    label: "review-checklist",
+    description: "Diff review gates before merge",
+  },
+};
+
+export function isSkillTemplateId(value: string): value is SkillTemplateId {
+  return (SKILL_TEMPLATE_IDS as readonly string[]).includes(value);
+}
+
+export function sanitizeSkillName(raw: string): string {
+  const trimmed = raw.trim().toLowerCase().replace(/_/g, "-");
+  if (!trimmed) {
+    throw new SkillNameError("Skill name is required");
+  }
+  if (trimmed === "." || trimmed === ".." || trimmed.includes("..")) {
+    throw new SkillNameError("Skill name cannot contain path traversal");
+  }
+  if (trimmed.includes("/") || trimmed.includes("\\")) {
+    throw new SkillNameError("Skill name cannot contain path separators");
+  }
+  if (trimmed.length > 64) {
+    throw new SkillNameError("Skill name must be 64 characters or fewer");
+  }
+  if (!/^[a-z0-9]+(?:-[a-z0-9]+)*$/.test(trimmed)) {
+    throw new SkillNameError(
+      "Skill name must be lowercase letters, digits, and hyphens",
+    );
+  }
+  return trimmed;
+}
+
+export function parseSkillsNewArgs(args: string): {
+  name?: string;
+  template: SkillTemplateId;
+} {
+  const parts = args.trim().split(/\s+/).filter(Boolean);
+  if (parts[0]?.toLowerCase() === "new") parts.shift();
+  if (parts.length === 0) return { template: "standard" };
+  if (parts.length === 1) {
+    const singleRaw = parts[0]!.toLowerCase();
+    if (isSkillTemplateId(singleRaw)) return { template: singleRaw };
+    return { name: parts[0], template: "standard" };
+  }
+  const templateRaw = parts[1]!.toLowerCase();
+  if (!isSkillTemplateId(templateRaw)) {
+    throw new SkillNameError(
+      `Unknown template '${parts[1]}'. Use: ${SKILL_TEMPLATE_IDS.join(", ")}`,
+    );
+  }
+  return { name: parts[0], template: templateRaw };
+}
+
+export function renderSkillTemplate(
+  id: SkillTemplateId,
+  name: string,
+): string {
+  const title = name;
+  switch (id) {
+    case "standard":
+      return `---
+name: ${title}
+description: Short skill for ${title}. State when to use it in one sentence.
+---
+
+# ${title}
+
+Use this skill when the operator asks for ${title}.
+
+## Steps
+
+1. Restate the goal in one line.
+2. Do the work with the tools already in session.
+3. Report what changed and how to verify it.
+`;
+    case "browser-workflow":
+      return `---
+name: ${title}
+description: Browser UI verify for ${title}. Screenshot evidence, no profile wipe.
+---
+
+# ${title}
+
+Use for visual checks in a real browser. Do not author layout here.
+
+## Steps
+
+1. Open the target URL in the existing session.
+2. Snapshot the page, then act on stable refs.
+3. Take a screenshot of the result.
+4. Do not wipe profiles, cookies, or login state unless the operator asked.
+`;
+    case "cli-workflow":
+      return `---
+name: ${title}
+description: CLI workflow for ${title}. Command, flags, and expected output.
+---
+
+# ${title}
+
+Use when the work is a command-line tool or script.
+
+## Steps
+
+1. Name the binary and the exact invocation.
+2. List required flags and inputs.
+3. Run the command and capture exit code plus stdout/stderr.
+4. State the expected output and how to rerun it.
+`;
+    case "review-checklist":
+      return `---
+name: ${title}
+description: Review checklist for ${title}. Gates before merge, no rubber-stamp.
+---
+
+# ${title}
+
+Use before marking a change merge-ready.
+
+## Checklist
+
+- [ ] Scope matches the request; no drive-by edits
+- [ ] Tests cover the changed behavior
+- [ ] No secrets in the diff
+- [ ] Docs match the new surface
+- [ ] Independent review is present; do not self-approve
+`;
+  }
+}
+
+export function writeSkillFromTemplate(
+  name: string,
+  template: SkillTemplateId,
+  skillsRoot: string = getAgentPath("skills"),
+): { filePath: string } {
+  const safe = sanitizeSkillName(name);
+  const dir = join(skillsRoot, safe);
+  const filePath = join(dir, "SKILL.md");
+  if (existsSync(filePath)) {
+    throw new SkillNameError(`Skill already exists: ${safe}`);
+  }
+  mkdirSync(dir, { recursive: true });
+  writeFileSync(filePath, renderSkillTemplate(template, safe), "utf8");
+  invalidateSkillCache();
+  return { filePath };
+}
+
+export function buildSkillTemplateItems(): SelectItem[] {
+  return SKILL_TEMPLATE_IDS.map((id) => ({
+    value: id,
+    label: TEMPLATE_META[id].label,
+    description: TEMPLATE_META[id].description,
+  }));
+}
+
+function shellQuote(value: string): string {
+  return `'${value.replace(/'/g, `'"'"'`)}'`;
+}
+
+export function editorCommandFor(path: string): string {
+  const ed = process.env.EDITOR?.trim() || "nvim";
+  return `!${ed} ${shellQuote(path)}`;
+}
+
+function appendEditorText(ctx: any, text: string): void {
+  const current = ctx.ui.getEditorText?.() ?? "";
+  const separator = current && !current.endsWith("\n") ? "\n" : "";
+  ctx.ui.setEditorText(`${current}${separator}${text}\n`);
+}
+
+export async function pickSkillTemplate(
+  ctx: any,
+): Promise<SkillTemplateId | null> {
+  const selected = await showSelectOverlay(
+    ctx,
+    "New skill template",
+    "↑↓ navigate • enter choose • esc cancel",
+    buildSkillTemplateItems(),
+    SKILL_TEMPLATE_IDS.length,
+  );
+  return selected && isSkillTemplateId(selected.value)
+    ? selected.value
+    : null;
+}
+
+export async function runSkillsNew(ctx: any, args: string): Promise<void> {
+  let parsed: { name?: string; template: SkillTemplateId };
+  try {
+    parsed = parseSkillsNewArgs(args);
+  } catch (error) {
+    ctx.ui.notify(
+      error instanceof Error ? error.message : String(error),
+      "error",
+    );
+    return;
+  }
+
+  let template = parsed.template;
+  let name = parsed.name;
+  if (!name) {
+    const picked = await pickSkillTemplate(ctx);
+    if (!picked) return;
+    template = picked;
+    appendEditorText(ctx, `/skills new <name> ${template}`);
+    ctx.ui.notify(
+      `Replace <name> and run to create a ${template} skill.`,
+      "info",
+    );
+    return;
+  }
+
+  try {
+    const { filePath } = writeSkillFromTemplate(name, template);
+    appendEditorText(ctx, editorCommandFor(filePath));
+    ctx.ui.notify(`Created ${name} (${template}). Enter runs the editor.`, "info");
+  } catch (error) {
+    ctx.ui.notify(
+      error instanceof Error ? error.message : String(error),
+      "error",
+    );
+  }
+}