@groeponline/pi-wishcraft 0.17.3

package/RELEASE.md

@@ -0,0 +1,117 @@
+# Releasing `@groeponline/pi-wishcraft`
+
+This is the GroepOnline fork of `pi-powerline-footer`. It ships to npm as the
+scoped package `@groeponline/pi-wishcraft` and installs locally from the
+repo path. This doc records the end-to-end release flow and how to verify it.
+
+## Identity
+
+- **GitHub repo:** `GroepOnline/pi-wishcraft` (fork of `nicobailon/pi-powerline-footer`)
+- **npm package:** `@groeponline/pi-wishcraft` (scoped, `--access public`)
+- **Default branch:** `main`
+- **Local checkout:** `/home/joep/pi-wishcraft`
+- **Pi settings (`~/.pi/agent/settings.json`):** packages entry `/home/joep/pi-wishcraft` (local path, not the npm name) and `"powerline": "chef"`. Local edits are picked up on `/reload` — no reinstall needed.
+
+## The release flow
+
+A release is: bump version → roll CHANGELOG → commit → tag → push. The tag
+triggers CI which tests and publishes to npm.
+
+```bash
+# 1. Make sure the working tree is clean and tests/typecheck pass (see Verification)
+npm run typecheck        # tsc --noEmit
+npm test                 # node --experimental-strip-types --test tests/**/*.test.ts
+
+# 2. Release (patch | minor | major | explicit 1.2.3)
+npm run release minor    # = node scripts/release.mjs minor
+```
+
+`scripts/release.mjs` (zero deps, node built-ins only) does:
+
+1. Bumps `version` in `package.json`.
+2. Replaces the top `## [Unreleased]` heading in `CHANGELOG.md` with `## [<version>] - <YYYY-MM-DD>`.
+3. `git add package.json CHANGELOG.md`
+4. `git commit -m "chore: release <version>"`
+5. `git tag -a v<version> -m "Release <version>"`
+
+It does **not** push — it prints the push command. Push with the GroepOnline SSH
+identity (the laptop default `ssh`/OnlineChef key is denied for this org):
+
+```bash
+GIT_SSH_COMMAND='ssh -F ~/.ssh/config-groeponline -o IdentityFile=~/.ssh/sheesh' \
+  git push origin HEAD --tags
+```
+
+- SSH host alias: `github.com-groeponline` (defined in `~/.ssh/config-groeponline` with `IdentityFile ~/.ssh/sheesh`, `IdentitiesOnly yes`).
+- Push actor: `chefadmin-netizen` (GroepOnline SSH). API/`gh` actor: `MisterWanted` (FG) via `chef-gh`.
+
+## CI publish (on tag)
+
+`.github/workflows/release.yml` triggers on `push: tags: ['v*']`:
+
+1. `actions/checkout@v4`
+2. `actions/setup-node@v4` (node 24, `registry-url: https://registry.npmjs.org`)
+3. `npm ci --ignore-scripts` (installs devDependencies incl. `typescript`)
+4. `npm run typecheck` (tsc)
+5. `npm test` (node test runner)
+6. `npm publish --access public` with `NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}`
+
+`NPM_TOKEN` is a GitHub Actions secret on the repo (publish rights to the
+`@groeponline` scope). It is **not** readable after being set; verify it works by
+checking that the publish step on a real release succeeds and `npm view` resolves
+the new version (see below).
+
+The package has no build step — `*.ts` files are shipped directly (`pi.extensions:
+["./index.ts"]`), and Pi loads them with TypeScript stripping at runtime.
+
+## Verification (the "status" line)
+
+After a release, confirm each layer. Example for `0.15.0`:
+
+```bash
+# 1. Local: typecheck + tests green BEFORE tagging
+npm run typecheck        # exit 0
+npm test                 # "ℹ pass 170", "ℹ fail 0"
+
+# 2. Tag pushed
+git ls-remote --tags origin | grep v0.15.0   # shows v0.15.0 on origin
+
+# 3. CI Release workflow
+gh run list --repo GroepOnline/pi-wishcraft --workflow release.yml \
+  --limit 5 --json databaseId,status,conclusion,headBranch,url
+gh run view <databaseId> --repo GroepOnline/pi-wishcraft \
+  --log-failed   # or --log for full transcript
+
+# 4. npm registry (published + propagated)
+npm view @groeponline/pi-wishcraft version        # 0.15.0
+npm view @groeponline/pi-wishcraft dist-tags      # { latest: '0.15.0' }
+```
+
+A release is "done" when all four hold: local green, tag on origin, CI
+`success`, and `npm view` returns the new version.
+
+## Known gotchas
+
+- **npm propagation delay.** Right after `npm publish` the public registry can
+  404 on `npm view` for a short window (seconds to ~1 minute) even though the
+  publish succeeded. The CI log line `+ @groeponline/pi-wishcraft@<v>`
+  and HTTP `200` from `https://registry.npmjs.org/@groeponline%2fpi-wishcraft`
+  are the real success signals; retry `npm view` if you see an early 404.
+- **Wrong SSH key = `Permission denied (publickey)` / `denied to OnlineChef`.**
+  Always push with `GIT_SSH_COMMAND='ssh -F ~/.ssh/config-groeponline -o IdentityFile=~/.ssh/sheesh'`.
+- **TPS used to show absurd values** (e.g. `tps:12775`) because `sessionStartTime`
+  resets on extension reload while output is cumulative. Fixed in 0.15.0 with a
+  rolling token-rate. If TPS ever looks wrong again, check that `tpsSegment` still
+  uses the rolling/EMA path, not `output / elapsed`.
+- **Open-ports used to count raw `ss` lines** (IPv4+IPv6 double counting).
+  Fixed in 0.15.0 to dedupe by port number; column parsing is column-agnostic for
+  both `ss` and `netstat`.
+- The footer is rendered by Pi core (`FooterComponent.render` returns `string[]`),
+  so the live status bar cannot be clicked. Interactivity is delivered via
+  `alt+p` (navigable segment overlay), `/tps`, and `/open-ports`.
+
+## Versioning
+
+- **patch** (`0.15.0 → 0.15.1`): bug fixes, doc only.
+- **minor** (`0.15.x → 0.16.0`): new segments/presets, features, additive changes.
+- **major**: breaking changes to settings shape or exported API.

package/ROADMAP.md

@@ -0,0 +1,52 @@
+# Roadmap — what to improve & how to integrate better
+
+Status after 0.17.2. Package renamed to `@groeponline/pi-wishcraft` from v0.18.0. Concrete, prioritized. Not commitments — pick what Joep wants.
+
+## Next release (0.18.0 — pi-wishcraft)
+
+- Package renamed from `@groeponline/pi-powerline-footer` to `@groeponline/pi-wishcraft`
+- src/ restructure committed (all root-level monofiles moved to `src/<domain>/`)
+- Flaky `process.env.USER` test fixed
+- `npx madge --circular src index.ts bash-mode queue` added as CI step
+
+## Correctness (done, keep honest)
+
+- TPS = 1s sliding window over a 5s sample ring. **Verify it stays this way** if anyone touches `tpsSegment`. Do not regress to session-average or per-render EMA (both spike: `tps:12775`, `tps:1118`).
+- Open-ports = unique TCP by default; `openPorts.includeUdp` opts in. Column parsing is column-agnostic (ss + netstat).
+- Context segment hides on `contextWindow <= 0` (no more `NaN`/`??`).
+
+## Configurability improvements (next, low effort)
+
+1. **Labels for every segment, not just tps/open_ports.** Today `segmentLabels` is applied inside the two custom segments. Generalize: apply in `renderSegment` so `model`, `git`, `cost`, `context_pct`, `time`, … all honor a label. Small diff, big consistency win.
+2. **Per-segment `format`/`template` override.** Let users set e.g. `segmentOptions.tps.template: "{value} tok/s"` or `time.format: "HH:mm"`. Template > label for full control.
+3. **Visibility toggle per segment from the menu.** `Configure…` already changes preset/TPS/UDP/labels; add "disable segment" / "enable segment" that writes `powerline.disabledSegments` live (no edit-the-JSON round-trip).
+4. **Preset editor in the menu.** Build a custom preset interactively (pick left/right segments) and save it to settings — today custom presets are JSON-only.
+5. **`segmentOptions.tps.windowMs`** — expose the 1s window length so fast models (Groq) can widen it for a smoother read.
+
+## Interaction improvements (the "levendig + klikbaar" thread)
+
+1. **Sub-menus via stacked overlays.** `ctx.ui.custom()` closes on `done()`; a sub-menu opens a new `custom()`. Today the menu uses `ctx.ui.select` (flat). Upgrade the navigator + configure to overlay `SelectList` for arrow nav + descriptions, matching the segment-navigator chrome.
+2. **Per-segment "more info" on a second key.** In the navigator, `enter` activates, `→`/`tab` opens a detail view for that segment (full ports list, git diff summary, cost breakdown, context window math). This is the "soort gelijk menu maar anders waar je bijv alle open ports kan zien" Joep asked for.
+3. **Live refresh while the overlay is open.** Overlays re-render on `tui.requestRender()`; wire a light timer so the ports list / TPS detail tick while open.
+4. **Mouse support** — not available; Pi core owns the footer. Keep documenting that overlay nav is the equivalent.
+
+## Integration with ChefGroep surfaces
+
+1. **ChefBar / command center.** Expose powerline state (preset, TPS, ports, cost) via `ctx.ui.setStatus("powerline-tps", …)` so ChefBar/other extensions can read it. Already partly there (extension statuses); formalize a stable key set (`powerline.tps`, `powerline.ports`, `powerline.preset`).
+2. **joep-ops / Vault dashboard.** The same `ss`/token data could feed a fleet dashboard. Factor `countListeningPorts` + a token-rate sampler into a tiny shared module both can import (keep it in this repo, export it).
+3. **PostHog.** Capture preset/menu usage events (`powerline.preset_changed`, `powerline.menu_opened`) per the org instrumentation rule — only if Joep opts in; the bar itself stays telemetry-free.
+4. **Fleet (sofie/bc-scan-2).** `open_ports` is laptop-local. A fleet variant could SSH-probe a named host's ports; gate behind a `segmentOptions.openPorts.host` setting.
+
+## Release/quality
+
+1. **Dependabot vulns** — GitHub flagged 7 (3 high, 4 moderate) on default branch. Triage; most are devDep transitive. Add `npm audit` to CI as non-blocking info, or pin.
+2. **Test the menu.** The overlay/menu functions aren't unit-tested (hard to test `ctx.ui.custom` headless). Add a thin `SelectList`-based pure function for "build segment items" and test that, leaving the overlay shell untested.
+3. **Typecheck in pre-push.** Add a `prepublishOnly` that runs `tsc` so a bad type never ships even if CI is skipped.
+4. `npm deprecate @groeponline/pi-powerline-footer "Renamed to @groeponline/pi-wishcraft"` after first successful publish under new name
+5. `prepublishOnly` script with `tsc` to prevent bad types from shipping
+
+## Not doing (YAGNI)
+
+- No mouse/click on the live footer (Pi core limitation; overlay nav is the path).
+- No custom "embed/component" registration for footer segments — segments are data (text), and `customItems` + `command/env/static` segments already cover user-defined content. `setWidget`/`registerEntryRenderer` are for chat, not the footer.
+- No third control surface — keep interactivity in this extension's overlays + commands.

package/bash-mode/completion-providers.ts

@@ -0,0 +1,269 @@
+import type {
+  AutocompleteItem,
+  AutocompleteProvider,
+  AutocompleteSuggestions,
+} from "@earendil-works/pi-tui";
+
+import {
+  getOneOffBashCommandContext,
+  isExtendedCompletionItem,
+  supportsShouldTriggerFileCompletion,
+} from "./completion.ts";
+import type { ExtendedCompletionItem } from "./types.ts";
+
+function applyExtendedCompletion(
+  lines: string[],
+  cursorLine: number,
+  item: ExtendedCompletionItem,
+): {
+  lines: string[];
+  cursorLine: number;
+  cursorCol: number;
+} {
+  const currentLine = lines[cursorLine] || "";
+  const startCol = Math.max(0, Math.min(item.startCol, currentLine.length));
+  const endCol = Math.max(startCol, Math.min(item.endCol, currentLine.length));
+  const nextLine =
+    currentLine.slice(0, startCol) +
+    item.replacement +
+    currentLine.slice(endCol);
+  const nextLines = [...lines];
+  nextLines[cursorLine] = nextLine;
+  return {
+    lines: nextLines,
+    cursorLine,
+    cursorCol: startCol + item.replacement.length,
+  };
+}
+
+export class BashAutocompleteProvider implements AutocompleteProvider {
+  async getSuggestions(): Promise<AutocompleteSuggestions | null> {
+    return null;
+  }
+
+  applyCompletion(
+    lines: string[],
+    cursorLine: number,
+    cursorCol: number,
+    item: AutocompleteItem,
+  ): {
+    lines: string[];
+    cursorLine: number;
+    cursorCol: number;
+  } {
+    if (!isExtendedCompletionItem(item)) {
+      throw new Error(
+        "Expected an extended completion item for bash autocomplete",
+      );
+    }
+
+    return applyExtendedCompletion(lines, cursorLine, item);
+  }
+
+  shouldTriggerFileCompletion(): boolean {
+    return false;
+  }
+}
+
+export class OneOffBashAutocompleteProvider implements AutocompleteProvider {
+  async getSuggestions(): Promise<AutocompleteSuggestions | null> {
+    return null;
+  }
+
+  applyCompletion(
+    lines: string[],
+    cursorLine: number,
+    cursorCol: number,
+    item: AutocompleteItem,
+  ): {
+    lines: string[];
+    cursorLine: number;
+    cursorCol: number;
+  } {
+    if (!isExtendedCompletionItem(item)) {
+      throw new Error(
+        "Expected an extended completion item for one-off bash autocomplete",
+      );
+    }
+
+    return applyExtendedCompletion(lines, cursorLine, item);
+  }
+
+  shouldTriggerFileCompletion(
+    lines: string[],
+    cursorLine: number,
+    cursorCol: number,
+  ): boolean {
+    const bang =
+      cursorLine === 0 ? getOneOffBashCommandContext(lines[0] || "") : null;
+    return bang !== null && cursorCol >= bang.offset;
+  }
+}
+
+function getProviderTriggerCharacters(
+  provider: AutocompleteProvider | undefined,
+): string[] {
+  const candidate =
+    provider && typeof provider === "object"
+      ? Reflect.get(provider, "triggerCharacters")
+      : undefined;
+  return Array.isArray(candidate)
+    ? candidate.filter(
+        (character): character is string =>
+          typeof character === "string" && character.length === 1,
+      )
+    : [];
+}
+
+export class ModeAwareAutocompleteProvider implements AutocompleteProvider {
+  readonly triggerCharacters: string[];
+  private readonly defaultProvider: AutocompleteProvider | undefined;
+  private readonly bashProvider: AutocompleteProvider;
+  private readonly oneOffBashProvider: AutocompleteProvider;
+  private readonly isBashModeActive: () => boolean;
+
+  constructor(
+    defaultProvider: AutocompleteProvider | undefined,
+    bashProvider: AutocompleteProvider,
+    oneOffBashProvider: AutocompleteProvider,
+    isBashModeActive: () => boolean,
+  ) {
+    this.defaultProvider = defaultProvider;
+    this.bashProvider = bashProvider;
+    this.oneOffBashProvider = oneOffBashProvider;
+    this.isBashModeActive = isBashModeActive;
+    this.triggerCharacters = [
+      ...new Set([
+        ...getProviderTriggerCharacters(defaultProvider),
+        ...getProviderTriggerCharacters(bashProvider),
+        ...getProviderTriggerCharacters(oneOffBashProvider),
+      ]),
+    ];
+  }
+
+  async getSuggestions(
+    lines: string[],
+    cursorLine: number,
+    cursorCol: number,
+    options: { signal: AbortSignal; force?: boolean },
+  ): Promise<AutocompleteSuggestions | null> {
+    if (this.isBashModeActive()) {
+      return this.bashProvider.getSuggestions(
+        lines,
+        cursorLine,
+        cursorCol,
+        options,
+      );
+    }
+
+    const shouldUseOneOffBash =
+      supportsShouldTriggerFileCompletion(this.oneOffBashProvider) &&
+      this.oneOffBashProvider.shouldTriggerFileCompletion(
+        lines,
+        cursorLine,
+        cursorCol,
+      );
+    if (shouldUseOneOffBash) {
+      return this.oneOffBashProvider.getSuggestions(
+        lines,
+        cursorLine,
+        cursorCol,
+        options,
+      );
+    }
+
+    return (
+      this.defaultProvider?.getSuggestions(lines, cursorLine, cursorCol, options) ??
+      null
+    );
+  }
+
+  applyCompletion(
+    lines: string[],
+    cursorLine: number,
+    cursorCol: number,
+    item: AutocompleteItem,
+    prefix: string,
+  ) {
+    if (this.isBashModeActive()) {
+      return this.bashProvider.applyCompletion(
+        lines,
+        cursorLine,
+        cursorCol,
+        item,
+        prefix,
+      );
+    }
+
+    const shouldUseOneOffBash =
+      supportsShouldTriggerFileCompletion(this.oneOffBashProvider) &&
+      this.oneOffBashProvider.shouldTriggerFileCompletion(
+        lines,
+        cursorLine,
+        cursorCol,
+      );
+    if (shouldUseOneOffBash) {
+      return this.oneOffBashProvider.applyCompletion(
+        lines,
+        cursorLine,
+        cursorCol,
+        item,
+        prefix,
+      );
+    }
+
+    if (!this.defaultProvider) {
+      return { lines, cursorLine, cursorCol };
+    }
+    return this.defaultProvider.applyCompletion(
+      lines,
+      cursorLine,
+      cursorCol,
+      item,
+      prefix,
+    );
+  }
+
+  shouldTriggerFileCompletion(
+    lines: string[],
+    cursorLine: number,
+    cursorCol: number,
+  ): boolean {
+    if (this.isBashModeActive()) {
+      if (!supportsShouldTriggerFileCompletion(this.bashProvider)) {
+        return true;
+      }
+      const bashProvider = this.bashProvider;
+      return bashProvider.shouldTriggerFileCompletion(
+        lines,
+        cursorLine,
+        cursorCol,
+      );
+    }
+
+    const oneOffBashProvider = this.oneOffBashProvider;
+    const shouldUseOneOffBash =
+      supportsShouldTriggerFileCompletion(oneOffBashProvider) &&
+      oneOffBashProvider.shouldTriggerFileCompletion(
+        lines,
+        cursorLine,
+        cursorCol,
+      );
+    if (shouldUseOneOffBash) {
+      return true;
+    }
+
+    if (
+      !this.defaultProvider ||
+      !supportsShouldTriggerFileCompletion(this.defaultProvider)
+    ) {
+      return false;
+    }
+    const defaultProvider = this.defaultProvider;
+    return defaultProvider.shouldTriggerFileCompletion(
+      lines,
+      cursorLine,
+      cursorCol,
+    );
+  }
+}