@grknbyk/agent-wire 0.13.0 → 0.13.2

package/README.md

@@ -35,7 +35,7 @@ agent-wire setup
 ```
 
 Run `setup` in a real terminal window. It asks questions, so it refuses a pipe, a
-script, and an editor task — an agent that tries to run it from a tool gets a
+script, and an editor task. An agent that tries to run it from a tool gets a
 one-line refusal and usually tells you the wrong thing about why.
 
 On macOS the first line often fails with `EACCES` on `/usr/local/lib/node_modules`,
@@ -56,7 +56,7 @@ the Bot User OAuth Token back. Then you create the channel in Slack and type
 
 **Give every install its own nickname.** The first key seen under a name is pinned
 to it, so a second install answering to the same name is reported as `impostor` by
-everyone who already heard from the first — and a forged sighting stays on the
+everyone who already heard from the first, and a forged sighting stays on the
 record even after a later message verifies.
 
 The whole team shares one Slack app and one bot token. Only the first person
@@ -138,7 +138,7 @@ again.
 
 `status` returns the same card the CLI draws, already fenced. It exists because a
 shell result gets read, understood and then retyped as prose, and a drawn box does
-not survive that — two installs reporting the same state should not produce two
+not survive that. Two installs reporting the same state should not produce two
 different-looking answers.
 
 The mode of a channel is a command the user runs, never a tool. A message
@@ -169,7 +169,7 @@ file was left there.
 
 Every channel the bot is in is a channel it works in. Slack owns that list, so
 `setup` and `doctor` read it rather than asking, and a channel renamed in Slack
-keeps working — the config stores the id and refreshes the name.
+keeps working: the config stores the id and refreshes the name.
 
 Every message is tagged with the channel it came from, `send` takes an optional
 `channel`, and `inbox` can filter by one. The first entry is the default.
@@ -198,7 +198,7 @@ Unread messages : mira(5), kai(2)
 Loudest sender first, because five messages from one person is a conversation
 waiting while one each from five people is a standup. Past five names the rest
 become `+3 more`. Anything that failed its signature check is called out on the
-same line — `[1 FORGED]` — rather than counted in silently.
+same line as `[1 FORGED]`, rather than counted in silently.
 
 `read` is the one to think about before turning on: it puts other people's
 writing into your agent's prompt without you asking. It arrives inside the same
@@ -210,8 +210,8 @@ content share a page.
 ### What "per session" means
 
 A session is identified by the client's own session id when the client publishes
-one. Claude Code puts `CLAUDE_CODE_SESSION_ID` into everything it spawns — the MCP
-server, the prompt hook and the shell alike — so two windows open on one project
+one. Claude Code puts `CLAUDE_CODE_SESSION_ID` into everything it spawns (the MCP
+server, the prompt hook and the shell alike), so two windows open on one project
 hold different modes. The nickname, the keys and the Slack app stay shared.
 
 A plain terminal has no session id, so a mode command there lands on the working
@@ -237,7 +237,7 @@ everything it is handed, and if that also marked the message read next door, an
 
 The poller is not per session. One poller feeds one shared log for the whole
 machine, so a channel stays polled while any session still wants it. `off` means
-"do not tell me", not "stop collecting" — otherwise the quietest session on the
+"do not tell me", not "stop collecting". Otherwise the quietest session on the
 machine would decide what the busiest one is allowed to see.
 
 ## Working on two of five channels
@@ -281,7 +281,7 @@ With one channel configured the name is the whole argument, so it is dropped:
 
 The MCP server offers the same three as prompts, which a client shows in its
 slash-command list: `/mcp__agent-wire__read` in Claude Code. Nothing needs to be
-copied into `~/.claude/commands/` — the package carries them. A prompt is offered
+copied into `~/.claude/commands/`, because the package carries them. A prompt is offered
 to the user and invoked by nobody else, so this is the same boundary as the shell
 command, minus the typing.
 
@@ -324,7 +324,7 @@ The channel is read by the colleagues who own these agents, under their own name
 in a normal Slack client. Two things follow from that.
 
 The handshake tells the agent what the channel is for, which is the part that
-reaches judgement — the message that prompted this was innuendo with no banned
+reaches judgement. The message that prompted this was innuendo with no banned
 word in it, and no list would have caught it.
 
 Then a short list of slurs is refused at `send`, before Slack and before the log.
@@ -375,9 +375,8 @@ governs. If a payload contains the live delimiter, it is replaced with
 `[FENCE-ECHO REDACTED]`, which turns reflection into a visible event instead of a
 silently broken boundary.
 
-Be clear about what this buys you. An attacker cannot close the fence, and does
-not need to, because text inside a correctly labelled `UNTRUSTED` block still
-reads as language to a model. The fence makes the labelling accurate. Hostile
+An attacker cannot close the fence, and does not need to, because text inside a
+correctly labelled `UNTRUSTED` block still reads as language to a model. The fence makes the labelling accurate. Hostile
 text stays exactly as persuasive as it was, so this is a boundary rather than a
 filter.
 
@@ -417,9 +416,9 @@ column 60 so a scrolled channel has one straight edge to read down:
 🛰️ mehmet-emin-kaya => hakan-akduman       wms-agents@8g88zm
 ```
 
-Scrolling the channel and want your agent to look at that one line? Say
-"wms-agents@k7m2pq oku" and it fetches exactly that message, whatever channel it
-came from and whether it was already read. Beats copying a Slack timestamp.
+To point your agent at one line you scrolled past, say "wms-agents@k7m2pq oku".
+It fetches that message whatever channel it came from and whether it was already
+read, which saves copying a Slack timestamp.
 
 The six characters come from an alphabet with no `i`, `l`, `o`, `0` or `1`
 in it, because the point is retyping it from a screen. The channel name in front
@@ -427,11 +426,11 @@ keeps two channels from ever meaning the same handle. Your agent is told the
 handle after every send, so it can quote it back to you.
 
 Slack's font is proportional, so the right edge is close rather than exact. A
-nickname long enough to reach the column pushes past it instead of being cut —
-losing the edge on one line costs less than losing a character of somebody's
+nickname long enough to reach the column pushes past it instead of being cut.
+Losing the edge on one line costs less than losing a character of somebody's
 name.
 
-Like the header line around it, the handle is decoration — unsigned, and anyone
+Like the header line around it, the handle is decoration: unsigned, and anyone
 in the channel can type one. It names a message; the signature is what proves
 who wrote it.
 
@@ -481,13 +480,13 @@ reinstalled app cannot produce duplicates.
 - Discord as a second transport
 - Published measurements of fenced against unfenced injection compliance
 
-Wire format v2 signs the attached file id alongside the text, so a 0.5 agent and
-a 0.4 agent cannot verify each other. Upgrade both ends together.
+Wire format v2 signs the attached file id alongside the text, so two agents on
+different wire formats cannot verify each other. Upgrade both ends together.
 
 ## Development
 
 ```bash
-npm test       # 60 tests, no network
+npm test       # 86 tests, no network
 npm run bench  # medians over a synthetic 20k-message log
 ```
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@grknbyk/agent-wire",
-    "version": "0.13.0",
+    "version": "0.13.2",
     "description": "Let AI coding agents message each other through a shared Slack channel, over MCP.",
     "type": "module",
     "license": "MIT",

package/src/config.mjs

@@ -192,5 +192,5 @@ export function setChannelMode(name, mode) {
 export function findChannel(config, wanted) {
     if (!wanted) return defaultChannel(config);
     const name = String(wanted).replace(/^#/, '').toLowerCase();
-    return config.channels?.find((c) => c.name.toLowerCase() === name || c.id === wanted) ?? null;
+    return config.channels?.find((channel) => channel.name.toLowerCase() === name || channel.id === wanted) ?? null;
 }

package/src/drain.mjs

@@ -16,7 +16,7 @@ export function senderTally(items) {
     const counts = new Map();
     for (const item of items) counts.set(item.from, (counts.get(item.from) ?? 0) + 1);
 
-    const ranked = [...counts].sort((left, right) => right[1] - left[1]);
+    const ranked = [...counts].sort(([, leftCount], [, rightCount]) => rightCount - leftCount);
     const shown = ranked.slice(0, SENDERS_SHOWN).map(([from, count]) => `${from}(${count})`);
     const hidden = ranked.length - shown.length;
     return hidden > 0 ? `${shown.join(', ')}, +${hidden} more` : shown.join(', ');

package/src/hook.mjs

@@ -56,8 +56,8 @@ export function installHook(path = settingsPath()) {
     mkdirSync(dirname(path), { recursive: true });
     if (existsSync(path)) writeFileSync(`${path}.agent-wire.bak`, readFileSync(path));
 
-    const temporary = `${path}.${process.pid}.tmp`;
-    writeFileSync(temporary, `${JSON.stringify(merged, null, 2)}\n`);
-    renameSync(temporary, path);
+    const tempFile = `${path}.${process.pid}.tmp`;
+    writeFileSync(tempFile, `${JSON.stringify(merged, null, 2)}\n`);
+    renameSync(tempFile, path);
     return { ok: true, path, backedUp: settings !== null };
 }

package/src/inbox.mjs

@@ -98,8 +98,8 @@ const STATE_KEYS_MAX = 8000;
 const STATE_KEYS_KEEP = 6000;
 
 const scopeOfKey = (key) => {
-    const bar = key.indexOf('|');
-    return bar === -1 ? '' : key.slice(0, bar); // written before scopes existed
+    const separator = key.indexOf('|');
+    return separator === -1 ? '' : key.slice(0, separator); // written before scopes existed
 };
 
 function prunedStates(states) {
@@ -160,9 +160,13 @@ export const findByTs = (ts) => readInbox().find((item) => item.ts === ts) ?? nu
 
 // Newest first: a ref is short enough to collide eventually, and the one a person
 // just read off the channel is the recent one.
-export const findByRef = (ref) => readInbox()
-    .filter((item) => item.ref === String(ref).replace(/^@/, '').toLowerCase())
-    .at(-1) ?? null;
+export function findByRef(handle) {
+    const [channel, ref] = String(handle).toLowerCase().split('@');
+    const wanted = ref ?? channel;
+    return readInbox()
+        .filter((item) => item.ref === wanted && (!ref || !channel || item.channel === channel))
+        .at(-1) ?? null;
+}
 
 export const readCursor = (channelId) => readJsonCached(paths.cursors, {})[channelId] ?? null;
 

package/src/mcp.mjs

@@ -262,7 +262,7 @@ async function sendText(config, { to, text, channel, replyTo }) {
 
     const client = slackClient(config.bot_token);
     const ref = mintRef();
-    const rendered = formatMessage({ mark: config.mark, from: config.nickname, to, text, ref });
+    const rendered = formatMessage({ mark: config.mark, from: config.nickname, to, text, ref, channel: target.name });
     const signature = signMessage(config.private_key, {
         channel: target.id, from: config.nickname, to, conv: chain.conv, hop: chain.hop, text,
     });
@@ -279,7 +279,7 @@ async function sendText(config, { to, text, channel, replyTo }) {
     if (!posted.ok) return `Slack rejected it (${posted.reason})`;
 
     recordOwnMessage(config, { ts: posted.ts, target, to, text, chain, ref });
-    return `delivered to ${to} in #${target.name} as @${ref}`;
+    return `delivered to ${to} in #${target.name} as ${target.name}@${ref}`;
 }
 
 // Our own sent messages go into the local log too, so the log is a complete
@@ -319,7 +319,7 @@ async function postFile(config, { to, path, note, target, chain, logText }) {
     });
     const posted = await postMessage(client, {
         channel: target.id,
-        rendered: formatMessage({ mark: config.mark, from: config.nickname, to, text, ref }),
+        rendered: formatMessage({ mark: config.mark, from: config.nickname, to, text, ref, channel: target.name }),
         signature,
         publicKey: config.public_key,
         from: config.nickname,
@@ -351,7 +351,7 @@ async function sendLongText(config, { to, text, target, chain }) {
     unlinkSync(path);
     if (!result.ok) return result.message;
 
-    return `delivered to ${to} in #${result.channelName} as @${result.ref} — ${text.length} characters, sent as a file`;
+    return `delivered to ${to} in #${result.channelName} as ${result.channelName}@${result.ref} — ${text.length} characters, sent as a file`;
 }
 
 async function call(name, args, session) {
@@ -454,7 +454,7 @@ async function call(name, args, session) {
         });
         if (!result.ok) return result.message;
 
-        return `sent ${result.name} to ${args.to} in #${result.channelName} as @${result.ref}`;
+        return `sent ${result.name} to ${args.to} in #${result.channelName} as ${result.channelName}@${result.ref}`;
     }
 
     if (name === 'archive') return `archived ${archive(args.ts)} message(s)`;

package/src/protocol.mjs

@@ -20,14 +20,14 @@ export const MAX_HOPS = 8;
 // Slack escapes these three on the way in, so they are escaped on the way out and
 // restored on the way in. & is decoded last: decoding it first would turn a
 // literal "&amp;lt;" into "<".
-export const toSlackText = (s) => String(s).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
+export const toSlackText = (text) => String(text).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
 
 // Slack rewrites a bare URL to <url> or <url|label>. Scheme-anchored on purpose:
 // stripping every <...> would eat <div> out of a code block, which is exactly the
 // content this has to survive.
-const unlinkify = (s) => s.replace(/<((?:https?:\/\/|mailto:)[^|>]+)(\|[^>]*)?>/g, '$1');
+const unlinkify = (text) => text.replace(/<((?:https?:\/\/|mailto:)[^|>]+)(\|[^>]*)?>/g, '$1');
 
-export const fromSlackText = (s) => unlinkify(String(s))
+export const fromSlackText = (text) => unlinkify(String(text))
     .replace(/&lt;/g, '<').replace(/&gt;/g, '>').replace(/&amp;/g, '&');
 
 // A short handle printed at the right edge of the header line, so a human
@@ -72,25 +72,30 @@ export function formatMessage({ mark, from, to, text, ref, channel }) {
     const left = `${mark ? `${mark} ` : ''}${from} => ${to}`;
     if (!ref) return `${left}\n${toSlackText(text)}\n`;
 
-    const handle = `${channel ?? ''}@${ref}`;
+    // Shipped once without this: a call site forgot the channel, the handle went out
+    // bare, and every test still passed because they all called this directly.
+    if (!channel) throw new TypeError(`formatMessage: ref ${ref} with no channel to put in front of it`);
+
+    const handle = `${channel}@${ref}`;
     const gap = Math.max(1, HEADER_WIDTH - displayWidth(left) - handle.length);
     return `${left}${' '.repeat(gap)}${handle}\n${toSlackText(text)}\n`;
 }
 
 // Rejects "*" as a sender so a bold-wrapped line cannot file a message under "*".
-const HEADER = /^(?:(\S+)\s+)?([^\s=*]+)\s*=>\s*(\S+?)(?:\s+([a-z0-9][\w.-]*)?@([a-z2-9]{4,12}))?$/;
+const HEADER = /^(?:(?<mark>\S+)\s+)?(?<from>[^\s=*]+)\s*=>\s*(?<to>\S+?)(?:\s+(?<refChannel>[a-z0-9][\w.-]*)?@(?<ref>[a-z2-9]{4,12}))?$/;
 
 export function parseMessage(raw) {
     const lines = fromSlackText(String(raw ?? '').replace(/\r\n/g, '\n')).trim().split('\n');
     const header = HEADER.exec((lines[0] ?? '').trim());
     if (!header) return null;
 
+    const { mark, from, to, refChannel, ref } = header.groups;
     return {
-        mark: header[1] ?? '',
-        from: header[2],
-        to: header[3],
-        refChannel: header[4] ?? '',
-        ref: header[5] ?? '',
+        mark: mark ?? '',
+        from,
+        to,
+        refChannel: refChannel ?? '',
+        ref: ref ?? '',
         text: lines.slice(1).join('\n').trim(),
     };
 }

package/src/setup.mjs

@@ -83,7 +83,7 @@ const markFor = (nickname) => {
 
 export async function runSetup() {
     // Setup is a conversation, so it needs a terminal on the other end. Without
-    // one, stdin reaches end of file before the first answer and rl.question()
+    // one, stdin reaches end of file before the first answer and terminal.question()
     // waits for a line that can never arrive: the process hangs with no output.
     if (!process.stdin.isTTY) {
         console.log('agent-wire setup needs an interactive terminal.');
@@ -91,12 +91,12 @@ export async function runSetup() {
         return 1;
     }
 
-    const rl = createInterface({ input: process.stdin, output: process.stdout });
+    const terminal = createInterface({ input: process.stdin, output: process.stdout });
     // A terminal can still close mid-answer, on Ctrl-D or a lost session. Race
     // the question against that, or the same silent hang comes back.
     const ask = (question) => Promise.race([
-        rl.question(question),
-        new Promise((_, reject) => rl.once('close', () => reject(new Error('input closed')))),
+        terminal.question(question),
+        new Promise((_, reject) => terminal.once('close', () => reject(new Error('input closed')))),
     ]);
 
     try {
@@ -194,7 +194,7 @@ export async function runSetup() {
         console.log('\nStopped: no more input. Re-run setup — it resumes where it left off.');
         return 1;
     } finally {
-        rl.close();
+        terminal.close();
     }
 }
 

package/src/slack.mjs

@@ -202,10 +202,10 @@ async function downloadAll(client, files) {
 }
 
 async function downloadById(client, fileId) {
-    const info = await client.form('files.info', { file: fileId });
-    if (!info.ok) return [];
+    const fileInfo = await client.form('files.info', { file: fileId });
+    if (!fileInfo.ok) return [];
 
-    const saved = await downloadAttachment(client, info.file);
+    const saved = await downloadAttachment(client, fileInfo.file);
     return saved ? [saved] : [];
 }