@griddo/ax 12.4.0 → 12.5.0

package/src/__tests__/components/Fields/FileField/FileField.test.tsx

@@ -13,7 +13,13 @@ import { defaultStore } from "./../../../../__mocks__/store/GenericStore";
 
 afterEach(cleanup);
 
-const defaultProps = mock<IFileFieldProps>();
+// Props por test. Antes se compartía un objeto mutable: el segundo test dejaba
+// `value` en undefined y los dos de "onClick events" contaban con eso sin
+// decirlo, así que al reordenarlos se caían.
+const makeProps = (overrides: Partial<IFileFieldProps> = {}): IFileFieldProps =>
+	Object.assign(mock<IFileFieldProps>(), overrides);
+
+const fileValue = { url: "google.es", uploadDate: "1/1/2022", sizeBytes: "123" };
 
 const initialStore = {
 	...defaultStore,
@@ -37,11 +43,9 @@ const store = mockStore(initialStore);
 
 describe("FileField component rendering", () => {
 	it("should render the component", () => {
-		defaultProps.value.url = "google.es";
-
 		render(
 			<ThemeProvider theme={parseTheme(globalTheme)}>
-				<FileField {...defaultProps} />
+				<FileField {...makeProps({ value: { url: "google.es" } })} />
 			</ThemeProvider>,
 			{ store },
 		);
@@ -52,11 +56,9 @@ describe("FileField component rendering", () => {
 	});
 
 	it("should render the component when there is not value", () => {
-		defaultProps.value = undefined;
-
 		render(
 			<ThemeProvider theme={parseTheme(globalTheme)}>
-				<FileField {...defaultProps} />
+				<FileField {...makeProps({ value: undefined })} />
 			</ThemeProvider>,
 			{ store },
 		);
@@ -71,7 +73,7 @@ describe("onClick events", () => {
 	it("should open FileDragAndDrop when clicking the file button", () => {
 		const Component = (
 			<ThemeProvider theme={parseTheme(globalTheme)}>
-				<FileField {...defaultProps} />
+				<FileField {...makeProps({ value: undefined })} />
 			</ThemeProvider>
 		);
 
@@ -89,7 +91,7 @@ describe("onClick events", () => {
 	it("should not open FileDragAndDrop when clicking the file button", () => {
 		const Component = (
 			<ThemeProvider theme={parseTheme(globalTheme)}>
-				<FileField {...defaultProps} disabled />
+				<FileField {...makeProps({ value: undefined })} disabled />
 			</ThemeProvider>
 		);
 
@@ -105,11 +107,9 @@ describe("onClick events", () => {
 	});
 
 	it("should call handleOnClickUrl when clicking the url button", () => {
-		defaultProps.value = { url: "google.es", uploadDate: "1/1/2022", sizeBytes: "123" };
-
 		const Component = (
 			<ThemeProvider theme={parseTheme(globalTheme)}>
-				<FileField {...defaultProps} />
+				<FileField {...makeProps({ value: fileValue })} />
 			</ThemeProvider>
 		);
 
@@ -136,12 +136,11 @@ describe("onClick events", () => {
 	});
 
 	it("should call onChange when clicking the delete action", () => {
-		defaultProps.value = { url: "google.es", uploadDate: "1/1/2022", sizeBytes: "123" };
 		const onChange = vi.fn();
 
 		const Component = (
 			<ThemeProvider theme={parseTheme(globalTheme)}>
-				<FileField {...defaultProps} onChange={onChange} />
+				<FileField {...makeProps({ value: fileValue })} onChange={onChange} />
 			</ThemeProvider>
 		);