@grepr/cli 1.13.0-2632478 → 1.14.3-a181b29

package/build/dist/lib/docs-search.js

@@ -1,12 +1,20 @@
-import { LocalDocumentIndex } from 'vectra';
 import path from 'path';
 import { fileURLToPath } from 'url';
-import { TransformersEmbeddings } from './transformers-embeddings.js';
+import { docsIndexExists, readDocsIndex } from './docs-index.js';
+import { KeywordScorer } from './keyword-scorer.js';
+import { MiniLmEmbedder } from './text-embedder.js';
+/** Excerpts returned per matching document. */
+const MAX_SECTIONS = 3;
+/**
+ * How much keyword (BM25) relevance counts next to embedding similarity in a chunk's score.
+ * Swept from 0 to 1 on two labelled query sets (100 queries): both do well between 0.2 and 0.3,
+ * and the set whose queries deliberately avoid the docs' own wording falls off above 0.3.
+ */
+const KEYWORD_WEIGHT = 0.25;
 /**
  * Semantic search engine for Grepr documentation.
  *
- * This class provides high-level search functionality over a pre-built Vectra index
- * of documentation files. Key architectural decisions:
+ * Key architectural decisions:
  *
  * 1. **Build-time indexing**: The documentation index is generated at build time
  *    by scripts/build-docs-index.ts and bundled with the CLI distribution. This
@@ -19,25 +27,27 @@ import { TransformersEmbeddings } from './transformers-embeddings.js';
  *    location (build/dist/lib/), pointing to build/dist/docs-index/. This works
  *    both during development and after npm publication.
  *
- * 4. **Two-stage filtering**: Vectra returns top-K results by similarity, then we
- *    apply threshold filtering. This ensures we always consider the most relevant
- *    documents even if they're below threshold.
+ * 4. **Exhaustive matching**: The index holds a few thousand chunks, so a query is
+ *    compared against every one of them; there is no approximate-nearest-neighbour
+ *    structure to build or tune.
  */
 export class DocsSearch {
     index = null;
+    keywordScorer = null;
     indexPath;
-    embeddings;
+    embedder;
     /**
      * Creates a new DocsSearch instance.
      *
-     * The constructor sets up paths and creates the embeddings provider, but does
+     * The constructor sets up paths and creates the embedder, but does
      * NOT load the model or index yet (lazy initialization).
      *
      * @param indexPath - Optional path to the index directory. If not provided,
      *                    defaults to the bundled docs-index directory relative to
      *                    this file. Used primarily for testing with temporary indices.
+     * @param embedder - Optional embedder; must be the one the index was built with.
      */
-    constructor(indexPath, embeddings) {
+    constructor(indexPath, embedder) {
         if (indexPath) {
             this.indexPath = indexPath;
         }
@@ -46,61 +56,50 @@ export class DocsSearch {
             const __dirname = path.dirname(__filename);
             this.indexPath = path.resolve(__dirname, '../docs-index');
         }
-        this.embeddings = embeddings ?? new TransformersEmbeddings('Xenova/all-MiniLM-L6-v2', 512);
+        this.embedder = embedder ?? new MiniLmEmbedder();
     }
     async openIndex() {
         if (this.index) {
             return this.index;
         }
-        const index = new LocalDocumentIndex({
-            folderPath: this.indexPath,
-            embeddings: this.embeddings
-        });
-        if (!(await index.isIndexCreated())) {
+        if (!(await docsIndexExists(this.indexPath))) {
             throw new Error('Documentation index not found. The CLI package may be corrupted. ' +
                 'Please reinstall the CLI: npm install -g @grepr/cli');
         }
-        this.index = index;
-        return index;
+        this.index = await readDocsIndex(this.indexPath);
+        return this.index;
     }
     /**
      * Initializes the search engine by loading the embedding model and opening the index.
      *
      * This method is idempotent - multiple calls have no effect after the first successful
-     * initialization. It performs the following steps:
-     * 1. Loads the Transformers.js embedding model (downloads on first run)
-     * 2. Opens the Vectra index from the bundled docs-index directory
-     * 3. Verifies the index exists and is valid
+     * initialization.
      *
      * @throws Error if the index is not found or corrupted. This typically indicates
      *         a corrupted CLI installation and the user should reinstall.
      */
     async initialize() {
-        await this.embeddings.initialize();
+        await this.embedder.initialize();
         return this.openIndex();
     }
     /**
      * Performs semantic search over the documentation.
      *
-     * This method converts the query text into an embedding vector and finds the most
-     * similar documents in the index using cosine similarity. The search process:
+     * The search process:
      *
-     * 1. Auto-initializes if not already initialized
-     * 2. Generates embedding for the query text
-     * 3. Performs vector similarity search via Vectra
-     * 4. Filters results by threshold (if specified)
-     * 5. Renders document sections with minimal context (focused excerpts)
-     * 6. Returns formatted results sorted by relevance
+     * 1. Scores every chunk of the requested type by cosine similarity to the embedded query,
+     *    blended with its keyword (BM25) relevance; see KEYWORD_WEIGHT
+     * 2. Keeps the `maxChunks` best chunks and groups them by document
+     * 3. Scores each document by its best kept chunk, and returns the top `limit`. Averaging
+     *    instead would rank a long page below a short one whenever the long page also had
+     *    weaker matching chunks; on a 60-query labelled set it cost 25 points of top-1 accuracy.
+     * 4. Drops documents scoring below `threshold`
+     * 5. Renders up to three excerpts per document around its matching chunks
      *
-     * Note on threshold filtering: We apply threshold AFTER Vectra's top-K search.
+     * Note on threshold filtering: We apply threshold AFTER the top-`limit` cut.
      * This means if limit=5 and threshold=0.7, we might return fewer than 5 results
      * if some of the top 5 don't meet the threshold.
      *
-     * Note on section rendering: We use 300 tokens per section (roughly 1200 characters)
-     * to show focused, relevant excerpts rather than large chunks that include
-     * irrelevant content from the start of the document. This matches our 512-token
-     * chunking strategy during indexing.
-     *
      * @param query - Natural language search query
      * @param options - Search customization options
      * @returns Array of search results, sorted by relevance (highest first)
@@ -108,51 +107,54 @@ export class DocsSearch {
     async search(query, options = {}) {
         const index = await this.initialize();
         const { limit = 5, threshold = 0.0, maxChunks = 40, type = 'all', contextTokens = 300 } = options;
-        const filter = this.buildMetadataFilter(type);
-        const results = await index.queryDocuments(query, {
-            maxDocuments: limit,
-            maxChunks,
-            filter
-        });
-        const formatted = [];
-        for (const result of results) {
-            if (result.score < threshold) {
-                continue;
-            }
-            const sections = await result.renderSections(contextTokens, 3, true);
-            formatted.push({
-                score: result.score,
-                uri: result.uri,
-                sections
-            });
+        const queryVector = await this.embedder.embed(query);
+        const keywordScores = this.keywordScores(index, query);
+        const searched = index.chunks
+            .map((chunk, i) => ({ chunk, keywordScore: keywordScores[i] ?? 0 }))
+            .filter(({ chunk }) => type === 'all' || chunk.document.docType === type);
+        // Scaled so the best searched chunk scores 1, putting keyword relevance on the same footing as
+        // cosine similarity whatever the query's length or the --type filter.
+        const bestKeywordScore = Math.max(0, ...searched.map(({ keywordScore }) => keywordScore));
+        const matches = searched
+            .map(({ chunk, keywordScore }) => {
+            const keyword = bestKeywordScore > 0 ? keywordScore / bestKeywordScore : 0;
+            const blended = (dotProduct(queryVector, chunk.vector) + KEYWORD_WEIGHT * keyword) / (1 + KEYWORD_WEIGHT);
+            // Cosine similarity can be slightly negative; clamping keeps scores in the 0-1 range
+            // --threshold is documented with, so the default threshold of 0 never drops every result.
+            return { chunk, score: Math.max(0, blended) };
+        })
+            .sort((a, b) => b.score - a.score)
+            .slice(0, maxChunks);
+        const matchesByDocument = new Map();
+        for (const match of matches) {
+            const documentMatches = matchesByDocument.get(match.chunk.document) ?? [];
+            documentMatches.push(match);
+            matchesByDocument.set(match.chunk.document, documentMatches);
         }
-        return formatted;
+        return [...matchesByDocument]
+            .map(([document, documentMatches]) => ({ document, documentMatches, score: bestScore(documentMatches) }))
+            .sort((a, b) => b.score - a.score)
+            .slice(0, limit)
+            .filter(result => result.score >= threshold)
+            .map(({ document, documentMatches, score }) => ({
+            score,
+            uri: document.uri,
+            sections: this.renderSections(document, documentMatches, contextTokens)
+        }));
+    }
+    /**
+     * BM25 relevance of every chunk to the query, in index order. The scorer is built on first use;
+     * over the bundled docs that takes a few tens of milliseconds.
+     */
+    keywordScores(index, query) {
+        this.keywordScorer ??= new KeywordScorer(index.chunks.map(chunk => chunk.document.text.slice(chunk.start, chunk.end)));
+        return this.keywordScorer.score(query);
     }
     /**
      * Retrieves the full content of a document by its URI.
      *
-     * This method fetches the complete raw text of a document, not just the top
-     * matching sections from a search. It's designed for retrieving complete
-     * documentation after finding it via search.
-     *
-     * Implementation details:
-     *
-     * 1. **Direct lookup**: Calls `listDocuments()` to get all indexed documents,
-     *    then finds the matching URI. This is more efficient than query-based
-     *    retrieval because it avoids unnecessary similarity calculations.
-     *
-     * 2. **Raw text loading**: Uses `loadText()` to read the original document text
-     *    directly from disk, bypassing Vectra's `renderAllSections()` which runs text
-     *    through a GPT-3 tokenizer encode/decode round-trip that corrupts special
-     *    characters (e.g., pipe characters in GFM tables become `\|`).
-     *
-     * Performance: This method loads the entire document list into memory once,
-     * which is acceptable since the index is immutable and relatively small (tens
-     * to hundreds of documents). For larger indices, consider adding a caching layer.
-     *
-     * Alternative considered (Option B): Query-based retrieval using `queryDocuments()`
-     * was rejected because it returns sections in relevance order rather than document
-     * order, which would break the natural flow of documentation.
+     * This returns the complete document text exactly as indexed, not just the
+     * excerpts a search shows, and does not load the embedding model.
      *
      * @param uri - Document URI in format 'doc://path/to/file.mdx'
      * @returns Complete document content as markdown text
@@ -160,24 +162,11 @@ export class DocsSearch {
      */
     async getDocument(uri) {
         const index = await this.openIndex();
-        const docs = await index.listDocuments();
-        const doc = docs.find(d => d.uri === uri);
+        const doc = index.documents.find(d => d.uri === uri);
         if (!doc) {
             throw new Error(`Document not found: ${uri}`);
         }
-        return doc.loadText();
-    }
-    /**
-     * Builds a metadata filter for the specified document type.
-     *
-     * @param type - Type filter to apply
-     * @returns Metadata filter for Vectra query, or undefined for 'all'
-     */
-    buildMetadataFilter(type) {
-        if (type === 'all') {
-            return undefined;
-        }
-        return { docType: type };
+        return doc.text;
     }
     /**
      * Retrieves statistics about the documentation index.
@@ -188,11 +177,75 @@ export class DocsSearch {
      */
     async getIndexStats() {
         const index = await this.openIndex();
-        const stats = await index.listDocuments();
         return {
-            documentCount: stats.length,
+            documentCount: index.documents.length,
             indexPath: this.indexPath
         };
     }
+    /**
+     * Cuts up to MAX_SECTIONS excerpts from a document.
+     *
+     * A document that fits in maxTokens is returned whole. Otherwise matching chunks that
+     * overlap or touch are merged into one excerpt while the result fits in maxTokens, each excerpt
+     * is scored by the best chunk it covers, and the best excerpts are returned.
+     *
+     * The best excerpt is never cut inside a chunk: a chunk's score does not say where in it the
+     * match is, so trimming it could drop exactly the passage that matched. Lower-ranked excerpts
+     * only lose lines already shown above them. Excerpts are slices of the original text, so code,
+     * tables and punctuation come back unchanged.
+     */
+    renderSections(document, matches, maxTokens) {
+        const textTokens = this.embedder.countTokens(document.text);
+        if (textTokens <= maxTokens) {
+            return [{ text: document.text, tokenCount: textTokens, score: bestScore(matches) }];
+        }
+        const spans = [];
+        for (const match of [...matches].sort((a, b) => a.chunk.start - b.chunk.start)) {
+            const span = spans[spans.length - 1];
+            const mergedEnd = Math.max(span?.end ?? 0, match.chunk.end);
+            if (span && match.chunk.start <= span.end &&
+                this.embedder.countTokens(document.text.slice(span.start, mergedEnd)) <= maxTokens) {
+                span.end = mergedEnd;
+                span.matches.push(match);
+            }
+            else {
+                spans.push({ start: match.chunk.start, end: match.chunk.end, matches: [match] });
+            }
+        }
+        // Neighbouring chunks share a few lines. Keep the best excerpts whole and trim the shared lines
+        // from lower-ranked ones, so no text is shown twice and the best match is never cut.
+        const excerpts = [];
+        for (const span of spans.map(s => ({ ...s, score: bestScore(s.matches) })).sort((a, b) => b.score - a.score)) {
+            for (const shown of excerpts) {
+                if (shown.start <= span.start && span.start < shown.end) {
+                    span.start = shown.end;
+                }
+                if (shown.start < span.end && span.end <= shown.end) {
+                    span.end = shown.start;
+                }
+            }
+            if (span.start < span.end) {
+                excerpts.push(span);
+            }
+            if (excerpts.length === MAX_SECTIONS) {
+                break;
+            }
+        }
+        return excerpts.map(({ start, end, score }) => {
+            const text = document.text.slice(start, end);
+            return { text, tokenCount: this.embedder.countTokens(text), score };
+        });
+    }
+}
+/** Cosine similarity, given unit-length vectors. */
+function dotProduct(a, b) {
+    let sum = 0;
+    for (let i = 0; i < a.length; i++) {
+        sum += (a[i] ?? 0) * (b[i] ?? 0);
+    }
+    return sum;
+}
+function bestScore(matches) {
+    return Math.max(...matches.map(match => match.score));
 }
 //# sourceMappingURL=docs-search.js.map

package/build/dist/lib/docs-search.js.map

@@ -1 +1 @@
-{"version":3,"file":"docs-search.js","sourceRoot":"","sources":["../../../src/main/typescript/lib/docs-search.ts"],"names":[],"mappings":"AAAA,OAAO,EAAmB,kBAAkB,EAAuC,MAAM,QAAQ,CAAC;AAClG,OAAO,IAAI,MAAM,MAAM,CAAC;AACxB,OAAO,EAAE,aAAa,EAAE,MAAM,KAAK,CAAC;AACpC,OAAO,EAAE,sBAAsB,EAAE,MAAM,8BAA8B,CAAC;AAkCtE;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,MAAM,OAAO,UAAU;IACb,KAAK,GAA8B,IAAI,CAAC;IACxC,SAAS,CAAS;IAClB,UAAU,CAA0B;IAE5C;;;;;;;;;OASG;IACH,YAAY,SAAkB,EAAE,UAAoC;QAClE,IAAI,SAAS,EAAE,CAAC;YACd,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC7B,CAAC;aAAM,CAAC;YACN,MAAM,UAAU,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAClD,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,IAAI,CAAC,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,EAAE,eAAe,CAAC,CAAC;QAC5D,CAAC;QAED,IAAI,CAAC,UAAU,GAAG,UAAU,IAAI,IAAI,sBAAsB,CAAC,yBAAyB,EAAE,GAAG,CAAC,CAAC;IAC7F,CAAC;IAEO,KAAK,CAAC,SAAS;QACrB,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YACf,OAAO,IAAI,CAAC,KAAK,CAAC;QACpB,CAAC;QAED,MAAM,KAAK,GAAG,IAAI,kBAAkB,CAAC;YACnC,UAAU,EAAE,IAAI,CAAC,SAAS;YAC1B,UAAU,EAAE,IAAI,CAAC,UAAU;SAC5B,CAAC,CAAC;QAEH,IAAI,CAAC,CAAC,MAAM,KAAK,CAAC,cAAc,EAAE,CAAC,EAAE,CAAC;YACpC,MAAM,IAAI,KAAK,CACb,mEAAmE;gBACnE,qDAAqD,CACtD,CAAC;QACJ,CAAC;QAED,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,OAAO,KAAK,CAAC;IACf,CAAC;IAED;;;;;;;;;;;OAWG;IACH,KAAK,CAAC,UAAU;QACd,MAAM,IAAI,CAAC,UAAU,CAAC,UAAU,EAAE,CAAC;QACnC,OAAO,IAAI,CAAC,SAAS,EAAE,CAAC;IAC1B,CAAC;IAED;;;;;;;;;;;;;;;;;;;;;;;;;OAyBG;IACH,KAAK,CAAC,MAAM,CAAC,KAAa,EAAE,UAAyB,EAAE;QACrD,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,UAAU,EAAE,CAAC;QAEtC,MAAM,EACJ,KAAK,GAAG,CAAC,EACT,SAAS,GAAG,GAAG,EACf,SAAS,GAAG,EAAE,EACd,IAAI,GAAG,KAAK,EACZ,aAAa,GAAG,GAAG,EACpB,GAAG,OAAO,CAAC;QAEZ,MAAM,MAAM,GAAG,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QAE9C,MAAM,OAAO,GAAG,MAAM,KAAK,CAAC,cAAc,CAAC,KAAK,EAAE;YAChD,YAAY,EAAE,KAAK;YACnB,SAAS;YACT,MAAM;SACP,CAAC,CAAC;QAEH,MAAM,SAAS,GAAmB,EAAE,CAAC;QACrC,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC7B,IAAI,MAAM,CAAC,KAAK,GAAG,SAAS,EAAE,CAAC;gBAC7B,SAAS;YACX,CAAC;YAED,MAAM,QAAQ,GAAG,MAAM,MAAM,CAAC,cAAc,CAAC,aAAa,EAAE,CAAC,EAAE,IAAI,CAAC,CAAC;YAErE,SAAS,CAAC,IAAI,CAAC;gBACb,KAAK,EAAE,MAAM,CAAC,KAAK;gBACnB,GAAG,EAAE,MAAM,CAAC,GAAG;gBACf,QAAQ;aACT,CAAC,CAAC;QACL,CAAC;QAED,OAAO,SAAS,CAAC;IACnB,CAAC;IAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OA6BG;IACH,KAAK,CAAC,WAAW,CAAC,GAAW;QAC3B,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC;QAErC,MAAM,IAAI,GAAG,MAAM,KAAK,CAAC,aAAa,EAAE,CAAC;QACzC,MAAM,GAAG,GAAG,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,KAAK,GAAG,CAAC,CAAC;QAE1C,IAAI,CAAC,GAAG,EAAE,CAAC;YACT,MAAM,IAAI,KAAK,CAAC,uBAAuB,GAAG,EAAE,CAAC,CAAC;QAChD,CAAC;QAED,OAAO,GAAG,CAAC,QAAQ,EAAE,CAAC;IACxB,CAAC;IAED;;;;;OAKG;IACK,mBAAmB,CAAC,IAAsC;QAChE,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;YACnB,OAAO,SAAS,CAAC;QACnB,CAAC;QAED,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC3B,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,aAAa;QACjB,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC;QAErC,MAAM,KAAK,GAAG,MAAM,KAAK,CAAC,aAAa,EAAE,CAAC;QAE1C,OAAO;YACL,aAAa,EAAE,KAAK,CAAC,MAAM;YAC3B,SAAS,EAAE,IAAI,CAAC,SAAS;SAC1B,CAAC;IACJ,CAAC;CACF"}
+{"version":3,"file":"docs-search.js","sourceRoot":"","sources":["../../../src/main/typescript/lib/docs-search.ts"],"names":[],"mappings":"AAAA,OAAO,IAAI,MAAM,MAAM,CAAC;AACxB,OAAO,EAAE,aAAa,EAAE,MAAM,KAAK,CAAC;AACpC,OAAO,EAA4C,eAAe,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAC3G,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,cAAc,EAAgB,MAAM,oBAAoB,CAAC;AAuClE,+CAA+C;AAC/C,MAAM,YAAY,GAAG,CAAC,CAAC;AAEvB;;;;GAIG;AACH,MAAM,cAAc,GAAG,IAAI,CAAC;AAO5B;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,OAAO,UAAU;IACb,KAAK,GAAqB,IAAI,CAAC;IAC/B,aAAa,GAAyB,IAAI,CAAC;IAC3C,SAAS,CAAS;IAClB,QAAQ,CAAe;IAE/B;;;;;;;;;;OAUG;IACH,YAAY,SAAkB,EAAE,QAAuB;QACrD,IAAI,SAAS,EAAE,CAAC;YACd,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC7B,CAAC;aAAM,CAAC;YACN,MAAM,UAAU,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAClD,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,IAAI,CAAC,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,EAAE,eAAe,CAAC,CAAC;QAC5D,CAAC;QAED,IAAI,CAAC,QAAQ,GAAG,QAAQ,IAAI,IAAI,cAAc,EAAE,CAAC;IACnD,CAAC;IAEO,KAAK,CAAC,SAAS;QACrB,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YACf,OAAO,IAAI,CAAC,KAAK,CAAC;QACpB,CAAC;QAED,IAAI,CAAC,CAAC,MAAM,eAAe,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,EAAE,CAAC;YAC7C,MAAM,IAAI,KAAK,CACb,mEAAmE;gBACnE,qDAAqD,CACtD,CAAC;QACJ,CAAC;QAED,IAAI,CAAC,KAAK,GAAG,MAAM,aAAa,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACjD,OAAO,IAAI,CAAC,KAAK,CAAC;IACpB,CAAC;IAED;;;;;;;;OAQG;IACH,KAAK,CAAC,UAAU;QACd,MAAM,IAAI,CAAC,QAAQ,CAAC,UAAU,EAAE,CAAC;QACjC,OAAO,IAAI,CAAC,SAAS,EAAE,CAAC;IAC1B,CAAC;IAED;;;;;;;;;;;;;;;;;;;;;OAqBG;IACH,KAAK,CAAC,MAAM,CAAC,KAAa,EAAE,UAAyB,EAAE;QACrD,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,UAAU,EAAE,CAAC;QAEtC,MAAM,EACJ,KAAK,GAAG,CAAC,EACT,SAAS,GAAG,GAAG,EACf,SAAS,GAAG,EAAE,EACd,IAAI,GAAG,KAAK,EACZ,aAAa,GAAG,GAAG,EACpB,GAAG,OAAO,CAAC;QAEZ,MAAM,WAAW,GAAG,MAAM,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QACrD,MAAM,aAAa,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACvD,MAAM,QAAQ,GAAG,KAAK,CAAC,MAAM;aAC1B,GAAG,CAAC,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,KAAK,EAAE,YAAY,EAAE,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;aACnE,MAAM,CAAC,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,IAAI,KAAK,KAAK,IAAI,KAAK,CAAC,QAAQ,CAAC,OAAO,KAAK,IAAI,CAAC,CAAC;QAC5E,+FAA+F;QAC/F,sEAAsE;QACtE,MAAM,gBAAgB,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,YAAY,EAAE,EAAE,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC;QAC1F,MAAM,OAAO,GAAiB,QAAQ;aACnC,GAAG,CAAC,CAAC,EAAE,KAAK,EAAE,YAAY,EAAE,EAAE,EAAE;YAC/B,MAAM,OAAO,GAAG,gBAAgB,GAAG,CAAC,CAAC,CAAC,CAAC,YAAY,GAAG,gBAAgB,CAAC,CAAC,CAAC,CAAC,CAAC;YAC3E,MAAM,OAAO,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,KAAK,CAAC,MAAM,CAAC,GAAG,cAAc,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,GAAG,cAAc,CAAC,CAAC;YAC1G,qFAAqF;YACrF,0FAA0F;YAC1F,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,OAAO,CAAC,EAAE,CAAC;QAChD,CAAC,CAAC;aACD,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC;aACjC,KAAK,CAAC,CAAC,EAAE,SAAS,CAAC,CAAC;QAEvB,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAiC,CAAC;QACnE,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;YAC5B,MAAM,eAAe,GAAG,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC1E,eAAe,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YAC5B,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,eAAe,CAAC,CAAC;QAC/D,CAAC;QAED,OAAO,CAAC,GAAG,iBAAiB,CAAC;aAC1B,GAAG,CAAC,CAAC,CAAC,QAAQ,EAAE,eAAe,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,QAAQ,EAAE,eAAe,EAAE,KAAK,EAAE,SAAS,CAAC,eAAe,CAAC,EAAE,CAAC,CAAC;aACxG,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC;aACjC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC;aACf,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,IAAI,SAAS,CAAC;aAC3C,GAAG,CAAC,CAAC,EAAE,QAAQ,EAAE,eAAe,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,CAAC;YAC9C,KAAK;YACL,GAAG,EAAE,QAAQ,CAAC,GAAG;YACjB,QAAQ,EAAE,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,eAAe,EAAE,aAAa,CAAC;SACxE,CAAC,CAAC,CAAC;IACR,CAAC;IAED;;;OAGG;IACK,aAAa,CAAC,KAAgB,EAAE,KAAa;QACnD,IAAI,CAAC,aAAa,KAAK,IAAI,aAAa,CAAC,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,KAAK,EAAE,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QACvH,OAAO,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IACzC,CAAC;IAED;;;;;;;;;OASG;IACH,KAAK,CAAC,WAAW,CAAC,GAAW;QAC3B,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC;QAErC,MAAM,GAAG,GAAG,KAAK,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,KAAK,GAAG,CAAC,CAAC;QACrD,IAAI,CAAC,GAAG,EAAE,CAAC;YACT,MAAM,IAAI,KAAK,CAAC,uBAAuB,GAAG,EAAE,CAAC,CAAC;QAChD,CAAC;QAED,OAAO,GAAG,CAAC,IAAI,CAAC;IAClB,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,aAAa;QACjB,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC;QAErC,OAAO;YACL,aAAa,EAAE,KAAK,CAAC,SAAS,CAAC,MAAM;YACrC,SAAS,EAAE,IAAI,CAAC,SAAS;SAC1B,CAAC;IACJ,CAAC;IAED;;;;;;;;;;;OAWG;IACK,cAAc,CAAC,QAAyB,EAAE,OAAqB,EAAE,SAAiB;QACxF,MAAM,UAAU,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QAC5D,IAAI,UAAU,IAAI,SAAS,EAAE,CAAC;YAC5B,OAAO,CAAC,EAAE,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,UAAU,EAAE,UAAU,EAAE,KAAK,EAAE,SAAS,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACtF,CAAC;QAED,MAAM,KAAK,GAA4D,EAAE,CAAC;QAC1E,KAAK,MAAM,KAAK,IAAI,CAAC,GAAG,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;YAC/E,MAAM,IAAI,GAAG,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;YACrC,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,GAAG,IAAI,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;YAC5D,IAAI,IAAI,IAAI,KAAK,CAAC,KAAK,CAAC,KAAK,IAAI,IAAI,CAAC,GAAG;gBACrC,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC,IAAI,SAAS,EAAE,CAAC;gBACvF,IAAI,CAAC,GAAG,GAAG,SAAS,CAAC;gBACrB,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YAC3B,CAAC;iBAAM,CAAC;gBACN,KAAK,CAAC,IAAI,CAAC,EAAE,KAAK,EAAE,KAAK,CAAC,KAAK,CAAC,KAAK,EAAE,GAAG,EAAE,KAAK,CAAC,KAAK,CAAC,GAAG,EAAE,OAAO,EAAE,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YACnF,CAAC;QACH,CAAC;QAED,gGAAgG;QAChG,qFAAqF;QACrF,MAAM,QAAQ,GAAoD,EAAE,CAAC;QACrE,KAAK,MAAM,IAAI,IAAI,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,KAAK,EAAE,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,EAAE,CAAC;YAC7G,KAAK,MAAM,KAAK,IAAI,QAAQ,EAAE,CAAC;gBAC7B,IAAI,KAAK,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC,GAAG,EAAE,CAAC;oBACxD,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC,GAAG,CAAC;gBACzB,CAAC;gBACD,IAAI,KAAK,CAAC,KAAK,GAAG,IAAI,CAAC,GAAG,IAAI,IAAI,CAAC,GAAG,IAAI,KAAK,CAAC,GAAG,EAAE,CAAC;oBACpD,IAAI,CAAC,GAAG,GAAG,KAAK,CAAC,KAAK,CAAC;gBACzB,CAAC;YACH,CAAC;YACD,IAAI,IAAI,CAAC,KAAK,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;gBAC1B,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACtB,CAAC;YACD,IAAI,QAAQ,CAAC,MAAM,KAAK,YAAY,EAAE,CAAC;gBACrC,MAAM;YACR,CAAC;QACH,CAAC;QAED,OAAO,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,KAAK,EAAE,GAAG,EAAE,KAAK,EAAE,EAAE,EAAE;YAC5C,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;YAC7C,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,KAAK,EAAE,CAAC;QACtE,CAAC,CAAC,CAAC;IACL,CAAC;CACF;AAED,oDAAoD;AACpD,SAAS,UAAU,CAAC,CAAe,EAAE,CAAe;IAClD,IAAI,GAAG,GAAG,CAAC,CAAC;IACZ,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QAClC,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC;IACnC,CAAC;IACD,OAAO,GAAG,CAAC;AACb,CAAC;AAED,SAAS,SAAS,CAAC,OAAqB;IACtC,OAAO,IAAI,CAAC,GAAG,CAAC,GAAG,OAAO,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC;AACxD,CAAC"}

package/build/dist/lib/job-patch.d.ts

@@ -136,7 +136,7 @@ export type JobPatchOp = {
     target: 'processed-logs';
 } | {
     op: 'set-raw-dataset';
-    /** New raw-logs dataset ID. Template: `input.datasetId` (and `rawSinkConfig.datasetId` when that override is set). Raw job-graph: `datasetId` on the raw data-lake `logs-iceberg-table-sink` (matched by name prefix). */
+    /** New raw-logs dataset ID. Template: `input.datasetId`. Raw job-graph: `datasetId` on the raw data-lake `logs-iceberg-table-sink` (matched by name prefix). */
     datasetId: string;
 } | {
     op: 'remove-message-attribute';
@@ -219,11 +219,12 @@ export interface JobPatch {
  */
 export type PatchClassification = 'transform' | 'source' | 'sink' | 'mixed';
 /**
- * Validate the patch file shape, including each op's name and required fields, so
- * a typo'd or under-specified op (e.g. `add-group-by` with no `attributePath`)
- * fails cleanly at the file boundary rather than deep inside `applyPatch` with a
- * confusing internal error. `applyPatch` still does the deeper
- * semantic/target-conditional validation.
+ * Validate the patch file shape, including each op's name and required fields and
+ * that a `set/unset-input-field` path names a template input field (and, under
+ * `transforms`, a slot), so a typo'd or
+ * under-specified op (e.g. `add-group-by` with no `attributePath`) fails cleanly at
+ * the file boundary rather than deep inside `applyPatch` with a confusing internal
+ * error. `applyPatch` still does the deeper semantic/target-conditional validation.
  */
 export declare function parsePatch(raw: unknown): JobPatch;
 /** Detect whether a job is template-backed (a `template-operation` vertex) or job-graph. */

package/build/dist/lib/job-patch.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"job-patch.d.ts","sourceRoot":"","sources":["../../../src/main/typescript/lib/job-patch.ts"],"names":[],"mappings":"AAAA,8JAA8J;AAC9J,OAAO,EACL,aAAa,EACb,eAAe,EACf,eAAe,EAGf,oBAAoB,EACpB,6BAA6B,EAC7B,gBAAgB,EAOhB,eAAe,EAKf,kBAAkB,EAClB,qBAAqB,EAOrB,oBAAoB,EAgBpB,8BAA8B,EAC9B,8BAA8B,EAC9B,8BAA8B,EAC9B,kCAAkC,EAEnC,MAAM,wBAAwB,CAAC;AAchC,MAAM,MAAM,mBAAmB,GAC3B,GAAG,8BAA8B,EAAE,GACnC,GAAG,8BAA8B,EAAE,GACnC,GAAG,8BAA8B,EAAE,GACnC,GAAG,kCAAkC,EAAE,CAAC;AAE5C,4EAA4E;AAC5E,MAAM,MAAM,sBAAsB,GAAG,YAAY,GAAG,eAAe,GAAG,gBAAgB,CAAC;AASvF,MAAM,MAAM,sBAAsB,GAAG,MAAM,GAAG,aAAa,CAAC;AAI5D,0CAA0C;AAC1C,MAAM,MAAM,UAAU,GAAG,QAAQ,GAAG,gBAAgB,CAAC;AAmBrD;;;;GAIG;AACH,MAAM,MAAM,UAAU,GAAG,UAAU,GAAG,WAAW,CAAC;AAElD,6DAA6D;AAC7D,MAAM,MAAM,UAAU,GAClB;IACE,EAAE,EAAE,uBAAuB,CAAC;IAC5B,2HAA2H;IAC3H,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,cAAc,CAAC;IACnB,qJAAqJ;IACrJ,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,kGAAkG;IAClG,aAAa,EAAE,MAAM,CAAC;IACtB,UAAU,EAAE,mBAAmB,EAAE,CAAC;CACnC,GACD;IACE,EAAE,EAAE,uBAAuB,CAAC;IAC5B;;;;OAIG;IACH,SAAS,EAAE,oBAAoB,CAAC;CACjC,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,8EAA8E;IAC9E,OAAO,EAAE,MAAM,CAAC;IAChB,uFAAuF;IACvF,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,qHAAqH;IACrH,gBAAgB,CAAC,EAAE,MAAM,CAAC;CAC3B,GAMD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,2EAA2E;IAC3E,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,OAAO,CAAC;CAChB,GACD;IACE,EAAE,EAAE,mBAAmB,CAAC;IACxB,6DAA6D;IAC7D,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,EAAE,EAAE,YAAY,CAAC;IACjB;;;;OAIG;IACH,MAAM,EAAE,eAAe,CAAC;CACzB,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,gEAAgE;IAChE,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,EAAE,EAAE,YAAY,CAAC;IACjB,KAAK,EAAE,sBAAsB,CAAC;IAC9B,2IAA2I;IAC3I,MAAM,EAAE,gBAAgB,CAAC;CAC1B,GACD;IACE,EAAE,EAAE,cAAc,CAAC;IACnB,KAAK,EAAE,sBAAsB,CAAC;CAC/B,GAGD;IACE,EAAE,EAAE,qBAAqB,CAAC;IAC1B,KAAK,EAAE,sBAAsB,CAAC;IAC9B,6DAA6D;IAC7D,IAAI,EAAE,eAAe,CAAC;CACvB,GACD;IACE,EAAE,EAAE,uBAAuB,CAAC;IAC5B,KAAK,EAAE,sBAAsB,CAAC;CAC/B,GACD;IACE,EAAE,EAAE,mBAAmB,CAAC;IACxB,KAAK,EAAE,sBAAsB,CAAC;IAC9B,mEAAmE;IACnE,YAAY,EAAE,kBAAkB,CAAC;IACjC,iFAAiF;IACjF,aAAa,EAAE,MAAM,CAAC,MAAM,EAAE,oBAAoB,CAAC,CAAC;IACpD,wEAAwE;IACxE,UAAU,EAAE,sBAAsB,CAAC;IACnC;;;OAGG;IACH,IAAI,CAAC,EAAE,oBAAoB,CAAC;CAC7B,GAID;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,qFAAqF;IACrF,OAAO,EAAE,qBAAqB,CAAC;CAChC,GACD;IACE,EAAE,EAAE,eAAe,CAAC;CACrB,GACD;IACE,EAAE,EAAE,YAAY,CAAC;IACjB,oDAAoD;IACpD,MAAM,EAAE,eAAe,CAAC;CACzB,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,gEAAgE;IAChE,IAAI,EAAE,MAAM,CAAC;CACd,GAKD;IACE,EAAE,EAAE,UAAU,CAAC;IACf,8BAA8B;IAC9B,MAAM,EAAE,QAAQ,CAAC;IACjB,mCAAmC;IACnC,IAAI,EAAE,eAAe,CAAC;IACtB;;;;OAIG;IACH,MAAM,CAAC,EAAE,gBAAgB,CAAC;CAC3B,GACD;IACE,EAAE,EAAE,UAAU,CAAC;IACf,iDAAiD;IACjD,MAAM,EAAE,gBAAgB,CAAC;IACzB,6CAA6C;IAC7C,IAAI,EAAE,eAAe,CAAC;CACvB,GACD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,MAAM,EAAE,QAAQ,CAAC;IACjB,yCAAyC;IACzC,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,kEAAkE;IAClE,MAAM,EAAE,gBAAgB,CAAC;CAC1B,GACD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,0NAA0N;IAC1N,SAAS,EAAE,MAAM,CAAC;CACnB,GAID;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,+IAA+I;IAC/I,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,sIAAsI;IACtI,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,6BAA6B,CAAC;IAClC,uGAAuG;IACvG,aAAa,EAAE,MAAM,CAAC;IACtB,0FAA0F;IAC1F,UAAU,CAAC,EAAE,mBAAmB,EAAE,CAAC;CACpC,GACD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,6LAA6L;IAC7L,SAAS,EAAE,oBAAoB,CAAC;CACjC,GACD;IACE,EAAE,EAAE,kBAAkB,CAAC;IACvB,8EAA8E;IAC9E,OAAO,EAAE,MAAM,CAAC;IAChB,uFAAuF;IACvF,UAAU,CAAC,EAAE,MAAM,CAAC;CACrB,GAID;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,yFAAyF;IACzF,MAAM,EAAE,eAAe,CAAC;CACzB,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,yFAAyF;IACzF,MAAM,EAAE,eAAe,CAAC;CACzB,GAGD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,wEAAwE;IACxE,MAAM,EAAE,QAAQ,CAAC;IACjB,IAAI,EAAE,eAAe,CAAC;IACtB;;;OAGG;IACH,MAAM,CAAC,EAAE,gBAAgB,CAAC;CAC3B,GACD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,yEAAyE;IACzE,MAAM,EAAE,gBAAgB,CAAC;IACzB,IAAI,EAAE,eAAe,CAAC;CACvB,GAKD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,kDAAkD;IAClD,IAAI,EAAE,MAAM,CAAC;IACb,yHAAyH;IACzH,EAAE,EAAE,MAAM,CAAC;CACZ,GACD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,yCAAyC;IACzC,IAAI,EAAE,MAAM,CAAC;IACb,yHAAyH;IACzH,EAAE,EAAE,MAAM,CAAC;CACZ,GACD;IACE,EAAE,EAAE,6BAA6B,CAAC;IAClC,0GAA0G;IAC1G,aAAa,EAAE,MAAM,CAAC;IACtB,iHAAiH;IACjH,UAAU,EAAE,mBAAmB,EAAE,CAAC;CACnC,GACD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,qFAAqF;IACrF,IAAI,EAAE,oBAAoB,CAAC;IAC3B,0EAA0E;IAC1E,EAAE,EAAE,oBAAoB,CAAC;CAC1B,CAAC;AAEN,MAAM,WAAW,QAAQ;IACvB,UAAU,EAAE,UAAU,EAAE,CAAC;CAC1B;AAED;;;GAGG;AACH,MAAM,MAAM,mBAAmB,GAAG,WAAW,GAAG,QAAQ,GAAG,MAAM,GAAG,OAAO,CAAC;AA0F5E;;;;;;GAMG;AACH,wBAAgB,UAAU,CAAC,GAAG,EAAE,OAAO,GAAG,QAAQ,CAkBjD;AAED,4FAA4F;AAC5F,wBAAgB,aAAa,CAAC,GAAG,EAAE;IAAE,QAAQ,CAAC,EAAE;QAAE,QAAQ,CAAC,EAAE,eAAe,EAAE,CAAA;KAAE,CAAA;CAAE,GAAG,UAAU,CAI9F;AAED;;;;GAIG;AACH,wBAAgB,UAAU,CAAC,GAAG,EAAE,aAAa,EAAE,KAAK,EAAE,QAAQ,GAAG,eAAe,CAG/E;AAq4CD,wBAAgB,UAAU,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAEzD;AAED,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAEhE;AAED,wBAAgB,SAAS,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAExD;AAED,wBAAgB,eAAe,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAE9D;AA4fD,iJAAiJ;AACjJ,wBAAgB,4BAA4B,CAAC,KAAK,EAAE,QAAQ,GAAG,MAAM,EAAE,CAItE;AAED,gGAAgG;AAChG,wBAAgB,aAAa,CAAC,KAAK,EAAE,QAAQ,GAAG,mBAAmB,CAWlE;AAyED;;;;GAIG;AACH,wBAAgB,qBAAqB,CAAC,GAAG,EAAE;IAAE,QAAQ,CAAC,EAAE;QAAE,QAAQ,CAAC,EAAE,eAAe,EAAE,CAAA;KAAE,CAAA;CAAE,GAAG,eAAe,GAAG;IAAE,SAAS,CAAC,EAAE,OAAO,CAAC;IAAC,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;CAAE,CAmB/K;AAED,wBAAgB,iBAAiB,CAAC,UAAU,EAAE;IAAE,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;CAAE,GAAG,6BAA6B,CAUzH"}
+{"version":3,"file":"job-patch.d.ts","sourceRoot":"","sources":["../../../src/main/typescript/lib/job-patch.ts"],"names":[],"mappings":"AAAA,8JAA8J;AAC9J,OAAO,EACL,aAAa,EACb,eAAe,EACf,eAAe,EAGf,oBAAoB,EACpB,6BAA6B,EAC7B,gBAAgB,EAOhB,eAAe,EAKf,kBAAkB,EAClB,qBAAqB,EAOrB,oBAAoB,EAgBpB,8BAA8B,EAC9B,8BAA8B,EAC9B,8BAA8B,EAC9B,kCAAkC,EAEnC,MAAM,wBAAwB,CAAC;AAchC,MAAM,MAAM,mBAAmB,GAC3B,GAAG,8BAA8B,EAAE,GACnC,GAAG,8BAA8B,EAAE,GACnC,GAAG,8BAA8B,EAAE,GACnC,GAAG,kCAAkC,EAAE,CAAC;AAE5C,4EAA4E;AAC5E,MAAM,MAAM,sBAAsB,GAAG,YAAY,GAAG,eAAe,GAAG,gBAAgB,CAAC;AASvF,MAAM,MAAM,sBAAsB,GAAG,MAAM,GAAG,aAAa,CAAC;AAI5D,0CAA0C;AAC1C,MAAM,MAAM,UAAU,GAAG,QAAQ,GAAG,gBAAgB,CAAC;AAmBrD;;;;GAIG;AACH,MAAM,MAAM,UAAU,GAAG,UAAU,GAAG,WAAW,CAAC;AAElD,6DAA6D;AAC7D,MAAM,MAAM,UAAU,GAClB;IACE,EAAE,EAAE,uBAAuB,CAAC;IAC5B,2HAA2H;IAC3H,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,cAAc,CAAC;IACnB,qJAAqJ;IACrJ,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,kGAAkG;IAClG,aAAa,EAAE,MAAM,CAAC;IACtB,UAAU,EAAE,mBAAmB,EAAE,CAAC;CACnC,GACD;IACE,EAAE,EAAE,uBAAuB,CAAC;IAC5B;;;;OAIG;IACH,SAAS,EAAE,oBAAoB,CAAC;CACjC,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,8EAA8E;IAC9E,OAAO,EAAE,MAAM,CAAC;IAChB,uFAAuF;IACvF,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,qHAAqH;IACrH,gBAAgB,CAAC,EAAE,MAAM,CAAC;CAC3B,GAQD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,2EAA2E;IAC3E,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,OAAO,CAAC;CAChB,GACD;IACE,EAAE,EAAE,mBAAmB,CAAC;IACxB,6DAA6D;IAC7D,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,EAAE,EAAE,YAAY,CAAC;IACjB;;;;OAIG;IACH,MAAM,EAAE,eAAe,CAAC;CACzB,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,gEAAgE;IAChE,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,EAAE,EAAE,YAAY,CAAC;IACjB,KAAK,EAAE,sBAAsB,CAAC;IAC9B,2IAA2I;IAC3I,MAAM,EAAE,gBAAgB,CAAC;CAC1B,GACD;IACE,EAAE,EAAE,cAAc,CAAC;IACnB,KAAK,EAAE,sBAAsB,CAAC;CAC/B,GAGD;IACE,EAAE,EAAE,qBAAqB,CAAC;IAC1B,KAAK,EAAE,sBAAsB,CAAC;IAC9B,6DAA6D;IAC7D,IAAI,EAAE,eAAe,CAAC;CACvB,GACD;IACE,EAAE,EAAE,uBAAuB,CAAC;IAC5B,KAAK,EAAE,sBAAsB,CAAC;CAC/B,GACD;IACE,EAAE,EAAE,mBAAmB,CAAC;IACxB,KAAK,EAAE,sBAAsB,CAAC;IAC9B,mEAAmE;IACnE,YAAY,EAAE,kBAAkB,CAAC;IACjC,iFAAiF;IACjF,aAAa,EAAE,MAAM,CAAC,MAAM,EAAE,oBAAoB,CAAC,CAAC;IACpD,wEAAwE;IACxE,UAAU,EAAE,sBAAsB,CAAC;IACnC;;;OAGG;IACH,IAAI,CAAC,EAAE,oBAAoB,CAAC;CAC7B,GAID;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,qFAAqF;IACrF,OAAO,EAAE,qBAAqB,CAAC;CAChC,GACD;IACE,EAAE,EAAE,eAAe,CAAC;CACrB,GACD;IACE,EAAE,EAAE,YAAY,CAAC;IACjB,oDAAoD;IACpD,MAAM,EAAE,eAAe,CAAC;CACzB,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,gEAAgE;IAChE,IAAI,EAAE,MAAM,CAAC;CACd,GAKD;IACE,EAAE,EAAE,UAAU,CAAC;IACf,8BAA8B;IAC9B,MAAM,EAAE,QAAQ,CAAC;IACjB,mCAAmC;IACnC,IAAI,EAAE,eAAe,CAAC;IACtB;;;;OAIG;IACH,MAAM,CAAC,EAAE,gBAAgB,CAAC;CAC3B,GACD;IACE,EAAE,EAAE,UAAU,CAAC;IACf,iDAAiD;IACjD,MAAM,EAAE,gBAAgB,CAAC;IACzB,6CAA6C;IAC7C,IAAI,EAAE,eAAe,CAAC;CACvB,GACD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,MAAM,EAAE,QAAQ,CAAC;IACjB,yCAAyC;IACzC,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,kEAAkE;IAClE,MAAM,EAAE,gBAAgB,CAAC;CAC1B,GACD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,gKAAgK;IAChK,SAAS,EAAE,MAAM,CAAC;CACnB,GAID;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,+IAA+I;IAC/I,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,sIAAsI;IACtI,aAAa,EAAE,MAAM,CAAC;CACvB,GACD;IACE,EAAE,EAAE,6BAA6B,CAAC;IAClC,uGAAuG;IACvG,aAAa,EAAE,MAAM,CAAC;IACtB,0FAA0F;IAC1F,UAAU,CAAC,EAAE,mBAAmB,EAAE,CAAC;CACpC,GACD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,6LAA6L;IAC7L,SAAS,EAAE,oBAAoB,CAAC;CACjC,GACD;IACE,EAAE,EAAE,kBAAkB,CAAC;IACvB,8EAA8E;IAC9E,OAAO,EAAE,MAAM,CAAC;IAChB,uFAAuF;IACvF,UAAU,CAAC,EAAE,MAAM,CAAC;CACrB,GAID;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,yFAAyF;IACzF,MAAM,EAAE,eAAe,CAAC;CACzB,GACD;IACE,EAAE,EAAE,eAAe,CAAC;IACpB,yFAAyF;IACzF,MAAM,EAAE,eAAe,CAAC;CACzB,GAGD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,wEAAwE;IACxE,MAAM,EAAE,QAAQ,CAAC;IACjB,IAAI,EAAE,eAAe,CAAC;IACtB;;;OAGG;IACH,MAAM,CAAC,EAAE,gBAAgB,CAAC;CAC3B,GACD;IACE,EAAE,EAAE,aAAa,CAAC;IAClB,yEAAyE;IACzE,MAAM,EAAE,gBAAgB,CAAC;IACzB,IAAI,EAAE,eAAe,CAAC;CACvB,GAKD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,kDAAkD;IAClD,IAAI,EAAE,MAAM,CAAC;IACb,yHAAyH;IACzH,EAAE,EAAE,MAAM,CAAC;CACZ,GACD;IACE,EAAE,EAAE,iBAAiB,CAAC;IACtB,yCAAyC;IACzC,IAAI,EAAE,MAAM,CAAC;IACb,yHAAyH;IACzH,EAAE,EAAE,MAAM,CAAC;CACZ,GACD;IACE,EAAE,EAAE,6BAA6B,CAAC;IAClC,0GAA0G;IAC1G,aAAa,EAAE,MAAM,CAAC;IACtB,iHAAiH;IACjH,UAAU,EAAE,mBAAmB,EAAE,CAAC;CACnC,GACD;IACE,EAAE,EAAE,0BAA0B,CAAC;IAC/B,qFAAqF;IACrF,IAAI,EAAE,oBAAoB,CAAC;IAC3B,0EAA0E;IAC1E,EAAE,EAAE,oBAAoB,CAAC;CAC1B,CAAC;AAEN,MAAM,WAAW,QAAQ;IACvB,UAAU,EAAE,UAAU,EAAE,CAAC;CAC1B;AAED;;;GAGG;AACH,MAAM,MAAM,mBAAmB,GAAG,WAAW,GAAG,QAAQ,GAAG,MAAM,GAAG,OAAO,CAAC;AA8F5E;;;;;;;GAOG;AACH,wBAAgB,UAAU,CAAC,GAAG,EAAE,OAAO,GAAG,QAAQ,CAqBjD;AAED,4FAA4F;AAC5F,wBAAgB,aAAa,CAAC,GAAG,EAAE;IAAE,QAAQ,CAAC,EAAE;QAAE,QAAQ,CAAC,EAAE,eAAe,EAAE,CAAA;KAAE,CAAA;CAAE,GAAG,UAAU,CAI9F;AAED;;;;GAIG;AACH,wBAAgB,UAAU,CAAC,GAAG,EAAE,aAAa,EAAE,KAAK,EAAE,QAAQ,GAAG,eAAe,CAG/E;AAq4CD,wBAAgB,UAAU,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAEzD;AAED,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAEhE;AAED,wBAAgB,SAAS,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAExD;AAED,wBAAgB,eAAe,CAAC,IAAI,EAAE,eAAe,GAAG,OAAO,CAE9D;AAqfD,iJAAiJ;AACjJ,wBAAgB,4BAA4B,CAAC,KAAK,EAAE,QAAQ,GAAG,MAAM,EAAE,CAItE;AAED,gGAAgG;AAChG,wBAAgB,aAAa,CAAC,KAAK,EAAE,QAAQ,GAAG,mBAAmB,CAWlE;AA0GD;;;;GAIG;AACH,wBAAgB,qBAAqB,CAAC,GAAG,EAAE;IAAE,QAAQ,CAAC,EAAE;QAAE,QAAQ,CAAC,EAAE,eAAe,EAAE,CAAA;KAAE,CAAA;CAAE,GAAG,eAAe,GAAG;IAAE,SAAS,CAAC,EAAE,OAAO,CAAC;IAAC,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;CAAE,CAmB/K;AAED,wBAAgB,iBAAiB,CAAC,UAAU,EAAE;IAAE,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;CAAE,GAAG,6BAA6B,CAUzH"}

package/build/dist/lib/job-patch.js

@@ -86,6 +86,9 @@ function isRecord(value) {
 function isKnownPatchOpName(opName) {
     return Object.prototype.hasOwnProperty.call(REQUIRED_OP_FIELDS, opName);
 }
+function isTemplateInputField(field) {
+    return Object.prototype.hasOwnProperty.call(INPUT_FIELD_TOUCHES, field);
+}
 function assertValidPatchOperation(op, index) {
     if (!isRecord(op) || typeof op['op'] !== 'string') {
         throw new Error(`Operation ${index} must be an object with a string "op" field`);
@@ -101,11 +104,12 @@ function assertValidPatchOperation(op, index) {
     }
 }
 /**
- * Validate the patch file shape, including each op's name and required fields, so
- * a typo'd or under-specified op (e.g. `add-group-by` with no `attributePath`)
- * fails cleanly at the file boundary rather than deep inside `applyPatch` with a
- * confusing internal error. `applyPatch` still does the deeper
- * semantic/target-conditional validation.
+ * Validate the patch file shape, including each op's name and required fields and
+ * that a `set/unset-input-field` path names a template input field (and, under
+ * `transforms`, a slot), so a typo'd or
+ * under-specified op (e.g. `add-group-by` with no `attributePath`) fails cleanly at
+ * the file boundary rather than deep inside `applyPatch` with a confusing internal
+ * error. `applyPatch` still does the deeper semantic/target-conditional validation.
  */
 export function parsePatch(raw) {
     if (raw === null || typeof raw !== 'object') {
@@ -120,6 +124,9 @@ export function parsePatch(raw) {
     for (let i = 0; i < operations.length; i++) {
         const op = operations[i];
         assertValidPatchOperation(op, i);
+        if (op.op === 'set-input-field' || op.op === 'unset-input-field') {
+            templateInputField(op, i);
+        }
         parsedOperations.push(op);
     }
     return { operations: parsedOperations };
@@ -1589,17 +1596,10 @@ function applyRemoveSink(input, target, name, index) {
 }
 function applySetRawDataset(input, datasetId) {
     input.datasetId = datasetId;
-    // rawSinkConfig.datasetId is an override that takes precedence over input.datasetId
-    // for the raw sink, so when it is set, update it too or the raw sink keeps writing
-    // to the old dataset.
-    const rawSinkConfig = input.rawSinkConfig;
-    if (rawSinkConfig?.datasetId != null) {
-        rawSinkConfig.datasetId = datasetId;
-    }
 }
 /** Returns limitation strings for the user-facing draft preamble; non-empty when the patch touches sinks (external delivery is not verified). */
 export function draftVerificationLimitations(patch) {
-    return patch.operations.some(op => touchesSinkConfig(op))
+    return patch.operations.some(touchesSinkConfig)
         ? ['Sink/data-lake output edits are submitted for graph/upstream verification only; external sink delivery is not verified.']
         : [];
 }
@@ -1607,12 +1607,12 @@ export function draftVerificationLimitations(patch) {
 export function classifyPatch(patch) {
     let source = false;
     let sink = false;
-    for (const op of patch.operations) {
-        if (touchesSourceConfig(op))
+    patch.operations.forEach((op, index) => {
+        if (touchesSourceConfig(op, index))
             source = true;
-        if (touchesSinkConfig(op))
+        if (touchesSinkConfig(op, index))
             sink = true;
-    }
+    });
     if (source && sink)
         return 'mixed';
     if (source)
@@ -1624,9 +1624,9 @@ export function classifyPatch(patch) {
 /**
  * What a write to each top-level `templateInputs.input` field touches. Keyed by
  * `keyof SchemaLogReducerTemplateInput` so the compiler forces every schema
- * field to be classified — a new field is a build error here, not a silent
- * `unknown`. `datasetId` is the raw-logs dataset (semantic equivalent of
- * set-raw-dataset).
+ * field to be classified — a new field is a build error here. Its keys are also
+ * the only fields `set/unset-input-field` accept. `datasetId` is the raw-logs
+ * dataset (semantic equivalent of set-raw-dataset).
  */
 const INPUT_FIELD_TOUCHES = {
     sources: 'source',
@@ -1638,7 +1638,6 @@ const INPUT_FIELD_TOUCHES = {
     rawSinkConfig: 'sink',
     datasetId: 'sink',
     conditionalDatasets: 'sink',
-    confirmedDeliveryEnabled: 'sink',
     reducer: 'transform',
     parsers: 'transform',
     transforms: 'transform',
@@ -1646,33 +1645,58 @@ const INPUT_FIELD_TOUCHES = {
     sampler: 'transform',
     masking: 'transform',
 };
+const TEMPLATE_INPUT_FIELDS = Object.keys(INPUT_FIELD_TOUCHES).sort();
+/**
+ * The template's `transforms` slots, keyed by `keyof SchemaTransforms` so the compiler forces
+ * every slot to be listed. They're the only keys `set/unset-input-field` accept under
+ * `transforms`; the filter phase names (`pre-parser`, ...) aren't slots.
+ */
+const TRANSFORM_SLOTS = {
+    preParser: true,
+    preWarehouse: true,
+    preExceptions: true,
+};
+const TRANSFORM_SLOT_NAMES = Object.keys(TRANSFORM_SLOTS).sort();
+const INPUT_FIELD_ERROR_HINT = 'Edit filters with set-filter / clear-filter and transform chains with set-transform-chain. ' +
+    'If the field is newer than this CLI, upgrade it: npm install -g @grepr/cli@latest.';
 /**
- * Classify a generic `set/unset-input-field` path by its top-level field.
- * Fails closed: an unrecognized field returns `unknown`, which callers treat as
- * touching both source and sink so the change routes to a conservative
- * (source-preserving, non-replay) draft rather than being misclassified
- * `transform` and previewed on a chain that never exercises it.
+ * The top-level template input field a generic `set/unset-input-field` path edits: its first
+ * segment, matched exactly against the schema's own fields. Under `transforms`, the slot (the
+ * path's second segment, or each key of a whole `transforms` value) must be a real slot too.
+ * Anything else throws. The server stores an unknown key and the template never reads it, so
+ * the edit would plan and draft cleanly while changing nothing.
  */
-function classifyInputPath(path) {
-    const top = (stripInputRoot(path).split('.')[0] ?? '').split('[')[0] ?? '';
-    return (top in INPUT_FIELD_TOUCHES) ? INPUT_FIELD_TOUCHES[top] : 'unknown';
+function templateInputField(op, index) {
+    const [top = '', slot] = stripInputRoot(op.path).split('.');
+    if (!isTemplateInputField(top)) {
+        throw new Error(`Operation ${index} (${op.op}): "${top}" is not a template input field, so the template would ignore this edit. ` +
+            `Template input fields: ${TEMPLATE_INPUT_FIELDS.join(', ')}. ${INPUT_FIELD_ERROR_HINT}`);
+    }
+    if (top === 'transforms') {
+        const wholeValue = op.op === 'set-input-field' && isRecord(op.value) ? Object.keys(op.value) : [];
+        for (const key of slot === undefined ? wholeValue : [slot]) {
+            if (!Object.prototype.hasOwnProperty.call(TRANSFORM_SLOTS, key)) {
+                throw new Error(`Operation ${index} (${op.op}): "transforms.${key}" is not a transform slot, so the template would ignore this edit. ` +
+                    `Transform slots: ${TRANSFORM_SLOT_NAMES.join(', ')}. ${INPUT_FIELD_ERROR_HINT}`);
+            }
+        }
+    }
+    return top;
 }
-function touchesSourceConfig(op) {
+function touchesSourceConfig(op, index) {
     switch (op.op) {
         case 'add-source':
         case 'remove-source':
         case 'update-source':
             return true;
         case 'set-input-field':
-        case 'unset-input-field': {
-            const cls = classifyInputPath(op.path);
-            return cls === 'source' || cls === 'unknown';
-        }
+        case 'unset-input-field':
+            return INPUT_FIELD_TOUCHES[templateInputField(op, index)] === 'source';
         default:
             return false;
     }
 }
-function touchesSinkConfig(op) {
+function touchesSinkConfig(op, index) {
     switch (op.op) {
         case 'add-sink':
         case 'remove-sink':
@@ -1680,10 +1704,8 @@ function touchesSinkConfig(op) {
         case 'set-raw-dataset':
             return true;
         case 'set-input-field':
-        case 'unset-input-field': {
-            const cls = classifyInputPath(op.path);
-            return cls === 'sink' || cls === 'unknown';
-        }
+        case 'unset-input-field':
+            return INPUT_FIELD_TOUCHES[templateInputField(op, index)] === 'sink';
         default:
             return false;
     }