@graphql-tools/stitch 10.3.0 → 10.3.1

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @graphql-tools/stitch
 
+## 10.3.1
+### Patch Changes
+
+
+
+- [#2591](https://github.com/graphql-hive/gateway/pull/2591) [`8f582af`](https://github.com/graphql-hive/gateway/commit/8f582af7e2cd250d9538495487c33a64b038bcb4) Thanks [@kpiotr](https://github.com/kpiotr)! - `stitchSchemas` no longer mutates the resolver objects passed in `resolvers`.
+  
+  The wrapper it adds around resolvers of fields that return a merged type (so the merged type's fields get resolved) used to be written back into the caller's field config (`existing.resolve = wrappedResolve`). A resolver map reused across `stitchSchemas` calls — a gateway's additional resolvers on every supergraph reload — therefore gained one wrapper per call, and every wrapper kept its call's `stitchingInfo`, and with it the entire superseded schema, subschemas and executors, reachable: a heap leak of one schema generation per reload.
+  
+  Nesting also changed behaviour, because `wrappedResolve` closes over its own call's `stitchingInfo` and the innermost (oldest) wrapper runs first: such a field hydrated through a superseded call's stitching plan and executors, and once that hydration satisfied the selection the newest wrapper found nothing left to resolve.
+  
+  The merged resolver map is now cloned before the wrappers are added. Enum value maps, scalars, union and input type resolvers and plain resolver functions are still passed through by reference, so their identities are unchanged.
+
 ## 10.3.0
 ### Minor Changes
 

package/dist/index.cjs

@@ -3234,7 +3234,10 @@ function stitchSchemas(options) {
       commentDescriptions: true
     });
   }
-  const resolverMap = merge.mergeResolvers(resolvers);
+  const resolverMap = cloneResolverMap(
+    merge.mergeResolvers(resolvers),
+    schema$1
+  );
   const finalResolvers = inheritResolversFromInterfaces ? schema.extendResolversFromInterfaces(schema$1, resolverMap) : resolverMap;
   stitchingInfo = completeStitchingInfo(stitchingInfo, finalResolvers, schema$1);
   addLocalFieldResolvers(schema$1, finalResolvers, stitchingInfo, typeCandidates);
@@ -3301,6 +3304,31 @@ function stripCustomDirectiveUsages(types) {
     }
   }
 }
+function isResolverRecord(value) {
+  return value != null && typeof value === "object" && !Array.isArray(value);
+}
+function cloneResolverMap(resolverMap, schema) {
+  const cloned = {};
+  for (const typeName in resolverMap) {
+    const typeResolvers = resolverMap[typeName];
+    if (typeResolvers === void 0) {
+      continue;
+    }
+    const type = schema.getType(typeName);
+    if (!isResolverRecord(typeResolvers) || !graphql.isObjectType(type) && !graphql.isInterfaceType(type)) {
+      cloned[typeName] = typeResolvers;
+      continue;
+    }
+    const fieldConfigs = typeResolvers;
+    const clonedType = {};
+    for (const fieldName in fieldConfigs) {
+      const field = fieldConfigs[fieldName];
+      clonedType[fieldName] = isResolverRecord(field) ? { ...field } : field;
+    }
+    cloned[typeName] = clonedType;
+  }
+  return cloned;
+}
 function addLocalFieldResolvers(schema, resolvers, stitchingInfo, typeCandidates) {
   const subschemaFields = /* @__PURE__ */ new Set();
   const localFields = /* @__PURE__ */ new Map();

package/dist/index.js

@@ -3232,7 +3232,10 @@ function stitchSchemas(options) {
       commentDescriptions: true
     });
   }
-  const resolverMap = mergeResolvers(resolvers);
+  const resolverMap = cloneResolverMap(
+    mergeResolvers(resolvers),
+    schema
+  );
   const finalResolvers = inheritResolversFromInterfaces ? extendResolversFromInterfaces(schema, resolverMap) : resolverMap;
   stitchingInfo = completeStitchingInfo(stitchingInfo, finalResolvers, schema);
   addLocalFieldResolvers(schema, finalResolvers, stitchingInfo, typeCandidates);
@@ -3299,6 +3302,31 @@ function stripCustomDirectiveUsages(types) {
     }
   }
 }
+function isResolverRecord(value) {
+  return value != null && typeof value === "object" && !Array.isArray(value);
+}
+function cloneResolverMap(resolverMap, schema) {
+  const cloned = {};
+  for (const typeName in resolverMap) {
+    const typeResolvers = resolverMap[typeName];
+    if (typeResolvers === void 0) {
+      continue;
+    }
+    const type = schema.getType(typeName);
+    if (!isResolverRecord(typeResolvers) || !isObjectType(type) && !isInterfaceType(type)) {
+      cloned[typeName] = typeResolvers;
+      continue;
+    }
+    const fieldConfigs = typeResolvers;
+    const clonedType = {};
+    for (const fieldName in fieldConfigs) {
+      const field = fieldConfigs[fieldName];
+      clonedType[fieldName] = isResolverRecord(field) ? { ...field } : field;
+    }
+    cloned[typeName] = clonedType;
+  }
+  return cloned;
+}
 function addLocalFieldResolvers(schema, resolvers, stitchingInfo, typeCandidates) {
   const subschemaFields = /* @__PURE__ */ new Set();
   const localFields = /* @__PURE__ */ new Map();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@graphql-tools/stitch",
-  "version": "10.3.0",
+  "version": "10.3.1",
   "type": "module",
   "description": "A set of utils for faster development of GraphQL tools",
   "repository": {