@graphql-tools/delegate 12.0.11 → 12.0.12-alpha-bcdf6a1333a84f3ead114d676e66e609c350e084

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @graphql-tools/delegate
 
+## 12.0.12-alpha-bcdf6a1333a84f3ead114d676e66e609c350e084
+### Patch Changes
+
+
+
+- [#2106](https://github.com/graphql-hive/gateway/pull/2106) [`bcdf6a1`](https://github.com/graphql-hive/gateway/commit/bcdf6a1333a84f3ead114d676e66e609c350e084) Thanks [@ardatan](https://github.com/ardatan)! - - Optimizations to select ONLY required fields when fetching the missing fields from other subgraphs
+  - Do not try to resolve types from the subschemas which only have the stub types, for example if a subgraph only has `id` field as a stub, do not use that subgraph as a target subgraph for resolving the type, because it will not have any other fields than `id`.
+
 ## 12.0.11
 ### Patch Changes
 

package/dist/index.cjs

@@ -598,6 +598,9 @@ function finalizeGatewayDocument(targetSchema, fragments, operations, onOverlapp
   const validFragments = [];
   const validFragmentsWithType = /* @__PURE__ */ Object.create(null);
   for (const fragment of fragments) {
+    if (fragment.selectionSet.selections.length === 0) {
+      continue;
+    }
     const typeName = fragment.typeCondition.name.value;
     const type = targetSchema.getType(typeName);
     if (type != null) {
@@ -1206,6 +1209,12 @@ function prepareGatewayDocument(originalDocument, transformedSchema, returnType,
     kind: graphql.Kind.DOCUMENT,
     definitions: [...operations, ...fragments, ...expandedFragments]
   };
+  const fragmentMap = /* @__PURE__ */ Object.create(null);
+  for (const fragment of expandedDocument.definitions) {
+    if (fragment.kind === graphql.Kind.FRAGMENT_DEFINITION) {
+      fragmentMap[fragment.name.value] = fragment;
+    }
+  }
   const visitorKeyMap = {
     Document: ["definitions"],
     OperationDefinition: ["selectionSet"],
@@ -1229,7 +1238,8 @@ function prepareGatewayDocument(originalDocument, transformedSchema, returnType,
         fieldNodesByField,
         dynamicSelectionSetsByField,
         infoSchema,
-        visitedSelections
+        visitedSelections,
+        fragmentMap
       )
     }),
     // visitorKeys argument usage a la https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-graphql/src/batching/merge-queries.js
@@ -1267,11 +1277,19 @@ const getExtraPossibleTypesFn = utils.memoize2(function getExtraPossibleTypes(tr
     return extraTypesForSubschema;
   };
 });
-function visitSelectionSet(node, fragmentReplacements, transformedSchema, typeInfo, possibleTypesMap, reversePossibleTypesMap2, interfaceExtensionsMap, fieldNodesByType, fieldNodesByField, dynamicSelectionSetsByField, infoSchema, visitedSelections) {
+function visitSelectionSet(node, fragmentReplacements, transformedSchema, typeInfo, possibleTypesMap, reversePossibleTypesMap2, interfaceExtensionsMap, fieldNodesByType, fieldNodesByField, dynamicSelectionSetsByField, infoSchema, visitedSelections, fragmentMap) {
   const newSelections = /* @__PURE__ */ new Set();
   const maybeType = typeInfo.getParentType();
   if (maybeType != null) {
     const parentType = graphql.getNamedType(maybeType);
+    if (isSelectionSetSatisfiedBySchema(
+      transformedSchema,
+      parentType,
+      node,
+      fragmentMap
+    )) {
+      return node;
+    }
     const parentTypeName = parentType.name;
     const fieldNodes = fieldNodesByType[parentTypeName];
     if (fieldNodes) {
@@ -1461,6 +1479,91 @@ function isFieldNodeSatisfiedBySelections(fieldNode, existing) {
   }
   return false;
 }
+function isSelectionSetSatisfiedBySchema(schema, type, selectionSet, fragmentsMap) {
+  const namedType = graphql.getNamedType(type);
+  if (graphql.isLeafType(namedType)) {
+    return true;
+  }
+  for (const selection of selectionSet.selections) {
+    if (selection.kind === graphql.Kind.FIELD) {
+      if (graphql.isAbstractType(namedType)) {
+        return false;
+      }
+      const fieldName = selection.name.value;
+      if (fieldName === "__typename") {
+        continue;
+      }
+      if (graphql.isObjectType(namedType) || graphql.isInterfaceType(namedType)) {
+        const field = namedType.getFields()[fieldName];
+        if (!field) {
+          return false;
+        }
+        if (selection.selectionSet) {
+          const fieldType = graphql.getNamedType(field.type);
+          const satisfied = isSelectionSetSatisfiedBySchema(
+            schema,
+            fieldType,
+            selection.selectionSet,
+            fragmentsMap
+          );
+          if (!satisfied) {
+            return false;
+          }
+        }
+      } else {
+        return false;
+      }
+    } else if (selection.kind === graphql.Kind.INLINE_FRAGMENT) {
+      if (selection.typeCondition) {
+        const typeConditionName = selection.typeCondition.name.value;
+        const typeCondition = schema.getType(typeConditionName);
+        if (!typeCondition) {
+          return false;
+        }
+        const satisfied = isSelectionSetSatisfiedBySchema(
+          schema,
+          typeCondition,
+          selection.selectionSet,
+          fragmentsMap
+        );
+        if (!satisfied) {
+          return false;
+        }
+      } else {
+        const satisfied = isSelectionSetSatisfiedBySchema(
+          schema,
+          type,
+          selection.selectionSet,
+          fragmentsMap
+        );
+        if (!satisfied) {
+          return false;
+        }
+      }
+    } else if (selection.kind === graphql.Kind.FRAGMENT_SPREAD) {
+      const fragmentName = selection.name.value;
+      const fragment = fragmentsMap[fragmentName];
+      if (!fragment) {
+        return false;
+      }
+      const typeConditionName = fragment.typeCondition.name.value;
+      const typeCondition = schema.getType(typeConditionName);
+      if (!typeCondition) {
+        return false;
+      }
+      const satisfied = isSelectionSetSatisfiedBySchema(
+        schema,
+        typeCondition,
+        fragment.selectionSet,
+        fragmentsMap
+      );
+      if (!satisfied) {
+        return false;
+      }
+    }
+  }
+  return true;
+}
 function isSelectionSetSatisfied({
   incoming,
   existing

package/dist/index.js

@@ -598,6 +598,9 @@ function finalizeGatewayDocument(targetSchema, fragments, operations, onOverlapp
   const validFragments = [];
   const validFragmentsWithType = /* @__PURE__ */ Object.create(null);
   for (const fragment of fragments) {
+    if (fragment.selectionSet.selections.length === 0) {
+      continue;
+    }
     const typeName = fragment.typeCondition.name.value;
     const type = targetSchema.getType(typeName);
     if (type != null) {
@@ -1206,6 +1209,12 @@ function prepareGatewayDocument(originalDocument, transformedSchema, returnType,
     kind: Kind.DOCUMENT,
     definitions: [...operations, ...fragments, ...expandedFragments]
   };
+  const fragmentMap = /* @__PURE__ */ Object.create(null);
+  for (const fragment of expandedDocument.definitions) {
+    if (fragment.kind === Kind.FRAGMENT_DEFINITION) {
+      fragmentMap[fragment.name.value] = fragment;
+    }
+  }
   const visitorKeyMap = {
     Document: ["definitions"],
     OperationDefinition: ["selectionSet"],
@@ -1229,7 +1238,8 @@ function prepareGatewayDocument(originalDocument, transformedSchema, returnType,
         fieldNodesByField,
         dynamicSelectionSetsByField,
         infoSchema,
-        visitedSelections
+        visitedSelections,
+        fragmentMap
       )
     }),
     // visitorKeys argument usage a la https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-graphql/src/batching/merge-queries.js
@@ -1267,11 +1277,19 @@ const getExtraPossibleTypesFn = memoize2(function getExtraPossibleTypes(transfor
     return extraTypesForSubschema;
   };
 });
-function visitSelectionSet(node, fragmentReplacements, transformedSchema, typeInfo, possibleTypesMap, reversePossibleTypesMap2, interfaceExtensionsMap, fieldNodesByType, fieldNodesByField, dynamicSelectionSetsByField, infoSchema, visitedSelections) {
+function visitSelectionSet(node, fragmentReplacements, transformedSchema, typeInfo, possibleTypesMap, reversePossibleTypesMap2, interfaceExtensionsMap, fieldNodesByType, fieldNodesByField, dynamicSelectionSetsByField, infoSchema, visitedSelections, fragmentMap) {
   const newSelections = /* @__PURE__ */ new Set();
   const maybeType = typeInfo.getParentType();
   if (maybeType != null) {
     const parentType = getNamedType(maybeType);
+    if (isSelectionSetSatisfiedBySchema(
+      transformedSchema,
+      parentType,
+      node,
+      fragmentMap
+    )) {
+      return node;
+    }
     const parentTypeName = parentType.name;
     const fieldNodes = fieldNodesByType[parentTypeName];
     if (fieldNodes) {
@@ -1461,6 +1479,91 @@ function isFieldNodeSatisfiedBySelections(fieldNode, existing) {
   }
   return false;
 }
+function isSelectionSetSatisfiedBySchema(schema, type, selectionSet, fragmentsMap) {
+  const namedType = getNamedType(type);
+  if (isLeafType(namedType)) {
+    return true;
+  }
+  for (const selection of selectionSet.selections) {
+    if (selection.kind === Kind.FIELD) {
+      if (isAbstractType(namedType)) {
+        return false;
+      }
+      const fieldName = selection.name.value;
+      if (fieldName === "__typename") {
+        continue;
+      }
+      if (isObjectType(namedType) || isInterfaceType(namedType)) {
+        const field = namedType.getFields()[fieldName];
+        if (!field) {
+          return false;
+        }
+        if (selection.selectionSet) {
+          const fieldType = getNamedType(field.type);
+          const satisfied = isSelectionSetSatisfiedBySchema(
+            schema,
+            fieldType,
+            selection.selectionSet,
+            fragmentsMap
+          );
+          if (!satisfied) {
+            return false;
+          }
+        }
+      } else {
+        return false;
+      }
+    } else if (selection.kind === Kind.INLINE_FRAGMENT) {
+      if (selection.typeCondition) {
+        const typeConditionName = selection.typeCondition.name.value;
+        const typeCondition = schema.getType(typeConditionName);
+        if (!typeCondition) {
+          return false;
+        }
+        const satisfied = isSelectionSetSatisfiedBySchema(
+          schema,
+          typeCondition,
+          selection.selectionSet,
+          fragmentsMap
+        );
+        if (!satisfied) {
+          return false;
+        }
+      } else {
+        const satisfied = isSelectionSetSatisfiedBySchema(
+          schema,
+          type,
+          selection.selectionSet,
+          fragmentsMap
+        );
+        if (!satisfied) {
+          return false;
+        }
+      }
+    } else if (selection.kind === Kind.FRAGMENT_SPREAD) {
+      const fragmentName = selection.name.value;
+      const fragment = fragmentsMap[fragmentName];
+      if (!fragment) {
+        return false;
+      }
+      const typeConditionName = fragment.typeCondition.name.value;
+      const typeCondition = schema.getType(typeConditionName);
+      if (!typeCondition) {
+        return false;
+      }
+      const satisfied = isSelectionSetSatisfiedBySchema(
+        schema,
+        typeCondition,
+        fragment.selectionSet,
+        fragmentsMap
+      );
+      if (!satisfied) {
+        return false;
+      }
+    }
+  }
+  return true;
+}
 function isSelectionSetSatisfied({
   incoming,
   existing

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@graphql-tools/delegate",
-  "version": "12.0.11",
+  "version": "12.0.12-alpha-bcdf6a1333a84f3ead114d676e66e609c350e084",
   "type": "module",
   "description": "A set of utils for faster development of GraphQL tools",
   "repository": {