@graphql-tools/batch-execute 10.0.8 → 10.0.9-alpha-adaef9d2f8175d3f2870a7f6efd2df86b4a46a9c

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @graphql-tools/batch-execute
 
+## 10.0.9-alpha-adaef9d2f8175d3f2870a7f6efd2df86b4a46a9c
+### Patch Changes
+
+
+
+- [#2452](https://github.com/graphql-hive/gateway/pull/2452) [`4311d79`](https://github.com/graphql-hive/gateway/commit/4311d79d854a589f2f6295629b9ad5b0a5c00f92) Thanks [@wijskinner](https://github.com/wijskinner)! - Fix `DataLoader must be constructed with a function which accepts Array<key> and returns Promise<Array<value>>, but the function did not return a Promise of an Array` thrown when a batched subgraph response omits some of the merged sub-requests.
+  
+  `splitResult` builds `new Array(numResults)` and only assigns the indices present in the merged response's `data`/`errors`. When a subgraph answers only some of the batched operations — returning neither a data key nor a path-scoped error for the rest — those slots stay holes. A hole at the trailing slot fails DataLoader's `isArrayLike` check (which requires `hasOwnProperty(length - 1)`) even though `Array.isArray` is `true`, so the batching executor's DataLoader throws. The result is now densified to `numResults`, filling any missing slot with an empty `ExecutionResult`.
+  
+  This mirrors the sibling fix for `@graphql-tools/batch-delegate` in [#2393](https://github.com/graphql-hive/gateway/issues/2393).
+
 ## 10.0.8
 ### Patch Changes
 

package/dist/index.cjs

@@ -313,6 +313,11 @@ function splitResult({ data, errors }, numResults) {
       }
     }
   }
+  for (let i = 0; i < numResults; i++) {
+    if (splitResults[i] == null) {
+      splitResults[i] = { data: {} };
+    }
+  }
   return splitResults;
 }
 

package/dist/index.js

@@ -307,6 +307,11 @@ function splitResult({ data, errors }, numResults) {
       }
     }
   }
+  for (let i = 0; i < numResults; i++) {
+    if (splitResults[i] == null) {
+      splitResults[i] = { data: {} };
+    }
+  }
   return splitResults;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@graphql-tools/batch-execute",
-  "version": "10.0.8",
+  "version": "10.0.9-alpha-adaef9d2f8175d3f2870a7f6efd2df86b4a46a9c",
   "type": "module",
   "description": "A set of utils for faster development of GraphQL tools",
   "repository": {
@@ -45,7 +45,7 @@
   },
   "devDependencies": {
     "graphql": "^16.12.0",
-    "pkgroll": "2.27.0"
+    "pkgroll": "2.27.1"
   },
   "sideEffects": false
 }