@graphql-tools/batch-delegate 10.0.23 → 10.0.24-rc-8a13ce71a0e8f58bfb291d30e79cd42e96a06972

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @graphql-tools/batch-delegate
 
+## 10.0.24-rc-8a13ce71a0e8f58bfb291d30e79cd42e96a06972
+### Patch Changes
+
+
+
+- [#2393](https://github.com/graphql-hive/gateway/pull/2393) [`b6230c9`](https://github.com/graphql-hive/gateway/commit/b6230c97709065c2f540b6d263af492379eca359) Thanks [@sjransom](https://github.com/sjransom)! - Fix `DataLoader must be constructed with a function which accepts Array<key> and returns Promise<Array<value>>, but the function did not return a Promise of an Array` thrown when the batch resolves to a sparse array.
+  
+  When `valuesFromResults` returns an array with a hole at the trailing slot — for example when it maps results back to keys by index and the last key in a batch has no matching row — the resulting array fails DataLoader's `isArrayLike` check (which requires `hasOwnProperty(length - 1)`), even though `Array.isArray` returns `true`. The batch result is now normalised to a dense array of `keys.length`, padding any missing entries with `null`.
+
 ## 10.0.23
 ### Patch Changes
 

package/dist/index.cjs

@@ -40,7 +40,14 @@ function createBatchFn(options) {
       })
     ).then((results) => {
       const values = valuesFromResults == null ? results : results instanceof Error ? keys.map(() => results) : valuesFromResults(results, keys);
-      return Array.isArray(values) ? values : keys.map(() => values);
+      if (!Array.isArray(values)) {
+        return keys.map(() => values);
+      }
+      const dense = new Array(keys.length);
+      for (let i = 0; i < keys.length; i++) {
+        dense[i] = values[i] ?? null;
+      }
+      return dense;
     }).catch((error) => keys.map(() => error));
   };
 }

package/dist/index.js

@@ -34,7 +34,14 @@ function createBatchFn(options) {
       })
     ).then((results) => {
       const values = valuesFromResults == null ? results : results instanceof Error ? keys.map(() => results) : valuesFromResults(results, keys);
-      return Array.isArray(values) ? values : keys.map(() => values);
+      if (!Array.isArray(values)) {
+        return keys.map(() => values);
+      }
+      const dense = new Array(keys.length);
+      for (let i = 0; i < keys.length; i++) {
+        dense[i] = values[i] ?? null;
+      }
+      return dense;
     }).catch((error) => keys.map(() => error));
   };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@graphql-tools/batch-delegate",
-  "version": "10.0.23",
+  "version": "10.0.24-rc-8a13ce71a0e8f58bfb291d30e79cd42e96a06972",
   "type": "module",
   "description": "A set of utils for faster development of GraphQL tools",
   "repository": {