npm - @graphql-eslint/eslint-plugin - Versions diffs - 2.3.2-alpha-6c4312e.0 → 2.3.2-alpha-da2ba63.0 - Mend

@graphql-eslint/eslint-plugin 2.3.2-alpha-6c4312e.0 → 2.3.2-alpha-da2ba63.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (4) hide show

package/index.js CHANGED Viewed

@@ -612,7 +612,7 @@ const rule = {
             ],
         },
         messages: {
-            [ALPHABETIZE]: '"{{ currName }}" should be before "{{ prevName }}"',
+            [ALPHABETIZE]: '"{{ currName }}" should be before "{{ prevName }}".',
         },
         schema: {
             type: 'array',
@@ -669,9 +669,16 @@ const rule = {
             for (const node of nodes) {
                 const currName = node.name.value;
                 if (prevName && prevName > currName) {
+                    const { start, end } = node.name.loc;
                     const isVariableNode = node.kind === graphql.Kind.VARIABLE;
                     context.report({
-                        loc: getLocation(node.loc, node.name.value, { offsetEnd: isVariableNode ? 0 : 1 }),
+                        loc: {
+                            start: {
+                                line: start.line,
+                                column: start.column - (isVariableNode ? 2 : 1),
+                            },
+                            end,
+                        },
                         messageId: ALPHABETIZE,
                         data: isVariableNode
                             ? {
@@ -2155,7 +2162,7 @@ const rule$e = {
             const typeName = node.name.value;
             if (!reachableTypes.has(typeName)) {
                 context.report({
-                    node,
+                    loc: getLocation(node.name.loc, typeName, { offsetStart: node.kind === graphql.Kind.DIRECTIVE_DEFINITION ? 2 : 1 }),
                     messageId: UNREACHABLE_TYPE,
                     data: { typeName },
                     fix: fixer => fixer.remove(node),
@@ -2253,7 +2260,7 @@ const rule$f = {
                     return;
                 }
                 context.report({
-                    node,
+                    loc: getLocation(node.loc, fieldName),
                     messageId: UNUSED_FIELD,
                     data: { fieldName },
                     fix(fixer) {
@@ -3786,25 +3793,7 @@ class GraphQLRuleTester extends eslint.RuleTester {
         return fs.readFileSync(path.resolve(__dirname, `../tests/mocks/${path$1}`), 'utf-8');
     }
     runGraphQLTests(name, rule, tests) {
-        const ruleTests = eslint.Linter.version.startsWith('8')
-            ? tests
-            : {
-                valid: tests.valid.map(test => {
-                    if (typeof test === 'string') {
-                        return test;
-                    }
-                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-                    const { name, ...testCaseOptions } = test;
-                    return testCaseOptions;
-                }),
-                invalid: tests.invalid.map(test => {
-                    // ESLint 7 throws an error on CI - Unexpected top-level property "name"
-                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-                    const { name, ...testCaseOptions } = test;
-                    return testCaseOptions;
-                }),
-            };
-        super.run(name, rule, ruleTests);
+        super.run(name, rule, tests);
         // Skip snapshot testing if `expect` variable is not defined
         if (typeof expect === 'undefined') {
             return;

package/index.mjs CHANGED Viewed

@@ -606,7 +606,7 @@ const rule = {
             ],
         },
         messages: {
-            [ALPHABETIZE]: '"{{ currName }}" should be before "{{ prevName }}"',
+            [ALPHABETIZE]: '"{{ currName }}" should be before "{{ prevName }}".',
         },
         schema: {
             type: 'array',
@@ -663,9 +663,16 @@ const rule = {
             for (const node of nodes) {
                 const currName = node.name.value;
                 if (prevName && prevName > currName) {
+                    const { start, end } = node.name.loc;
                     const isVariableNode = node.kind === Kind.VARIABLE;
                     context.report({
-                        loc: getLocation(node.loc, node.name.value, { offsetEnd: isVariableNode ? 0 : 1 }),
+                        loc: {
+                            start: {
+                                line: start.line,
+                                column: start.column - (isVariableNode ? 2 : 1),
+                            },
+                            end,
+                        },
                         messageId: ALPHABETIZE,
                         data: isVariableNode
                             ? {
@@ -2149,7 +2156,7 @@ const rule$e = {
             const typeName = node.name.value;
             if (!reachableTypes.has(typeName)) {
                 context.report({
-                    node,
+                    loc: getLocation(node.name.loc, typeName, { offsetStart: node.kind === Kind.DIRECTIVE_DEFINITION ? 2 : 1 }),
                     messageId: UNREACHABLE_TYPE,
                     data: { typeName },
                     fix: fixer => fixer.remove(node),
@@ -2247,7 +2254,7 @@ const rule$f = {
                     return;
                 }
                 context.report({
-                    node,
+                    loc: getLocation(node.loc, fieldName),
                     messageId: UNUSED_FIELD,
                     data: { fieldName },
                     fix(fixer) {
@@ -3780,25 +3787,7 @@ class GraphQLRuleTester extends RuleTester {
         return readFileSync(resolve(__dirname, `../tests/mocks/${path}`), 'utf-8');
     }
     runGraphQLTests(name, rule, tests) {
-        const ruleTests = Linter.version.startsWith('8')
-            ? tests
-            : {
-                valid: tests.valid.map(test => {
-                    if (typeof test === 'string') {
-                        return test;
-                    }
-                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-                    const { name, ...testCaseOptions } = test;
-                    return testCaseOptions;
-                }),
-                invalid: tests.invalid.map(test => {
-                    // ESLint 7 throws an error on CI - Unexpected top-level property "name"
-                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-                    const { name, ...testCaseOptions } = test;
-                    return testCaseOptions;
-                }),
-            };
-        super.run(name, rule, ruleTests);
+        super.run(name, rule, tests);
         // Skip snapshot testing if `expect` variable is not defined
         if (typeof expect === 'undefined') {
             return;

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@graphql-eslint/eslint-plugin",
-  "version": "2.3.2-alpha-6c4312e.0",
+  "version": "2.3.2-alpha-da2ba63.0",
   "sideEffects": false,
   "peerDependencies": {
     "graphql": "^0.8.0 || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0"

package/testkit.d.ts CHANGED Viewed

@@ -6,7 +6,6 @@ export declare type GraphQLESLintRuleListener<WithTypeInfo extends boolean = fal
     [K in keyof ASTKindToNode]?: (node: GraphQLESTreeNode<ASTKindToNode[K], WithTypeInfo>) => void;
 } & Record<string, any>;
 export declare type GraphQLValidTestCase<Options> = Omit<RuleTester.ValidTestCase, 'options' | 'parserOptions'> & {
-    name: string;
     options?: Options;
     parserOptions?: ParserOptions;
 };