@graphql-codegen/visitor-plugin-common 5.7.0 → 5.7.1-alpha-20250221120941-a01a9a425c7b5284592b7e1cfdf2cb663fa9e736

package/cjs/selection-set-to-object.js

@@ -359,6 +359,7 @@ class SelectionSetToObject {
         selectionNodes = [...selectionNodes];
         let inlineFragmentConditional = false;
         for (const selectionNode of selectionNodes) {
+            // 1. Handle Field or Directtives selection nodes
             if ('kind' in selectionNode) {
                 if (selectionNode.kind === 'Field') {
                     if (selectionNode.selectionSet) {
@@ -410,15 +411,21 @@ class SelectionSetToObject {
                 }
                 continue;
             }
+            // 2. Handle Fragment selection nodes
+            // 2a. If `inlineFragmentTypes` is 'combine' or 'mask', the fragment is masked i.e. do not generate inline types
+            // In some cases like Apollo `@unmask`, the fragment would be generated inline.
             if (this._config.inlineFragmentTypes === 'combine' || this._config.inlineFragmentTypes === 'mask') {
-                fragmentsSpreadUsages.push(selectionNode.typeName);
-                const isApolloUnmaskEnabled = this._config.customDirectives.apolloUnmask;
-                if (!isApolloUnmaskEnabled ||
-                    (isApolloUnmaskEnabled && !selectionNode.fragmentDirectives?.some(d => d.name.value === 'unmask'))) {
+                let isMasked = true;
+                if (this._config.customDirectives.apolloUnmask &&
+                    selectionNode.fragmentDirectives.some(d => d.name.value === 'unmask')) {
+                    isMasked = false;
+                }
+                if (isMasked) {
+                    fragmentsSpreadUsages.push(selectionNode.typeName);
                     continue;
                 }
             }
-            // Handle Fragment Spreads by generating inline types.
+            // 2b. If the Fragment is not masked, handle Fragment Spreads by generating inline types.
             const fragmentType = this._schema.getType(selectionNode.onType);
             if (fragmentType == null) {
                 throw new TypeError(`Unexpected error: Type ${selectionNode.onType} does not exist within schema.`);

package/esm/selection-set-to-object.js

@@ -355,6 +355,7 @@ export class SelectionSetToObject {
         selectionNodes = [...selectionNodes];
         let inlineFragmentConditional = false;
         for (const selectionNode of selectionNodes) {
+            // 1. Handle Field or Directtives selection nodes
             if ('kind' in selectionNode) {
                 if (selectionNode.kind === 'Field') {
                     if (selectionNode.selectionSet) {
@@ -406,15 +407,21 @@ export class SelectionSetToObject {
                 }
                 continue;
             }
+            // 2. Handle Fragment selection nodes
+            // 2a. If `inlineFragmentTypes` is 'combine' or 'mask', the fragment is masked i.e. do not generate inline types
+            // In some cases like Apollo `@unmask`, the fragment would be generated inline.
             if (this._config.inlineFragmentTypes === 'combine' || this._config.inlineFragmentTypes === 'mask') {
-                fragmentsSpreadUsages.push(selectionNode.typeName);
-                const isApolloUnmaskEnabled = this._config.customDirectives.apolloUnmask;
-                if (!isApolloUnmaskEnabled ||
-                    (isApolloUnmaskEnabled && !selectionNode.fragmentDirectives?.some(d => d.name.value === 'unmask'))) {
+                let isMasked = true;
+                if (this._config.customDirectives.apolloUnmask &&
+                    selectionNode.fragmentDirectives.some(d => d.name.value === 'unmask')) {
+                    isMasked = false;
+                }
+                if (isMasked) {
+                    fragmentsSpreadUsages.push(selectionNode.typeName);
                     continue;
                 }
             }
-            // Handle Fragment Spreads by generating inline types.
+            // 2b. If the Fragment is not masked, handle Fragment Spreads by generating inline types.
             const fragmentType = this._schema.getType(selectionNode.onType);
             if (fragmentType == null) {
                 throw new TypeError(`Unexpected error: Type ${selectionNode.onType} does not exist within schema.`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@graphql-codegen/visitor-plugin-common",
-  "version": "5.7.0",
+  "version": "5.7.1-alpha-20250221120941-a01a9a425c7b5284592b7e1cfdf2cb663fa9e736",
   "peerDependencies": {
     "graphql": "^0.8.0 || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0 || ^16.0.0"
   },