@graphql-box/connection-resolver 4.1.4 → 5.0.1

package/package.json

@@ -1,52 +1,70 @@
 {
   "name": "@graphql-box/connection-resolver",
-  "version": "4.1.4",
-  "description": "The GraphQL Box connection manager module.",
-  "keywords": [
-    "graphql-box",
-    "graphql",
-    "client",
-    "server",
-    "isomorphic"
-  ],
+  "description": "The GraphQL Box connection resolver module.",
+  "version": "5.0.1",
+  "author": "Dylan Aubrey",
+  "license": "MIT",
   "homepage": "https://github.com/badbatch/graphql-box",
-  "bugs": {
-    "url": "https://github.com/badbatch/graphql-box/issues"
-  },
   "repository": {
+    "directory": "packages/connection-resolver",
     "type": "git",
-    "url": "https://github.com/badbatch/graphql-box",
-    "directory": "packages/connection-resolver"
+    "url": "https://github.com/badbatch/graphql-box"
+  },
+  "bugs": "https://github.com/badbatch/graphql-box/issues",
+  "type": "module",
+  "main": "./dist/cjs/index.cjs",
+  "module": "./dist/esm/index.mjs",
+  "types": "./dist/types/cjs/index.d.cts",
+  "exports": {
+    ".": {
+      "types": {
+        "import": "./dist/types/esm/index.d.ts",
+        "require": "./dist/types/cjs/index.d.cts"
+      },
+      "import": "./dist/esm/index.mjs",
+      "require": "./dist/cjs/index.cjs"
+    }
   },
   "publishConfig": {
     "access": "public"
   },
-  "license": "MIT",
-  "author": "Dylan Aubrey <dylanaubrey@gmail.com>",
-  "main": "lib/main/index.js",
-  "module": "lib/module/index.mjs",
-  "browser": "lib/browser/index.js",
-  "types": "lib/types/index.d.ts",
-  "scripts": {
-    "compile": "concurrently npm:compile:*",
-    "compile-watch": "concurrently npm:compile-watch:*",
-    "compile-watch:main": "yarn run compile:main --watch",
-    "compile-watch:types": "yarn run compile:types --watch",
-    "compile:browser": "cross-env BABEL_ENV=browser rollup -c ../../rollup.config.js",
-    "compile:main": "cross-env BABEL_ENV=main babel ./src --out-dir ./lib/main --extensions \".ts\" --source-maps --config-file ../../babel.config.js",
-    "compile:module": "cross-env BABEL_ENV=module babel ./src --out-dir ./lib/module --extensions \".ts\" --out-file-extension \".mjs\" --source-maps --config-file ../../babel.config.js",
-    "compile:types": "tsc --build",
-    "docs": "typedoc --includes ./src/main --out ./docs --options ../../typedoc.js"
-  },
   "dependencies": {
-    "js-base64": "3.6.0",
-    "type-fest": "^1.1.1"
+    "@cachemap/core": "^5.0.8",
+    "js-base64": "^3.7.5",
+    "type-fest": "^4.5.0",
+    "@graphql-box/core": "5.0.1"
   },
   "peerDependencies": {
-    "@babel/runtime": "< 8",
-    "@graphql-box/core": "< 5",
-    "core-js": "< 4",
-    "graphql": "< 17",
-    "lodash": "< 5"
+    "@babel/runtime": "<8",
+    "core-js": "<4",
+    "graphql": "<17",
+    "lodash-es": "<5"
+  },
+  "devDependencies": {
+    "@babel/runtime": "^7.20.13",
+    "@cachemap/map": "^5.0.6",
+    "@jest/globals": "^29.3.1",
+    "@types/lodash-es": "^4.14.191",
+    "core-js": "^3.27.2",
+    "cts-types": "^0.0.6",
+    "del-cli": "^5.1.0",
+    "graphql": "^16.8.1",
+    "lodash-es": "^4.17.21"
+  },
+  "keywords": [
+    "client",
+    "graphql",
+    "graphql-box",
+    "isomorphic",
+    "server"
+  ],
+  "scripts": {
+    "build": "pnpm run clean:dist && pnpm run compile",
+    "clean:deps": "del-cli ./node_modules",
+    "clean:dist": "del-cli ./dist",
+    "compile": "pnpm run /^compile:.*/",
+    "compile:cjs": "MODULE_SYSTEM=cjs rollup -c ../../rollup.config.cjs",
+    "compile:esm": "rollup -c ../../rollup.config.cjs",
+    "compile:types": "tsc --project ./tsconfig.build.json && cts-types build dist/types/esm dist/types/cjs"
   }
 }

package/src/__testUtils__/generateCursorCache.ts

@@ -1,8 +1,8 @@
-import Cachemap from "@cachemap/core";
-import map from "@cachemap/map";
-import { encode } from "js-base64";
-import cacheCursors from "../helpers/cacheCursors";
-import generatePages from "./generatePages";
+import { Core } from '@cachemap/core';
+import { init as map } from '@cachemap/map';
+import { encode } from 'js-base64';
+import { cacheCursors } from '../helpers/cacheCursors.ts';
+import { generatePages } from './generatePages.ts';
 
 export type Params = {
   group: string;
@@ -12,16 +12,22 @@ export type Params = {
   totalResults: number;
 };
 
-export default async ({ group, pageRanges = [], resultsPerPage, totalPages, totalResults }: Params) => {
-  const cursorCache = new Cachemap({
-    name: "cursorCache",
+export const generateCursorCache = async ({
+  group,
+  pageRanges = [],
+  resultsPerPage,
+  totalPages,
+  totalResults,
+}: Params) => {
+  const cursorCache = new Core({
+    name: 'cursorCache',
     store: map(),
-    type: "someType",
+    type: 'someType',
   });
 
-  const headers = new Headers({ "Cache-Control": "max-age=60" });
+  const headers = new Headers({ 'Cache-Control': 'max-age=60' });
 
-  if (pageRanges.length && resultsPerPage) {
+  if (pageRanges.length > 0 && resultsPerPage) {
     const pages = generatePages(pageRanges);
 
     await Promise.all(
@@ -36,19 +42,19 @@ export default async ({ group, pageRanges = [], resultsPerPage, totalPages, tota
           resultsOnCurrentPage = resultsPerPage;
         }
 
-        const edges = Array.from({ length: resultsOnCurrentPage }, (_v, i) => i).map(index => {
+        const edges = Array.from({ length: resultsOnCurrentPage }, (_v, index) => index).map(index => {
           const id = encode(`${index}::${page}`);
           return { cursor: `${id}::${group}`, node: { id } };
         });
 
         await cacheCursors(cursorCache, { edges, group, headers, page, totalPages, totalResults });
-      }),
+      })
     );
   } else {
     await cursorCache.set(
       `${group}-metadata`,
       { totalPages, totalResults },
-      { cacheHeaders: { cacheControl: headers.get("cache-control") ?? undefined } },
+      { cacheHeaders: { cacheControl: headers.get('cache-control') ?? undefined } }
     );
   }
 

package/src/__testUtils__/generatePageResponse.ts

@@ -1,4 +1,6 @@
-import { encode } from "js-base64";
+import type { PlainObject } from '@graphql-box/core';
+import { encode } from 'js-base64';
+import type { ResourceResponse } from '../types.ts';
 
 export type Params = {
   resultsPerPage: number;
@@ -6,14 +8,17 @@ export type Params = {
   totalResults: number;
 };
 
-export default ({ resultsPerPage, totalPages, totalResults }: Params) => (page: number) => ({
-  data: {
-    page,
-    results: Array.from({ length: resultsPerPage }, (_v, i) => i).map(index => {
-      return { id: encode(`${index}::${page}`) };
-    }),
-    totalPages,
-    totalResults,
-  },
-  headers: new Headers({ "Cache-Control": "max-age=60" }),
-});
+export const generatePageResponse =
+  ({ resultsPerPage, totalPages, totalResults }: Params) =>
+  (page: number) =>
+    Promise.resolve({
+      data: {
+        page,
+        results: Array.from({ length: resultsPerPage }, (_v, index) => index).map(index => {
+          return { id: encode(`${index}::${page}`) };
+        }),
+        totalPages,
+        totalResults,
+      },
+      headers: new Headers({ 'Cache-Control': 'max-age=60' }),
+    }) as unknown as Promise<ResourceResponse<PlainObject>>;

package/src/__testUtils__/generatePages.ts

@@ -1,12 +1,12 @@
-import { range } from "lodash";
+import { range } from 'lodash-es';
 
-export default (pageRanges: string[]) =>
-  pageRanges.reduce((pages, pageRange) => {
-    const [start, end] = pageRange.split("-");
+export const generatePages = (pageRanges: string[]) =>
+  pageRanges.reduce<number[]>((pages, pageRange) => {
+    const [start, end] = pageRange.split('-');
 
     if (!end) {
       return [...pages, Number(start)];
     }
 
     return [...pages, ...range(Number(start), Number(end)), Number(end)];
-  }, [] as number[]);
+  }, []);

package/src/helpers/cacheCursors.ts

@@ -1,5 +1,5 @@
-import Cachemap from "@cachemap/core";
-import { Edge } from "../defs";
+import { type Core } from '@cachemap/core';
+import { type Edge } from '../types.ts';
 
 export type Params = {
   edges: Edge[];
@@ -10,13 +10,16 @@ export type Params = {
   totalResults: number;
 };
 
-export default async (cursorCache: Cachemap, { edges, group, headers, page, totalPages, totalResults }: Params) => {
-  const cacheControl = headers.get("cache-control");
-  const opts = cacheControl ? { cacheHeaders: { cacheControl } } : undefined;
+export const cacheCursors = async (
+  cursorCache: Core,
+  { edges, group, headers, page, totalPages, totalResults }: Params
+) => {
+  const cacheControl = headers.get('cache-control');
+  const options = cacheControl ? { cacheHeaders: { cacheControl } } : undefined;
 
   await Promise.all(
-    edges.map(async ({ cursor, node }, index) => cursorCache.set(cursor, { node, index, group, page }, opts)),
+    edges.map(async ({ cursor, node }, index) => cursorCache.set(cursor, { group, index, node, page }, options))
   );
 
-  await cursorCache.set(`${group}-metadata`, { totalPages, totalResults }, opts);
+  await cursorCache.set(`${group}-metadata`, { totalPages, totalResults }, options);
 };

package/src/helpers/extractEdges.ts

@@ -1,4 +1,4 @@
-import { CachedEdges, Edge } from "../defs";
+import { type CachedEdges, type Edge } from '../types.ts';
 
-export default (cachedEdges: CachedEdges[]) =>
-  cachedEdges.reduce((edges, cachedEdge) => [...edges, ...cachedEdge.edges], [] as Edge[]);
+export const extractEdges = (cachedEdges: CachedEdges[]) =>
+  cachedEdges.reduce<Edge[]>((edges, cachedEdge) => [...edges, ...cachedEdge.edges], []);

package/src/helpers/extractNodes.ts

@@ -1,3 +1,3 @@
-import { Edge } from "../defs";
+import { type Edge } from '../types.ts';
 
-export default (edges: Edge[]) => edges.map(edge => edge.node);
+export const extractNodes = (edges: Edge[]) => edges.map(edge => edge.node);

package/src/helpers/getCount.test.ts

@@ -1,11 +1,15 @@
-import getCount from "./getCount";
+import { getCount } from './getCount.ts';
 
-describe("getCount", () => {
-  test("when `first` is provided", () => {
-    expect(getCount({ first: 5 })).toBe(5);
+describe('getCount', () => {
+  describe('when `first` is provided', () => {
+    it('should return the correct value', () => {
+      expect(getCount({ first: 5 })).toBe(5);
+    });
   });
 
-  test("when `last` is provided", () => {
-    expect(getCount({ last: 5 })).toBe(5);
+  describe('when `last` is provided', () => {
+    it('should return the correct value', () => {
+      expect(getCount({ last: 5 })).toBe(5);
+    });
   });
 });

package/src/helpers/getCount.ts

@@ -1,3 +1,3 @@
-import { ConnectionInputOptions } from "../defs";
+import { type ConnectionInputOptions } from '../types.ts';
 
-export default ({ first, last }: ConnectionInputOptions) => (first || last) as number;
+export const getCount = ({ first, last }: ConnectionInputOptions) => first ?? last!;

package/src/helpers/getCurrentPageStartAndEndIndexes.ts

@@ -1,4 +1,4 @@
-import { Indexes } from "../defs";
+import { type Indexes } from '../types.ts';
 
 export type StartIndexContext = {
   pageIndex: number;

package/src/helpers/getCursor.test.ts

@@ -1,11 +1,15 @@
-import getCursor from "./getCursor";
+import { getCursor } from './getCursor.ts';
 
-describe("getCursor", () => {
-  test("when `before` is provided", () => {
-    expect(getCursor({ before: "abcdefg" })).toBe("abcdefg");
+describe('getCursor', () => {
+  describe('when `before` is provided', () => {
+    it('should return the correct value', () => {
+      expect(getCursor({ before: 'abcdefg' })).toBe('abcdefg');
+    });
   });
 
-  test("when `after` is provided", () => {
-    expect(getCursor({ after: "abcdefg" })).toBe("abcdefg");
+  describe('when `after` is provided', () => {
+    it('should return the correct value', () => {
+      expect(getCursor({ after: 'abcdefg' })).toBe('abcdefg');
+    });
   });
 });

package/src/helpers/getCursor.ts

@@ -1,3 +1,3 @@
-import { ConnectionInputOptions } from "../defs";
+import { type ConnectionInputOptions } from '../types.ts';
 
-export default ({ after, before }: ConnectionInputOptions) => before || after;
+export const getCursor = ({ after, before }: ConnectionInputOptions) => before ?? after;

package/src/helpers/getDirection.test.ts

@@ -1,11 +1,15 @@
-import getDirection from "./getDirection";
+import { getDirection } from './getDirection.ts';
 
-describe("getDirection", () => {
-  test("when last is provided", () => {
-    expect(getDirection(5)).toBe("backward");
+describe('getDirection', () => {
+  describe('when last is provided', () => {
+    it('should return "backward"', () => {
+      expect(getDirection(5)).toBe('backward');
+    });
   });
 
-  test("when last is NOT provided", () => {
-    expect(getDirection(undefined)).toBe("forward");
+  describe('when last is NOT provided', () => {
+    it('should return "forward"', () => {
+      expect(getDirection()).toBe('forward');
+    });
   });
 });

package/src/helpers/getDirection.ts

@@ -1 +1,3 @@
-export default (last: number | undefined) => (last ? "backward" : "forward");
+import type { Direction } from '../types.ts';
+
+export const getDirection = (last?: number): Direction => (last ? 'backward' : 'forward');

package/src/helpers/getInRangeCachedEdges.ts

@@ -1,5 +1,5 @@
-import { CachedEdges, Indexes } from "../defs";
-import { getCurrentPageEndIndex, getCurrentPageStartIndex } from "./getCurrentPageStartAndEndIndexes";
+import { type CachedEdges, type Indexes } from '../types.ts';
+import { getCurrentPageEndIndex, getCurrentPageStartIndex } from './getCurrentPageStartAndEndIndexes.ts';
 
 export type Context = {
   endIndex: Indexes;
@@ -7,13 +7,16 @@ export type Context = {
   startIndex: Indexes;
 };
 
-export default (cachedEdgesByPage: CachedEdges[], { endIndex, resultsPerPage, startIndex }: Context) => {
-  return cachedEdgesByPage.reduce((inRange, cachedEdgesPage, i) => {
-    const currentPageStartIndex = getCurrentPageStartIndex({ startIndex, pageIndex: i });
+export const getInRangeCachedEdges = (
+  cachedEdgesByPage: CachedEdges[],
+  { endIndex, resultsPerPage, startIndex }: Context
+) => {
+  return cachedEdgesByPage.reduce<CachedEdges[]>((inRange, cachedEdgesPage, index) => {
+    const currentPageStartIndex = getCurrentPageStartIndex({ pageIndex: index, startIndex });
 
     const currentPageEndIndex = getCurrentPageEndIndex({
       endIndex,
-      pageIndex: i,
+      pageIndex: index,
       resultsPerPage,
       totalCachedPages: cachedEdgesByPage.length,
     });
@@ -21,5 +24,5 @@ export default (cachedEdgesByPage: CachedEdges[], { endIndex, resultsPerPage, st
     const cachedEdges = cachedEdgesPage.edges.slice(currentPageStartIndex, currentPageEndIndex + 1);
     inRange.push({ edges: cachedEdges, pageNumber: cachedEdgesPage.pageNumber });
     return inRange;
-  }, [] as CachedEdges[]);
+  }, []);
 };

package/src/helpers/getIndexesOnCurrentPage.test.ts

@@ -1,15 +1,19 @@
-import getIndexesOnCurrentPage from "./getIndexesOnCurrentPage";
+import { getIndexesOnCurrentPage } from './getIndexesOnCurrentPage.ts';
 
-describe("getIndexesOnCurrentPage", () => {
-  test("when current page is last page", () => {
-    expect(
-      getIndexesOnCurrentPage({ metadata: { totalPages: 6, totalResults: 53 }, page: 6, resultsPerPage: 10 }),
-    ).toBe(2);
+describe('getIndexesOnCurrentPage', () => {
+  describe('when current page is last page', () => {
+    it('should return the correct value', () => {
+      expect(
+        getIndexesOnCurrentPage({ metadata: { totalPages: 6, totalResults: 53 }, page: 6, resultsPerPage: 10 })
+      ).toBe(2);
+    });
   });
 
-  test("when current page is NOT last page", () => {
-    expect(
-      getIndexesOnCurrentPage({ metadata: { totalPages: 6, totalResults: 53 }, page: 5, resultsPerPage: 10 }),
-    ).toBe(9);
+  describe('when current page is NOT last page', () => {
+    it('should return the correct value', () => {
+      expect(
+        getIndexesOnCurrentPage({ metadata: { totalPages: 6, totalResults: 53 }, page: 5, resultsPerPage: 10 })
+      ).toBe(9);
+    });
   });
 });

package/src/helpers/getIndexesOnCurrentPage.ts

@@ -1,14 +1,19 @@
-import { Context } from "../defs";
-import getResultsOnLastPage from "./getResultsOnLastPage";
-import isLastPage from "./isLastPage";
+import type { CursorGroupMetadata } from '../types.ts';
+import { getResultsOnLastPage } from './getResultsOnLastPage.ts';
+import { isLastPage } from './isLastPage.ts';
 
 export type IndexesOnCurrentPageContext = {
   page: number;
 };
 
-export default ({
-  page,
+export type Context = {
+  metadata: CursorGroupMetadata;
+  resultsPerPage: number;
+};
+
+export const getIndexesOnCurrentPage = ({
   metadata: { totalPages, totalResults },
+  page,
   resultsPerPage,
-}: IndexesOnCurrentPageContext & Omit<Context, "entry">) =>
+}: IndexesOnCurrentPageContext & Context) =>
   (isLastPage({ page, totalPages }) ? getResultsOnLastPage({ resultsPerPage, totalResults }) : resultsPerPage) - 1;

package/src/helpers/getIndexesOnLastPage.test.ts

@@ -1,11 +1,15 @@
-import getIndexesOnLastPage from "./getIndexesOnLastPage";
+import { getIndexesOnLastPage } from './getIndexesOnLastPage.ts';
 
-describe("getIndexesOnLastPage", () => {
-  test("when results on last page equal results per page", () => {
-    expect(getIndexesOnLastPage({ resultsPerPage: 10, totalResults: 50 })).toBe(9);
+describe('getIndexesOnLastPage', () => {
+  describe('when results on last page equal results per page', () => {
+    it('should return the correct value', () => {
+      expect(getIndexesOnLastPage({ resultsPerPage: 10, totalResults: 50 })).toBe(9);
+    });
   });
 
-  test("when results on last page do NOT equal results per page", () => {
-    expect(getIndexesOnLastPage({ resultsPerPage: 10, totalResults: 53 })).toBe(2);
+  describe('when results on last page do NOT equal results per page', () => {
+    it('should return the correct value', () => {
+      expect(getIndexesOnLastPage({ resultsPerPage: 10, totalResults: 53 })).toBe(2);
+    });
   });
 });

package/src/helpers/getIndexesOnLastPage.ts

@@ -1,3 +1,4 @@
-import getResultsOnLastPage, { Params } from "./getResultsOnLastPage";
+import { type Params, getResultsOnLastPage } from './getResultsOnLastPage.ts';
 
-export default ({ resultsPerPage, totalResults }: Params) => getResultsOnLastPage({ resultsPerPage, totalResults }) - 1;
+export const getIndexesOnLastPage = ({ resultsPerPage, totalResults }: Params) =>
+  getResultsOnLastPage({ resultsPerPage, totalResults }) - 1;

package/src/helpers/getPageNumbersToRequest.test.ts

@@ -1,17 +1,17 @@
-import getPageNumbersToRequest from "./getPageNumbersToRequest";
+import { getPageNumbersToRequest } from './getPageNumbersToRequest.ts';
 
-describe("getPageNumbersToRequest", () => {
-  test("when direction is forward", () => {
+describe('getPageNumbersToRequest', () => {
+  describe('when direction is forward', () => {
     const args = {
-      after: "abcdefg",
+      after: 'abcdefg',
     };
 
     const ctx = {
       endIndex: { absolute: 22, relative: 5 },
       entry: {
-        group: "group",
+        group: 'group',
         index: 2,
-        node: { id: "123" },
+        node: { id: '123' },
         page: 2,
       },
       metadata: {
@@ -22,10 +22,12 @@ describe("getPageNumbersToRequest", () => {
       startIndex: { absolute: 3, relative: 3 },
     };
 
-    expect(getPageNumbersToRequest(args, ctx)).toEqual([2, 3, 4]);
+    it('should return the correct value', () => {
+      expect(getPageNumbersToRequest(args, ctx)).toEqual([2, 3, 4]);
+    });
   });
 
-  test("when direction is backward", () => {
+  describe('when direction is backward', () => {
     const args = {
       last: 5,
     };
@@ -33,9 +35,9 @@ describe("getPageNumbersToRequest", () => {
     const ctx = {
       endIndex: { absolute: 4, relative: 4 },
       entry: {
-        group: "group",
+        group: 'group',
         index: 3,
-        node: { id: "123" },
+        node: { id: '123' },
         page: 4,
       },
       metadata: {
@@ -47,6 +49,8 @@ describe("getPageNumbersToRequest", () => {
       startIndex: { absolute: -5, relative: 6 },
     };
 
-    expect(getPageNumbersToRequest(args, ctx)).toEqual([3, 4]);
+    it('should return the correct value', () => {
+      expect(getPageNumbersToRequest(args, ctx)).toEqual([3, 4]);
+    });
   });
 });

package/src/helpers/getPageNumbersToRequest.ts

@@ -1,17 +1,28 @@
-import { range } from "lodash";
-import { ConnectionInputOptions, Context, Indexes } from "../defs";
-import { getEndPageNumber, getStartPageNumber } from "./getStartAndEndPageNumbers";
+import { range } from 'lodash-es';
+import {
+  type ConnectionInputOptions,
+  type CursorGroupMetadata,
+  type Indexes,
+  type PartialCursorCacheEntry,
+} from '../types.ts';
+import { getEndPageNumber, getStartPageNumber } from './getStartAndEndPageNumbers.ts';
 
 export type GetPageNumbersToRequestContext = {
   endIndex: Indexes;
   startIndex: Indexes;
 };
 
-export default (
+export type Context = {
+  entry: PartialCursorCacheEntry;
+  metadata: CursorGroupMetadata;
+  resultsPerPage: number;
+};
+
+export const getPageNumbersToRequest = (
   args: ConnectionInputOptions,
-  { endIndex, entry: { page }, metadata, resultsPerPage, startIndex }: GetPageNumbersToRequestContext & Context,
+  { endIndex, entry: { page }, metadata, resultsPerPage, startIndex }: GetPageNumbersToRequestContext & Context
 ) => {
-  const startPageNumber = getStartPageNumber(args, { page, startIndex, resultsPerPage });
+  const startPageNumber = getStartPageNumber(args, { page, resultsPerPage, startIndex });
   const endPageNumber = getEndPageNumber(args, { endIndex, metadata, page, resultsPerPage });
 
   if (startPageNumber === endPageNumber) {

package/src/helpers/getPagesMissingFromCache.ts

@@ -1,11 +1,11 @@
-import { CachedEdges } from "../defs";
+import { type CachedEdges } from '../types.ts';
 
-export default (cachedEdgesByPage: CachedEdges[]) => {
-  return cachedEdgesByPage.reduce((missing, cachedEdgesPage) => {
-    if (!cachedEdgesPage.edges.length) {
+export const getPagesMissingFromCache = (cachedEdgesByPage: CachedEdges[]) => {
+  return cachedEdgesByPage.reduce<number[]>((missing, cachedEdgesPage) => {
+    if (cachedEdgesPage.edges.length === 0) {
       missing.push(cachedEdgesPage.pageNumber);
     }
 
     return missing;
-  }, [] as number[]);
+  }, []);
 };

package/src/helpers/getResultsOnLastPage.test.ts

@@ -1,11 +1,15 @@
-import getResultsOnLastPage from "./getResultsOnLastPage";
+import { getResultsOnLastPage } from './getResultsOnLastPage.ts';
 
-describe("getResultsOnLastPage", () => {
-  test("when results on last page equal results per page", () => {
-    expect(getResultsOnLastPage({ resultsPerPage: 10, totalResults: 50 })).toBe(10);
+describe('getResultsOnLastPage', () => {
+  describe('when results on last page equal results per page', () => {
+    it('should return the correct value', () => {
+      expect(getResultsOnLastPage({ resultsPerPage: 10, totalResults: 50 })).toBe(10);
+    });
   });
 
-  test("when results on last page do NOT equal results per page", () => {
-    expect(getResultsOnLastPage({ resultsPerPage: 10, totalResults: 53 })).toBe(3);
+  describe('when results on last page do NOT equal results per page', () => {
+    it('should return the correct value', () => {
+      expect(getResultsOnLastPage({ resultsPerPage: 10, totalResults: 53 })).toBe(3);
+    });
   });
 });