@graphql-box/cache-manager 3.4.1 → 3.4.3

package/src/index.test.ts

@@ -1200,6 +1200,60 @@ describe("@graphql-box/cache-manager >>", () => {
         });
       });
 
+      describe("single type with just ID match >>", () => {
+        beforeAll(async () => {
+          analyzeQueryResult = undefined;
+          // @ts-ignore
+          jest.spyOn(CacheManager, "_isValid").mockReturnValue(true);
+
+          cacheManager = new CacheManager({
+            cache: new Cachemap({
+              name: "cachemap",
+              store: map(),
+              type: "someType",
+            }),
+            typeCacheDirectives: {
+              Organization: "public, max-age=1",
+            },
+            typeIDKey: DEFAULT_TYPE_ID_KEY,
+          });
+
+          const requestData = getRequestData(parsedRequests.singleTypeQuerySmallA);
+
+          await cacheManager.cacheQuery(
+            requestData,
+            requestData,
+            responses.singleTypeQuerySmallA,
+            { awaitDataCaching: true },
+            getRequestContext({ fieldTypeMap: requestFieldTypeMaps.singleTypeQuery }),
+          );
+
+          analyzeQueryResult = await cacheManager.analyzeQuery(
+            getRequestData(parsedRequests.singleTypeQuerySmallB),
+            { awaitDataCaching: true },
+            getRequestContext({ fieldTypeMap: requestFieldTypeMaps.singleTypeQuery }),
+          );
+        });
+
+        it("correct request data", () => {
+          const { ast, ...otherProps } = analyzeQueryResult?.updated as RequestData;
+          expect(otherProps).toMatchSnapshot();
+        });
+
+        it("no response data", () => {
+          expect(analyzeQueryResult?.response).toBeUndefined();
+        });
+
+        it("correct cache data", async () => {
+          expect(await cacheManager.cache.export()).toMatchSnapshot();
+        });
+
+        it("correct partial data", () => {
+          // @ts-ignore
+          expect(cacheManager._partialQueryResponses).toMatchSnapshot();
+        });
+      });
+
       describe("nested type with edges >", () => {
         beforeAll(async () => {
           analyzeQueryResult = undefined;

package/src/main/index.ts

@@ -59,6 +59,7 @@ import {
   TypeNamesAndKind,
   UserOptions,
 } from "../defs";
+import areOnlyPopulatedFieldsTypeIdKeys from "../helpers/areOnlyPopulatedFieldsTypeIdKeys";
 import deriveOpCacheability from "../helpers/deriveOpCacheability";
 import filterOutPropsWithArgsOrDirectives from "../helpers/filterOutPropsWithArgsOrDirectives";
 import filterQuery from "../helpers/filterQuery";
@@ -260,7 +261,10 @@ export class CacheManager implements CacheManagerDef {
     const cachedResponseData = await this._retrieveCachedResponseData(requestData, options, cacheManagerContext);
     const { cacheMetadata, data, fieldCount } = cachedResponseData;
 
-    if (fieldCount.missing === fieldCount.total) {
+    // Second half of check is required for the scenario where the only matching data is
+    // the typeIDKey field, i.e. "id", in which case there is no point settings a partial
+    // query reponse because we request the typeIDKey field with every request.
+    if (fieldCount.missing === fieldCount.total || areOnlyPopulatedFieldsTypeIdKeys(data, this._typeIDKey)) {
       return { updated: requestData };
     }