@graphcommerce/react-hook-form 3.3.2 → 3.3.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Change Log
 
+## 3.3.4
+
+### Patch Changes
+
+- [#1660](https://github.com/graphcommerce-org/graphcommerce/pull/1660) [`75ae24a93`](https://github.com/graphcommerce-org/graphcommerce/commit/75ae24a93bd74e3b9b7efda21ec7ba6fbe9a3a75) Thanks [@paales](https://github.com/paales)! - Remove heuristicEncode for GraphQL input objects provided by react-hook-form
+
+## 3.3.3
+
+### Patch Changes
+
+- [#1629](https://github.com/graphcommerce-org/graphcommerce/pull/1629) [`662f510c2`](https://github.com/graphcommerce-org/graphcommerce/commit/662f510c21fc44a63036e5c7a0726ccb33c31600) Thanks [@paales](https://github.com/paales)! - The submit button would remain in a loading state when all composed forms were invalid
+
 ## 3.3.2
 
 ### Patch Changes

package/package.json

@@ -2,7 +2,7 @@
   "name": "@graphcommerce/react-hook-form",
   "homepage": "https://www.graphcommerce.org/",
   "repository": "github:graphcommerce-org/graphcommerce",
-  "version": "3.3.2",
+  "version": "3.3.4",
   "sideEffects": false,
   "prettier": "@graphcommerce/prettier-config-pwa",
   "eslintConfig": {

package/src/ComposedForm/ComposedSubmit.tsx

@@ -104,7 +104,12 @@ export function ComposedSubmit(props: ComposedSubmitProps) {
           throw e
         }
       }
-      dispatch({ type: 'SUBMITTING' })
+
+      dispatch(
+        invalidKeys.length === 0
+          ? { type: 'SUBMITTING' }
+          : { type: 'SUBMITTED', isSubmitSuccessful: false },
+      )
     } catch (error) {
       dispatch({ type: 'SUBMITTED', isSubmitSuccessful: false })
     }

package/src/useFormGqlMutation.tsx

@@ -26,6 +26,7 @@ export function assertFormGqlOperation<V, Q = Record<string, unknown>>(
   }
 }
 
+/** Bindings between react-hook-form's useForm and Apollo Client's useMutation hook. */
 export function useFormGqlMutation<Q, V>(
   document: TypedDocumentNode<Q, V>,
   options: UseFormGraphQlOptions<Q, V> = {},

package/src/useGqlDocumentHandler.tsx

@@ -1,5 +1,5 @@
 import type { TypedDocumentNode } from '@apollo/client'
-import {
+import type {
   DefinitionNode,
   OperationDefinitionNode,
   ValueNode,
@@ -116,20 +116,8 @@ export function handlerFactory<Q, V>(document: TypedDocumentNode<Q, V>): UseGqlD
   const required = requiredPartial as Required
   const encoding = encodingPartial as Encoding
 
-  function heuristicEncode(val: string) {
-    if (Number(val).toString() === val) return Number(val)
-    if (val === 'true') return true
-    if (val === 'false') return false
-    return val
-  }
-
   function encodeItem(enc: FieldTypes, val: unknown) {
     if (Array.isArray(val)) return val.map((v, i) => encodeItem(enc[i], v))
-    if (val && typeof val === 'object') {
-      return Object.fromEntries(
-        Object.entries(val).map(([key, v]) => [key, heuristicEncode(v as string)]),
-      )
-    }
     if (enc === 'Boolean') return Boolean(val)
     if (enc === 'Float' || enc === 'Int') return Number(val)
     return val