@graphcommerce/magento-cart-payment-method 10.0.0-canary.68 → 10.0.0-canary.72

package/Api/PaymentMethod.ts

@@ -22,7 +22,7 @@ export type PaymentOptionsProps = PaymentMethod & PaymentMethodOptionsProps
 export type PaymentHandlerProps = { code: string }
 
 export type ExpandPaymentMethodsContext = Partial<PaymentMethodContextFragment> & {
-  client: ApolloClient<object>
+  client: ApolloClient
 }
 
 export type ExpandPaymentMethods = (

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Change Log
 
+## 10.0.0-canary.72
+
+## 10.0.0-canary.71
+
+## 10.0.0-canary.70
+
+### Major Changes
+
+- [#2565](https://github.com/graphcommerce-org/graphcommerce/pull/2565) [`c96dfcd`](https://github.com/graphcommerce-org/graphcommerce/commit/c96dfcdca981baca387c270ad9e2b9515cdd00cc) - Updated to Apollo Client 4 ([@paales](https://github.com/paales))
+
+## 10.0.0-canary.69
+
 ## 10.0.0-canary.68
 
 ## 10.0.0-canary.67

package/PaymentMethodPlaceOrderNoop/PaymentMethodPlaceOrderNoop.tsx

@@ -12,7 +12,10 @@ export function PaymentMethodPlaceOrderNoop(props: PaymentPlaceOrderProps) {
   const form = useFormGqlMutationCart(PaymentMethodPlaceOrderNoopDocument, {
     onComplete: async (result) => {
       assertOrderPlaced(result)
-      await onSuccess(result.data.placeOrder.order.order_number)
+      // After assertOrderPlaced, result.data.placeOrder.order.order_number is guaranteed
+      const orderNumber = (result.data as { placeOrder: { order: { order_number: string } } })
+        .placeOrder.order.order_number
+      await onSuccess(orderNumber)
     },
     submitWhileLocked: true,
   })

package/PaymentMethodPlaceOrderNoop/assertOrderPlaced.ts

@@ -1,21 +1,23 @@
-import type { FetchResult } from '@graphcommerce/graphql'
-import { ApolloError } from '@graphcommerce/graphql'
+import type { ApolloLink } from '@graphcommerce/graphql'
+import { CombinedGraphQLErrors } from '@apollo/client/errors'
 import { t } from '@lingui/core/macro'
 import type { PaymentMethodPlaceOrderNoopMutation } from './PaymentMethodPlaceOrderNoop.gql'
 
-export type PlacedOrder<T extends FetchResult<PaymentMethodPlaceOrderNoopMutation>> = NonNullable<
-  NonNullable<NonNullable<T['data']>['placeOrder']>['order']
->
+type PlaceOrderResult = ApolloLink.Result<PaymentMethodPlaceOrderNoopMutation>
 
-export type AssertedOrderPlaced<T extends FetchResult<PaymentMethodPlaceOrderNoopMutation>> = T & {
+export type PlacedOrder = {
+  order_number: string
+}
+
+export type AssertedOrderPlaced = PlaceOrderResult & {
   data: {
-    placeOrder: { order: PlacedOrder<T> }
+    placeOrder: { order: PlacedOrder }
   }
 }
 
-export function throwGenericPlaceOrderError() {
-  throw new ApolloError({
-    graphQLErrors: [
+export function throwGenericPlaceOrderError(): never {
+  throw new CombinedGraphQLErrors({
+    errors: [
       {
         message: t`An error occurred while processing your payment. Please contact the store owner`,
       },
@@ -24,20 +26,26 @@ export function throwGenericPlaceOrderError() {
 }
 
 /** Assert that the order was place successfully. */
-export function assertOrderPlaced<T extends FetchResult<PaymentMethodPlaceOrderNoopMutation>>(
-  result: T,
-): asserts result is AssertedOrderPlaced<T> {
+export function assertOrderPlaced(result: PlaceOrderResult): asserts result is AssertedOrderPlaced {
+  // Check for GraphQL errors in the result
   if (result.errors && result.errors.length > 0) {
-    const graphQLErrors = result.errors.filter((e) => e !== null)
-    throw new ApolloError({ graphQLErrors })
+    throw new CombinedGraphQLErrors(result)
   }
 
-  if (result.data?.placeOrder?.errors && result.data.placeOrder.errors.length > 0) {
-    const graphQLErrors = result.data.placeOrder.errors.filter((e) => e !== null)
-    throw new ApolloError({ graphQLErrors })
+  // Check for place order specific errors
+  const placeOrderData = result.data?.placeOrder as
+    | { errors?: { message: string }[] | null; order?: { order_number?: string } | null }
+    | null
+    | undefined
+
+  if (placeOrderData?.errors && placeOrderData.errors.length > 0) {
+    throw new CombinedGraphQLErrors({
+      errors: placeOrderData.errors.filter((e) => e !== null),
+    })
   }
 
-  if (!result.data?.placeOrder?.order?.order_number) {
+  const orderNumber = placeOrderData?.order?.order_number
+  if (!orderNumber) {
     console.info('Error while placing order', result)
     throwGenericPlaceOrderError()
   }

package/package.json

@@ -2,7 +2,7 @@
   "name": "@graphcommerce/magento-cart-payment-method",
   "homepage": "https://www.graphcommerce.org/",
   "repository": "github:graphcommerce-org/graphcommerce",
-  "version": "10.0.0-canary.68",
+  "version": "10.0.0-canary.72",
   "sideEffects": false,
   "prettier": "@graphcommerce/prettier-config-pwa",
   "eslintConfig": {
@@ -18,18 +18,18 @@
     "./PaymentMethodPlaceOrderNoop/PaymentMethodPlaceOrderNoop": "./PaymentMethodPlaceOrderNoop/PaymentMethodPlaceOrderNoop.tsx"
   },
   "peerDependencies": {
-    "@graphcommerce/ecommerce-ui": "^10.0.0-canary.68",
-    "@graphcommerce/eslint-config-pwa": "^10.0.0-canary.68",
-    "@graphcommerce/framer-scroller": "^10.0.0-canary.68",
-    "@graphcommerce/graphql": "^10.0.0-canary.68",
-    "@graphcommerce/image": "^10.0.0-canary.68",
-    "@graphcommerce/magento-cart": "^10.0.0-canary.68",
-    "@graphcommerce/magento-cart-shipping-address": "^10.0.0-canary.68",
-    "@graphcommerce/magento-store": "^10.0.0-canary.68",
-    "@graphcommerce/next-ui": "^10.0.0-canary.68",
-    "@graphcommerce/prettier-config-pwa": "^10.0.0-canary.68",
-    "@graphcommerce/react-hook-form": "^10.0.0-canary.68",
-    "@graphcommerce/typescript-config-pwa": "^10.0.0-canary.68",
+    "@graphcommerce/ecommerce-ui": "^10.0.0-canary.72",
+    "@graphcommerce/eslint-config-pwa": "^10.0.0-canary.72",
+    "@graphcommerce/framer-scroller": "^10.0.0-canary.72",
+    "@graphcommerce/graphql": "^10.0.0-canary.72",
+    "@graphcommerce/image": "^10.0.0-canary.72",
+    "@graphcommerce/magento-cart": "^10.0.0-canary.72",
+    "@graphcommerce/magento-cart-shipping-address": "^10.0.0-canary.72",
+    "@graphcommerce/magento-store": "^10.0.0-canary.72",
+    "@graphcommerce/next-ui": "^10.0.0-canary.72",
+    "@graphcommerce/prettier-config-pwa": "^10.0.0-canary.72",
+    "@graphcommerce/react-hook-form": "^10.0.0-canary.72",
+    "@graphcommerce/typescript-config-pwa": "^10.0.0-canary.72",
     "@lingui/core": "^5",
     "@lingui/macro": "^5",
     "@lingui/react": "^5",

package/test/goToPayment.ts

@@ -4,10 +4,7 @@ import { fillShippingAddressForm } from '@graphcommerce/magento-cart-shipping-ad
 import { fillCartAgreementsForm } from '@graphcommerce/magento-cart/test/fillCartAgreementsForm'
 import type { Page } from '@playwright/test'
 
-export const goToPayment = async (
-  page: Page,
-  apolloClient: ApolloClient<NormalizedCacheObject>,
-) => {
+export const goToPayment = async (page: Page, apolloClient: ApolloClient) => {
   await page.locator('#view-shopping-cart-button').click()
   await page.locator('#cart-start-checkout').click()