@graphcommerce/graphql-mesh 10.1.0-canary.36 → 10.1.0-canary.38

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+## 10.1.0-canary.38
+
+### Minor Changes
+
+- [#2650](https://github.com/graphcommerce-org/graphcommerce/pull/2650) [`ccd01e9`](https://github.com/graphcommerce-org/graphcommerce/commit/ccd01e9ad061783b354fd8655b5319edb26a15f1) - Route server-side Magento traffic over an internal network with the new runtime-only `GC_MAGENTO_ENDPOINT_SERVER` environment variable (e.g. `http://varnish.magento-namespace.svc.cluster.local`). When set, every mesh request whose URL starts with the origin of `GC_MAGENTO_ENDPOINT` — GraphQL and REST — is rewritten to the internal origin and gains an `X-Forwarded-Proto: https` header, so frontend↔Magento traffic inside a Kubernetes cluster no longer hairpins over the public load balancer. Unset, behavior is unchanged. See the new "Routing Magento traffic over an internal network" section in the mesh docs. ([@paales](https://github.com/paales))
+
+## 10.1.0-canary.37
+
 ## 10.1.0-canary.36
 
 ## 10.1.0-canary.35

package/customFetch.ts

@@ -17,6 +17,45 @@ const fetcher = fetchRetry(
   require('@whatwg-node/fetch').fetch,
 )
 
+/**
+ * Optionally reroute server-side Magento traffic to an internal endpoint.
+ *
+ * When the runtime environment sets `GC_MAGENTO_ENDPOINT_SERVER` (e.g.
+ * `http://varnish.magento-namespace.svc.cluster.local`), every request whose URL starts with the
+ * origin of `GC_MAGENTO_ENDPOINT` is rewritten to that origin. All Magento traffic the mesh
+ * performs (GraphQL and REST) then stays on the internal network — e.g. within a Kubernetes cluster
+ * — instead of hairpinning over the public load balancer, while the public endpoint keeps serving
+ * the browser-facing concerns (media URLs, image optimization).
+ *
+ * - Both variables are read from `process.env` at request time: this module also runs outside the
+ *   Next.js bundler (the mesh CLI imports it during `gc-mesh build`), so it cannot rely on
+ *   build-inlined configuration.
+ * - Set `GC_MAGENTO_ENDPOINT_SERVER` in the runtime environment only (e.g. a Kubernetes ConfigMap),
+ *   never in the build environment: schema introspection and static generation run where the
+ *   internal endpoint is not reachable. Unset, this is a no-op.
+ * - The rewrite adds `X-Forwarded-Proto: https` — the internal path bypasses the TLS-terminating
+ *   proxy that normally adds it, and without it Magento considers the request insecure and
+ *   generates http:// URLs in responses.
+ */
+function toServerEndpoint(
+  url: RequestInfo | URL,
+  options: RequestInitWithRetry | undefined,
+): [RequestInfo | URL, RequestInitWithRetry | undefined] {
+  const serverEndpoint = process.env.GC_MAGENTO_ENDPOINT_SERVER
+  const publicEndpoint = process.env.GC_MAGENTO_ENDPOINT
+  if (!serverEndpoint || !publicEndpoint) return [url, options]
+  if (typeof url !== 'string' && !(url instanceof URL)) return [url, options]
+
+  const publicOrigin = new URL(publicEndpoint).origin
+  const target = url.toString()
+  if (!target.startsWith(publicOrigin)) return [url, options]
+
+  return [
+    new URL(serverEndpoint).origin + target.slice(publicOrigin.length),
+    { ...options, headers: { ...options?.headers, 'x-forwarded-proto': 'https' } },
+  ]
+}
+
 /**
  * @param {RequestInfo | URL} url
  * @param {import('fetch-retry').RequestInitWithRetry | undefined} options
@@ -27,12 +66,14 @@ export const fetch = (
   url: RequestInfo | URL,
   options: RequestInitWithRetry | undefined,
 ): Promise<Response> => {
+  const [serverUrl, serverOptions] = toServerEndpoint(url, options)
+
   const headers = Object.fromEntries(
-    Object.entries(options?.headers ?? {}).filter(([, value]) => value !== ''),
+    Object.entries(serverOptions?.headers ?? {}).filter(([, value]) => value !== ''),
   )
 
-  return fetcher(url, {
-    ...options,
+  return fetcher(serverUrl, {
+    ...serverOptions,
     headers,
     retries: 6,
     retryDelay: (attempt) => 2 ** attempt * 200, // 200, 400, 800, 1600, 3200, 6400

package/package.json

@@ -2,7 +2,7 @@
   "name": "@graphcommerce/graphql-mesh",
   "homepage": "https://www.graphcommerce.org/",
   "repository": "github:graphcommerce-org/graphcommerce",
-  "version": "10.1.0-canary.36",
+  "version": "10.1.0-canary.38",
   "dependencies": {
     "@whatwg-node/fetch": "^0.10.13",
     "fetch-retry": "^5.0.6",
@@ -20,9 +20,9 @@
   },
   "peerDependencies": {
     "@apollo/client": "*",
-    "@graphcommerce/eslint-config-pwa": "^10.1.0-canary.36",
-    "@graphcommerce/prettier-config-pwa": "^10.1.0-canary.36",
-    "@graphcommerce/typescript-config-pwa": "^10.1.0-canary.36",
+    "@graphcommerce/eslint-config-pwa": "^10.1.0-canary.38",
+    "@graphcommerce/prettier-config-pwa": "^10.1.0-canary.38",
+    "@graphcommerce/typescript-config-pwa": "^10.1.0-canary.38",
     "@graphql-mesh/runtime": "*",
     "@graphql-mesh/types": "*"
   },