@graphcommerce/docs 8.0.0 → 8.0.1-canary.1

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Change Log
 
+## 8.0.1-canary.1
+
+### Patch Changes
+
+- [#2186](https://github.com/graphcommerce-org/graphcommerce/pull/2186) [`09eb25c`](https://github.com/graphcommerce-org/graphcommerce/commit/09eb25c9892bf4cf57519024e31c2ae4cf2f7a0b) - Update Magento known issues
+  ([@hnsr](https://github.com/hnsr))
+
+## 8.0.1-canary.0
+
+### Patch Changes
+
+- [#2187](https://github.com/graphcommerce-org/graphcommerce/pull/2187) [`6c4cee8`](https://github.com/graphcommerce-org/graphcommerce/commit/6c4cee8469ee4934281bda53ac96aeb5af2f9479) - Make sure the config page can be properly rendered in the docs
+  ([@paales](https://github.com/paales))
+
 ## 8.0.0
 
 ### Minor Changes

package/framework/config.md

@@ -115,12 +115,12 @@ When Magento's StoreConfig adds this value, this can be replaced.
 
 Use compare functionality
 
-#### compareVariant: 'CHECKBOX' | 'ICON' = 'ICON'
+#### compareVariant: CHECKBOX | ICON = `ICON`
 
 By default the compare feature is denoted with a 'compare ICON' (2 arrows facing one another).
 This may be fine for experienced users, but for more clarity it's also possible to present the compare feature as a CHECKBOX accompanied by the 'Compare' label
 
-#### configurableVariantForSimple: boolean = false
+#### configurableVariantForSimple: boolean = `false`
 
 If a simple product is part of a Configurable product page, should the simple product be
 rendered as a configured option of the configurable product page?
@@ -133,19 +133,19 @@ Magento also returns the Simple product and the Configurable product the simple
 If that is the case we render the configurable product page instead of the simple product page but
 the options to select the simple product are pre-selected.
 
-#### configurableVariantValues: [MagentoConfigurableVariantValues](#MagentoConfigurableVariantValues) = { content: true, url: true }
+#### configurableVariantValues: [MagentoConfigurableVariantValues](#MagentoConfigurableVariantValues) = `{ content: true, url: true }`
 
 When a user selects a variant, it will switch the values on the configurable page with the values of the configured variant.
 
 Enabling options here will allow switching of those variants.
 
-#### crossSellsHideCartItems: boolean = false
+#### crossSellsHideCartItems: boolean = `false`
 
 Determines if cross sell items should be shown when the user already has the product in their cart. This will result in a product will popping off the screen when you add it to the cart.
 
 Default: 'false'
 
-#### crossSellsRedirectItems: boolean = false
+#### crossSellsRedirectItems: boolean = `false`
 
 Determines if, after adding a cross-sell item to the cart, the user should be redirected to the cross-sell items of the product they just added.
 
@@ -163,7 +163,7 @@ This value should match Magento 2's configuration value for
 
 Debug configuration for GraphCommerce
 
-#### demoMode: boolean = true
+#### demoMode: boolean = `true`
 
 Enables some demo specific code that is probably not useful for a project:
 
@@ -263,7 +263,7 @@ By default GraphCommerce will statically generate all product and category pages
 
 To enable next.js' preview mode, configure the secret you'd like to use.
 
-#### productFiltersLayout: 'DEFAULT' | 'SIDEBAR' = 'DEFAULT'
+#### productFiltersLayout: DEFAULT | SIDEBAR = `DEFAULT`
 
 Layout how the filters are rendered.
 DEFAULT: Will be rendered as horzontal chips on desktop and mobile
@@ -427,6 +427,6 @@ Number of recently viewed products to be stored in localStorage
 
 SidebarGalleryConfig will contain all configuration values for the Sidebar Gallery component.
 
-#### paginationVariant: 'DOTS' | 'THUMBNAILS_BOTTOM'
+#### paginationVariant: DOTS | THUMBNAILS_BOTTOM
 
 Variant used for the pagination

package/hygraph/cli.md

@@ -58,9 +58,9 @@ The following steps are needed to utilize this tool:
    1. Copy the project ID from the URL when logged in
       `https://app.hygraph.com/PROJECT_ID_IS_HERE/master`
    2. Add the project ID to your env file:
-      `GC_HYGRAPH_PROJECT_ID=”{YOUR_PROJECT_ID}”`
+      `GC_HYGRAPH_PROJECT_ID="{YOUR_PROJECT_ID}"`
 4. Add your hygraphManagementApi to your env file like this:
-   `GC_HYGRAPH_MANAGEMENT_API="{YOUR_MANAGEMENT_API}"`
+   1. Copy the Management API URL and add to your env file: `GC_HYGRAPH_MANAGEMENT_API="{YOUR_MANAGEMENT_API}"`
 5. Run `yarn graphcommerce hygraph-migrate`
 6. Select the migration you want to run and press enter.
 7. The migrations should now be applied, check your Hygraph Schema if changes

package/hygraph/property-picker.md

@@ -6,11 +6,9 @@ row to each page. These rules hinge on shared attributes among the pages, with a
 category being a typical example of such an attribute. To enable the Dynamic Row
 UI Extension, follow the installation instructions as below.
 
-> Installation
->
-> [Click here to install the Dynamic Row UI Extension](https://app.hygraph.com/apps/dynamic-row-property-picker/new)
+> Installation: [Click here to install the Dynamic Row UI Extension](https://app.hygraph.com/apps/dynamic-row-property-picker/new)
 
-<img width="1792" alt="image" src="https://github.com/graphcommerce-org/graphcommerce/assets/49681263/3226eedb-e58c-4d3f-9516-14ff6ed56f24">
+<img width="1792" alt="image" src="https://github.com/graphcommerce-org/graphcommerce/assets/49681263/3226eedb-e58c-4d3f-9516-14ff6ed56f24"/>
 
 ## Enabling the Application
 
@@ -18,7 +16,7 @@ Once you click the link and authorize the application, you'll be taken to the
 app's configuration page. On this page, you can switch the application on or off
 as needed.
 
-<img width="1792" alt="image" src="https://github.com/graphcommerce-org/graphcommerce/assets/49681263/ec9b55f6-14f6-466e-8a31-0b893ffe1297">
+<img width="1792" alt="image" src="https://github.com/graphcommerce-org/graphcommerce/assets/49681263/ec9b55f6-14f6-466e-8a31-0b893ffe1297"/>
 
 ## Enabling the field
 
@@ -37,7 +35,7 @@ Replace the existing fields with the new `Property picker` field in the right si
 (it should be under `Slug` and above `Rich text`). While adding the
 `Property picker` field make sure that you make it `required`.
 
-<img width="1792" alt="image" src="https://github.com/graphcommerce-org/graphcommerce/assets/49681263/9206f86d-477c-4eaf-bec6-1648874bee5e">
+<img width="1792" alt="image" src="https://github.com/graphcommerce-org/graphcommerce/assets/49681263/9206f86d-477c-4eaf-bec6-1648874bee5e"/>
 
 ## Start building with your new Dynamic Rows UI!
 

package/magento/known-issues.md

@@ -10,7 +10,7 @@ An overview of bugs and limitations you may run into with Magento's GraphQL API:
 
 Affected Magento versions:
 
-- `2.4.7`: only `2.4.7-beta1`
+- `2.4.7`: fixed after 2.4.7-beta1
 - `2.4.6`: all versions
 
 This is caused by a regression which results in some GraphQL errors no longer
@@ -24,6 +24,72 @@ As a workaround, you can apply
 See also
 https://github.com/magento/magento2/commit/49cbe774020d3dfa6ee2b8702376a947801c9971
 
+## After adding a product to cart with custom options, options are not saved and/or retrieving the cart results in an error
+
+Affected Magento versions:
+
+- `2.4.7`: unknown, see below
+- `2.4.6`: all versions
+
+When adding a product to cart, custom options are not processed and saved
+correctly, and can result in an error on the `Cart.items.errors.message` field
+when subsequently retrieving the cart, if the product had required custom
+options.
+
+The observed error happens because no value is given for the non-nullable
+`message` field, however the original error occurs due a required custom option
+not being present on the cart item, as the custom options we not saved correctly
+during the previous `addProductsToCart` call.
+
+Note that although the relevant PR for this fix was merged, the fix seems to
+have gotten reverted and is not present in 2.4-develop at the time of writing,
+and may not be included in the final release of 2.4.7.
+
+As a workaround, you can apply
+[fix-custom-option-processing.patch](./patches/fix-custom-option-processing.patch).
+
+See also:
+
+- Original PR: https://github.com/magento/magento2/issues/37599
+- PR regarding revert of fix: https://github.com/magento/magento2/issues/37928
+
+## Adding products to cart with pre-existing items that are out of stock always results in an error
+
+Affected Magento versions:
+
+- `2.4.7`: fixed after 2.4.7-beta2
+- `2.4.6`: all versions
+
+This is due to an inconsistency between errors that are reported through the
+`AddProductsToCartOutput.user_errors` field and those on the cart items, which
+make it impossible to differentiate between errors cause by the product that was
+being added, and those from pre-existing cart items.
+
+As a workaround you can apply
+[fix-cart-user-error-reporting.patch](./patches/fix-cart-user-error-reporting.patch).
+
+See also:
+
+- Issue: https://github.com/magento/magento2/issues/37908
+- PR with fix: https://github.com/magento/magento2/pull/38014/files
+
+## Bundle selection products are not shown due to their visibility setting
+
+Affected Magento versions:
+
+- `2.4.6`: all versions
+
+The `BundleItemOption.product` GraphQL field is returned as `null` if the
+product visibility is set to not be visible in the catalog (which you may not
+want).
+
+As a workaround you can apply the following patches:
+
+- [fix-bundle-selection-visibility-catalog.patch](./patches/fix-bundle-selection-visibility-catalog.patch)
+- [fix-bundle-selection-visibility-related.patch](./patches/fix-bundle-selection-visibility-related.patch)
+
+See also https://github.com/magento/magento2/issues/37774
+
 ## Next steps
 
 - [Overview](./readme)

package/magento/patches/fix-bundle-selection-visibility-catalog.patch

@@ -0,0 +1,17 @@
+Fix bundle product children not showing up on some products, see https://github.com/magento/magento2/issues/37774
+
+@package magento/module-catalog-graph-ql
+
+diff --git a/Model/Resolver/Products/DataProvider/Product.php b/Model/Resolver/Products/DataProvider/Product.php
+index 30be41072242b..3e955ae303453 100644
+--- a/Model/Resolver/Products/DataProvider/Product.php
++++ b/Model/Resolver/Products/DataProvider/Product.php
+@@ -89,7 +89,7 @@ public function getList(
+
+         $this->collectionPreProcessor->process($collection, $searchCriteria, $attributes, $context);
+
+-        if ($isChildSearch) {
++        if (!$isChildSearch) {
+             $visibilityIds = $isSearch
+                 ? $this->visibility->getVisibleInSearchIds()
+                 : $this->visibility->getVisibleInCatalogIds();

package/magento/patches/fix-bundle-selection-visibility-related.patch

@@ -0,0 +1,19 @@
+Fix bundle product children not showing up on some products, see https://github.com/magento/magento2/issues/37774
+
+@package magento/module-related-product-graph-ql
+
+diff --git a/Model/Resolver/Batch/AbstractLikedProducts.php b/Model/Resolver/Batch/AbstractLikedProducts.php
+index fac7b23d408e3..f35af6f4885d2 100644
+--- a/Model/Resolver/Batch/AbstractLikedProducts.php
++++ b/Model/Resolver/Batch/AbstractLikedProducts.php
+@@ -94,9 +94,7 @@ private function findRelations(array $products, array $loadAttributes, int $link
+         $this->searchCriteriaBuilder->addFilter('entity_id', $relatedIds, 'in');
+         $relatedSearchResult = $this->productDataProvider->getList(
+             $this->searchCriteriaBuilder->create(),
+-            $loadAttributes,
+-            false,
+-            true
++            $loadAttributes
+         );
+         //Filling related products map.
+         /** @var \Magento\Catalog\Api\Data\ProductInterface[] $relatedProducts */

package/magento/patches/fix-cart-user-error-reporting.patch

@@ -0,0 +1,21 @@
+Fix add to cart `user_error` field containing inconsistent errors. See https://github.com/magento/magento2/pull/38014
+
+@package magento/module-quote
+
+--- a/Model/Cart/AddProductsToCart.php
++++ b/Model/Cart/AddProductsToCart.php	(date 1696845624268)
+@@ -80,14 +80,6 @@
+         $cartId = $this->maskedQuoteIdToQuoteId->execute($maskedCartId);
+         $cart = $this->cartRepository->get($cartId);
+         $allErrors = [];
+-        if ($cart->getData('has_error')) {
+-            $errors = $cart->getErrors();
+-
+-            /** @var MessageInterface $error */
+-            foreach ($errors as $error) {
+-                $allErrors[] = $this->error->create($error->getText());
+-            }
+-        }
+
+         $failedCartItems = $this->addItemsToCart($cart, $cartItems);
+         $saveCart = empty($failedCartItems);

package/magento/patches/fix-custom-option-processing.patch

@@ -0,0 +1,15 @@
+Fix custom options not saving on addProductsToCart. See https://github.com/magento/magento2/issues/37599
+
+@package magento/module-quote
+
+--- a/Model/Quote.php
++++ b/Model/Quote.php
+@@ -1647,6 +1647,8 @@ public function addProduct(
+             );
+         }
+
++        $productId = $product->getId();
++        $product = clone $this->productRepository->getById($productId, false, $this->getStore()->getId());
+         $cartCandidates = $product->getTypeInstance()->prepareForCartAdvanced($request, $product, $processMode);
+
+         /**

package/package.json

@@ -2,10 +2,10 @@
   "name": "@graphcommerce/docs",
   "homepage": "https://www.graphcommerce.org/docs",
   "repository": "github:graphcommerce-org/graphcommerce/docs",
-  "version": "8.0.0",
+  "version": "8.0.1-canary.1",
   "sideEffects": true,
   "peerDependencies": {
-    "@graphcommerce/prettier-config-pwa": "^8.0.0"
+    "@graphcommerce/prettier-config-pwa": "^8.0.1-canary.1"
   },
   "prettier": "@graphcommerce/prettier-config-pwa"
 }

package/upgrading/graphcommerce-7-to-8.md

@@ -1,4 +1,4 @@
-# Upgrading from GraphCommerce 6 to 7
+# Upgrading from GraphCommerce 7 to 8
 
 Depending on the amounts of customisations you've made, there are some manual
 steps. Please follow the regular [upgrade steps first](./readme.md).