@granite-js/screen 1.0.0

package/gradle-plugin/src/test/kotlin/run/granite/gradle/config/DependencyConfiguratorTest.kt

@@ -0,0 +1,338 @@
+package run.granite.gradle.config
+
+import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.io.TempDir
+import java.io.File
+import kotlin.test.assertEquals
+import kotlin.test.assertFalse
+import kotlin.test.assertNotNull
+import kotlin.test.assertTrue
+
+/**
+ * Unit tests for DependencyConfigurator.
+ *
+ * Tests the dependency substitution logic that replaces deprecated React Native artifacts
+ * with new ones and enforces version consistency across the project.
+ *
+ * Note: Custom Maven group tests are excluded (no real use case, official RN always uses com.facebook.react)
+ */
+class DependencyConfiguratorTest {
+
+  @TempDir
+  lateinit var tempDir: File
+
+  @Test
+  fun `getDependencySubstitutions returns base substitutions for default group`() {
+    // Given
+    val version = "0.81.1"
+    val group = "com.facebook.react"
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(version, group)
+
+    // Then
+    // When using default group, only react-native and hermes-engine substitutions are needed
+    assertEquals(2, substitutions.size)
+
+    // react-native -> react-android substitution
+    val reactSubstitution = substitutions.find { it.first == "com.facebook.react:react-native" }
+    assertEquals("com.facebook.react:react-android:0.81.1", reactSubstitution?.second)
+    assertTrue(reactSubstitution?.third?.contains("deprecated") == true)
+
+    // hermes-engine -> hermes-android substitution
+    val hermesSubstitution = substitutions.find { it.first == "com.facebook.react:hermes-engine" }
+    assertEquals("com.facebook.react:hermes-android:0.81.1", hermesSubstitution?.second)
+    assertTrue(hermesSubstitution?.third?.contains("deprecated") == true)
+  }
+
+  @Test
+  fun `getDependencySubstitutions handles SNAPSHOT versions`() {
+    // Given
+    val version = "0.0.0-20250123-1234-abc123-SNAPSHOT"
+    val group = "com.facebook.react"
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(version, group)
+
+    // Then
+    assertEquals(2, substitutions.size)
+
+    val reactSubstitution = substitutions.find { it.first == "com.facebook.react:react-native" }
+    assertEquals("com.facebook.react:react-android:0.0.0-20250123-1234-abc123-SNAPSHOT", reactSubstitution?.second)
+
+    val hermesSubstitution = substitutions.find { it.first == "com.facebook.react:hermes-engine" }
+    assertEquals("com.facebook.react:hermes-android:0.0.0-20250123-1234-abc123-SNAPSHOT", hermesSubstitution?.second)
+  }
+
+  @Test
+  fun `getDependencySubstitutions includes reason for each substitution`() {
+    // Given
+    val version = "0.81.1"
+    val group = "com.facebook.react"
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(version, group)
+
+    // Then
+    // All substitution rules should include a reason (third = reason)
+    assertTrue(substitutions.all { it.third.isNotBlank() })
+  }
+
+  @Test
+  fun `getDependencySubstitutions handles stable release versions`() {
+    // Given
+    val version = "0.81.6"
+    val group = "com.facebook.react"
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(version, group)
+
+    // Then
+    assertEquals(2, substitutions.size)
+
+    val reactSubstitution = substitutions.find { it.first == "com.facebook.react:react-native" }
+    assertEquals("com.facebook.react:react-android:0.81.6", reactSubstitution?.second)
+  }
+
+  @Test
+  fun `getDependencySubstitutions handles rc versions`() {
+    // Given
+    val version = "0.82.0-rc.0"
+    val group = "com.facebook.react"
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(version, group)
+
+    // Then
+    assertEquals(2, substitutions.size)
+
+    val reactSubstitution = substitutions.find { it.first == "com.facebook.react:react-native" }
+    assertEquals("com.facebook.react:react-android:0.82.0-rc.0", reactSubstitution?.second)
+  }
+
+  // === DependencyCoordinates-based tests ===
+
+  @Test
+  fun `getDependencySubstitutions with coordinates includes hermes-android to new group substitution`() {
+    // Given - RN 0.84 scenario
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    // Verify new substitution rules
+    val hermesAndroidSubstitution = substitutions.find {
+      it.first == "com.facebook.react:hermes-android"
+    }
+    assertNotNull(hermesAndroidSubstitution)
+    assertEquals("com.facebook.hermes:hermes-android:250829098.0.6", hermesAndroidSubstitution.second)
+    assertTrue(hermesAndroidSubstitution.third.contains("moved"))
+  }
+
+  @Test
+  fun `getDependencySubstitutions with coordinates uses V1 hermes version`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    val hermesEngineSubstitution = substitutions.find {
+      it.first == "com.facebook.react:hermes-engine"
+    }
+    // V1 version should be used
+    assertEquals("com.facebook.hermes:hermes-android:250829098.0.6", hermesEngineSubstitution?.second)
+  }
+
+  @Test
+  fun `getDependencySubstitutions with coordinates falls back to classic hermes when V1 empty`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "", // No V1
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    val hermesEngineSubstitution = substitutions.find {
+      it.first == "com.facebook.react:hermes-engine"
+    }
+    assertEquals("com.facebook.hermes:hermes-android:0.15.0", hermesEngineSubstitution?.second)
+  }
+
+  @Test
+  fun `getDependencySubstitutions with coordinates returns 3 base substitutions for default groups`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    assertEquals(3, substitutions.size) // react-native, hermes-engine, hermes-android
+  }
+
+  @Test
+  fun `getDependencySubstitutions with custom react group adds react-android substitution`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+      reactGroup = "io.github.custom",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    assertEquals(4, substitutions.size)
+    val reactAndroidSubstitution = substitutions.find {
+      it.first == "com.facebook.react:react-android"
+    }
+    assertEquals("io.github.custom:react-android:0.84.0", reactAndroidSubstitution?.second)
+  }
+
+  @Test
+  fun `getDependencySubstitutions with custom hermes group adds hermes-android substitution`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+      hermesGroup = "io.github.custom.hermes",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    assertEquals(4, substitutions.size) // base 3 + custom hermes group
+    val hermesSubstitution = substitutions.find {
+      it.first == "com.facebook.hermes:hermes-android"
+    }
+    assertEquals("io.github.custom.hermes:hermes-android:250829098.0.6", hermesSubstitution?.second)
+  }
+
+  @Test
+  fun `getDependencySubstitutions with both custom groups adds all substitutions`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+      reactGroup = "io.github.custom",
+      hermesGroup = "io.github.custom.hermes",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    assertEquals(5, substitutions.size) // base 3 + custom react + custom hermes
+  }
+
+  @Test
+  fun `getDependencySubstitutions handles Hermes V1 version format correctly`() {
+    // Given - Hermes V1 build number format
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6", // Build number-based
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then
+    val allHermesSubstitutions = substitutions.filter {
+      it.second.contains("hermes-android")
+    }
+    assertTrue(allHermesSubstitutions.all { it.second.contains("250829098.0.6") })
+  }
+
+  // === Tests for existing deprecated API (additional) ===
+
+  @Test
+  fun `getDependencySubstitutions with custom group returns 4 substitutions`() {
+    // Given
+    val version = "0.81.1"
+    val group = "io.github.custom"
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(version, group)
+
+    // Then
+    assertEquals(4, substitutions.size) // base 2 + custom group 2
+  }
+
+  // === Dynamic version substitution tests ===
+
+  @Test
+  fun `substitution rules use version-less module selectors for dynamic version matching`() {
+    // Given
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then - All source coordinates should be version-less for dynamic version matching
+    val reactNativeSubstitution = substitutions.find {
+      it.first == "com.facebook.react:react-native"
+    }
+    assertNotNull(reactNativeSubstitution)
+    // Source has no version (group:artifact format without version)
+    assertFalse(reactNativeSubstitution.first.contains(":0."))
+    assertFalse(reactNativeSubstitution.first.contains(":+"))
+    // Target has version
+    assertTrue(reactNativeSubstitution.second.contains(":0.84.0"))
+  }
+
+  @Test
+  fun `substitution rules match all versions including dynamic versions`() {
+    // Given - Scenario where dynamic versions are used
+    // When com.facebook.react:react-native:+ is declared
+    val coordinates = DependencyCoordinates(
+      reactVersion = "0.84.0",
+      hermesVersion = "0.15.0",
+      hermesV1Version = "250829098.0.6",
+    )
+
+    // When
+    val substitutions = DependencyConfigurator.getDependencySubstitutions(coordinates)
+
+    // Then - Substitution source should be declared without version
+    // Gradle's substitute(module("group:artifact")) matches all versions
+    // (+, latest.release, 1.+, 0.84.0, etc.)
+    for ((source, target, _) in substitutions) {
+      // Source is "group:artifact" format (no version)
+      val parts = source.split(":")
+      assertEquals(2, parts.size, "Source '$source' should be version-less (group:artifact)")
+
+      // Target is "group:artifact:version" format (with version)
+      val targetParts = target.split(":")
+      assertEquals(3, targetParts.size, "Target '$target' should have version (group:artifact:version)")
+    }
+  }
+}

package/gradle-plugin/src/test/kotlin/run/granite/gradle/config/DevServerResourceConfiguratorTest.kt

@@ -0,0 +1,205 @@
+package run.granite.gradle.config
+
+import org.gradle.api.Project
+import org.gradle.testfixtures.ProjectBuilder
+import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
+import run.granite.gradle.GraniteExtension
+import java.io.File
+import kotlin.test.assertFalse
+import kotlin.test.assertNotNull
+import kotlin.test.assertTrue
+
+/**
+ * Unit tests for DevServerResourceConfigurator.
+ *
+ * Tests the generation of Android resources for React Native development server configuration.
+ */
+class DevServerResourceConfiguratorTest {
+
+  private lateinit var project: Project
+  private lateinit var extension: GraniteExtension
+  private lateinit var configurator: DevServerResourceConfigurator
+  private lateinit var testResDir: File
+
+  @BeforeEach
+  fun setup() {
+    project = ProjectBuilder.builder().build()
+    project.pluginManager.apply("com.android.library")
+
+    extension = project.extensions.create("granite", GraniteExtension::class.java, project)
+    configurator = DevServerResourceConfigurator(project, extension)
+
+    testResDir = File(project.projectDir, "src/debug/res/values")
+  }
+
+  @AfterEach
+  fun cleanup() {
+    // Clean up generated test files
+    val debugSrcDir = File(project.projectDir, "src/debug")
+    if (debugSrcDir.exists()) {
+      debugSrcDir.deleteRecursively()
+    }
+  }
+
+  @Test
+  fun `configurator is created successfully`() {
+    assertNotNull(configurator, "DevServerResourceConfigurator should be created")
+  }
+
+  @Test
+  fun `configure does not generate files when dev server not configured`() {
+    // Don't set devServerHost or devServerPort
+    configurator.configure()
+
+    // Verify no resources were generated
+    assertFalse(
+      testResDir.exists(),
+      "Resource directory should not be created when dev server is not configured",
+    )
+  }
+
+  @Test
+  fun `configure generates strings xml when host is set`() {
+    extension.devServerHost.set("localhost")
+
+    configurator.configure()
+
+    val stringsFile = File(testResDir, "strings.xml")
+    assertTrue(stringsFile.exists(), "strings.xml should be generated")
+    assertTrue(
+      stringsFile.readText().contains("react_native_dev_server_host"),
+      "strings.xml should contain dev server host",
+    )
+    assertTrue(
+      stringsFile.readText().contains("localhost"),
+      "strings.xml should contain the configured host",
+    )
+  }
+
+  @Test
+  fun `configure generates integers xml when port is set`() {
+    extension.devServerPort.set(8081)
+
+    configurator.configure()
+
+    val integersFile = File(testResDir, "integers.xml")
+    assertTrue(integersFile.exists(), "integers.xml should be generated")
+    assertTrue(
+      integersFile.readText().contains("react_native_dev_server_port"),
+      "integers.xml should contain dev server port",
+    )
+    assertTrue(
+      integersFile.readText().contains("8081"),
+      "integers.xml should contain the configured port",
+    )
+  }
+
+  @Test
+  fun `configure generates both strings and integers when both are set`() {
+    extension.devServerHost.set("10.0.2.2")
+    extension.devServerPort.set(8082)
+
+    configurator.configure()
+
+    val stringsFile = File(testResDir, "strings.xml")
+    val integersFile = File(testResDir, "integers.xml")
+
+    assertTrue(stringsFile.exists(), "strings.xml should be generated")
+    assertTrue(integersFile.exists(), "integers.xml should be generated")
+
+    assertTrue(
+      stringsFile.readText().contains("10.0.2.2"),
+      "strings.xml should contain the configured host",
+    )
+    assertTrue(
+      integersFile.readText().contains("8082"),
+      "integers.xml should contain the configured port",
+    )
+  }
+
+  @Test
+  fun `configure generates valid xml format for strings`() {
+    extension.devServerHost.set("192.168.1.100")
+
+    configurator.configure()
+
+    val stringsFile = File(testResDir, "strings.xml")
+    val content = stringsFile.readText()
+
+    assertTrue(content.contains("<?xml version=\"1.0\" encoding=\"utf-8\"?>"), "Should have XML declaration")
+    assertTrue(content.contains("<resources>"), "Should have resources tag")
+    assertTrue(content.contains("</resources>"), "Should close resources tag")
+    assertTrue(content.contains("translatable=\"false\""), "Should mark as non-translatable")
+  }
+
+  @Test
+  fun `configure generates valid xml format for integers`() {
+    extension.devServerPort.set(9999)
+
+    configurator.configure()
+
+    val integersFile = File(testResDir, "integers.xml")
+    val content = integersFile.readText()
+
+    assertTrue(content.contains("<?xml version=\"1.0\" encoding=\"utf-8\"?>"), "Should have XML declaration")
+    assertTrue(content.contains("<resources>"), "Should have resources tag")
+    assertTrue(content.contains("</resources>"), "Should close resources tag")
+    assertTrue(content.contains("<integer name=\"react_native_dev_server_port\">"), "Should have integer tag")
+  }
+
+  @Test
+  fun `configure can be called multiple times`() {
+    extension.devServerHost.set("localhost")
+    extension.devServerPort.set(8081)
+
+    // Should not throw when called multiple times
+    configurator.configure()
+    configurator.configure()
+
+    // Files should still exist
+    assertTrue(File(testResDir, "strings.xml").exists())
+    assertTrue(File(testResDir, "integers.xml").exists())
+  }
+
+  @Test
+  fun `configure handles emulator android host`() {
+    extension.devServerHost.set("10.0.2.2") // Standard Android emulator host
+
+    configurator.configure()
+
+    val stringsFile = File(testResDir, "strings.xml")
+    assertTrue(
+      stringsFile.readText().contains("10.0.2.2"),
+      "Should handle Android emulator host address",
+    )
+  }
+
+  @Test
+  fun `configure handles custom ports`() {
+    extension.devServerPort.set(19000) // Custom Expo port
+
+    configurator.configure()
+
+    val integersFile = File(testResDir, "integers.xml")
+    assertTrue(
+      integersFile.readText().contains("19000"),
+      "Should handle custom port numbers",
+    )
+  }
+
+  @Test
+  fun `configure creates directory structure if not exists`() {
+    // Ensure directory doesn't exist
+    val debugSrcDir = File(project.projectDir, "src/debug")
+    if (debugSrcDir.exists()) {
+      debugSrcDir.deleteRecursively()
+    }
+
+    extension.devServerHost.set("localhost")
+    configurator.configure()
+
+    assertTrue(testResDir.exists(), "Should create directory structure")
+  }
+}

package/gradle-plugin/src/test/kotlin/run/granite/gradle/config/ResourceConfiguratorTest.kt

@@ -0,0 +1,131 @@
+package run.granite.gradle.config
+
+import com.android.build.gradle.LibraryExtension
+import org.gradle.api.Project
+import org.gradle.testfixtures.ProjectBuilder
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
+import run.granite.gradle.GraniteExtension
+import kotlin.test.assertNotNull
+import kotlin.test.assertTrue
+
+/**
+ * Unit tests for ResourceConfigurator.
+ *
+ * Tests the configuration of Android resource packaging options,
+ * particularly bundle compression settings.
+ */
+class ResourceConfiguratorTest {
+
+  private lateinit var project: Project
+  private lateinit var extension: GraniteExtension
+  private lateinit var androidExtension: LibraryExtension
+  private lateinit var configurator: ResourceConfigurator
+
+  @BeforeEach
+  fun setup() {
+    project = ProjectBuilder.builder().build()
+    project.pluginManager.apply("com.android.library")
+
+    extension = project.extensions.create("granite", GraniteExtension::class.java, project)
+    androidExtension = project.extensions.getByType(LibraryExtension::class.java)
+
+    configurator = ResourceConfigurator(project, extension)
+  }
+
+  @Test
+  fun `configurator is created successfully`() {
+    assertNotNull(configurator, "ResourceConfigurator should be created")
+  }
+
+  @Test
+  fun `configure method executes without errors when compression is enabled`() {
+    extension.bundleCompressionEnabled.set(true)
+
+    // Should not throw
+    configurator.configure(androidExtension)
+  }
+
+  @Test
+  fun `configure method executes without errors when compression is disabled`() {
+    extension.bundleCompressionEnabled.set(false)
+
+    // Should not throw
+    configurator.configure(androidExtension)
+  }
+
+  @Test
+  fun `packaging configuration is applied to android extension`() {
+    extension.bundleCompressionEnabled.set(false)
+
+    configurator.configure(androidExtension)
+
+    // Verify packaging configuration exists
+    assertNotNull(androidExtension.packaging, "Packaging should be configured")
+  }
+
+  @Test
+  fun `map files are always excluded from compression`() {
+    extension.bundleCompressionEnabled.set(true)
+
+    configurator.configure(androidExtension)
+
+    // Verify packaging resources exist
+    assertNotNull(androidExtension.packaging.resources, "Packaging resources should be configured")
+  }
+
+  @Test
+  fun `bundle compression disabled excludes bundle and hbc files`() {
+    extension.bundleCompressionEnabled.set(false)
+
+    configurator.configure(androidExtension)
+
+    val excludes = androidExtension.packaging.resources.excludes
+
+    // When compression is disabled, bundle files should be excluded from APK compression
+    assertTrue(
+      excludes.any { it.contains(".bundle") },
+      "Bundle files should be excluded when compression is disabled",
+    )
+    assertTrue(
+      excludes.any { it.contains(".hbc") },
+      "Hermes bytecode files should be excluded when compression is disabled",
+    )
+    assertTrue(
+      excludes.any { it.contains(".map") },
+      "Map files should always be excluded",
+    )
+  }
+
+  @Test
+  fun `bundle compression enabled only excludes map files`() {
+    extension.bundleCompressionEnabled.set(true)
+
+    configurator.configure(androidExtension)
+
+    val excludes = androidExtension.packaging.resources.excludes
+
+    // When compression is enabled, only map files should be excluded
+    assertTrue(
+      excludes.any { it.contains(".map") },
+      "Map files should always be excluded",
+    )
+  }
+
+  @Test
+  fun `configurator can be called multiple times`() {
+    extension.bundleCompressionEnabled.set(false)
+
+    // Should not throw when called multiple times
+    configurator.configure(androidExtension)
+    configurator.configure(androidExtension)
+  }
+
+  @Test
+  fun `configurator works with default extension values`() {
+    // Don't set any values explicitly, use defaults
+
+    // Should not throw with default values
+    configurator.configure(androidExtension)
+  }
+}