@graffiti-garden/implementation-decentralized 0.1.3 → 0.1.5

package/src/1-services/4-inboxes-tests.ts

@@ -1,8 +1,8 @@
-import { assert, describe, expect, test } from "vitest";
+import { afterEach, assert, describe, expect, test, vi } from "vitest";
 import { Inboxes, LABELED_MESSAGE_LABEL_KEY } from "./4-inboxes";
 import { GraffitiErrorUnauthorized } from "./utilities";
 import { randomBytes } from "@noble/hashes/utils.js";
-import type { GraffitiObjectBase } from "@graffiti-garden/api";
+import { GraffitiErrorCursorExpired, type GraffitiObjectBase } from "@graffiti-garden/api";
 import { encode as dagCborEncode, decode as dagCborDecode } from "@ipld/dag-cbor";
 
 export function inboxTests(inboxEndpoint: string, inboxToken: string) {
@@ -179,3 +179,388 @@ export function inboxTests(inboxEndpoint: string, inboxToken: string) {
     }, 100000);
   });
 }
+
+// Focused client behavior tests use mocked network and browser locks.
+const inboxUrl = "https://example.test/inbox";
+const message = {
+  id: "message-1",
+  m: {
+    t: [new Uint8Array([1])],
+    o: {
+      url: "https://example.test/object",
+      actor: "did:example:author",
+      channels: ["test"],
+      value: {},
+    },
+    m: new Uint8Array([2]),
+  },
+  l: 0,
+};
+
+function cborResponse(value: unknown) {
+  return new Response(new Uint8Array(dagCborEncode(value)).slice(), {
+    headers: { "Content-Type": "application/cbor" },
+  });
+}
+
+function queryPage(results: (typeof message)[], cursor: string, hasMore = false) {
+  return cborResponse({ results, hasMore, cursor });
+}
+
+class TestInboxes extends Inboxes {
+  async prepareCache() {
+    await this.cache;
+  }
+
+  async deleteCachedQuery(key: string) {
+    await (await this.cache).messageIds.del(key);
+  }
+
+  async fetchQueryBatch() {
+    const batch = await this.fetchMessageBatch(
+      "https://example.test/inbox",
+      "query",
+      undefined,
+    );
+    await batch.response.arrayBuffer();
+    return batch;
+  }
+}
+
+function enableLockPath(request: unknown) {
+  vi.stubGlobal("indexedDB", {
+    open: () => {
+      const probe: { result?: { close: () => void }; onsuccess?: () => void } = {};
+      queueMicrotask(() => {
+        probe.result = { close() {} };
+        probe.onsuccess?.();
+      });
+      return probe;
+    },
+  });
+  vi.stubGlobal("window", { navigator: { locks: { request } } });
+}
+
+export function inboxUnitTests() {
+  describe("Inboxes unit", () => {
+    afterEach(() => {
+      vi.unstubAllGlobals();
+      vi.restoreAllMocks();
+    });
+
+    describe("inbox stream lock and network failures", () => {
+      test("backs off for five seconds after an initial request failure", async () => {
+        const failure = new Error("offline");
+        const fetch = vi.fn(() => Promise.reject(failure));
+        vi.stubGlobal("fetch", fetch);
+        vi.spyOn(console, "error").mockImplementation(() => {});
+        const realSetTimeout = globalThis.setTimeout;
+        const timer = vi.spyOn(globalThis, "setTimeout").mockImplementation(
+          ((handler: TimerHandler, delay?: number, ...args: unknown[]) =>
+            realSetTimeout(
+              handler,
+              delay === 5000 ? 0 : delay,
+              ...args,
+            )) as typeof setTimeout,
+        );
+
+        await expect(new Inboxes().query(inboxUrl, [], {}).next()).rejects.toBe(
+          failure,
+        );
+        expect(fetch).toHaveBeenCalledOnce();
+        expect(timer).toHaveBeenCalledWith(expect.any(Function), 5000);
+      });
+
+      test("a rejected lock request rejects the stream", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        const error = new Error("lock request failed");
+        enableLockPath(vi.fn(() => Promise.reject(error)));
+
+        await expect(
+          inboxes.query("https://example.test/inbox", [], {}).next(),
+        ).rejects.toBe(error);
+      });
+
+      test("waiting for another tab's lock has a deadline", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        const timeoutError = new DOMException("timed out", "TimeoutError");
+        vi.spyOn(AbortSignal, "timeout").mockReturnValue(
+          AbortSignal.abort(timeoutError),
+        );
+        const request = vi.fn(
+          (
+            _key: string,
+            _options: { signal?: AbortSignal },
+          ) => Promise.reject(timeoutError),
+        );
+        enableLockPath(request);
+
+        await expect(
+          inboxes.query("https://example.test/inbox", [], {}).next(),
+        ).rejects.toThrow("Timed out waiting for another tab's inbox query");
+        expect(request).toHaveBeenCalledOnce();
+      });
+
+      test("a stalled request is aborted", async () => {
+        const realTimeout = AbortSignal.timeout;
+        vi.spyOn(AbortSignal, "timeout").mockImplementation(() => realTimeout(5));
+        vi.stubGlobal(
+          "fetch",
+          vi.fn((_url: string, options: RequestInit) =>
+            new Promise<Response>((_resolve, reject) => {
+              const signal = options.signal as AbortSignal;
+              signal.addEventListener("abort", () => reject(signal.reason), {
+                once: true,
+              });
+            }),
+          ),
+        );
+
+        await expect(new TestInboxes().fetchQueryBatch()).rejects.toMatchObject({
+          name: "TimeoutError",
+        });
+      });
+
+      test("the deadline remains active while reading a response body", async () => {
+        const realTimeout = AbortSignal.timeout;
+        vi.spyOn(AbortSignal, "timeout").mockImplementation(() => realTimeout(5));
+        vi.stubGlobal(
+          "fetch",
+          vi.fn((_url: string, options: RequestInit) => {
+            const signal = options.signal as AbortSignal;
+            const body = new ReadableStream({
+              start(controller) {
+                signal.addEventListener("abort", () => controller.error(signal.reason), {
+                  once: true,
+                });
+              },
+            });
+            return Promise.resolve(new Response(body));
+          }),
+        );
+
+        await expect(new TestInboxes().fetchQueryBatch()).rejects.toMatchObject({
+          name: "TimeoutError",
+        });
+      });
+    });
+
+    describe("inbox query cache", () => {
+      test("fetches the next page while the current message is yielded", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        let held = 0;
+        enableLockPath(vi.fn(async (
+          key: string,
+          _options: { signal?: AbortSignal },
+          callback: (lock: Lock) => Promise<unknown>,
+        ) => {
+          held++;
+          try {
+            return await callback({ name: key, mode: "exclusive" });
+          } finally {
+            held--;
+          }
+        }));
+        let prefetchAborted = false;
+        const fetch = vi.fn((_url: string, options: RequestInit) => {
+          if (fetch.mock.calls.length === 1) {
+            return Promise.resolve(queryPage([message], "cursor-1", true));
+          }
+          return new Promise<Response>((_resolve, reject) => {
+            const signal = options.signal as AbortSignal;
+            signal.addEventListener("abort", () => {
+              prefetchAborted = true;
+              reject(signal.reason);
+            }, { once: true });
+          });
+        });
+        vi.stubGlobal("fetch", fetch);
+
+        const iterator = inboxes.query(inboxUrl, [new Uint8Array([1])], {});
+        expect((await iterator.next()).value).toEqual(message);
+        await vi.waitFor(() => expect(fetch).toHaveBeenCalledTimes(2));
+        expect(fetch.mock.calls[1][0]).toBe(`${inboxUrl}/query?cursor=cursor-1`);
+        await iterator.return("");
+        expect(prefetchAborted).toBe(true);
+        await vi.waitFor(() => expect(held).toBe(0));
+      });
+
+      test("reports a cursor that expires after the first page", async () => {
+        const fetch = vi.fn()
+          .mockResolvedValueOnce(queryPage([message], "cursor-1", true))
+          .mockResolvedValueOnce(new Response("stale", { status: 410 }));
+        vi.stubGlobal("fetch", fetch);
+
+        const iterator = new Inboxes().query(inboxUrl, [new Uint8Array([1])], {});
+        expect((await iterator.next()).value).toEqual(message);
+        await expect(iterator.next()).rejects.toBeInstanceOf(
+          GraffitiErrorCursorExpired,
+        );
+        expect(fetch).toHaveBeenCalledTimes(2);
+      });
+
+      test("does not replay messages after another tab resets the cache", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        let markPrefetchStarted!: () => void;
+        const prefetchStarted = new Promise<void>((resolve) => {
+          markPrefetchStarted = resolve;
+        });
+        let releasePrefetch!: () => void;
+        const pause = new Promise<void>((resolve) => {
+          releasePrefetch = resolve;
+        });
+        let lockCalls = 0;
+        let cacheKey = "";
+        enableLockPath(vi.fn(async (
+          name: string,
+          _options: { signal?: AbortSignal },
+          work: (lock: Lock) => Promise<unknown>,
+        ) => {
+          cacheKey = name.slice("graffiti:inbox:".length);
+          if (++lockCalls === 2) {
+            markPrefetchStarted();
+            await pause;
+          }
+          return work({ name, mode: "exclusive" });
+        }));
+        vi.stubGlobal("fetch", vi.fn(async () => queryPage([message], "cursor-1", true)));
+
+        const iterator = inboxes.query(inboxUrl, [new Uint8Array([1])], {});
+        expect((await iterator.next()).value).toEqual(message);
+        await prefetchStarted;
+        await inboxes.deleteCachedQuery(cacheKey);
+        releasePrefetch();
+        await expect(iterator.next()).rejects.toBeInstanceOf(
+          GraffitiErrorCursorExpired,
+        );
+      });
+
+      test("a later query reads messages from the cached server cursor", async () => {
+        const fetch = vi.fn()
+          .mockResolvedValueOnce(queryPage([message], "cursor-1"))
+          .mockResolvedValueOnce(queryPage([], "cursor-2"));
+        vi.stubGlobal("fetch", fetch);
+        const inboxes = new Inboxes();
+        const tags = [new Uint8Array([1])];
+
+        const first = inboxes.query(inboxUrl, tags, {});
+        expect((await first.next()).value).toEqual(message);
+        expect((await first.next()).done).toBe(true);
+
+        const second = inboxes.query(inboxUrl, tags, {});
+        expect((await second.next()).value).toEqual(message);
+        expect((await second.next()).done).toBe(true);
+        expect(fetch).toHaveBeenCalledTimes(2);
+        expect(fetch.mock.calls[1][0]).toBe(`${inboxUrl}/query?cursor=cursor-1`);
+      });
+
+      test("does not hold the query lock while a message is yielded", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        let held = false;
+        enableLockPath(vi.fn(async (
+          key: string,
+          _options: { ifAvailable?: boolean },
+          callback: (lock: Lock) => Promise<unknown>,
+        ) => {
+          held = true;
+          try {
+            return await callback({ name: key, mode: "exclusive" });
+          } finally {
+            held = false;
+          }
+        }));
+        vi.stubGlobal("fetch", vi.fn(async () => queryPage([message], "cursor-1")));
+
+        const iterator = inboxes.query(inboxUrl, [new Uint8Array([1])], {});
+        try {
+          expect((await iterator.next()).value).toEqual(message);
+          expect(held).toBe(false);
+        } finally {
+          await iterator.return("");
+        }
+      });
+
+      test("closing a yielded query leaves no lock held", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        let held = false;
+        enableLockPath(vi.fn(async (
+          key: string,
+          _options: { ifAvailable?: boolean },
+          callback: (lock: Lock) => Promise<unknown>,
+        ) => {
+          held = true;
+          try {
+            return await callback({ name: key, mode: "exclusive" });
+          } finally {
+            held = false;
+          }
+        }));
+        vi.stubGlobal("fetch", vi.fn(async () => queryPage([message], "cursor-1")));
+
+        const iterator = inboxes.query(inboxUrl, [new Uint8Array([1])], {});
+        expect((await iterator.next()).value).toEqual(message);
+        expect(held).toBe(false);
+        await iterator.return("");
+        expect(held).toBe(false);
+      });
+
+      test("concurrent queries reuse a page fetched under the lock", async () => {
+        const inboxes = new TestInboxes();
+        await inboxes.prepareCache();
+        let releasePrevious = Promise.resolve();
+        let requests = 0;
+        let bothRequested!: () => void;
+        const ready = new Promise<void>((resolve) => { bothRequested = resolve; });
+        enableLockPath(vi.fn(async (
+          key: string,
+          _options: { signal?: AbortSignal },
+          callback: (lock: Lock) => Promise<unknown>,
+        ) => {
+          requests++;
+          if (requests === 2) bothRequested();
+          const previous = releasePrevious;
+          let release!: () => void;
+          releasePrevious = new Promise<void>((resolve) => { release = resolve; });
+          await previous;
+          try {
+            return await callback({ name: key, mode: "exclusive" });
+          } finally {
+            release();
+          }
+        }));
+        const nextMessage = { ...message, id: "message-2" };
+        const fetch = vi.fn(async () => {
+          await ready;
+          return fetch.mock.calls.length === 1
+            ? queryPage([message], "cursor-1", true)
+            : queryPage([nextMessage], "cursor-2");
+        });
+        vi.stubGlobal("fetch", fetch);
+
+        const tags = [new Uint8Array([1])];
+        const first = inboxes.query(inboxUrl, tags, {});
+        const second = inboxes.query(inboxUrl, tags, {});
+        const [firstResult, secondResult] = await Promise.all([
+          first.next(), second.next(),
+        ]);
+        expect(firstResult.value).toEqual(message);
+        expect(secondResult.value).toEqual(message);
+        const [firstNext, secondNext] = await Promise.all([
+          first.next(), second.next(),
+        ]);
+        expect(firstNext.value).toEqual(nextMessage);
+        expect(secondNext.value).toEqual(nextMessage);
+        expect(fetch).toHaveBeenCalledTimes(2);
+        expect((await first.next()).done).toBe(true);
+        expect((await second.next()).done).toBe(true);
+      });
+
+    });
+  });
+}