@grafema/core 0.2.4-beta → 0.2.5-beta

package/src/plugins/validation/EvalBanValidator.ts

@@ -59,7 +59,7 @@ export class EvalBanValidator extends Plugin {
     return {
       name: 'EvalBanValidator',
       phase: 'VALIDATION',
-      priority: 95, // Высокий приоритет - security check
+      dependencies: ['JSASTAnalyzer'],
       creates: {
         nodes: [],
         edges: []

package/src/plugins/validation/GraphConnectivityValidator.ts

@@ -8,14 +8,6 @@ import type { PluginContext, PluginMetadata, PluginResult } from '../Plugin.js';
 import type { NodeRecord } from '@grafema/types';
 import { ValidationError } from '../../errors/GrafemaError.js';
 
-/**
- * Edge structure
- */
-interface EdgeRecord {
-  src: string;
-  dst: string;
-  [key: string]: unknown;
-}
 
 /**
  * Unreachable node info for manifest
@@ -51,7 +43,7 @@ export class GraphConnectivityValidator extends Plugin {
     return {
       name: 'GraphConnectivityValidator',
       phase: 'VALIDATION',
-      priority: 100,
+      dependencies: [],
       creates: {
         nodes: [],
         edges: []

package/src/plugins/validation/SQLInjectionValidator.ts

@@ -102,7 +102,7 @@ export class SQLInjectionValidator extends Plugin {
     return {
       name: 'SQLInjectionValidator',
       phase: 'VALIDATION',
-      priority: 90, // After ValueDomainAnalyzer (65)
+      dependencies: ['ValueDomainAnalyzer'],
       creates: {
         nodes: ['issue:security'],
         edges: ['AFFECTS']
@@ -396,7 +396,8 @@ export class SQLInjectionValidator extends Plugin {
       }
     } catch (err) {
       // Datalog query might fail if backend doesn't support it
-      logger.debug('Datalog check skipped', { error: (err as Error).message });
+      const message = err instanceof Error ? err.message : String(err);
+      logger.debug('Datalog check skipped', { error: message });
     }
 
     return issues;

package/src/plugins/validation/ShadowingDetector.ts

@@ -60,7 +60,7 @@ export class ShadowingDetector extends Plugin {
     return {
       name: 'ShadowingDetector',
       phase: 'VALIDATION',
-      priority: 80, // After enrichment, before other validators
+      dependencies: ['JSASTAnalyzer'],
       creates: {
         nodes: [],
         edges: []

package/src/plugins/validation/TypeScriptDeadCodeValidator.ts

@@ -47,12 +47,11 @@ export class TypeScriptDeadCodeValidator extends Plugin {
     return {
       name: 'TypeScriptDeadCodeValidator',
       phase: 'VALIDATION',
-      priority: 50, // Lower priority - runs after other validators
+      dependencies: ['JSASTAnalyzer'],
       creates: {
         nodes: [],
         edges: []
-      },
-      dependencies: ['JSASTAnalyzer'] // Requires TypeScript nodes to be created
+      }
     };
   }
 

package/src/plugins/vcs/GitPlugin.ts

@@ -114,8 +114,9 @@ export class GitPlugin extends VCSPlugin {
 
       return files;
     } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
       throw new FileAccessError(
-        `Failed to get changed files: ${(error as Error).message}`,
+        `Failed to get changed files: ${message}`,
         'ERR_GIT_ACCESS_DENIED',
         { plugin: 'GitPlugin' },
         'Check that git is installed and this is a valid git repository'
@@ -157,8 +158,9 @@ export class GitPlugin extends VCSPlugin {
       // Парсим unified diff
       return this._parseUnifiedDiff(filePath, stdout);
     } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
       throw new FileAccessError(
-        `Failed to get diff for ${filePath}: ${(error as Error).message}`,
+        `Failed to get diff for ${filePath}: ${message}`,
         'ERR_GIT_ACCESS_DENIED',
         { plugin: 'GitPlugin', filePath },
         'Ensure the file is tracked by git and the working directory is accessible'
@@ -174,8 +176,9 @@ export class GitPlugin extends VCSPlugin {
       const { stdout } = await this._exec('git rev-parse --abbrev-ref HEAD');
       return stdout.trim();
     } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
       throw new FileAccessError(
-        `Failed to get current branch: ${(error as Error).message}`,
+        `Failed to get current branch: ${message}`,
         'ERR_GIT_ACCESS_DENIED',
         { plugin: 'GitPlugin' },
         'Ensure this is a valid git repository with at least one commit'
@@ -191,8 +194,9 @@ export class GitPlugin extends VCSPlugin {
       const { stdout } = await this._exec('git rev-parse HEAD');
       return stdout.trim();
     } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
       throw new FileAccessError(
-        `Failed to get last commit hash: ${(error as Error).message}`,
+        `Failed to get last commit hash: ${message}`,
         'ERR_GIT_NOT_FOUND',
         { plugin: 'GitPlugin' },
         'Ensure this is a valid git repository with at least one commit'
@@ -328,8 +332,9 @@ export class GitPlugin extends VCSPlugin {
       const { stdout } = await this._exec('git ls-files');
       return stdout.trim().split('\n').filter(line => line.length > 0);
     } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
       throw new FileAccessError(
-        `Failed to get tracked files: ${(error as Error).message}`,
+        `Failed to get tracked files: ${message}`,
         'ERR_GIT_ACCESS_DENIED',
         { plugin: 'GitPlugin' },
         'Check that git is installed and this is a valid git repository'
@@ -353,8 +358,9 @@ export class GitPlugin extends VCSPlugin {
         message: lines[4]
       };
     } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
       throw new FileAccessError(
-        `Failed to get last commit info: ${(error as Error).message}`,
+        `Failed to get last commit info: ${message}`,
         'ERR_GIT_NOT_FOUND',
         { plugin: 'GitPlugin' },
         'Ensure this is a valid git repository with at least one commit'

package/src/queries/findCallsInFunction.ts

@@ -30,7 +30,7 @@ interface GraphBackend {
   getNode(id: string): Promise<{
     id: string;
     type: string;
-    name: string;
+    name?: string;
     file?: string;
     line?: number;
     object?: string;
@@ -126,7 +126,7 @@ export async function findCallsInFunction(
  */
 async function buildCallInfo(
   backend: GraphBackend,
-  callNode: { id: string; type: string; name: string; file?: string; line?: number; object?: string },
+  callNode: { id: string; type: string; name?: string; file?: string; line?: number; object?: string },
   depth: number
 ): Promise<CallInfo> {
   // Check for CALLS edge (resolved target)
@@ -139,7 +139,7 @@ async function buildCallInfo(
     if (targetNode) {
       target = {
         id: targetNode.id,
-        name: targetNode.name,
+        name: targetNode.name ?? '<anonymous>',
         file: targetNode.file,
         line: targetNode.line,
       };
@@ -148,7 +148,7 @@ async function buildCallInfo(
 
   return {
     id: callNode.id,
-    name: callNode.name,
+    name: callNode.name ?? '<unknown>',
     type: callNode.type as 'CALL' | 'METHOD_CALL',
     object: callNode.object,
     resolved: isResolved,

package/src/queries/findContainingFunction.ts

@@ -24,7 +24,7 @@ interface GraphBackend {
   getNode(id: string): Promise<{
     id: string;
     type: string;
-    name: string;
+    name?: string;
     file?: string;
     line?: number;
   } | null>;

package/src/queries/traceValues.ts

@@ -26,7 +26,6 @@ import type {
   TraceValuesGraphBackend,
   ValueSetResult,
   NondeterministicPattern,
-  UnknownReason,
 } from './types.js';
 
 // =============================================================================

package/src/storage/backends/RFDBServerBackend.ts

@@ -22,13 +22,17 @@ import { RFDBClient } from '@grafema/rfdb-client';
 import { existsSync, unlinkSync } from 'fs';
 import { spawn, type ChildProcess } from 'child_process';
 import { join, dirname } from 'path';
+import { fileURLToPath } from 'url';
+import { createRequire } from 'module';
 import { setTimeout as sleep } from 'timers/promises';
 
-import type { WireNode, WireEdge } from '@grafema/types';
+import type { WireNode, WireEdge, FieldDeclaration, AttrQuery as RFDBAttrQuery } from '@grafema/types';
 import type { NodeType, EdgeType } from '@grafema/types';
 import type { BaseNodeRecord, EdgeRecord } from '@grafema/types';
 import type { AttrQuery, GraphStats, GraphExport } from '../../core/GraphBackend.js';
-import { findRfdbBinary, getBinaryNotFoundMessage } from '../../utils/findRfdbBinary.js';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
 
 /**
  * Options for RFDBServerBackend
@@ -42,6 +46,11 @@ export interface RFDBServerBackendOptions {
    * Default: true (for backwards compatibility)
    */
   autoStart?: boolean;
+  /**
+   * If true, suppress all console output (for clean CLI progress).
+   * Default: false
+   */
+  silent?: boolean;
 }
 
 /**
@@ -92,6 +101,7 @@ export class RFDBServerBackend {
   readonly socketPath: string;
   readonly dbPath: string | undefined;
   private readonly autoStart: boolean;
+  private readonly silent: boolean;
   private client: RFDBClient | null;
   private serverProcess: ChildProcess | null;
   connected: boolean;  // Public for compatibility
@@ -102,6 +112,7 @@ export class RFDBServerBackend {
   constructor(options: RFDBServerBackendOptions = {}) {
     this.dbPath = options.dbPath;
     this.autoStart = options.autoStart ?? true; // Default true for backwards compat
+    this.silent = options.silent ?? false;
     // Default socket path: next to the database in .grafema folder
     // This ensures each project has its own socket, avoiding conflicts
     if (options.socketPath) {
@@ -117,6 +128,22 @@ export class RFDBServerBackend {
     this.edgeTypes = new Set();
   }
 
+  /**
+   * Log message if not in silent mode.
+   */
+  private log(message: string): void {
+    if (!this.silent) {
+      console.log(message);
+    }
+  }
+
+  /**
+   * Log error (always shown, even in silent mode).
+   */
+  private logError(message: string, error?: unknown): void {
+    console.error(message, error ?? '');
+  }
+
   /**
    * Connect to RFDB server.
    * If autoStart is true (default), starts the server if not running.
@@ -128,33 +155,42 @@ export class RFDBServerBackend {
     // Try to connect first
     this.client = new RFDBClient(this.socketPath);
 
+    // Attach error handler to prevent unhandled 'error' events
+    // This is important for stale sockets (socket file exists but server is dead)
+    this.client.on('error', (err: Error) => {
+      this.logError('[RFDBServerBackend] Client error:', err.message);
+    });
+
     try {
       await this.client.connect();
       // Verify server is responsive
       await this.client.ping();
       this.connected = true;
-      console.log(`[RFDBServerBackend] Connected to RFDB server at ${this.socketPath}`);
+      this.log(`[RFDBServerBackend] Connected to RFDB server at ${this.socketPath}`);
       return;
     } catch {
-      // Server not running
+      // Server not running or stale socket
       if (!this.autoStart) {
         throw new Error(
           `RFDB server not running at ${this.socketPath}\n` +
           `Start the server first: grafema server start`
         );
       }
-      console.log(`[RFDBServerBackend] RFDB server not running, starting...`);
+      this.log(`[RFDBServerBackend] RFDB server not running, starting...`);
     }
 
     // Start the server (only if autoStart is true)
     await this._startServer();
 
-    // Connect again
+    // Connect again with fresh client
     this.client = new RFDBClient(this.socketPath);
+    this.client.on('error', (err: Error) => {
+      this.logError('[RFDBServerBackend] Client error:', err.message);
+    });
     await this.client.connect();
     await this.client.ping();
     this.connected = true;
-    console.log(`[RFDBServerBackend] Connected to RFDB server at ${this.socketPath}`);
+    this.log(`[RFDBServerBackend] Connected to RFDB server at ${this.socketPath}`);
   }
 
   /**
@@ -165,14 +201,62 @@ export class RFDBServerBackend {
   }
 
   /**
-   * Find RFDB server binary using shared utility
+   * Find RFDB server binary in order of preference:
+   * 1. packages/rfdb-server/target/release (monorepo development - prioritized for dev)
+   * 2. packages/rfdb-server/target/debug
+   * 3. @grafema/rfdb npm package
+   * 4. ~/.local/bin/rfdb-server (user-installed binary)
    */
   private _findServerBinary(): string | null {
-    const binaryPath = findRfdbBinary();
-    if (binaryPath) {
-      console.log(`[RFDBServerBackend] Found binary: ${binaryPath}`);
+    // 1. Check packages/rfdb-server in monorepo (prioritized for development)
+    const projectRoot = join(__dirname, '../../../../..');
+    const releaseBinary = join(projectRoot, 'packages/rfdb-server/target/release/rfdb-server');
+    if (existsSync(releaseBinary)) {
+      this.log(`[RFDBServerBackend] Found release binary: ${releaseBinary}`);
+      return releaseBinary;
+    }
+
+    // 2. Check debug build
+    const debugBinary = join(projectRoot, 'packages/rfdb-server/target/debug/rfdb-server');
+    if (existsSync(debugBinary)) {
+      this.log(`[RFDBServerBackend] Found debug binary: ${debugBinary}`);
+      return debugBinary;
     }
-    return binaryPath;
+
+    // 3. Check @grafema/rfdb npm package
+    try {
+      const require = createRequire(import.meta.url);
+      const rfdbPkg = require.resolve('@grafema/rfdb');
+      const rfdbDir = dirname(rfdbPkg);
+      const platform = process.platform;
+      const arch = process.arch;
+
+      let platformDir: string;
+      if (platform === 'darwin') {
+        platformDir = arch === 'arm64' ? 'darwin-arm64' : 'darwin-x64';
+      } else if (platform === 'linux') {
+        platformDir = arch === 'arm64' ? 'linux-arm64' : 'linux-x64';
+      } else {
+        platformDir = `${platform}-${arch}`;
+      }
+
+      const npmBinary = join(rfdbDir, 'prebuilt', platformDir, 'rfdb-server');
+      if (existsSync(npmBinary)) {
+        this.log(`[RFDBServerBackend] Found binary in @grafema/rfdb: ${npmBinary}`);
+        return npmBinary;
+      }
+    } catch {
+      // @grafema/rfdb not installed
+    }
+
+    // 4. Check ~/.local/bin (user-installed binary for unsupported platforms)
+    const homeBinary = join(process.env.HOME || '', '.local', 'bin', 'rfdb-server');
+    if (existsSync(homeBinary)) {
+      this.log(`[RFDBServerBackend] Found user binary: ${homeBinary}`);
+      return homeBinary;
+    }
+
+    return null;
   }
 
   /**
@@ -186,7 +270,11 @@ export class RFDBServerBackend {
     // Find server binary - check multiple locations
     const binaryPath = this._findServerBinary();
     if (!binaryPath) {
-      throw new Error(getBinaryNotFoundMessage());
+      throw new Error(
+        'RFDB server binary not found.\n' +
+        'Install @grafema/rfdb: npm install @grafema/rfdb\n' +
+        'Or build from source: cargo build --release --bin rfdb-server'
+      );
     }
 
     // Remove stale socket
@@ -194,25 +282,18 @@ export class RFDBServerBackend {
       unlinkSync(this.socketPath);
     }
 
-    console.log(`[RFDBServerBackend] Starting: ${binaryPath} ${this.dbPath} --socket ${this.socketPath}`);
+    this.log(`[RFDBServerBackend] Starting: ${binaryPath} ${this.dbPath} --socket ${this.socketPath}`);
 
     this.serverProcess = spawn(binaryPath, [this.dbPath, '--socket', this.socketPath], {
-      stdio: ['ignore', 'pipe', 'pipe'],
+      stdio: ['ignore', 'ignore', 'inherit'], // stdin/stdout ignored, stderr inherited
       detached: true, // Allow server to outlive this process
     });
 
     // Don't let server process prevent parent from exiting
     this.serverProcess.unref();
 
-    this.serverProcess.stderr?.on('data', (data: Buffer) => {
-      const msg = data.toString().trim();
-      if (!msg.includes('FLUSH') && !msg.includes('WRITER')) {
-        console.log(`[rfdb-server] ${msg}`);
-      }
-    });
-
     this.serverProcess.on('error', (err: Error) => {
-      console.error(`[RFDBServerBackend] Server process error:`, err);
+      this.logError(`[RFDBServerBackend] Server process error:`, err);
     });
 
     // Wait for socket to appear
@@ -226,7 +307,7 @@ export class RFDBServerBackend {
       throw new Error(`RFDB server failed to start (socket not created after ${attempts * 100}ms)`);
     }
 
-    console.log(`[RFDBServerBackend] Server started on ${this.socketPath}`);
+    this.log(`[RFDBServerBackend] Server started on ${this.socketPath}`);
   }
 
   /**
@@ -268,6 +349,15 @@ export class RFDBServerBackend {
     await this.client.flush();
   }
 
+  /**
+   * Declare metadata fields for server-side indexing.
+   * Persisted in metadata.json — survives database reopen.
+   */
+  async declareFields(fields: FieldDeclaration[]): Promise<number> {
+    if (!this.client) throw new Error('Not connected');
+    return this.client.declareFields(fields);
+  }
+
   // ===========================================================================
   // Node Operations
   // ===========================================================================
@@ -462,7 +552,7 @@ export class RFDBServerBackend {
     }
 
     // Otherwise use client's queryNodes
-    for await (const wireNode of this.client.queryNodes(serverQuery)) {
+    for await (const wireNode of this.client.queryNodes(serverQuery as unknown as RFDBAttrQuery)) {
       yield this._parseNode(wireNode);
     }
   }

package/src/storage/backends/typeValidation.ts

@@ -46,6 +46,8 @@ const KNOWN_EDGE_TYPES = new Set<string>([
   'RETURNS', 'RECEIVES_ARGUMENT', 'READS_FROM', 'THROWS', 'REGISTERS_VIEW',
   'GOVERNS', 'VIOLATES', 'HAS_PARAMETER', 'DERIVES_FROM',
   'RESOLVES_TO',  // Promise resolve() data flow
+  'YIELDS',       // Generator yield data flow (REG-270)
+  'DELEGATES_TO', // Generator yield* delegation (REG-270)
 ]);
 
 // Store initial edge types for reset