@grafema/core 0.1.0-alpha.4 → 0.1.1-alpha

package/src/plugins/analysis/SocketIOAnalyzer.ts

@@ -23,6 +23,7 @@ import type { NodePath } from '@babel/traverse';
 import { Plugin, createSuccessResult, createErrorResult } from '../Plugin.js';
 import type { PluginContext, PluginResult, PluginMetadata } from '../Plugin.js';
 import type { NodeRecord } from '@grafema/types';
+import { getLine, getColumn } from './ast/utils/location.js';
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const traverse = (traverseModule as any).default || traverseModule;
@@ -93,12 +94,14 @@ export class SocketIOAnalyzer extends Plugin {
   }
 
   async execute(context: PluginContext): Promise<PluginResult> {
+    const logger = this.log(context);
+
     try {
       const { graph } = context;
 
       // Получаем все модули
       const modules = await this.getModules(graph);
-      console.log(`[SocketIOAnalyzer] Processing ${modules.length} modules...`);
+      logger.info('Processing modules', { count: modules.length });
 
       let emitsCount = 0;
       let listenersCount = 0;
@@ -116,15 +119,16 @@ export class SocketIOAnalyzer extends Plugin {
         if ((i + 1) % 20 === 0 || i === modules.length - 1) {
           const elapsed = ((Date.now() - startTime) / 1000).toFixed(1);
           const avgTime = ((Date.now() - startTime) / (i + 1)).toFixed(0);
-          console.log(
-            `[SocketIOAnalyzer] Progress: ${i + 1}/${modules.length} (${elapsed}s, avg ${avgTime}ms/module)`
-          );
+          logger.debug('Progress', {
+            current: i + 1,
+            total: modules.length,
+            elapsed: `${elapsed}s`,
+            avgTime: `${avgTime}ms/module`
+          });
         }
       }
 
-      console.log(
-        `[SocketIOAnalyzer] Found ${emitsCount} emits, ${listenersCount} listeners, ${roomsCount} rooms`
-      );
+      logger.info('Analysis complete', { emitsCount, listenersCount, roomsCount });
 
       return createSuccessResult(
         {
@@ -134,7 +138,7 @@ export class SocketIOAnalyzer extends Plugin {
         { emitsCount, listenersCount, roomsCount }
       );
     } catch (error) {
-      console.error('[SocketIOAnalyzer] Error:', error);
+      logger.error('Analysis failed', { error });
       return createErrorResult(error as Error);
     }
   }
@@ -178,8 +182,8 @@ export class SocketIOAnalyzer extends Plugin {
           ) {
             const objectName = this.getObjectName(callee.object);
             const event = this.extractStringArg(node.arguments[0]);
-            const line = node.loc!.start.line;
-            const column = node.loc!.start.column;
+            const line = getLine(node);
+            const column = getColumn(node);
 
             // io.to('room').emit() - room-based emit
             let room: string | null = null;
@@ -232,7 +236,7 @@ export class SocketIOAnalyzer extends Plugin {
           ) {
             const objectName = this.getObjectName(callee.object);
             const event = this.extractStringArg(node.arguments[0]);
-            const line = node.loc!.start.line;
+            const line = getLine(node);
             const handler = node.arguments[1];
 
             // Извлекаем имя handler функции
@@ -243,8 +247,8 @@ export class SocketIOAnalyzer extends Plugin {
                 handler.type === 'FunctionExpression' ||
                 handler.type === 'ArrowFunctionExpression'
               ) {
-                handlerName = `anonymous:${handler.loc!.start.line}`;
-                handlerLine = handler.loc!.start.line;
+                handlerName = `anonymous:${getLine(handler)}`;
+                handlerLine = getLine(handler);
               } else if (handler.type === 'Identifier') {
                 handlerName = (handler as Identifier).name;
               }
@@ -270,7 +274,7 @@ export class SocketIOAnalyzer extends Plugin {
           ) {
             const objectName = this.getObjectName(callee.object);
             const roomName = this.extractStringArg(node.arguments[0]);
-            const line = node.loc!.start.line;
+            const line = getLine(node);
 
             if (objectName === 'socket') {
               rooms.push({
@@ -308,15 +312,23 @@ export class SocketIOAnalyzer extends Plugin {
           dst: listener.id
         });
 
-        // Ищем FUNCTION node для handler и создаём ребро LISTENS_TO
-        const handlerFunctionId = `FUNCTION#${listener.handlerName}#${listener.file}#${listener.handlerLine}`;
-        const handlerFunction = await graph.getNode(handlerFunctionId);
+        // Find FUNCTION node for handler by name and file (supports both legacy and semantic IDs)
+        const handlerFunctions = await graph.getAllNodes({
+          type: 'FUNCTION',
+          name: listener.handlerName,
+          file: listener.file
+        });
+
+        // Find the handler at the matching line
+        const handlerFunction = handlerFunctions.find(fn =>
+          fn.line === listener.handlerLine
+        );
 
         if (handlerFunction) {
           await graph.addEdge({
             type: 'LISTENS_TO',
             src: listener.id,
-            dst: handlerFunctionId
+            dst: handlerFunction.id
           });
         }
       }
@@ -338,10 +350,7 @@ export class SocketIOAnalyzer extends Plugin {
         rooms: rooms.length
       };
     } catch (error) {
-      console.error(
-        `[SocketIOAnalyzer] Error analyzing ${module.file}:`,
-        (error as Error).message
-      );
+      // Silent - per-module errors shouldn't spam logs
       return { emits: 0, listeners: 0, rooms: 0 };
     }
   }

package/src/plugins/analysis/SystemDbAnalyzer.ts

@@ -58,6 +58,8 @@ export class SystemDbAnalyzer extends Plugin {
   }
 
   async execute(context: PluginContext): Promise<PluginResult> {
+    const logger = this.log(context);
+
     try {
       const { graph } = context;
 
@@ -67,9 +69,7 @@ export class SystemDbAnalyzer extends Plugin {
       // Get all MODULE nodes
       const modules = await this.getModules(graph);
 
-      console.log(
-        `[SystemDbAnalyzer] Analyzing ${modules.length} modules for system_db patterns...\n`
-      );
+      logger.info('Analyzing modules for system_db patterns', { count: modules.length });
 
       for (const module of modules) {
         if (!module.file) continue;
@@ -169,9 +169,13 @@ export class SystemDbAnalyzer extends Plugin {
           for (const reg of registrations) {
             const nodeId = `${module.file}:SYSTEM_DB_VIEW_REGISTRATION:${reg.viewName}:${reg.line}`;
 
-            console.log(
-              `   📌 Found: ${reg.type}('${reg.viewName}', '${reg.serverName}') at ${module.file!.split('/').pop()}:${reg.line}`
-            );
+            logger.debug('Found registration', {
+              type: reg.type,
+              viewName: reg.viewName,
+              serverName: reg.serverName,
+              file: module.file!.split('/').pop(),
+              line: reg.line
+            });
 
             await graph.addNode({
               id: nodeId,
@@ -221,21 +225,22 @@ export class SystemDbAnalyzer extends Plugin {
         } catch (err) {
           // Skip files that can't be parsed
           if ((err as NodeJS.ErrnoException).code !== 'ENOENT') {
-            console.error(`   ⚠️  Failed to analyze ${module.file}: ${(err as Error).message}`);
+            logger.warn('Failed to analyze module', {
+              file: module.file,
+              error: (err as Error).message
+            });
           }
         }
       }
 
-      console.log(
-        `[SystemDbAnalyzer] Created ${nodesCreated} system_db nodes, ${edgesCreated} edges\n`
-      );
+      logger.info('Analysis complete', { nodesCreated, edgesCreated });
 
       return createSuccessResult(
         { nodes: nodesCreated, edges: edgesCreated },
         { modulesAnalyzed: modules.length }
       );
     } catch (error) {
-      console.error(`[SystemDbAnalyzer] Error:`, error);
+      logger.error('Analysis failed', { error });
       return createErrorResult(error as Error);
     }
   }