@grafana/scenes 6.19.0 → 6.20.1

package/dist/index.js

@@ -2986,7 +2986,6 @@ class GroupByVariableUrlSyncHandler {
     };
   }
   updateFromUrl(values) {
-    var _a, _b, _c, _d;
     let urlValue = values[this.getKey()];
     let restorableValue = values[this.getRestorableKey()];
     if (urlValue != null) {
@@ -2994,24 +2993,11 @@ class GroupByVariableUrlSyncHandler {
         this._sceneObject.skipNextValidation = true;
       }
       const { values: values2, texts } = fromUrlValues(urlValue);
-      if (restorableValue === "false") {
-        if (this._sceneObject.state.defaultValue) {
-          this._sceneObject.changeValueTo(
-            (_a = this._sceneObject.state.defaultValue) == null ? void 0 : _a.value,
-            (_b = this._sceneObject.state.defaultValue) == null ? void 0 : _b.text,
-            false
-          );
-          return;
-        }
-        this._sceneObject.changeValueTo([], []);
+      if (this._sceneObject.state.defaultValue && (restorableValue === "false" || restorableValue === void 0)) {
         return;
       }
-      if (restorableValue === void 0 && this._sceneObject.state.defaultValue) {
-        this._sceneObject.changeValueTo(
-          (_c = this._sceneObject.state.defaultValue) == null ? void 0 : _c.value,
-          (_d = this._sceneObject.state.defaultValue) == null ? void 0 : _d.text,
-          false
-        );
+      if (restorableValue === "false") {
+        this._sceneObject.changeValueTo([], [], false);
         return;
       }
       this._sceneObject.changeValueTo(values2, texts);
@@ -3226,17 +3212,8 @@ class GroupByVariable extends MultiValueVariable {
     this._urlSync = new GroupByVariableUrlSyncHandler(this);
     this._activationHandler = () => {
       if (this.state.defaultValue) {
-        const partial = {};
-        if (lodash.isArray(this.state.value) && !this.state.value.length || !this.state.value) {
-          partial.value = this.state.defaultValue.value;
-          partial.text = this.state.defaultValue.text;
-          partial.restorable = false;
-        }
-        if (this.state.defaultValue && this.checkIfRestorable(this.state.value)) {
-          partial.restorable = true;
-        }
-        if (Object.keys(partial).length) {
-          this.setState(partial);
+        if (this.checkIfRestorable(this.state.value)) {
+          this.setState({ restorable: true });
         }
       }
       return () => {
@@ -3283,6 +3260,9 @@ class GroupByVariable extends MultiValueVariable {
       }
       return keys;
     };
+    if (this.state.defaultValue) {
+      this.changeValueTo(this.state.defaultValue.value, this.state.defaultValue.text, false);
+    }
     if (this.state.applyMode === "auto") {
       this.addActivationHandler(() => {
         allActiveGroupByVariables.add(this);
@@ -3957,20 +3937,20 @@ class AdHocFiltersVariableUrlSyncHandler {
   }
   getUrlState() {
     const filters = this._variable.state.filters;
-    const baseFilters = this._variable.state.baseFilters;
+    const originFilters = this._variable.state.originFilters;
     let value = [];
-    if (filters.length === 0 && (baseFilters == null ? void 0 : baseFilters.length) === 0) {
+    if (filters.length === 0 && (originFilters == null ? void 0 : originFilters.length) === 0) {
       return { [this.getKey()]: [""] };
     }
     if (filters.length) {
       value.push(
-        ...filters.filter(isFilterComplete).filter((filter) => !filter.hidden).map((filter) => toArray(filter).map(escapeInjectedFilterUrlDelimiters).join("|"))
+        ...filters.filter(isFilterComplete).filter((filter) => !filter.hidden).map((filter) => toArray(filter).map(escapeOriginFilterUrlDelimiters).join("|"))
       );
     }
-    if (baseFilters == null ? void 0 : baseFilters.length) {
+    if (originFilters == null ? void 0 : originFilters.length) {
       value.push(
-        ...baseFilters == null ? void 0 : baseFilters.filter(isFilterComplete).filter((filter) => !filter.hidden && filter.origin && filter.restorable).map(
-          (filter) => toArray(filter).map(escapeInjectedFilterUrlDelimiters).join("|").concat(`#${filter.origin}#restorable`)
+        ...originFilters == null ? void 0 : originFilters.filter(isFilterComplete).filter((filter) => !filter.hidden && filter.origin && filter.restorable).map(
+          (filter) => toArray(filter).map(escapeOriginFilterUrlDelimiters).join("|").concat(`#${filter.origin}#restorable`)
         )
       );
     }
@@ -3984,31 +3964,35 @@ class AdHocFiltersVariableUrlSyncHandler {
       return;
     }
     const filters = deserializeUrlToFilters(urlValue);
-    const baseFilters = [...this._variable.state.baseFilters || []];
-    for (let i = 0; i < filters.length; i++) {
-      const foundBaseFilterIndex = baseFilters.findIndex((f) => f.key === filters[i].key);
-      if (foundBaseFilterIndex > -1) {
-        if (!filters[i].origin && baseFilters[foundBaseFilterIndex].origin === "dashboard") {
-          filters[i].origin = "dashboard";
-          filters[i].restorable = true;
-        }
-        if (isMatchAllFilter(filters[i])) {
-          filters[i].matchAllFilter = true;
-        }
-        baseFilters[foundBaseFilterIndex] = filters[i];
-      } else if (filters[i].origin === "dashboard") {
-        delete filters[i].origin;
-        delete filters[i].restorable;
-      } else if (foundBaseFilterIndex === -1 && filters[i].origin === "scope" && filters[i].restorable) {
-        baseFilters.push(filters[i]);
-      }
-    }
+    const originFilters = updateOriginFilters([...this._variable.state.originFilters || []], filters);
     this._variable.setState({
       filters: filters.filter((f) => !f.origin),
-      baseFilters
+      originFilters
     });
   }
 }
+function updateOriginFilters(prevOriginFilters, filters) {
+  const updatedOriginFilters = [...prevOriginFilters];
+  for (let i = 0; i < filters.length; i++) {
+    const foundOriginFilterIndex = prevOriginFilters.findIndex((f) => f.key === filters[i].key);
+    if (foundOriginFilterIndex > -1) {
+      if (!filters[i].origin && prevOriginFilters[foundOriginFilterIndex].origin === "dashboard") {
+        filters[i].origin = "dashboard";
+        filters[i].restorable = true;
+      }
+      if (isMatchAllFilter(filters[i])) {
+        filters[i].matchAllFilter = true;
+      }
+      updatedOriginFilters[foundOriginFilterIndex] = filters[i];
+    } else if (filters[i].origin === "dashboard") {
+      delete filters[i].origin;
+      delete filters[i].restorable;
+    } else if (foundOriginFilterIndex === -1 && filters[i].origin === "scope" && filters[i].restorable) {
+      updatedOriginFilters.push(filters[i]);
+    }
+  }
+  return updatedOriginFilters;
+}
 function deserializeUrlToFilters(value) {
   if (Array.isArray(value)) {
     const values = value;
@@ -5336,7 +5320,7 @@ const AdHocFiltersAlwaysWipCombobox = React.forwardRef(function AdHocFiltersAlwa
 });
 
 const AdHocFiltersComboboxRenderer = React.memo(function AdHocFiltersComboboxRenderer2({ model }) {
-  const { baseFilters, filters, readOnly } = model.useState();
+  const { originFilters, filters, readOnly } = model.useState();
   const styles = ui.useStyles2(getStyles$a);
   const focusOnWipInputRef = React.useRef();
   return /* @__PURE__ */ React__default.default.createElement(
@@ -5349,7 +5333,7 @@ const AdHocFiltersComboboxRenderer = React.memo(function AdHocFiltersComboboxRen
       }
     },
     /* @__PURE__ */ React__default.default.createElement(ui.Icon, { name: "filter", className: styles.filterIcon, size: "lg" }),
-    baseFilters == null ? void 0 : baseFilters.map(
+    originFilters == null ? void 0 : originFilters.map(
       (filter, index) => filter.origin ? /* @__PURE__ */ React__default.default.createElement(
         AdHocFilterPill,
         {
@@ -5513,17 +5497,14 @@ const OPERATORS = [
 ];
 class AdHocFiltersVariable extends SceneObjectBase {
   constructor(state) {
-    var _a, _b, _c, _d, _e, _f;
+    var _a, _b, _c, _d, _e;
     super({
       type: "adhoc",
       name: (_a = state.name) != null ? _a : "Filters",
       filters: [],
       datasource: null,
       applyMode: "auto",
-      filterExpression: (_e = state.filterExpression) != null ? _e : renderExpression(state.expressionBuilder, [
-        ...(_c = (_b = state.baseFilters) == null ? void 0 : _b.filter((filter) => filter.origin)) != null ? _c : [],
-        ...(_d = state.filters) != null ? _d : []
-      ]),
+      filterExpression: (_d = state.filterExpression) != null ? _d : renderExpression(state.expressionBuilder, [...(_b = state.originFilters) != null ? _b : [], ...(_c = state.filters) != null ? _c : []]),
       ...state
     });
     this._scopedVars = { __sceneObject: wrapInSafeSerializableSceneObject(this) };
@@ -5532,6 +5513,7 @@ class AdHocFiltersVariable extends SceneObjectBase {
     // are set on construct and used to restore a baseFilter with an origin
     // to its original value if edited at some point
     this._originalValues = /* @__PURE__ */ new Map();
+    this._prevScopes = [];
     /** Needed for scopes dependency */
     this._variableDependency = new VariableDependencyConfig(this, {
       dependsOnScopes: true,
@@ -5539,44 +5521,33 @@ class AdHocFiltersVariable extends SceneObjectBase {
     });
     this._urlSync = new AdHocFiltersVariableUrlSyncHandler(this);
     this._activationHandler = () => {
-      this._updateScopesFilters();
       return () => {
-        var _a, _b;
-        if ((_a = this.state.baseFilters) == null ? void 0 : _a.length) {
-          this.setState({
-            baseFilters: [...this.state.baseFilters.filter((filter) => filter.origin !== "scope")]
-          });
-          (_b = this.state.baseFilters) == null ? void 0 : _b.forEach((filter) => {
-            if (filter.origin === "dashboard" && filter.restorable) {
-              this.restoreOriginalFilter(filter);
-            }
-          });
-        }
+        var _a;
+        (_a = this.state.originFilters) == null ? void 0 : _a.forEach((filter) => {
+          if (filter.restorable) {
+            this.restoreOriginalFilter(filter);
+          }
+        });
       };
     };
     if (this.state.applyMode === "auto") {
       patchGetAdhocFilters(this);
     }
-    (_f = this.state.baseFilters) == null ? void 0 : _f.forEach((baseFilter) => {
+    (_e = this.state.originFilters) == null ? void 0 : _e.forEach((filter) => {
       var _a2;
-      if (baseFilter.origin === "dashboard") {
-        this._originalValues.set(baseFilter.key, {
-          operator: baseFilter.operator,
-          value: (_a2 = baseFilter.values) != null ? _a2 : [baseFilter.value]
-        });
-      }
+      this._originalValues.set(filter.key, {
+        operator: filter.operator,
+        value: (_a2 = filter.values) != null ? _a2 : [filter.value]
+      });
     });
     this.addActivationHandler(this._activationHandler);
   }
   _updateScopesFilters() {
     var _a, _b;
     const scopes = sceneGraph.getScopes(this);
-    if (!scopes) {
-      return;
-    }
-    if (!scopes.length) {
+    if (!scopes || !scopes.length) {
       this.setState({
-        baseFilters: (_a = this.state.baseFilters) == null ? void 0 : _a.filter((filter) => filter.origin !== "scope")
+        originFilters: (_a = this.state.originFilters) == null ? void 0 : _a.filter((filter) => filter.origin !== "scope")
       });
       return;
     }
@@ -5594,13 +5565,18 @@ class AdHocFiltersVariable extends SceneObjectBase {
         operator: scopeFilter.operator
       });
     });
-    (_b = this.state.baseFilters) == null ? void 0 : _b.forEach((filter) => {
+    (_b = this.state.originFilters) == null ? void 0 : _b.forEach((filter) => {
       if (filter.origin === "scope") {
         scopeInjectedFilters.push(filter);
       } else {
         remainingFilters.push(filter);
       }
     });
+    if (this._prevScopes.length) {
+      this.setState({ originFilters: [...finalFilters, ...remainingFilters] });
+      this._prevScopes = scopes;
+      return;
+    }
     const editedScopeFilters = scopeInjectedFilters.filter((filter) => filter.restorable);
     const editedScopeFilterKeys = editedScopeFilters.map((filter) => filter.key);
     const scopeFilterKeys = scopeFilters.map((filter) => filter.key);
@@ -5608,18 +5584,16 @@ class AdHocFiltersVariable extends SceneObjectBase {
       ...editedScopeFilters.filter((filter) => scopeFilterKeys.includes(filter.key)),
       ...scopeFilters.filter((filter) => !editedScopeFilterKeys.includes(filter.key))
     ];
-    this.setState({ baseFilters: [...finalFilters, ...remainingFilters] });
+    this.setState({ originFilters: [...finalFilters, ...remainingFilters] });
+    this._prevScopes = scopes;
   }
   setState(update) {
-    var _a, _b, _c;
+    var _a, _b;
     let filterExpressionChanged = false;
-    if ((update.filters && update.filters !== this.state.filters || update.baseFilters && update.baseFilters !== this.state.baseFilters) && !update.filterExpression) {
+    if ((update.filters && update.filters !== this.state.filters || update.originFilters && update.originFilters !== this.state.originFilters) && !update.filterExpression) {
       const filters = (_a = update.filters) != null ? _a : this.state.filters;
-      const baseFilters = (_b = update.baseFilters) != null ? _b : this.state.baseFilters;
-      update.filterExpression = renderExpression(this.state.expressionBuilder, [
-        ...(_c = baseFilters == null ? void 0 : baseFilters.filter((filter) => filter.origin)) != null ? _c : [],
-        ...filters != null ? filters : []
-      ]);
+      const originFilters = (_b = update.originFilters) != null ? _b : this.state.originFilters;
+      update.filterExpression = renderExpression(this.state.expressionBuilder, [...originFilters != null ? originFilters : [], ...filters]);
       filterExpressionChanged = update.filterExpression !== this.state.filterExpression;
     }
     super.setState(update);
@@ -5633,12 +5607,12 @@ class AdHocFiltersVariable extends SceneObjectBase {
    * allowing consumers to update the filters without triggering dependent data providers.
    */
   updateFilters(filters, options) {
-    var _a, _b;
+    var _a;
     let filterExpressionChanged = false;
     let filterExpression = void 0;
     if (filters && filters !== this.state.filters) {
       filterExpression = renderExpression(this.state.expressionBuilder, [
-        ...(_b = (_a = this.state.baseFilters) == null ? void 0 : _a.filter((filter) => filter.origin)) != null ? _b : [],
+        ...(_a = this.state.originFilters) != null ? _a : [],
         ...filters
       ]);
       filterExpressionChanged = filterExpression !== this.state.filterExpression;
@@ -5658,32 +5632,34 @@ class AdHocFiltersVariable extends SceneObjectBase {
     };
     if (filter.restorable) {
       const originalFilter = this._originalValues.get(filter.key);
+      if (!originalFilter) {
+        return;
+      }
       original.value = originalFilter == null ? void 0 : originalFilter.value[0];
       original.values = originalFilter == null ? void 0 : originalFilter.value;
       original.valueLabels = originalFilter == null ? void 0 : originalFilter.value;
       original.operator = originalFilter == null ? void 0 : originalFilter.operator;
+      this._updateFilter(filter, original);
     }
-    this._updateFilter(filter, original);
   }
   getValue() {
     return this.state.filterExpression;
   }
   _updateFilter(filter, update) {
     var _a;
-    const { baseFilters, filters, _wip } = this.state;
+    const { originFilters, filters, _wip } = this.state;
     if (filter.origin) {
       const originalValues = this._originalValues.get(filter.key);
       const updateValues = update.values || (update.value ? [update.value] : void 0);
-      const isRestorableOverride = update.hasOwnProperty("restorable");
-      if (!isRestorableOverride && (updateValues && !lodash.isEqual(updateValues, originalValues == null ? void 0 : originalValues.value) || update.operator && update.operator !== (originalValues == null ? void 0 : originalValues.operator))) {
+      if (updateValues && !lodash.isEqual(updateValues, originalValues == null ? void 0 : originalValues.value) || update.operator && update.operator !== (originalValues == null ? void 0 : originalValues.operator)) {
         update.restorable = true;
       } else if (updateValues && lodash.isEqual(updateValues, originalValues == null ? void 0 : originalValues.value)) {
         update.restorable = false;
       }
-      const updatedBaseFilters = (_a = baseFilters == null ? void 0 : baseFilters.map((f) => {
+      const updatedFilters2 = (_a = originFilters == null ? void 0 : originFilters.map((f) => {
         return f === filter ? { ...f, ...update } : f;
       })) != null ? _a : [];
-      this.setState({ baseFilters: updatedBaseFilters });
+      this.setState({ originFilters: updatedFilters2 });
       return;
     }
     if (filter === _wip) {
@@ -5746,13 +5722,13 @@ class AdHocFiltersVariable extends SceneObjectBase {
           return [...acc, f];
         }, [])
       });
-    } else if ((_a = this.state.baseFilters) == null ? void 0 : _a.length) {
-      let filterToForceIndex = this.state.baseFilters.length - 1;
+    } else if ((_a = this.state.originFilters) == null ? void 0 : _a.length) {
+      let filterToForceIndex = this.state.originFilters.length - 1;
       if (filter !== this.state._wip) {
         filterToForceIndex = -1;
       }
       this.setState({
-        baseFilters: this.state.baseFilters.reduce((acc, f, index) => {
+        originFilters: this.state.originFilters.reduce((acc, f, index) => {
           if (index === filterToForceIndex && !f.readOnly) {
             return [
               ...acc,
@@ -5822,8 +5798,8 @@ class AdHocFiltersVariable extends SceneObjectBase {
     if (!ds || !ds.getTagValues) {
       return [];
     }
-    const filteredBaseFilters = (_d = (_c = this.state.baseFilters) == null ? void 0 : _c.filter((f) => f.origin && f.key !== filter.key)) != null ? _d : [];
-    const otherFilters = this.state.filters.filter((f) => f.key !== filter.key).concat(filteredBaseFilters);
+    const originFilters = (_d = (_c = this.state.originFilters) == null ? void 0 : _c.filter((f) => f.key !== filter.key)) != null ? _d : [];
+    const otherFilters = this.state.filters.filter((f) => f.key !== filter.key).concat(originFilters);
     const timeRange = sceneGraph.getTimeRange(this).state.value;
     const queries = this.state.useQueriesAsFilterForOptions ? getQueriesForVariables(this) : void 0;
     let scopes = sceneGraph.getScopes(this);
@@ -6307,12 +6283,10 @@ class SceneQueryRunner extends SceneObjectBase {
       ...getEnrichedDataRequest(this)
     };
     if (this._adhocFiltersVar) {
-      request.filters = [];
-      if ((_a = this._adhocFiltersVar.state.baseFilters) == null ? void 0 : _a.length) {
-        const injectedBaseFilters = this._adhocFiltersVar.state.baseFilters.filter((filter) => filter.origin);
-        request.filters = request.filters.concat(injectedBaseFilters);
-      }
-      request.filters = request.filters.concat(this._adhocFiltersVar.state.filters.filter(isFilterComplete));
+      request.filters = [
+        ...(_a = this._adhocFiltersVar.state.originFilters) != null ? _a : [],
+        ...this._adhocFiltersVar.state.filters
+      ].filter(isFilterComplete);
     }
     if (this._groupByVar) {
       request.groupByKeys = this._groupByVar.state.value;
@@ -6549,7 +6523,7 @@ function escapeUrlHashDelimiters(value) {
   }
   return /#/g[Symbol.replace](value, "__gfh__");
 }
-function escapeInjectedFilterUrlDelimiters(value) {
+function escapeOriginFilterUrlDelimiters(value) {
   return escapeUrlHashDelimiters(escapeUrlPipeDelimiters(value));
 }
 function escapeURLDelimiters(value) {
@@ -6651,11 +6625,9 @@ class VariableDependencyConfig {
    * This is called whenever any set of variables have new values. It is up to this implementation to check if it's relevant given the current dependencies.
    */
   variableUpdateCompleted(variable, hasChanged) {
+    var _a, _b, _c, _d;
     const deps = this.getNames();
-    let dependencyChanged = false;
-    if ((deps.has(variable.state.name) || deps.has(data.DataLinkBuiltInVars.includeVars)) && hasChanged) {
-      dependencyChanged = true;
-    }
+    const dependencyChanged = (deps.has(variable.state.name) || deps.has(data.DataLinkBuiltInVars.includeVars)) && hasChanged;
     writeSceneLog(
       "VariableDependencyConfig",
       "variableUpdateCompleted",
@@ -6663,47 +6635,29 @@ class VariableDependencyConfig {
       dependencyChanged,
       this._isWaitingForVariables
     );
-    if (this._options.onAnyVariableChanged) {
-      this._options.onAnyVariableChanged(variable);
-    }
+    (_b = (_a = this._options).onAnyVariableChanged) == null ? void 0 : _b.call(_a, variable);
     if (this._options.onVariableUpdateCompleted && (this._isWaitingForVariables || dependencyChanged)) {
       this._options.onVariableUpdateCompleted();
     }
     if (dependencyChanged) {
-      if (this._options.onReferencedVariableValueChanged) {
-        this._options.onReferencedVariableValueChanged(variable);
-      }
+      (_d = (_c = this._options).onReferencedVariableValueChanged) == null ? void 0 : _d.call(_c, variable);
       if (!this._options.onReferencedVariableValueChanged && !this._options.onVariableUpdateCompleted) {
         this._sceneObject.forceRender();
       }
     }
   }
   hasDependencyInLoadingState() {
-    if (sceneGraph.hasVariableDependencyInLoadingState(this._sceneObject)) {
-      this._isWaitingForVariables = true;
-      return true;
-    }
-    this._isWaitingForVariables = false;
-    return false;
+    this._isWaitingForVariables = sceneGraph.hasVariableDependencyInLoadingState(this._sceneObject);
+    return this._isWaitingForVariables;
   }
   getNames() {
     const prevState = this._state;
     const newState = this._state = this._sceneObject.state;
-    if (!prevState) {
-      this.scanStateForDependencies(this._state);
-      return this._dependencies;
-    }
-    if (newState !== prevState) {
-      if (this._statePaths) {
-        for (const path of this._statePaths) {
-          if (path === "*" || newState[path] !== prevState[path]) {
-            this.scanStateForDependencies(newState);
-            break;
-          }
-        }
-      } else {
-        this.scanStateForDependencies(newState);
-      }
+    const noPreviousState = !prevState;
+    const stateDiffers = newState !== prevState;
+    const shouldScanForDependencies = noPreviousState || stateDiffers && (!this._statePaths || this._statePaths.some((path) => path === "*" || newState[path] !== prevState[path]));
+    if (shouldScanForDependencies) {
+      this.scanStateForDependencies(newState);
     }
     return this._dependencies;
   }
@@ -6719,7 +6673,7 @@ class VariableDependencyConfig {
   }
   scanStateForDependencies(state) {
     this._dependencies.clear();
-    this.scanCount += 1;
+    this.scanCount++;
     if (this._options.variableNames) {
       for (const name of this._options.variableNames) {
         this._dependencies.add(name);