@grafana/react-detect 0.6.1 → 0.6.2

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+# v0.6.2 (Wed Apr 01 2026)
+
+#### 🐛 Bug Fix
+
+- fix: reduce false positives in findStringRefs [#2551](https://github.com/grafana/plugin-tools/pull/2551) ([@jackw](https://github.com/jackw))
+
+#### Authors: 1
+
+- Jack Westbrook ([@jackw](https://github.com/jackw))
+
+---
+
 # v0.6.1 (Tue Feb 17 2026)
 
 #### 🐛 Bug Fix

package/dist/patterns/matcher.js

@@ -74,8 +74,13 @@ function findJsxRuntimeImports(ast, code) {
 }
 function findStringRefs(ast, code) {
   const matches = [];
+  const imports = trackImportsFromPackage(ast, "react");
+  const hasReactImport = imports.defaultImports.size > 0 || imports.namedImports.size > 0;
+  if (!hasReactImport) {
+    return matches;
+  }
   walk(ast, (node) => {
-    if (node && node.type === "MemberExpression" && node.object.type === "ThisExpression" && node.property.type === "Identifier" && node.property.name === "refs") {
+    if (node && node.type === "MemberExpression" && node.object?.type === "MemberExpression" && node.object.object?.type === "ThisExpression" && node.object.property?.type === "Identifier" && node.object.property.name === "refs") {
       matches.push(createPatternMatch(node, "stringRefs", code));
     }
   });

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@grafana/react-detect",
   "description": "Run various checks to detect if a Grafana plugin is compatible with React.",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "repository": {
     "directory": "packages/react-detect",
     "url": "https://github.com/grafana/plugin-tools"
@@ -41,5 +41,5 @@
   "engines": {
     "node": ">=20"
   },
-  "gitHead": "9a39d4b614fef1f11a7dff646dd417603e3e2ad7"
+  "gitHead": "def49813c11febf54299c9541b0eeb243fb4e495"
 }

package/src/patterns/matcher.test.ts

@@ -92,6 +92,7 @@ describe('matcher', () => {
   describe('findStringRefs', () => {
     it('should find stringRefs assignments in source code', () => {
       const code = `
+    import React from 'react';
     class MyComponent extends React.Component {
       componentDidMount() {
         this.refs.input.focus();
@@ -111,6 +112,7 @@ describe('matcher', () => {
 
     it('should find bracket notation refs access', () => {
       const code = `
+      import React from 'react';
       class MyComponent extends React.Component {
         componentDidMount() {
           this.refs['input'].focus();
@@ -127,6 +129,35 @@ describe('matcher', () => {
       expect(matches[0].pattern).toBe('stringRefs');
       expect(matches[0].matched).toContain('this.refs');
     });
+
+    it('should not match this.refs in files without a React import', () => {
+      const code = `
+      class ComponentRegistry {
+        getRef() {
+          return this.refs.primary;
+        }
+      }
+    `;
+      const ast = parseFile(code, 'test.js');
+      const matches = findStringRefs(ast, code);
+
+      expect(matches).toHaveLength(0);
+    });
+
+    it('should not match bare this.refs access without property access', () => {
+      const code = `
+      import React from 'react';
+      class MyComponent extends React.Component {
+        getAllRefs() {
+          return this.refs;
+        }
+      }
+    `;
+      const ast = parseFile(code, 'test.js');
+      const matches = findStringRefs(ast, code);
+
+      expect(matches).toHaveLength(0);
+    });
   });
 
   describe('findFindDOMNode', () => {

package/src/patterns/matcher.ts

@@ -102,14 +102,21 @@ export function findJsxRuntimeImports(ast: TSESTree.Program, code: string): Patt
 
 export function findStringRefs(ast: TSESTree.Program, code: string): PatternMatch[] {
   const matches: PatternMatch[] = [];
+  const imports = trackImportsFromPackage(ast, 'react');
+
+  const hasReactImport = imports.defaultImports.size > 0 || imports.namedImports.size > 0;
+  if (!hasReactImport) {
+    return matches;
+  }
 
   walk(ast, (node) => {
     if (
       node &&
       node.type === 'MemberExpression' &&
-      node.object.type === 'ThisExpression' &&
-      node.property.type === 'Identifier' &&
-      node.property.name === 'refs'
+      node.object?.type === 'MemberExpression' &&
+      node.object.object?.type === 'ThisExpression' &&
+      node.object.property?.type === 'Identifier' &&
+      node.object.property.name === 'refs'
     ) {
       matches.push(createPatternMatch(node, 'stringRefs', code));
     }