@grafana/create-plugin 3.3.0-canary.710.2bb43c7.0 → 3.3.0

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+# v3.3.0 (Fri Feb 02 2024)
+
+#### 🚀 Enhancement
+
+- Create-plugin: Check if inside a plugin directory [#706](https://github.com/grafana/plugin-tools/pull/706) ([@leventebalogh](https://github.com/leventebalogh))
+
+#### Authors: 1
+
+- Levente Balogh ([@leventebalogh](https://github.com/leventebalogh))
+
+---
+
 # v3.2.0 (Thu Feb 01 2024)
 
 #### 🚀 Enhancement

package/dist/commands/generate.command.js

@@ -57,8 +57,6 @@ function getTemplateData(answers) {
         isNPM: packageManagerName === 'npm',
         version: currentVersion,
         bundleGrafanaUI: features.bundleGrafanaUI,
-        useReactRouterV6: features.useReactRouterV6 && pluginType === PLUGIN_TYPES.app,
-        reactRouterVersion: features.useReactRouterV6 && pluginType === PLUGIN_TYPES.app ? '6.22.0' : '5.2.0',
     };
     return templateData;
 }

package/dist/utils/utils.config.js

@@ -51,7 +51,6 @@ function readRCFileSync(path) {
 }
 function createFeatureFlags(flags) {
     return {
-        useReactRouterV6: true,
         bundleGrafanaUI: false,
         ...flags,
     };

package/dist/utils/utils.templates.js

@@ -5,7 +5,7 @@ import mkdirp from 'mkdirp';
 import { filterOutCommonFiles, isFile, isFileStartingWith } from './utils.files.js';
 import { renderHandlebarsTemplate } from './utils.handlebars.js';
 import { getPluginJson } from './utils.plugin.js';
-import { TEMPLATE_PATHS, EXPORT_PATH_PREFIX, EXTRA_TEMPLATE_VARIABLES, PLUGIN_TYPES } from '../constants.js';
+import { TEMPLATE_PATHS, EXPORT_PATH_PREFIX, EXTRA_TEMPLATE_VARIABLES } from '../constants.js';
 import { getPackageManagerWithFallback } from './utils.packageManager.js';
 import { getExportFileName } from '../utils/utils.files.js';
 import { getVersion } from './utils.version.js';
@@ -69,7 +69,5 @@ export function getTemplateData() {
         packageManagerVersion,
         version: currentVersion,
         bundleGrafanaUI: features.bundleGrafanaUI,
-        useReactRouterV6: features.useReactRouterV6 && pluginJson.type === PLUGIN_TYPES.app,
-        reactRouterVersion: features.useReactRouterV6 ? '6.22.0' : '5.2.0',
     };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@grafana/create-plugin",
-  "version": "3.3.0-canary.710.2bb43c7.0",
+  "version": "3.3.0",
   "repository": {
     "directory": "packages/create-plugin",
     "url": "https://github.com/grafana/plugin-tools"
@@ -86,5 +86,5 @@
   "engines": {
     "node": ">=20"
   },
-  "gitHead": "2bb43c7ea455eec1f96590c21280ca41ff1586a9"
+  "gitHead": "46c7ec2fd92c02ad7089085a330f63fc61d27d89"
 }

package/src/commands/generate.command.ts

@@ -69,8 +69,6 @@ function getTemplateData(answers: CliArgs) {
     isNPM: packageManagerName === 'npm',
     version: currentVersion,
     bundleGrafanaUI: features.bundleGrafanaUI,
-    useReactRouterV6: features.useReactRouterV6 && pluginType === PLUGIN_TYPES.app,
-    reactRouterVersion: features.useReactRouterV6 && pluginType === PLUGIN_TYPES.app ? '6.22.0' : '5.2.0',
   };
 
   return templateData;

package/src/commands/types.ts

@@ -19,6 +19,4 @@ export type TemplateData = {
   isNPM: boolean;
   version: string;
   bundleGrafanaUI: boolean;
-  useReactRouterV6: boolean;
-  reactRouterVersion: string;
 };

package/src/utils/utils.config.ts

@@ -4,10 +4,6 @@ import { getVersion } from './utils.version.js';
 
 type FeatureFlags = {
   bundleGrafanaUI: boolean;
-
-  // If set to true, the plugin will be scaffolded with React Router v6. Defaults to true.
-  // (Attention! We always scaffold new projects with React Router v6, so if you are changing this to `false` manually you will need to make changes to the React code as well.)
-  useReactRouterV6: boolean;
 };
 
 type CreatePluginConfig = UserConfig & {
@@ -70,7 +66,6 @@ function readRCFileSync(path: string): CreatePluginConfig | undefined {
 
 function createFeatureFlags(flags?: FeatureFlags): FeatureFlags {
   return {
-    useReactRouterV6: true,
     bundleGrafanaUI: false,
     ...flags,
   };

package/src/utils/utils.templates.ts

@@ -5,7 +5,7 @@ import mkdirp from 'mkdirp';
 import { filterOutCommonFiles, isFile, isFileStartingWith } from './utils.files.js';
 import { renderHandlebarsTemplate } from './utils.handlebars.js';
 import { getPluginJson } from './utils.plugin.js';
-import { TEMPLATE_PATHS, EXPORT_PATH_PREFIX, EXTRA_TEMPLATE_VARIABLES, PLUGIN_TYPES } from '../constants.js';
+import { TEMPLATE_PATHS, EXPORT_PATH_PREFIX, EXTRA_TEMPLATE_VARIABLES } from '../constants.js';
 import { getPackageManagerWithFallback } from './utils.packageManager.js';
 import { getExportFileName } from '../utils/utils.files.js';
 import { getVersion } from './utils.version.js';
@@ -97,7 +97,5 @@ export function getTemplateData() {
     packageManagerVersion,
     version: currentVersion,
     bundleGrafanaUI: features.bundleGrafanaUI,
-    useReactRouterV6: features.useReactRouterV6 && pluginJson.type === PLUGIN_TYPES.app,
-    reactRouterVersion: features.useReactRouterV6 ? '6.22.0' : '5.2.0',
   };
 }

package/templates/app/src/components/App/App.tsx

@@ -1,20 +1,21 @@
 import React from 'react';
-import { Route, Routes } from 'react-router-dom';
+import { Route, Switch } from 'react-router-dom';
 import { AppRootProps } from '@grafana/data';
 import { ROUTES } from '../../constants';
 import { PageFour, PageOne, PageThree, PageTwo } from '../../pages';
+import { prefixRoute } from '../../utils/utils.routing';
 
 export function App(props: AppRootProps) {
   return (
-      <Routes>
-        <Route path={ROUTES.Two} element={<PageTwo />} />
-        <Route path={`${ROUTES.Three}/:id?`} element={<PageThree />} />
+      <Switch>
+        <Route exact path={prefixRoute(ROUTES.Two)} component={PageTwo} />
+        <Route exact path={prefixRoute(`${ROUTES.Three}/:id?`)} component={PageThree} />
 
         {/* Full-width page (this page will have no side navigation) */}
-        <Route path={ROUTES.Four} element={<PageFour />} />
+        <Route exact path={prefixRoute(ROUTES.Four)} component={PageFour} />
 
         {/* Default page */}
-        <Route path="*" element={<PageOne />} />
-      </Routes>
+        <Route component={PageOne} />
+      </Switch>
   );
 }

package/templates/common/.config/webpack/webpack.config.ts

@@ -49,8 +49,8 @@ const config = async (env): Promise<Configuration> => {
       'react-redux',
       'redux',
       'rxjs',
-      'react-router',{{#unless useReactRouterV6}}
-      'react-router-dom',{{/unless}}
+      'react-router',
+      'react-router-dom',
       'd3',
       'angular',{{#unless bundleGrafanaUI}}
       '@grafana/ui',{{/unless}}

package/templates/common/.cprc.json

@@ -2,7 +2,5 @@
   "features": {
     {{#if bundleGrafanaUI}}
     "bundleGrafanaUI": true{{/if}}
-    {{#if useReactRouterV6}}
-    "useReactRouterV6": true{{/if}}
   }
 }

package/templates/common/_package.json

@@ -30,8 +30,8 @@
     "@testing-library/react": "14.0.0",
     "@types/jest": "^29.5.0",
     "@types/lodash": "^4.14.194",
-    "@types/node": "^20.8.7",{{#unless useReactRouterV6}}
-    "@types/react-router-dom": "^{{ reactRouterVersion }}",{{/unless}}
+    "@types/node": "^20.8.7",{{#if isAppType}}
+    "@types/react-router-dom": "^5.3.3",{{/if}}
     "@types/testing-library__jest-dom": "5.14.8",
     "copy-webpack-plugin": "^11.0.0",
     "css-loader": "^6.7.3",
@@ -67,7 +67,7 @@
     "@grafana/scenes": "^1.28.0",{{/if_eq}}
     "react": "18.2.0",
     "react-dom": "18.2.0",{{#if isAppType}}
-    "react-router-dom": "^{{ reactRouterVersion }}",
+    "react-router-dom": "5.3.3",
     "rxjs": "7.8.0",{{/if}}
     "tslib": "2.5.3"
   },