@gperezmz/bb-plugin-thread-glance 0.1.3 → 0.2.1

package/shared/preferences.ts

@@ -9,7 +9,6 @@ const idListSchema = z.array(idSchema).max(MAX_ITEMS);
 export const organizationModeSchema = z.enum(["project", "chronological", "machine"]);
 export const sortFieldSchema = z.enum(["updated", "created", "alpha", "none"]);
 export const sortDirectionSchema = z.enum(["default", "ascending", "descending"]);
-export const nestingSchema = z.enum(["folded", "tree"]);
 export const lifecycleSchema = z.enum(["active", "archived"]);
 export const harnessIconSchema = z.enum(["muted", "colour", "hidden"]);
 export const childAttentionSchema = z.enum(["blocked", "everything"]);
@@ -22,7 +21,6 @@ const hiddenGroupsSchema = z
 export type OrganizationMode = z.infer<typeof organizationModeSchema>;
 export type SortField = z.infer<typeof sortFieldSchema>;
 export type SortDirection = z.infer<typeof sortDirectionSchema>;
-export type Nesting = z.infer<typeof nestingSchema>;
 export type Lifecycle = z.infer<typeof lifecycleSchema>;
 export type HarnessIcon = z.infer<typeof harnessIconSchema>;
 export type ChildAttention = z.infer<typeof childAttentionSchema>;
@@ -50,7 +48,7 @@ export const PREFERENCES = {
       .max(2)
       .refine((values) => new Set(values).size === values.length, "Lifecycles must be unique"),
     ["active"] as Lifecycle[],
-    "Thread lifecycles shown: active, archived, or both. At least one is required.",
+    "Threads shown: [\"active\"], [\"archived\"] or both. At least one is required.",
   ),
   organizationMode: define(
     organizationModeSchema,
@@ -60,7 +58,7 @@ export const PREFERENCES = {
   environmentGrouping: define(
     z.boolean(),
     false,
-    "Whether sibling threads sharing a worktree environment fold into a folder row.",
+    "Worktrees as folders: whether sibling threads sharing a worktree environment fold into a folder row.",
   ),
   chronologicalSort: define(
     sortFieldSchema,
@@ -70,7 +68,7 @@ export const PREFERENCES = {
   sortDirection: define(
     sortDirectionSchema,
     "default" as SortDirection,
-    "Sort direction; default keeps the field's natural direction.",
+    "Sort direction: ascending or descending. A saved default reads as the field's own direction (descending for dates, ascending for alpha).",
   ),
   sectionOrder: define(
     idListSchema,
@@ -109,20 +107,15 @@ export const PREFERENCES = {
     [] as string[],
     "Environment ids whose folder row is collapsed.",
   ),
-  nesting: define(
-    nestingSchema,
-    "folded" as Nesting,
-    "Child thread nesting: folded (one flat level behind a chip) or tree (bb's tree).",
-  ),
   foldOlder: define(
     z.boolean(),
     true,
-    "Whether quiet roots past the 5 most recent fold behind an N older row.",
+    "Collapse older threads: whether each group's quiet roots past its 5 newest fold behind an N older row.",
   ),
   workingFirst: define(
     z.boolean(),
     false,
-    "Whether working threads sort first under Updated, as bb's list does.",
+    "Working threads first: whether working threads sort first under Updated, as bb's list does.",
   ),
   expandedOlder: define(
     idListSchema,
@@ -132,18 +125,13 @@ export const PREFERENCES = {
   expandedChildren: define(
     idListSchema,
     [] as string[],
-    "Parent thread ids the user expanded (folded nesting).",
-  ),
-  collapsedChildren: define(
-    idListSchema,
-    [] as string[],
-    "Parent thread ids the user collapsed (tree nesting).",
+    "Parent thread ids whose chip the user opened.",
   ),
   showPullRequests: define(z.boolean(), true, "Whether rows show a pull request badge."),
   childAttention: define(
     childAttentionSchema,
     "blocked" as ChildAttention,
-    "Which child threads count under Needs attention, in badges and counters, and stay out of a family's fold along with running children: blocked (waiting on you, offline, or an orphaned failure) or everything (also every failed and unread child).",
+    "Needs you counts every child: blocked counts a child thread that waits on you, is offline or has an orphaned failure; everything also counts every failed or finished-unread child. The same children stay out of a family's older fold, as running ones do.",
   ),
   harnessIcon: define(
     harnessIconSchema,
@@ -207,7 +195,7 @@ export function coercePreferences(raw: unknown): Preferences {
 /**
  * Maps bb's own thread-list preferences onto ours for the first-run import
  *. `environmentGrouping: "auto"` becomes off, `collapsedThreads` is
- * skipped because it means the inverse of folded nesting, and invalid values
+ * skipped because it means the inverse of `expandedChildren`, and invalid values
  * are skipped. Returns only the keys that parsed.
  */
 export function mapBbPreferences(raw: unknown): Partial<Preferences> {
@@ -224,9 +212,8 @@ export function mapBbPreferences(raw: unknown): Partial<Preferences> {
   return mapped as Partial<Preferences>;
 }
 
-/** Per-client preferences, kept in localStorage only. */
+/** Per-client preferences, kept in localStorage only. A saved `filter` from before Needs you is dropped. */
 export const clientPreferencesSchema = z.object({
-  filter: z.enum(["all", "attention"]).catch("all"),
   density: z.enum(["compact", "comfortable"]).catch("compact"),
 });
 export type ClientPreferences = z.infer<typeof clientPreferencesSchema>;
@@ -237,5 +224,5 @@ export const BB_PREFERENCES_MIRROR_STORAGE_KEY = "bb.thread-list.preferences.v1"
 
 export function parseClientPreferences(raw: unknown): ClientPreferences {
   const result = clientPreferencesSchema.safeParse(raw ?? {});
-  return result.success ? result.data : { filter: "all", density: "compact" };
+  return result.success ? result.data : { density: "compact" };
 }

package/skills/thread-glance/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: thread-glance
-description: "Reads and changes the Thread Glance sidebar's layout preferences with `bb thread-glance prefs`: grouping, sort, group order, hidden and collapsed groups, child-thread nesting and folding, harness icons. Use when asked to change how the Thread Glance sidebar lists, groups, sorts, hides, collapses or nests threads or draws their harness icon."
+description: "Reads and changes the Thread Glance sidebar's layout preferences with `bb thread-glance prefs`: grouping, sort, group order, hidden and collapsed groups, child-thread folding, which child threads Needs you counts, harness icons. Use when asked to change how the Thread Glance sidebar lists, groups, sorts, hides, collapses or folds threads or draws their harness icon."
 ---
 
 # Thread Glance preferences
@@ -19,7 +19,7 @@ bb thread-glance prefs reset <key> [--json]
 `set` takes JSON, and a bare word is read as a string:
 
 ```sh
-bb thread-glance prefs set nesting tree
+bb thread-glance prefs set sortDirection ascending
 bb thread-glance prefs set threadLifecycles '["active","archived"]'
 bb thread-glance prefs set hiddenGroups '["threads","project:<project-id>"]'
 ```
@@ -42,7 +42,7 @@ and `bb environment list`; a thread id is a `thr_…` id.
 | `organizationMode` | `project`, `chronological` (custom sections) or `machine` | `project` |
 | `environmentGrouping` | `true` folds sibling threads sharing a worktree into a folder row | `false` |
 | `chronologicalSort` | `updated`, `created` or `alpha`; `none` reads as `updated` | `updated` |
-| `sortDirection` | `default` (the field's own direction), `ascending`, `descending` | `default` |
+| `sortDirection` | `ascending` or `descending`; a saved `default` reads as the field's own direction (descending for dates, ascending for `alpha`) | `default` |
 | `sectionOrder` | Top-level order by project: `pinned`, `projects`, `threads` | all three |
 | `manualSectionOrder` | Top-level order chronologically: `pinned`, `sections`, `threads` | all three |
 | `machineSectionOrder` | Top-level order by machine: `pinned`, `machines`, `threads` | all three |
@@ -52,18 +52,17 @@ and `bb environment list`; a thread id is a `thr_…` id.
 | `collapsedThreadSections` | Custom section keys, `section:<id>` | `[]` |
 | `collapsedMachines` | Machine ids | `[]` |
 | `collapsedEnvironments` | Environment ids of collapsed folder rows | `[]` |
-| `nesting` | `folded`: children one level deep behind a chip; `tree`: bb's full tree | `folded` |
-| `foldOlder` | `true` folds quiet top-level threads past the 5 most recent behind an "N older" row | `true` |
+| `foldOlder` | Collapse older threads: `true` folds a group's quiet top-level threads past its 5 newest behind an "N older" row | `true` |
 | `workingFirst` | `true` sorts working threads first under `updated` | `false` |
 | `expandedOlder` | Group ids and parent thread ids whose "N older" or "N more child threads" row is open | `[]` |
-| `expandedChildren` | Parent thread ids whose children are shown (`folded` nesting) | `[]` |
-| `collapsedChildren` | Parent thread ids whose children are hidden (`tree` nesting) | `[]` |
+| `expandedChildren` | Parent thread ids whose chip is open | `[]` |
 | `showPullRequests` | `true` shows a pull request badge on rows | `true` |
-| `childAttention` | Which child threads count as needing attention (filter, badge, counters, ordering, auto-reveal) and stay out of a family's "N more child threads" fold alongside running ones: `blocked` counts a child that waits on you, is offline, or failed with its manager idle; `everything` also counts every failed or unread child | `blocked` |
+| `childAttention` | Needs you counts every child. Which child threads need you (the Needs you section, counters, auto-reveal) and stay out of a family's "N more child threads" fold alongside running ones: `blocked` counts a child that waits on you, is offline, or has an orphaned failure (its parent thread idle since); `everything` also counts every failed or unread child | `blocked` |
 | `harnessIcon` | How rows draw the harness logo: `muted` (monochrome), `colour` (the provider's tint) or `hidden` | `muted` |
 
-The filter (all or needs attention) and the row density are kept per
-browser, and the CLI cannot read or change them.
+Row density is kept per browser, and the CLI cannot read or change it. No
+preference filters the list: families that need you always move into the
+Needs you section.
 
 Sections themselves and the section a thread is in are bb core state: use
 `bb thread section` and `bb thread update`.

package/features/thread-list/model/attention.ts

@@ -1,89 +0,0 @@
-// What counts as "needs attention", thread by thread. The filter, its
-// badge, the header counters, the urgency order and auto-reveal all read the
-// set this builds. Pure.
-import type { PluginSidebarThread } from "@get-bb/plugin-sdk/app";
-import type { ChildAttention } from "@/shared/preferences";
-import { type Flag, type StateKind, type ThreadState } from "./state";
-
-/** The flags that count for a thread nobody manages. Working is not one. */
-export const ROOT_ATTENTION: ReadonlySet<Flag> = new Set<Flag>([
-  "needs-you",
-  "unread-failed",
-  "queue-failed",
-  "offline",
-  "unread",
-]);
-
-/** States in which a manager is busy and may still deal with a failed child. */
-const BUSY: ReadonlySet<StateKind> = new Set<StateKind>(["working", "background", "queued", "scheduled"]);
-
-export interface Manager {
-  thread: Pick<PluginSidebarThread, "latestAttentionAt">;
-  state: Pick<ThreadState, "kind">;
-  /** When the plugin server last saw the manager finish a turn, if it did. */
-  finishedAt?: number;
-}
-
-/** A manager is idle when it is not working, setting up, running background work or holding a queued message. */
-export function isManagerIdle(manager: Manager): boolean {
-  return !BUSY.has(manager.state.kind);
-}
-
-/** When the thread's failure happened: an error bumps `latestAttentionAt`, a failed queue only `updatedAt`. */
-export function failureTime(
-  thread: Pick<PluginSidebarThread, "latestAttentionAt" | "updatedAt">,
-  flags: ReadonlySet<Flag>,
-): number {
-  let at = 0;
-  if (flags.has("unread-failed")) at = Math.max(at, thread.latestAttentionAt);
-  if (flags.has("queue-failed")) at = Math.max(at, thread.updatedAt);
-  return at;
-}
-
-/**
- * A failure nobody is dealing with: the manager is idle and has not run or
- * finished since the child failed. A busy manager, or one that finished after
- * the failure, is taken to know about it. The manager's own clock is its last
- * finish (`finishedAt`, or `latestAttentionAt` when it failed): `updatedAt`
- * also moves when someone merely opens or renames it.
- */
-export function isOrphanedFailure(
-  thread: Pick<PluginSidebarThread, "latestAttentionAt" | "updatedAt">,
-  flags: ReadonlySet<Flag>,
-  manager: Manager,
-): boolean {
-  if (!flags.has("unread-failed") && !flags.has("queue-failed")) return false;
-  if (!isManagerIdle(manager)) return false;
-  const managerActiveAt = Math.max(manager.thread.latestAttentionAt, manager.finishedAt ?? 0);
-  return managerActiveAt <= failureTime(thread, flags);
-}
-
-/**
- * The flags of one thread that count towards Needs attention. A root keeps
- * its own. A child counts when it waits on you or is offline, or when it
- * failed with an idle manager; a finished-unread child never does. With
- * `everything`, a child counts like a root.
- */
-export function attentionFlagsOf(
-  flags: ReadonlySet<Flag>,
-  options: { isRoot: boolean; mode: ChildAttention; orphaned: boolean },
-): Set<Flag> {
-  const kept = new Set<Flag>();
-  if (options.isRoot || options.mode === "everything") {
-    for (const flag of flags) if (ROOT_ATTENTION.has(flag)) kept.add(flag);
-    return kept;
-  }
-  if (flags.has("needs-you")) kept.add("needs-you");
-  if (flags.has("offline")) kept.add("offline");
-  if (options.orphaned) {
-    if (flags.has("unread-failed")) kept.add("unread-failed");
-    if (flags.has("queue-failed")) kept.add("queue-failed");
-  }
-  return kept;
-}
-
-/** Whether a set of attention flags is worth an auto-reveal: it waits on you or failed. */
-export function revealsOn(attention: ReadonlySet<Flag>, isRoot: boolean): boolean {
-  if (attention.has("needs-you") || attention.has("unread-failed")) return true;
-  return !isRoot && attention.has("queue-failed");
-}