@gpc-cli/core 0.9.65 → 0.9.67

package/dist/index.js

@@ -10,6 +10,7 @@ import {
   diffReleases,
   fetchReleaseNotes,
   findBundle,
+  formatSize,
   getReleasesStatus,
   isVersionedNotesDir,
   listBundles,
@@ -27,7 +28,7 @@ import {
   validateUploadFile,
   waitForBundle,
   waitForBundleProcessing
-} from "./chunk-4TBNOCVU.js";
+} from "./chunk-4KDWLQB3.js";
 
 // src/output.ts
 import process2 from "process";
@@ -404,7 +405,7 @@ var PluginManager = class {
     if (!isTrusted && manifest?.permissions) {
       validatePermissions(manifest.permissions);
     }
-    const hooks = createHooks(
+    const allHooks = createHooks(
       this.beforeHandlers,
       this.afterHandlers,
       this.errorHandlers,
@@ -412,7 +413,14 @@ var PluginManager = class {
       this.afterResponseHandlers,
       this.registeredCommands
     );
-    await plugin.register(hooks);
+    const hooks = isTrusted || !manifest?.permissions ? allHooks : createRestrictedHooks(allHooks, new Set(manifest.permissions));
+    try {
+      await plugin.register(hooks);
+    } catch (err) {
+      const msg = err instanceof Error ? err.message : String(err);
+      console.warn(`[gpc] Plugin "${plugin.name}" failed to register: ${msg}`);
+      return;
+    }
     this.plugins.push({
       name: plugin.name,
       version: plugin.version,
@@ -508,6 +516,33 @@ function createHooks(beforeHandlers, afterHandlers, errorHandlers, beforeRequest
     }
   };
 }
+var HOOK_PERMISSIONS = {
+  beforeCommand: "hooks:beforeCommand",
+  afterCommand: "hooks:afterCommand",
+  onError: "hooks:onError",
+  beforeRequest: "hooks:beforeRequest",
+  afterResponse: "hooks:afterResponse",
+  registerCommands: "commands:register"
+};
+function createRestrictedHooks(inner, permissions) {
+  function gate(key) {
+    const requiredPerm = HOOK_PERMISSIONS[key];
+    if (permissions.has(requiredPerm)) {
+      return inner[key];
+    }
+    return (() => {
+      console.warn(`[gpc] Plugin lacks permission "${requiredPerm}" for hook "${key}"`);
+    });
+  }
+  return {
+    beforeCommand: gate("beforeCommand"),
+    afterCommand: gate("afterCommand"),
+    onError: gate("onError"),
+    beforeRequest: gate("beforeRequest"),
+    afterResponse: gate("afterResponse"),
+    registerCommands: gate("registerCommands")
+  };
+}
 var VALID_PERMISSIONS = /* @__PURE__ */ new Set([
   "read:config",
   "write:config",
@@ -730,11 +765,6 @@ async function validateImage(filePath, imageType) {
   }
   return { valid: errors.length === 0, errors, warnings };
 }
-function formatSize(bytes) {
-  if (bytes >= 1024 * 1024) return `${(bytes / (1024 * 1024)).toFixed(1)} MB`;
-  if (bytes >= 1024) return `${(bytes / 1024).toFixed(1)} KB`;
-  return `${bytes} B`;
-}
 
 // src/utils/fastlane.ts
 import { readFile, writeFile, mkdir, readdir, stat as stat2 } from "fs/promises";
@@ -2804,7 +2834,10 @@ async function getAppStatus(client, reporting, packageName, options = {}) {
     sections.has("vitals") ? queryVitalWithTrend(reporting, packageName, "slowRenderingRateMetricSet", days) : Promise.resolve(SKIPPED_VITAL),
     sections.has("reviews") ? listReviews(client, packageName, { maxResults: 500 }) : Promise.resolve([])
   ]);
+  const sectionErrors = [];
   const rawReleases = releasesResult.status === "fulfilled" ? releasesResult.value : [];
+  if (releasesResult.status === "rejected")
+    sectionErrors.push(`releases: ${String(releasesResult.reason)}`);
   const releases = rawReleases.map((r) => ({
     track: r.track,
     versionCode: r.versionCodes[r.versionCodes.length - 1] ?? "\u2014",
@@ -2812,10 +2845,20 @@ async function getAppStatus(client, reporting, packageName, options = {}) {
     userFraction: r.userFraction ?? null
   }));
   const crashes = crashesResult.status === "fulfilled" ? crashesResult.value : SKIPPED_VITAL;
+  if (crashesResult.status === "rejected")
+    sectionErrors.push(`vitals/crashes: ${String(crashesResult.reason)}`);
   const anr = anrResult.status === "fulfilled" ? anrResult.value : SKIPPED_VITAL;
+  if (anrResult.status === "rejected")
+    sectionErrors.push(`vitals/anr: ${String(anrResult.reason)}`);
   const slowStart = slowStartResult.status === "fulfilled" ? slowStartResult.value : SKIPPED_VITAL;
+  if (slowStartResult.status === "rejected")
+    sectionErrors.push(`vitals/slowStarts: ${String(slowStartResult.reason)}`);
   const slowRender = slowRenderResult.status === "fulfilled" ? slowRenderResult.value : SKIPPED_VITAL;
+  if (slowRenderResult.status === "rejected")
+    sectionErrors.push(`vitals/slowRender: ${String(slowRenderResult.reason)}`);
   const rawReviews = reviewsResult.status === "fulfilled" ? reviewsResult.value : [];
+  if (reviewsResult.status === "rejected")
+    sectionErrors.push(`reviews: ${String(reviewsResult.reason)}`);
   const reviews = computeReviewSentiment(rawReviews, reviewDays);
   return {
     packageName,
@@ -2845,7 +2888,8 @@ async function getAppStatus(client, reporting, packageName, options = {}) {
         slowRender.trend
       )
     },
-    reviews
+    reviews,
+    ...sectionErrors.length > 0 ? { errors: sectionErrors } : {}
   };
 }
 function vitalIndicator(metric) {
@@ -3209,7 +3253,12 @@ async function dispatchWebhook(url, event) {
     signal: AbortSignal.timeout(1e4)
   });
   if (!response.ok) {
-    throw new Error(`Webhook returned ${response.status}`);
+    throw new GpcError(
+      `Webhook returned ${response.status}`,
+      "WATCH_WEBHOOK_FAILED",
+      5,
+      `The webhook endpoint returned HTTP ${response.status}. Check the URL and server status.`
+    );
   }
 }
 async function handleBreach(event, config, client) {
@@ -3226,7 +3275,7 @@ async function handleBreach(event, config, client) {
       }
       case "halt": {
         try {
-          const { updateRollout: updateRollout2 } = await import("./releases-XF5MYFQD.js");
+          const { updateRollout: updateRollout2 } = await import("./releases-OAKWPEAC.js");
           await updateRollout2(client, config.packageName, config.track, "halt");
           halted = true;
         } catch {
@@ -3271,8 +3320,13 @@ async function runWatch(client, reporting, config, callbacks) {
       round++;
       const rollout = await fetchRollout(client, config.packageName, config.track);
       const vitals = {};
-      for (const metric of config.metrics) {
-        const value = await queryWatchMetric(reporting, config.packageName, metric);
+      const metricResults = await Promise.all(
+        config.metrics.map(async (metric) => {
+          const value = await queryWatchMetric(reporting, config.packageName, metric);
+          return { metric, value };
+        })
+      );
+      for (const { metric, value } of metricResults) {
         const threshold = config.thresholds[metric];
         const result = threshold !== void 0 ? checkThreshold(value, threshold) : { breached: false };
         vitals[metric] = {
@@ -3293,14 +3347,12 @@ async function runWatch(client, reporting, config, callbacks) {
       if (breaches.length > 0) {
         breachCount++;
         const stateChanged = await trackBreachState(config.packageName, true);
-        if (stateChanged) {
-          const didHalt = await handleBreach(event, config, client);
-          if (didHalt) {
-            event.halted = true;
-            halted = true;
-          }
-          await callbacks.onBreach(event);
+        const didHalt = stateChanged ? await handleBreach(event, config, client) : false;
+        if (didHalt) {
+          event.halted = true;
+          halted = true;
         }
+        await callbacks.onBreach(event);
         callbacks.onEvent(event);
       } else {
         await trackBreachState(config.packageName, false);
@@ -3744,7 +3796,7 @@ async function getUser(client, developerId, email) {
 }
 async function inviteUser(client, developerId, email, permissions, grants) {
   const user = { email };
-  if (permissions) user.developerAccountPermission = permissions;
+  if (permissions) user.developerAccountPermissions = permissions;
   if (grants) user.grants = grants;
   return client.create(developerId, user);
 }
@@ -3752,8 +3804,8 @@ async function updateUser(client, developerId, userId, permissions, grants) {
   const updates = {};
   const masks = [];
   if (permissions) {
-    updates.developerAccountPermission = permissions;
-    masks.push("developerAccountPermission");
+    updates.developerAccountPermissions = permissions;
+    masks.push("developerAccountPermissions");
   }
   if (grants) {
     updates.grants = grants;
@@ -4802,7 +4854,7 @@ jobs:
         run: ./gradlew bundleRelease
 
       - name: Install GPC
-        run: npm install -g @gpc-cli/cli
+        run: npm install -g @gpc-cli/cli --ignore-scripts
 
       - name: Preflight compliance check
         run: gpc preflight app/build/outputs/bundle/release/app-release.aab --fail-on error
@@ -4841,14 +4893,14 @@ preflight:
   stage: preflight
   image: node:20
   script:
-    - npm install -g @gpc-cli/cli
+    - npm install -g @gpc-cli/cli --ignore-scripts
     - gpc preflight app/build/outputs/bundle/release/app-release.aab --fail-on error --json
 
 release:
   stage: release
   image: node:20
   script:
-    - npm install -g @gpc-cli/cli
+    - npm install -g @gpc-cli/cli --ignore-scripts
     - gpc releases upload app/build/outputs/bundle/release/app-release.aab --track internal
   only:
     - tags
@@ -4864,7 +4916,7 @@ var SEVERITY_ORDER = {
 };
 var DEFAULT_PREFLIGHT_CONFIG = {
   failOn: "error",
-  targetSdkMinimum: 35,
+  targetSdkMinimum: 36,
   maxDownloadSizeMb: 150,
   allowedPermissions: [],
   disabledRules: [],
@@ -5050,7 +5102,7 @@ function extractManifestData(manifest) {
   const appElements = getChildren(manifest, "application");
   const app = appElements[0];
   const debuggable = app ? getBoolByName(app.attribute || [], "debuggable", false) : false;
-  const testOnly = getBoolByName(attrs, "testOnly", false);
+  const testOnly = app ? getBoolByName(app.attribute || [], "testOnly", false) : false;
   const usesCleartextTraffic = app ? getBoolByName(app.attribute || [], "usesCleartextTraffic", true) : true;
   const extractNativeLibs = app ? getBoolByName(app.attribute || [], "extractNativeLibs", true) : true;
   const pageSizeCompat = app ? getBoolByName(app.attribute || [], "pageSizeCompat", false) : false;
@@ -5110,8 +5162,8 @@ function extractComponents(appElement, tagName) {
 // src/preflight/aab-reader.ts
 var AAB_MANIFEST_PATH = "base/manifest/AndroidManifest.xml";
 var APK_MANIFEST_PATH = "AndroidManifest.xml";
-var SO_HEADER_BYTES = 256;
-var SO_PATH_RE = /\/lib\/[^/]+\/[^/]+\.so$/;
+var SO_HEADER_BYTES = 4096;
+var SO_PATH_RE = /(?:^|\/)lib\/[^/]+\/[^/]+\.so$/;
 function detectManifestPath(filePath) {
   return filePath.toLowerCase().endsWith(".apk") ? APK_MANIFEST_PATH : AAB_MANIFEST_PATH;
 }
@@ -6506,16 +6558,35 @@ async function runPreflight(options) {
   if (options.metadataDir) ctx.metadataDir = options.metadataDir;
   if (options.sourceDir) ctx.sourceDir = options.sourceDir;
   const requestedNames = options.scanners ? new Set(options.scanners.map((s) => s.toLowerCase())) : null;
-  const applicableScanners = ALL_SCANNERS.filter((scanner) => {
-    if (requestedNames && !requestedNames.has(scanner.name)) return false;
+  const applicableScanners = [];
+  const skippedScanners = [];
+  for (const scanner of ALL_SCANNERS) {
+    if (requestedNames && !requestedNames.has(scanner.name)) continue;
+    let skip = false;
     for (const req of scanner.requires) {
-      if (req === "manifest" && !ctx.manifest) return false;
-      if (req === "zipEntries" && !ctx.zipEntries) return false;
-      if (req === "metadataDir" && !ctx.metadataDir) return false;
-      if (req === "sourceDir" && !ctx.sourceDir) return false;
+      if (req === "manifest" && !ctx.manifest) {
+        skip = true;
+        break;
+      }
+      if (req === "zipEntries" && !ctx.zipEntries) {
+        skip = true;
+        break;
+      }
+      if (req === "metadataDir" && !ctx.metadataDir) {
+        skip = true;
+        break;
+      }
+      if (req === "sourceDir" && !ctx.sourceDir) {
+        skip = true;
+        break;
+      }
     }
-    return true;
-  });
+    if (skip) {
+      skippedScanners.push(scanner.name);
+    } else {
+      applicableScanners.push(scanner);
+    }
+  }
   const settled = await Promise.allSettled(applicableScanners.map((scanner) => scanner.scan(ctx)));
   let findings = [...earlyFindings];
   for (let i = 0; i < settled.length; i++) {
@@ -6551,6 +6622,7 @@ async function runPreflight(options) {
   const passed = !findings.some((f) => SEVERITY_ORDER[f.severity] >= failThreshold);
   return {
     scanners: applicableScanners.map((s) => s.name),
+    ...skippedScanners.length > 0 ? { skippedScanners } : {},
     findings,
     summary,
     passed,
@@ -6812,12 +6884,17 @@ async function sendWebhook(config, payload, target) {
   try {
     const targets = target ? [target] : Object.keys(FORMATTERS);
     const promises = [];
+    const safePayload = {
+      ...payload,
+      error: payload.error ? String(redactSensitive(payload.error)) : void 0,
+      details: payload.details ? redactSensitive(payload.details) : void 0
+    };
     for (const t of targets) {
       const url = config[t];
       if (!url) continue;
       const formatter = FORMATTERS[t];
       if (!formatter) continue;
-      const body = formatter(payload);
+      const body = formatter(safePayload);
       promises.push(sendSingle(url, body).catch(() => {
       }));
     }
@@ -7114,15 +7191,15 @@ async function fetchChangelog(options) {
       signal: controller.signal
     });
   } catch {
-    throw new Error(`Could not fetch changelog. View online: ${DOCS_CHANGELOG_URL}`);
+    throw new GpcError(`Could not fetch changelog.`, "CHANGELOG_FETCH_FAILED", 5, `View online: ${DOCS_CHANGELOG_URL}`);
   } finally {
     clearTimeout(timer);
   }
   if (!response.ok) {
     if (response.status === 404 && options?.version) {
-      throw new Error(`Version ${options.version} not found. Run: gpc changelog --limit 10`);
+      throw new GpcError(`Version ${options.version} not found.`, "CHANGELOG_VERSION_NOT_FOUND", 1, `Run: gpc changelog --limit 10`);
     }
-    throw new Error(`GitHub API returned ${response.status}. View online: ${DOCS_CHANGELOG_URL}`);
+    throw new GpcError(`GitHub API returned ${response.status}.`, "CHANGELOG_FETCH_FAILED", 5, `View online: ${DOCS_CHANGELOG_URL}`);
   }
   const data = await response.json();
   const releases = Array.isArray(data) ? data : [data];