@gotgenes/pi-subagents 6.19.1 → 7.1.0

package/src/types.ts

@@ -4,6 +4,7 @@
 
 import type { ThinkingLevel } from "@earendil-works/pi-ai";
 import type { AgentSessionEvent } from "@earendil-works/pi-coding-agent";
+import type { ModelRegistry } from "#src/session/model-resolver";
 
 
 export { AgentRecord } from "#src/lifecycle/agent-record";
@@ -20,9 +21,6 @@ export interface SubscribableSession {
 /** Agent type: any string name (built-in defaults or user-defined). */
 export type SubagentType = string;
 
-/** Memory scope for persistent agent memory. */
-export type MemoryScope = "user" | "project" | "local";
-
 /** Isolation mode for agent execution. */
 export type IsolationMode = "worktree";
 
@@ -59,8 +57,6 @@ export interface AgentConfig extends AgentIdentity, AgentPromptConfig {
   runInBackground?: boolean;
   /** Default for spawn: no extension tools. undefined = caller decides. */
   isolated?: boolean;
-  /** Persistent memory scope — agents with memory get a persistent directory and MEMORY.md */
-  memory?: MemoryScope;
   /** Isolation mode — "worktree" runs the agent in a temporary git worktree */
   isolation?: IsolationMode;
   /** true = this is an embedded default agent (informational) */
@@ -82,6 +78,26 @@ export interface AgentInvocation {
   isolation?: IsolationMode;
 }
 
+/**
+ * Narrow shell-exec callback replacing `ExtensionAPI` in `detectEnv()`.
+ * Matches the shape of `pi.exec()` without carrying an SDK dependency.
+ */
+/**
+ * Narrow interface capturing the ExtensionContext fields SubagentRuntime needs.
+ * Avoids coupling runtime to the full SDK ExtensionContext surface (ISP).
+ */
+export interface SessionContext {
+  readonly cwd: string;
+  readonly model: unknown;
+  readonly modelRegistry: ModelRegistry | undefined;
+  getSystemPrompt(): string;
+  readonly sessionManager: {
+    getSessionFile(): string | undefined;
+    getSessionId(): string;
+    getBranch(): unknown[];
+  };
+}
+
 /**
  * Narrow shell-exec callback replacing `ExtensionAPI` in `detectEnv()`.
  * Matches the shape of `pi.exec()` without carrying an SDK dependency.

package/src/ui/agent-config-editor.ts

@@ -131,7 +131,6 @@ export function createAgentConfigEditor(
     if (cfg.inheritContext) fmFields.push("inherit_context: true");
     if (cfg.runInBackground) fmFields.push("run_in_background: true");
     if (cfg.isolated) fmFields.push("isolated: true");
-    if (cfg.memory) fmFields.push(`memory: ${cfg.memory}`);
     if (cfg.isolation) fmFields.push(`isolation: ${cfg.isolation}`);
 
     const content = `---\n${fmFields.join("\n")}\n---\n\n${cfg.systemPrompt}\n`;

package/src/ui/agent-creation-wizard.ts

@@ -115,7 +115,6 @@ disallowed_tools: <comma-separated tool names to block, even if otherwise availa
 inherit_context: <true to fork parent conversation into agent so it sees chat history. Default: false>
 run_in_background: <true to run in background by default. Default: false>
 isolated: <true for no extension/MCP tools, only built-in tools. Default: false>
-memory: <"user" (global), "project" (per-project), or "local" (gitignored per-project) for persistent memory. Omit for none>
 isolation: <"worktree" to run in isolated git worktree. Omit for normal>
 ---
 

package/src/session/memory.ts

@@ -1,168 +0,0 @@
-/**
- * memory.ts — Persistent agent memory: per-agent memory directories that persist across sessions.
- *
- * Memory scopes:
- *   - "user"    → ~/.pi/agent-memory/{agent-name}/
- *   - "project" → .pi/agent-memory/{agent-name}/
- *   - "local"   → .pi/agent-memory-local/{agent-name}/
- */
-
-import { existsSync, lstatSync, mkdirSync, readFileSync } from "node:fs";
-import { homedir } from "node:os";
-import { join, } from "node:path";
-import { debugLog } from "#src/debug";
-import type { MemoryScope } from "#src/types";
-
-/** Maximum lines to read from MEMORY.md */
-const MAX_MEMORY_LINES = 200;
-
-/**
- * Returns true if a name contains characters not allowed in agent/skill names.
- * Uses a whitelist: only alphanumeric, hyphens, underscores, and dots (no leading dot).
- */
-export function isUnsafeName(name: string): boolean {
-  if (!name || name.length > 128) return true;
-  return !/^[a-zA-Z0-9][a-zA-Z0-9._-]*$/.test(name);
-}
-
-/**
- * Returns true if the given path is a symlink (defense against symlink attacks).
- */
-export function isSymlink(filePath: string): boolean {
-  try {
-    return lstatSync(filePath).isSymbolicLink();
-  } catch (err) {
-    debugLog("lstatSync", err);
-    return false;
-  }
-}
-
-/**
- * Safely read a file, rejecting symlinks.
- * Returns undefined if the file doesn't exist, is a symlink, or can't be read.
- */
-export function safeReadFile(filePath: string): string | undefined {
-  if (!existsSync(filePath)) return undefined;
-  if (isSymlink(filePath)) return undefined;
-  try {
-    return readFileSync(filePath, "utf-8");
-  } catch (err) {
-    debugLog("readFileSync", err);
-    return undefined;
-  }
-}
-
-/**
- * Resolve the memory directory path for a given agent + scope + cwd.
- * Throws if agentName contains path traversal characters.
- */
-export function resolveMemoryDir(agentName: string, scope: MemoryScope, cwd: string): string {
-  if (isUnsafeName(agentName)) {
-    throw new Error(`Unsafe agent name for memory directory: "${agentName}"`);
-  }
-  switch (scope) {
-    case "user":
-      return join(homedir(), ".pi", "agent-memory", agentName);
-    case "project":
-      return join(cwd, ".pi", "agent-memory", agentName);
-    case "local":
-      return join(cwd, ".pi", "agent-memory-local", agentName);
-  }
-}
-
-/**
- * Ensure the memory directory exists, creating it if needed.
- * Refuses to create directories if any component in the path is a symlink
- * to prevent symlink-based directory traversal attacks.
- */
-export function ensureMemoryDir(memoryDir: string): void {
-  // If the directory already exists, verify it's not a symlink
-  if (existsSync(memoryDir)) {
-    if (isSymlink(memoryDir)) {
-      throw new Error(`Refusing to use symlinked memory directory: ${memoryDir}`);
-    }
-    return;
-  }
-  mkdirSync(memoryDir, { recursive: true });
-}
-
-/**
- * Read the first N lines of MEMORY.md from the memory directory, if it exists.
- * Returns undefined if no MEMORY.md exists or if the path is a symlink.
- */
-export function readMemoryIndex(memoryDir: string): string | undefined {
-  // Reject symlinked memory directories
-  if (isSymlink(memoryDir)) return undefined;
-
-  const memoryFile = join(memoryDir, "MEMORY.md");
-  const content = safeReadFile(memoryFile);
-  if (content === undefined) return undefined;
-
-  const lines = content.split("\n");
-  if (lines.length > MAX_MEMORY_LINES) {
-    return lines.slice(0, MAX_MEMORY_LINES).join("\n") + "\n... (truncated at 200 lines)";
-  }
-  return content;
-}
-
-/**
- * Build the memory block to inject into the agent's system prompt.
- * Also ensures the memory directory exists (creates it if needed).
- */
-export function buildMemoryBlock(agentName: string, scope: MemoryScope, cwd: string): string {
-  const memoryDir = resolveMemoryDir(agentName, scope, cwd);
-  // Create the memory directory so the agent can immediately write to it
-  ensureMemoryDir(memoryDir);
-
-  const existingMemory = readMemoryIndex(memoryDir);
-
-  const header = `# Agent Memory
-
-You have a persistent memory directory at: ${memoryDir}/
-Memory scope: ${scope}
-
-This memory persists across sessions. Use it to build up knowledge over time.`;
-
-  const memoryContent = existingMemory
-    ? `\n\n## Current MEMORY.md\n${existingMemory}`
-    : `\n\nNo MEMORY.md exists yet. Create one at ${join(memoryDir, "MEMORY.md")} to start building persistent memory.`;
-
-  const instructions = `
-
-## Memory Instructions
-- MEMORY.md is an index file — keep it concise (under 200 lines). Lines after 200 are truncated.
-- Store detailed memories in separate files within ${memoryDir}/ and link to them from MEMORY.md.
-- Each memory file should use this frontmatter format:
-  \`\`\`markdown
-  ---
-  name: <memory name>
-  description: <one-line description>
-  type: <user|feedback|project|reference>
-  ---
-  <memory content>
-  \`\`\`
-- Update or remove memories that become outdated. Check for existing memories before creating duplicates.
-- You have Read, Write, and Edit tools available for managing memory files.`;
-
-  return header + memoryContent + instructions;
-}
-
-/**
- * Build a read-only memory block for agents that lack write/edit tools.
- * Does NOT create the memory directory — agents can only consume existing memory.
- */
-export function buildReadOnlyMemoryBlock(agentName: string, scope: MemoryScope, cwd: string): string {
-  const memoryDir = resolveMemoryDir(agentName, scope, cwd);
-  const existingMemory = readMemoryIndex(memoryDir);
-
-  const header = `# Agent Memory (read-only)
-
-Memory scope: ${scope}
-You have read-only access to memory. You can reference existing memories but cannot create or modify them.`;
-
-  const memoryContent = existingMemory
-    ? `\n\n## Current MEMORY.md\n${existingMemory}`
-    : `\n\nNo memory is available yet. Other agents or sessions with write access can create memories for you to consume.`;
-
-  return header + memoryContent;
-}