@gotgenes/pi-subagents 6.18.3 → 6.18.4

package/CHANGELOG.md

@@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [6.18.4](https://github.com/gotgenes/pi-packages/compare/pi-subagents-v6.18.3...pi-subagents-v6.18.4) (2026-05-24)
+
+
+### Documentation
+
+* mark RunnerIO split done in architecture ([#167](https://github.com/gotgenes/pi-packages/issues/167)) ([824fd72](https://github.com/gotgenes/pi-packages/commit/824fd726361f62b6696dcc62de3b0bbb9cf45711))
+* plan narrow RunnerIO into EnvironmentIO + SessionFactoryIO ([#167](https://github.com/gotgenes/pi-packages/issues/167)) ([8110fec](https://github.com/gotgenes/pi-packages/commit/8110fec44dfaf08bd93d9cbc59ad04c6cba62a84))
+* **retro:** add planning stage notes for issue [#167](https://github.com/gotgenes/pi-packages/issues/167) ([1aceff7](https://github.com/gotgenes/pi-packages/commit/1aceff77c8177093c60b90b87a3f991cb0186602))
+* **retro:** add retro notes for issue [#180](https://github.com/gotgenes/pi-packages/issues/180) ([1fcd0ac](https://github.com/gotgenes/pi-packages/commit/1fcd0ace6fd7f5ec90a8d44423b276eb351875af))
+* **retro:** add TDD stage notes for issue [#167](https://github.com/gotgenes/pi-packages/issues/167) ([870c767](https://github.com/gotgenes/pi-packages/commit/870c7670fdab831d408232c126312d0b5010d6f4))
+
 ## [6.18.3](https://github.com/gotgenes/pi-packages/compare/pi-subagents-v6.18.2...pi-subagents-v6.18.3) (2026-05-24)
 
 

package/docs/architecture/architecture.md

@@ -500,20 +500,20 @@ These are fire-and-forget broadcast events — no request IDs, no reply channels
 These interfaces carry hidden dependencies that obscure true coupling.
 Bags with 10+ fields are the highest priority for decomposition.
 
-| Interface                   | Fields                             | Consumers                                         | Severity |
-| --------------------------- | ---------------------------------- | ------------------------------------------------- | -------- |
-| `ResolvedSpawnConfig`       | 3 nested                           | foreground-runner, background-spawner, agent-tool | ✓ done   |
-| `AgentSpawnConfig`          | 13 → 13 (ParentSessionInfo nested) | agent-manager (internal)                          | ✓ done   |
-| `RunOptions`                | 12                                 | agent-runner                                      | High     |
-| `SessionConfig`             | 11                                 | agent-runner (output of assembler)                | High     |
-| `NotificationDetails`       | 10                                 | notification                                      | Medium   |
-| `ResourceLoaderOptions`     | 10                                 | agent-runner (SDK bridge)                         | Medium   |
-| `RunnerIO`                  | 9 methods                          | agent-runner                                      | Medium   |
-| `CreateSessionOptions`      | 9                                  | agent-runner (SDK bridge)                         | Medium   |
-| `AgentToolDeps`             | 8                                  | agent-tool                                        | Low      |
-| `AgentMenuDeps`             | 8                                  | agent-menu                                        | Low      |
-| `ConversationViewerOptions` | 8                                  | conversation-viewer                               | Low      |
-| `AgentRecordInit`           | 8                                  | agent-record                                      | Low      |
+| Interface                   | Fields                                                 | Consumers                                         | Severity |
+| --------------------------- | ------------------------------------------------------ | ------------------------------------------------- | -------- |
+| `ResolvedSpawnConfig`       | 3 nested                                               | foreground-runner, background-spawner, agent-tool | ✓ done   |
+| `AgentSpawnConfig`          | 13 → 13 (ParentSessionInfo nested)                     | agent-manager (internal)                          | ✓ done   |
+| `RunOptions`                | 12                                                     | agent-runner                                      | High     |
+| `SessionConfig`             | 11                                                     | agent-runner (output of assembler)                | High     |
+| `NotificationDetails`       | 10                                                     | notification                                      | Medium   |
+| `ResourceLoaderOptions`     | 10                                                     | agent-runner (SDK bridge)                         | Medium   |
+| `RunnerIO`                  | split → `EnvironmentIO` (3) + `SessionFactoryIO` (5+1) | agent-runner                                      | ✓ done   |
+| `CreateSessionOptions`      | 9                                                      | agent-runner (SDK bridge)                         | Medium   |
+| `AgentToolDeps`             | 8                                                      | agent-tool                                        | Low      |
+| `AgentMenuDeps`             | 8                                                      | agent-menu                                        | Low      |
+| `ConversationViewerOptions` | 8                                                      | conversation-viewer                               | Low      |
+| `AgentRecordInit`           | 8                                                      | agent-record                                      | Low      |
 
 ### Complexity hotspots
 
@@ -681,10 +681,11 @@ Enables Step 3 (narrowing AgentSpawnConfig, [#166][166]).
 Extracted `parentSessionFile`, `parentSessionId`, `toolCallId` into `ParentSessionInfo`.
 `AgentSpawnConfig`, `BackgroundParams`, `ForegroundParams`, and `RunOptions` all carry the nested group.
 
-### Step 4: Narrow RunnerIO ([#167][167])
+### Step 4: Narrow RunnerIO ([#167][167]) ✓ Done
 
-Split into `EnvironmentIO` and `SessionFactoryIO`.
-Each half can be tested independently.
+`RunnerIO` split into `EnvironmentIO` (3 methods: environment discovery) and `SessionFactoryIO` (5 methods + `assemblerIO`: SDK object creation).
+`RunnerIO` kept as a backward-compatible type alias for the intersection.
+All existing consumers satisfy both sub-interfaces via structural typing with no call-site changes.
 
 ### Step 5: Extract ToolFilterConfig from SessionConfig ([#168][168])
 

package/docs/plans/0167-narrow-runner-io.md

@@ -0,0 +1,150 @@
+---
+issue: 167
+issue_title: "refactor(pi-subagents): narrow RunnerIO (9 methods → 2 focused interfaces)"
+---
+
+# Narrow RunnerIO into EnvironmentIO + SessionFactoryIO
+
+## Problem Statement
+
+`RunnerIO` in `agent-runner.ts` bundles 8 members (7 methods + 1 sub-interface) into a single IO boundary.
+The methods split naturally into two concerns — environment discovery vs. SDK object creation — but the current monolithic interface forces every consumer (and every test mock) to provide all members regardless of which subset they actually use.
+This violates Interface Segregation (ISP) and inflates test factory helpers.
+
+## Goals
+
+- Split `RunnerIO` into two focused interfaces: `EnvironmentIO` (3 methods) and `SessionFactoryIO` (5 methods + `assemblerIO`).
+- Keep `RunnerIO` as a type alias (`EnvironmentIO & SessionFactoryIO`) so the change is fully backward-compatible at the type level.
+- Update both test `createRunnerIO()` factories to use the new sub-interfaces in their comments/structure (no behavioral test changes needed — factories already return plain objects).
+- Zero runtime behavior change.
+
+## Non-Goals
+
+- Splitting the `runAgent()` function itself — that's a separate concern.
+- Changing how `createAgentRunner()` accepts its IO parameter — it keeps taking `RunnerIO` (the intersection).
+- Refactoring `index.ts` wiring — the construction site already builds a plain object; it will continue to satisfy `RunnerIO`.
+- Extracting `AssemblerIO` further — it already has its own interface in `session-config.ts`.
+
+## Background
+
+`RunnerIO` was introduced in issue #133 to decouple `agent-runner.ts` from direct Pi SDK imports.
+It succeeded at making the runner testable via plain stubs, but bundled all IO into one wide interface.
+Issue #164 (closed) reorganized source into domain directories; the current file path is `src/lifecycle/agent-runner.ts`.
+
+The 8 members group into two cohesive clusters:
+
+| Cluster               | Members                                                                                                 | Responsibility                                    |
+| --------------------- | ------------------------------------------------------------------------------------------------------- | ------------------------------------------------- |
+| Environment discovery | `detectEnv`, `getAgentDir`, `deriveSessionDir`                                                          | Discover runtime environment, resolve directories |
+| Session factory       | `createResourceLoader`, `createSessionManager`, `createSettingsManager`, `createSession`, `assemblerIO` | Create SDK objects for a child session            |
+
+In `runAgent()`, the environment methods are called first (lines ~265–275), then the factory methods build SDK objects (lines ~280–320).
+The two groups have no cross-dependencies within `runAgent()`.
+
+## Design Overview
+
+### New interfaces
+
+```typescript
+/** Environment discovery — detect runtime context and resolve directories. */
+export interface EnvironmentIO {
+  detectEnv: (exec: ShellExec, cwd: string) => Promise<EnvInfo>;
+  getAgentDir: () => string;
+  deriveSessionDir: (parentSessionFile: string | undefined, effectiveCwd: string) => string;
+}
+
+/** Session factory — create SDK objects for a child agent session. */
+export interface SessionFactoryIO {
+  createResourceLoader: (opts: ResourceLoaderOptions) => ResourceLoaderLike;
+  createSessionManager: (cwd: string, sessionDir: string) => SessionManagerLike;
+  createSettingsManager: (cwd: string, agentDir: string) => SettingsManager;
+  createSession: (opts: CreateSessionOptions) => Promise<{ session: AgentSession }>;
+  assemblerIO: AssemblerIO;
+}
+
+/**
+ * IO boundary injected into runAgent().
+ * Backward-compatible intersection of the two focused interfaces.
+ */
+export type RunnerIO = EnvironmentIO & SessionFactoryIO;
+```
+
+### Backward compatibility
+
+- `RunnerIO` becomes a type alias for the intersection.
+  Any code that imports `RunnerIO` continues to compile unchanged.
+- `index.ts` builds a plain object literal that satisfies `RunnerIO` — no change needed.
+- Test factories return unannotated objects that are structurally compatible — no change needed for compilation, but comments can be updated to reference the sub-interfaces.
+
+### Consumer call-site verification
+
+The call site in `createAgentRunner()` (3 lines):
+
+```typescript
+export function createAgentRunner(io: RunnerIO): AgentRunner {
+  return {
+    run: (snapshot, type, prompt, options) => runAgent(snapshot, type, prompt, options, io),
+    resume: resumeAgent,
+  };
+}
+```
+
+This passes the full `io` to `runAgent()`, which continues to accept `RunnerIO`.
+No Tell-Don't-Ask or LoD violations introduced.
+
+## Module-Level Changes
+
+### `src/lifecycle/agent-runner.ts`
+
+1. Add `EnvironmentIO` interface (3 members) before the current `RunnerIO` definition.
+2. Add `SessionFactoryIO` interface (5 members) after `EnvironmentIO`.
+3. Change `RunnerIO` from an `interface` to a `type` alias: `type RunnerIO = EnvironmentIO & SessionFactoryIO`.
+4. Export the two new interfaces alongside `RunnerIO`.
+5. Move existing JSDoc from `RunnerIO` members to the sub-interfaces.
+6. No changes to function signatures — `runAgent()` and `createAgentRunner()` keep accepting `RunnerIO`.
+
+### `src/index.ts`
+
+No changes.
+The construction site builds a plain object satisfying all 8 members — TypeScript's structural typing ensures it satisfies `EnvironmentIO & SessionFactoryIO` without annotation changes.
+
+### Test files
+
+No behavioral changes.
+The `createRunnerIO()` factories in both test files return unannotated plain objects that structurally satisfy the intersection.
+Comments referencing `RunnerIO` can be updated to mention the sub-interfaces for documentation clarity.
+
+Files affected:
+
+- `test/lifecycle/agent-runner.test.ts` — update comment (line ~23–27).
+- `test/lifecycle/agent-runner-extension-tools.test.ts` — update comment (line ~46).
+
+## Test Impact Analysis
+
+1. **New unit tests enabled:** The split enables future tests that inject only `EnvironmentIO` or only `SessionFactoryIO` — useful when testing environment-only or factory-only code paths in future extractions.
+   No new tests are needed in this issue because `runAgent()` still consumes the full intersection.
+2. **Redundant tests:** None — existing tests already test through `runAgent()` which uses all members.
+3. **Tests that stay as-is:** All existing tests in both `agent-runner.test.ts` and `agent-runner-extension-tools.test.ts` remain valid; the factories produce objects compatible with the new type alias.
+
+## TDD Order
+
+1. **Red → Green: export `EnvironmentIO` and `SessionFactoryIO`, convert `RunnerIO` to type alias.**
+   Test surface: existing `agent-runner.test.ts` and `agent-runner-extension-tools.test.ts` suites (must still pass).
+   Run `pnpm run check` to verify type compatibility.
+   Commit: `refactor: split RunnerIO into EnvironmentIO and SessionFactoryIO (#167)`
+
+2. **Update test comments to reference sub-interfaces.**
+   Test surface: no behavioral test changes — comment-only updates.
+   Commit: `refactor: update test comments for RunnerIO sub-interfaces (#167)`
+
+## Risks and Mitigations
+
+| Risk                                          | Mitigation                                                                                          |
+| --------------------------------------------- | --------------------------------------------------------------------------------------------------- |
+| External consumers importing `RunnerIO` break | `RunnerIO` remains exported as a type alias for the intersection — fully backward-compatible        |
+| Test factories need updating                  | Factories return unannotated objects — structural typing handles the new type alias without changes |
+| Future extractions assume wrong interface     | Each sub-interface has a clear JSDoc explaining its scope                                           |
+
+## Open Questions
+
+None — the split follows the natural cohesion boundary identified in the issue body.

package/docs/retro/0167-narrow-runner-io.md

@@ -0,0 +1,35 @@
+---
+issue: 167
+issue_title: "refactor(pi-subagents): narrow RunnerIO (9 methods → 2 focused interfaces)"
+---
+
+# Retro: #167 — narrow RunnerIO (9 methods → 2 focused interfaces)
+
+## Stage: Planning (2026-05-24T20:00:00Z)
+
+### Session summary
+
+Produced a plan to split the `RunnerIO` interface in `agent-runner.ts` into two focused sub-interfaces (`EnvironmentIO` and `SessionFactoryIO`) while keeping `RunnerIO` as a backward-compatible type alias for their intersection.
+The change is a pure refactoring with zero runtime behavior change.
+
+### Observations
+
+- The split is mechanical and low-risk: `RunnerIO` becomes `type RunnerIO = EnvironmentIO & SessionFactoryIO`, and all existing consumers (production code and test factories) continue to compile via structural typing.
+- Dependency #164 (reorganize into domain directories) is already closed, so file paths are current.
+- The two test `createRunnerIO()` factories are unannotated (intentionally, per testing skill guidelines), so they don't need type-level updates — only comment updates for documentation.
+- This is a two-commit TDD plan, suitable for `/build-plan` rather than full TDD cycles since no new tests are required.
+
+## Stage: Implementation — TDD (2026-05-24T20:45:00Z)
+
+### Session summary
+
+Completed both TDD steps in full.
+Step 1 added `EnvironmentIO` and `SessionFactoryIO` interfaces and converted `RunnerIO` to a type alias in `agent-runner.ts`; step 2 updated comments in both test factories.
+Test count held steady at 805/805 (50 files) — no behavioral changes.
+
+### Observations
+
+- The type check (`pnpm run check`) passed immediately after the interface split — structural typing meant zero call-site changes in `index.ts` or test factories.
+- `RunnerIO` JSDoc was split: `EnvironmentIO` got the environment-discovery description, `SessionFactoryIO` got the original "decouples from Pi SDK imports" description, and `RunnerIO` itself got a short backward-compatibility note.
+- Architecture doc updated: wide-interface table row and Step 4 roadmap entry both marked done.
+- No deviations from the plan.

package/docs/retro/0180-reorder-append-prompt-for-kv-cache.md

@@ -31,3 +31,32 @@ Test count unchanged at 805 across 50 files.
 - The JSDoc bullet for append mode also described the old ordering ("env header + parent system prompt + ...") and was corrected as part of the green step.
 - The `<active_agent>` tag is followed by a `\n\n`, so when it moves after `<sub_agent_context>`, a `\n\n` separator between the bridge and the tag was needed to maintain clean section boundaries.
 - No deviations from the plan; both steps were exactly as described.
+
+## Stage: Final Retrospective (2026-05-24T21:00:00Z)
+
+### Session summary
+
+Issue #180 went from external community observation through release (`pi-subagents-v6.18.3`) in a single continuous session.
+The plan predicted exactly two TDD steps; both executed without deviation or rework.
+
+### Observations
+
+#### What went well
+
+- End-to-end lifecycle in one session: external comment → issue → plan → TDD → ship → release.
+  No corrections, no scope drift, no rework across any stage.
+- The plan's test impact analysis was accurate — only two positional assertions needed updating; all `toContain()` tests passed untouched.
+- Confirming pi-permission-system's `ACTIVE_AGENT_TAG_REGEX.exec()` is position-independent during planning eliminated the second `pkg:*` label's scope entirely, keeping the change to a single file.
+
+#### What caused friction (agent side)
+
+- `wrong-abstraction` — Launched an Explore agent (75.9s, 18 tool uses) to map the prompt assembly flow when the `package-pi-subagents` skill already listed the file layout and `prompts.ts` is 107 lines.
+  Direct `read` + `grep` achieved the same confirmation in ~3 seconds during the planning phase.
+  Impact: added ~75 seconds of latency but no rework.
+- `missing-context` — The plan listed "Update the JSDoc comment" but missed that the mode-description bullet ("env header + parent system prompt + ...") also encoded the old ordering.
+  Caught during the green step and fixed in the same commit.
+  Impact: added friction but no rework.
+
+#### What caused friction (user side)
+
+- Nothing notable — the user's prompts were well-scoped and the issue description was unambiguous.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-subagents",
-  "version": "6.18.3",
+  "version": "6.18.4",
   "type": "module",
   "exports": {
     ".": "./src/service.ts"

package/src/lifecycle/agent-runner.ts

@@ -91,7 +91,7 @@ export interface SessionManagerLike {
   getSessionFile(): string | undefined;
 }
 
-/** Options passed to RunnerIO.createResourceLoader. */
+/** Options passed to EnvironmentIO/SessionFactoryIO methods. */
 export interface ResourceLoaderOptions {
   cwd: string;
   agentDir: string;
@@ -105,7 +105,7 @@ export interface ResourceLoaderOptions {
   appendSystemPromptOverride?: (base: string[]) => string[];
 }
 
-/** Options passed to RunnerIO.createSession. */
+/** Options passed to SessionFactoryIO.createSession. */
 export interface CreateSessionOptions {
   cwd: string;
   agentDir: string;
@@ -119,22 +119,40 @@ export interface CreateSessionOptions {
 }
 
 /**
- * IO boundary injected into runAgent().
+ * Environment discovery — detect runtime context and resolve directories.
  *
- * Decouples the runner from direct Pi SDK imports and sibling-module IO,
- * making it testable via plain stub objects without vi.mock().
+ * Decouples the runner from direct process/SDK reads so each can be stubbed
+ * independently in tests.
  */
-export interface RunnerIO {
+export interface EnvironmentIO {
   detectEnv: (exec: ShellExec, cwd: string) => Promise<EnvInfo>;
   getAgentDir: () => string;
-  createResourceLoader: (opts: ResourceLoaderOptions) => ResourceLoaderLike;
   deriveSessionDir: (parentSessionFile: string | undefined, effectiveCwd: string) => string;
+}
+
+/**
+ * Session factory — create SDK objects for a child agent session.
+ *
+ * Decouples the runner from direct Pi SDK imports and sibling-module IO,
+ * making it testable via plain stub objects without vi.mock().
+ */
+export interface SessionFactoryIO {
+  createResourceLoader: (opts: ResourceLoaderOptions) => ResourceLoaderLike;
   createSessionManager: (cwd: string, sessionDir: string) => SessionManagerLike;
   createSettingsManager: (cwd: string, agentDir: string) => SettingsManager;
   createSession: (opts: CreateSessionOptions) => Promise<{ session: AgentSession }>;
   assemblerIO: AssemblerIO;
 }
 
+/**
+ * IO boundary injected into runAgent().
+ *
+ * Backward-compatible intersection of EnvironmentIO and SessionFactoryIO.
+ * Callers that previously constructed a RunnerIO object continue to satisfy
+ * both sub-interfaces via TypeScript's structural typing.
+ */
+export type RunnerIO = EnvironmentIO & SessionFactoryIO;
+
 // ── Public interfaces ─────────────────────────────────────────────────────────
 
 export interface RunOptions {