@gotgenes/pi-subagents 6.12.1 → 6.13.1

package/src/ui/agent-creation-wizard.ts

@@ -0,0 +1,246 @@
+/**
+ * agent-creation-wizard.ts — AI-generation and manual-form agent creation flows.
+ *
+ * Extracted from agent-menu.ts to give each concern a single responsibility.
+ * Receives dependencies via injection — no direct `node:fs` imports.
+ */
+
+import { join } from "node:path";
+
+import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { BUILTIN_TOOL_NAMES } from "../agent-types.js";
+import type { AgentRecord } from "../types.js";
+import type { AgentFileOps } from "./agent-file-ops.js";
+
+// ---- Deps interface ----
+
+/** Narrow manager interface for agent spawning (generate wizard). */
+export interface WizardManager {
+  spawnAndWait: (
+    ctx: ExtensionContext,
+    type: string,
+    prompt: string,
+    opts: { description: string; maxTurns: number },
+  ) => Promise<AgentRecord>;
+}
+
+/** Narrow registry interface for reloading after creation. */
+export interface WizardRegistry {
+  reload(): void;
+}
+
+export interface AgentCreationWizardDeps {
+  fileOps: AgentFileOps;
+  manager: WizardManager;
+  registry: WizardRegistry;
+  personalAgentsDir: string;
+  projectAgentsDir: string;
+}
+
+// ---- Factory ----
+
+export function createAgentCreationWizard(deps: AgentCreationWizardDeps) {
+  async function showCreateWizard(ctx: ExtensionContext) {
+    const location = await ctx.ui.select("Choose location", [
+      "Project (.pi/agents/)",
+      `Personal (${deps.personalAgentsDir})`,
+    ]);
+    if (!location) return;
+
+    const targetDir = location.startsWith("Project")
+      ? deps.projectAgentsDir
+      : deps.personalAgentsDir;
+
+    const method = await ctx.ui.select("Creation method", [
+      "Generate with Claude (recommended)",
+      "Manual configuration",
+    ]);
+    if (!method) return;
+
+    if (method.startsWith("Generate")) {
+      await showGenerateWizard(ctx, targetDir);
+    } else {
+      await showManualWizard(ctx, targetDir);
+    }
+  }
+
+  async function showGenerateWizard(ctx: ExtensionContext, targetDir: string) {
+    const description = await ctx.ui.input("Describe what this agent should do");
+    if (!description) return;
+
+    const name = await ctx.ui.input("Agent name (filename, no spaces)");
+    if (!name) return;
+
+    deps.fileOps.ensureDir(targetDir);
+
+    const targetPath = join(targetDir, `${name}.md`);
+    if (deps.fileOps.exists(targetPath)) {
+      const overwrite = await ctx.ui.confirm(
+        "Overwrite",
+        `${targetPath} already exists. Overwrite?`,
+      );
+      if (!overwrite) return;
+    }
+
+    ctx.ui.notify("Generating agent definition...", "info");
+
+    const generatePrompt = `Create a custom pi sub-agent definition file based on this description: "${description}"
+
+Write a markdown file to: ${targetPath}
+
+The file format is a markdown file with YAML frontmatter and a system prompt body:
+
+\`\`\`markdown
+---
+description: <one-line description shown in UI>
+tools: <comma-separated built-in tools: read, bash, edit, write, grep, find, ls. Use "none" for no tools. Omit for all tools>
+model: <optional model as "provider/modelId", e.g. "anthropic/claude-haiku-4-5-20251001". Omit to inherit parent model>
+thinking: <optional thinking level: off, minimal, low, medium, high, xhigh. Omit to inherit>
+max_turns: <optional max agentic turns. 0 or omit for unlimited (default)>
+prompt_mode: <"replace" (body IS the full system prompt) or "append" (body is appended to default prompt). Default: replace>
+extensions: <true (inherit all MCP/extension tools), false (none), or comma-separated names. Default: true>
+skills: <true (inherit all), false (none), or comma-separated skill names to preload into prompt. Default: true>
+disallowed_tools: <comma-separated tool names to block, even if otherwise available. Omit for none>
+inherit_context: <true to fork parent conversation into agent so it sees chat history. Default: false>
+run_in_background: <true to run in background by default. Default: false>
+isolated: <true for no extension/MCP tools, only built-in tools. Default: false>
+memory: <"user" (global), "project" (per-project), or "local" (gitignored per-project) for persistent memory. Omit for none>
+isolation: <"worktree" to run in isolated git worktree. Omit for normal>
+---
+
+<system prompt body — instructions for the agent>
+\`\`\`
+
+Guidelines for choosing settings:
+- For read-only tasks (review, analysis): tools: read, bash, grep, find, ls
+- For code modification tasks: include edit, write
+- Use prompt_mode: append if the agent should keep the default system prompt and add specialization on top
+- Use prompt_mode: replace for fully custom agents with their own personality/instructions
+- Set inherit_context: true if the agent needs to know what was discussed in the parent conversation
+- Set isolated: true if the agent should NOT have access to MCP servers or other extensions
+- Only include frontmatter fields that differ from defaults — omit fields where the default is fine
+
+Write the file using the write tool. Only write the file, nothing else.`;
+
+    const record = await deps.manager.spawnAndWait(
+      ctx,
+      "general-purpose",
+      generatePrompt,
+      {
+        description: `Generate ${name} agent`,
+        maxTurns: 5,
+      },
+    );
+
+    if (record.status === "error") {
+      ctx.ui.notify(`Generation failed: ${record.error}`, "warning");
+      return;
+    }
+
+    deps.registry.reload();
+
+    if (deps.fileOps.exists(targetPath)) {
+      ctx.ui.notify(`Created ${targetPath}`, "info");
+    } else {
+      ctx.ui.notify(
+        "Agent generation completed but file was not created. Check the agent output.",
+        "warning",
+      );
+    }
+  }
+
+  async function showManualWizard(ctx: ExtensionContext, targetDir: string) {
+    const name = await ctx.ui.input("Agent name (filename, no spaces)");
+    if (!name) return;
+
+    const description = await ctx.ui.input("Description (one line)");
+    if (!description) return;
+
+    const toolChoice = await ctx.ui.select("Tools", [
+      "all",
+      "none",
+      "read-only (read, bash, grep, find, ls)",
+      "custom...",
+    ]);
+    if (!toolChoice) return;
+
+    let tools: string;
+    if (toolChoice === "all") {
+      tools = BUILTIN_TOOL_NAMES.join(", ");
+    } else if (toolChoice === "none") {
+      tools = "none";
+    } else if (toolChoice.startsWith("read-only")) {
+      tools = "read, bash, grep, find, ls";
+    } else {
+      const customTools = await ctx.ui.input(
+        "Tools (comma-separated)",
+        BUILTIN_TOOL_NAMES.join(", "),
+      );
+      if (!customTools) return;
+      tools = customTools;
+    }
+
+    const modelChoice = await ctx.ui.select("Model", [
+      "inherit (parent model)",
+      "haiku",
+      "sonnet",
+      "opus",
+      "custom...",
+    ]);
+    if (!modelChoice) return;
+
+    let modelLine = "";
+    if (modelChoice === "haiku")
+      modelLine = "\nmodel: anthropic/claude-haiku-4-5-20251001";
+    else if (modelChoice === "sonnet")
+      modelLine = "\nmodel: anthropic/claude-sonnet-4-6";
+    else if (modelChoice === "opus")
+      modelLine = "\nmodel: anthropic/claude-opus-4-6";
+    else if (modelChoice === "custom...") {
+      const customModel = await ctx.ui.input("Model (provider/modelId)");
+      if (customModel) modelLine = `\nmodel: ${customModel}`;
+    }
+
+    const thinkingChoice = await ctx.ui.select("Thinking level", [
+      "inherit",
+      "off",
+      "minimal",
+      "low",
+      "medium",
+      "high",
+      "xhigh",
+    ]);
+    if (!thinkingChoice) return;
+
+    let thinkingLine = "";
+    if (thinkingChoice !== "inherit") thinkingLine = `\nthinking: ${thinkingChoice}`;
+
+    const systemPrompt = await ctx.ui.editor("System prompt", "");
+    if (systemPrompt === undefined) return;
+
+    const content = `---
+description: ${description}
+tools: ${tools}${modelLine}${thinkingLine}
+prompt_mode: replace
+---
+
+${systemPrompt}
+`;
+
+    const targetPath = join(targetDir, `${name}.md`);
+
+    if (deps.fileOps.exists(targetPath)) {
+      const overwrite = await ctx.ui.confirm(
+        "Overwrite",
+        `${targetPath} already exists. Overwrite?`,
+      );
+      if (!overwrite) return;
+    }
+
+    deps.fileOps.write(targetPath, content);
+    deps.registry.reload();
+    ctx.ui.notify(`Created ${targetPath}`, "info");
+  }
+
+  return { showCreateWizard };
+}

package/src/ui/agent-file-ops.ts

@@ -0,0 +1,59 @@
+/**
+ * agent-file-ops.ts — Filesystem abstraction for agent .md file operations.
+ *
+ * Decouples menu sub-modules from direct `node:fs` imports, making them
+ * testable via plain stub objects without `vi.mock()`.
+ */
+
+import { existsSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from "node:fs";
+import { dirname, join } from "node:path";
+
+// ---- Interface ----
+
+/** Filesystem operations for agent `.md` files. */
+export interface AgentFileOps {
+  exists(filePath: string): boolean;
+  read(filePath: string): string | undefined;
+  write(filePath: string, content: string): void;
+  remove(filePath: string): void;
+  ensureDir(dirPath: string): void;
+  findAgentFile(name: string, dirs: string[]): string | undefined;
+}
+
+// ---- Production implementation ----
+
+/** Production implementation wrapping `node:fs` synchronous APIs. */
+export class FsAgentFileOps implements AgentFileOps {
+  exists(filePath: string): boolean {
+    return existsSync(filePath);
+  }
+
+  read(filePath: string): string | undefined {
+    try {
+      return readFileSync(filePath, "utf-8");
+    } catch {
+      return undefined;
+    }
+  }
+
+  write(filePath: string, content: string): void {
+    mkdirSync(dirname(filePath), { recursive: true });
+    writeFileSync(filePath, content, "utf-8");
+  }
+
+  remove(filePath: string): void {
+    unlinkSync(filePath);
+  }
+
+  ensureDir(dirPath: string): void {
+    mkdirSync(dirPath, { recursive: true });
+  }
+
+  findAgentFile(name: string, dirs: string[]): string | undefined {
+    for (const dir of dirs) {
+      const p = join(dir, `${name}.md`);
+      if (existsSync(p)) return p;
+    }
+    return undefined;
+  }
+}