@gotgenes/pi-subagents 5.4.0 → 5.4.1

package/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.4.1](https://github.com/gotgenes/pi-packages/compare/pi-subagents-v5.4.0...pi-subagents-v5.4.1) (2026-05-20)
+
+
+### Documentation
+
+* plan inject cwd into AgentManager constructor ([#76](https://github.com/gotgenes/pi-packages/issues/76)) ([7d3d50a](https://github.com/gotgenes/pi-packages/commit/7d3d50a7b7b96ef15cf5ffd7f609ed0baa46d6b9))
+* **retro:** add retro notes for issue [#80](https://github.com/gotgenes/pi-packages/issues/80) ([ac38a72](https://github.com/gotgenes/pi-packages/commit/ac38a7209788c7725c7307491a18fb5a8e83962d))
+
 ## [5.4.0](https://github.com/gotgenes/pi-packages/compare/pi-subagents-v5.3.0...pi-subagents-v5.4.0) (2026-05-20)
 
 

package/docs/plans/0076-inject-cwd-into-agent-manager.md

@@ -0,0 +1,102 @@
+---
+issue: 76
+issue_title: "refactor: inject cwd into AgentManager constructor instead of reading process.cwd() in dispose()"
+---
+
+# Inject cwd into AgentManager constructor
+
+## Problem Statement
+
+`AgentManager.dispose()` calls `pruneWorktrees(process.cwd())` directly — the only place in the class that reads a process global instead of accepting `cwd` from the caller.
+Every other code path that needs a working directory receives it via the per-spawn invocation context (`ctx.cwd`).
+This implicit dependency makes the class harder to test and inconsistent with its own conventions.
+
+## Goals
+
+- Add `cwd: string` as the first parameter of the `AgentManager` constructor and store it as a private field.
+- Replace `pruneWorktrees(process.cwd())` in `dispose()` with `pruneWorktrees(this.cwd)`.
+- Update the single production call site in `index.ts` to pass `process.cwd()`.
+- Update all 18 test-file constructor calls to pass a test directory string.
+
+## Non-Goals
+
+- Removing other `process.cwd()` calls elsewhere in the extension (e.g., `loadCustomAgents` in `index.ts`).
+- Changing how per-spawn `ctx.cwd` flows through `agent-runner.ts`.
+- Refactoring the constructor's callback-heavy signature into an options object (potential follow-up).
+
+## Background
+
+### Relevant modules
+
+| Module               | Role                                                                                                                          |
+| -------------------- | ----------------------------------------------------------------------------------------------------------------------------- |
+| `agent-manager.ts`   | Owns `AgentManager` class; constructor at line 83, `dispose()` at line 479 with the `process.cwd()` call.                     |
+| `index.ts`           | Extension entry point; constructs `AgentManager` at line 64. Already calls `process.cwd()` at line 43 for `loadCustomAgents`. |
+| `worktree.ts`        | Exports `pruneWorktrees(cwd: string)` consumed by `dispose()`.                                                                |
+| `service-adapter.ts` | Depends on `AgentManagerLike` interface, which does not expose the constructor — unaffected.                                  |
+
+### Constraints
+
+From AGENTS.md / code-style skill:
+
+> Do not read `process.env`, `process.cwd()`, or `process.platform` inside library/utility functions — accept the value as a parameter.
+
+This refactoring directly enforces that rule.
+
+`AgentManager` is internal — the public API surface (`exports` in `package.json`) is `service.ts` only, so this is a non-breaking change for consumers.
+
+## Design Overview
+
+The change is mechanical:
+
+1. Prepend `cwd: string` to the constructor parameter list.
+2. Store it as `private readonly cwd: string`.
+3. Replace `process.cwd()` in `dispose()` with `this.cwd`.
+4. At the call site in `index.ts`, pass `process.cwd()` as the first argument.
+5. In tests, pass a fixed string like `"/test-cwd"` to every `new AgentManager(...)` call.
+
+No new types, no interface changes, no export changes.
+
+## Module-Level Changes
+
+### `src/agent-manager.ts`
+
+- Add `private readonly cwd: string` field.
+- Constructor: add `cwd: string` as the first parameter, assign `this.cwd = cwd`.
+- `dispose()`: change `pruneWorktrees(process.cwd())` → `pruneWorktrees(this.cwd)`.
+- Remove the `process` global dependency (no more `process.cwd()` import needed in this file).
+
+### `src/index.ts`
+
+- Pass `process.cwd()` as the first argument to `new AgentManager(...)`.
+
+### `test/agent-manager.test.ts`
+
+- All 18 `new AgentManager(...)` calls gain `"/test-cwd"` as the first argument.
+- No other test logic changes — `pruneWorktrees` is already mocked.
+
+## Test Impact Analysis
+
+1. No new unit tests are needed — the existing `dispose()` test already exercises `pruneWorktrees` via the mock; it will now verify the injected `cwd` is forwarded instead of the process global.
+2. No existing tests become redundant.
+3. All 18 constructor calls must be updated with the new first argument, but the test assertions remain valid.
+
+## TDD Order
+
+1. **Red → Green: update constructor and dispose** — change the `AgentManager` constructor to accept `cwd` as the first parameter, store it, and use `this.cwd` in `dispose()`.
+   Update all 18 test constructor calls to pass `"/test-cwd"`.
+   Update `index.ts` call site to pass `process.cwd()`.
+   Commit message: `refactor: inject cwd into AgentManager constructor (#76)`
+
+This is a single-step refactoring — splitting it further would leave the codebase in a broken intermediate state since the constructor signature change must be applied atomically across production code and tests.
+
+## Risks and Mitigations
+
+| Risk                            | Mitigation                                                                                                                                |
+| ------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------- |
+| Missing a constructor call site | `grep 'new AgentManager'` across the entire repo confirms only `index.ts` (1 call) and `agent-manager.test.ts` (18 calls).                |
+| Accidentally changing behavior  | `pruneWorktrees` is already mocked in tests; production call site passes `process.cwd()` which is the same value `dispose()` read before. |
+
+## Open Questions
+
+None — the issue's proposed change section is unambiguous and the refactoring is mechanical.

package/docs/retro/0080-consolidate-agent-config-lookup.md

@@ -0,0 +1,35 @@
+---
+issue: 80
+issue_title: "refactor: consolidate getConfig / getAgentConfig into a single resolution path"
+---
+
+# Retro: #80 — consolidate getConfig / getAgentConfig
+
+## Final Retrospective (2026-05-20T00:35:00Z)
+
+### Session summary
+
+Consolidated two overlapping agent config lookup functions (`getConfig` and `getAgentConfig`) into a single `resolveAgentConfig(type): AgentConfig` with a guaranteed-non-null return and internal fallback chain.
+Migrated all 6 source callers and 5 test files across 6 TDD commits, then shipped as `pi-subagents-v5.4.0`.
+
+### Observations
+
+#### What went well
+
+- The lift-and-shift migration strategy (add new function → migrate callers incrementally → remove old functions) kept every commit green.
+  No intermediate step broke the test suite.
+- The planning phase correctly identified an under-documented scope question (callers beyond the two mentioned in the issue) and used `ask-user` to resolve it before writing the plan.
+- The `test/prompts.test.ts` caller, missed by the plan, was caught cleanly during the final grep sweep in step 6 — no rework needed, just an additional edit in the same commit.
+
+#### What caused friction (agent side)
+
+- `missing-context` — The plan specified that `resolveAgentConfig` should fall back for disabled types (matching `getConfig`'s semantics), but didn't trace what `agent-menu.ts` actually reads from disabled configs.
+  `agent-menu.ts` iterates `getAllTypes()` (including disabled agents) and needs the real config to render `✕` indicators, source badges, and `(disabled)` descriptions.
+  With fallback-for-disabled semantics, disabled agents would silently display as general-purpose.
+  Caught during step 4 while editing `agent-menu.ts`, before any wrong test assertions ran.
+  Impact: required changing `resolveAgentConfig` semantics (only fall back for unknown types, not disabled) and updating the step 1 test — a ~5 minute fix folded into the step 4 commit.
+
+#### What caused friction (user side)
+
+- Nothing notable.
+  The user's `ask-user` response during planning ("remove both, migrate all callers") was clear and included a useful directional note about computing values earlier.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-subagents",
-  "version": "5.4.0",
+  "version": "5.4.1",
   "exports": {
     ".": "./src/service.ts"
   },

package/src/agent-manager.ts

@@ -72,6 +72,7 @@ export class AgentManager {
   private onComplete?: OnAgentComplete;
   private onStart?: OnAgentStart;
   private onCompact?: OnAgentCompact;
+  private readonly cwd: string;
   private maxConcurrent: number;
   private getRunConfig?: () => RunConfig;
 
@@ -81,12 +82,14 @@ export class AgentManager {
   private runningBackground = 0;
 
   constructor(
+    cwd: string,
     onComplete?: OnAgentComplete,
     maxConcurrent = DEFAULT_MAX_CONCURRENT,
     onStart?: OnAgentStart,
     onCompact?: OnAgentCompact,
     getRunConfig?: () => RunConfig,
   ) {
+    this.cwd = cwd;
     this.onComplete = onComplete;
     this.onStart = onStart;
     this.onCompact = onCompact;
@@ -485,6 +488,6 @@ export class AgentManager {
     }
     this.agents.clear();
     // Prune any orphaned git worktrees (crash recovery)
-    try { pruneWorktrees(process.cwd()); } catch (err) { debugLog("pruneWorktrees on dispose", err); }
+    try { pruneWorktrees(this.cwd); } catch (err) { debugLog("pruneWorktrees on dispose", err); }
   }
 }

package/src/index.ts

@@ -61,7 +61,7 @@ export default function (pi: ExtensionAPI) {
   });
 
   // Background completion: emit lifecycle event and delegate to notification system
-  const manager = new AgentManager((record) => {
+  const manager = new AgentManager(process.cwd(), (record) => {
     // Emit lifecycle event based on terminal status
     const isError = record.status === "error" || record.status === "stopped" || record.status === "aborted";
     const eventData = buildEventData(record);