@gotgenes/pi-subagents 17.5.0 → 18.0.1

package/src/ui/agent-config-editor.ts

@@ -1,199 +0,0 @@
-/**
- * agent-config-editor.ts — Agent detail view with edit/delete/eject/disable/enable transitions.
- *
- * Extracted from agent-menu.ts to give each concern a single responsibility.
- * Receives dependencies via injection — no direct `node:fs` imports.
- */
-
-import { join } from "node:path";
-
-import type { AgentTypeRegistry } from "#src/config/agent-types";
-import type { AgentConfig } from "#src/types";
-import type { AgentFileOps } from "#src/ui/agent-file-ops";
-import { writeAgentFile } from "#src/ui/agent-file-writer";
-import type { MenuUI } from "#src/ui/agent-menu";
-
-// ---- Pure helpers ----
-
-/** Compute the menu option list for the agent detail view. */
-export function buildMenuOptions(
-  cfg: { isDefault?: boolean; enabled?: boolean },
-  file: string | undefined,
-): string[] {
-  const isDefault = cfg.isDefault === true;
-  const disabled = cfg.enabled === false;
-
-  if (disabled && file) {
-    return isDefault
-      ? ["Enable", "Edit", "Reset to default", "Delete", "Back"]
-      : ["Enable", "Edit", "Delete", "Back"];
-  }
-  if (isDefault && !file) {
-    return ["Eject (export as .md)", "Disable", "Back"];
-  }
-  if (isDefault && file) {
-    return ["Edit", "Disable", "Reset to default", "Delete", "Back"];
-  }
-  return ["Edit", "Disable", "Delete", "Back"];
-}
-
-/** Build the `.md` file content (frontmatter + system prompt) for an ejected agent. */
-export function buildEjectContent(cfg: AgentConfig): string {
-  const fmFields: string[] = [];
-  fmFields.push(`description: ${cfg.description}`);
-  if (cfg.displayName) fmFields.push(`display_name: ${cfg.displayName}`);
-  fmFields.push(`tools: ${cfg.builtinToolNames?.join(", ") ?? "all"}`);
-  if (cfg.model) fmFields.push(`model: ${cfg.model}`);
-  if (cfg.thinking) fmFields.push(`thinking: ${cfg.thinking}`);
-  if (cfg.maxTurns) fmFields.push(`max_turns: ${cfg.maxTurns}`);
-  fmFields.push(`prompt_mode: ${cfg.promptMode}`);
-  if (cfg.inheritContext) fmFields.push("inherit_context: true");
-  if (cfg.runInBackground) fmFields.push("run_in_background: true");
-  return `---\n${fmFields.join("\n")}\n---\n\n${cfg.systemPrompt}\n`;
-}
-
-// ---- Class ----
-
-export class AgentConfigEditor {
-  constructor(
-    private readonly fileOps: AgentFileOps,
-    private readonly registry: AgentTypeRegistry,
-    private readonly personalAgentsDir: string,
-    private readonly projectAgentsDir: string,
-  ) {}
-
-  private agentDirs(): string[] {
-    return [this.projectAgentsDir, this.personalAgentsDir];
-  }
-
-  async showAgentDetail(ui: MenuUI, name: string): Promise<void> {
-    if (this.registry.resolveType(name) == null) {
-      ui.notify(`Agent config not found for "${name}".`, "warning");
-      return;
-    }
-    const cfg = this.registry.resolveAgentConfig(name);
-    const file = this.fileOps.findAgentFile(name, this.agentDirs());
-
-    const choice = await ui.select(name, buildMenuOptions(cfg, file));
-    if (!choice || choice === "Back") return;
-
-    if (choice === "Edit" && file) await this.handleEdit(ui, name, file);
-    else if (choice === "Delete" && file) await this.handleDelete(ui, name, file);
-    else if (choice === "Reset to default" && file)
-      await this.handleReset(ui, name, file);
-    else if (choice.startsWith("Eject")) await this.ejectAgent(ui, name, cfg);
-    else if (choice === "Disable") await this.disableAgent(ui, name);
-    else if (choice === "Enable") await this.enableAgent(ui, name);
-  }
-
-  private async handleEdit(ui: MenuUI, name: string, file: string): Promise<void> {
-    const content = this.fileOps.read(file);
-    if (content === undefined) return;
-    const edited = await ui.editor(`Edit ${name}`, content);
-    if (edited !== undefined && edited !== content) {
-      this.fileOps.write(file, edited);
-      this.registry.reload();
-      ui.notify(`Updated ${file}`, "info");
-    }
-  }
-
-  private async handleDelete(ui: MenuUI, name: string, file: string): Promise<void> {
-    const confirmed = await ui.confirm(
-      "Delete agent",
-      `Delete ${name} (${file})?`,
-    );
-    if (confirmed) {
-      this.fileOps.remove(file);
-      this.registry.reload();
-      ui.notify(`Deleted ${file}`, "info");
-    }
-  }
-
-  private async handleReset(ui: MenuUI, name: string, file: string): Promise<void> {
-    const confirmed = await ui.confirm(
-      "Reset to default",
-      `Delete override ${file} and restore embedded default?`,
-    );
-    if (confirmed) {
-      this.fileOps.remove(file);
-      this.registry.reload();
-      ui.notify(`Restored default ${name}`, "info");
-    }
-  }
-
-  private async ejectAgent(ui: MenuUI, name: string, cfg: AgentConfig): Promise<void> {
-    const location = await ui.select("Choose location", [
-      "Project (.pi/agents/)",
-      `Personal (${this.personalAgentsDir})`,
-    ]);
-    if (!location) return;
-
-    const targetDir = location.startsWith("Project")
-      ? this.projectAgentsDir
-      : this.personalAgentsDir;
-
-    const targetPath = join(targetDir, `${name}.md`);
-    await writeAgentFile(
-      this.fileOps,
-      ui,
-      this.registry,
-      targetPath,
-      buildEjectContent(cfg),
-      `Ejected ${name} to`,
-    );
-  }
-
-  private async disableAgent(ui: MenuUI, name: string): Promise<void> {
-    const file = this.fileOps.findAgentFile(name, this.agentDirs());
-    if (file) {
-      const content = this.fileOps.read(file);
-      if (content?.includes("\nenabled: false\n")) {
-        ui.notify(`${name} is already disabled.`, "info");
-        return;
-      }
-      if (content) {
-        const updated = content.replace(/^---\n/, "---\nenabled: false\n");
-        this.fileOps.write(file, updated);
-        this.registry.reload();
-        ui.notify(`Disabled ${name} (${file})`, "info");
-      }
-      return;
-    }
-
-    const location = await ui.select("Choose location", [
-      "Project (.pi/agents/)",
-      `Personal (${this.personalAgentsDir})`,
-    ]);
-    if (!location) return;
-
-    const targetDir = location.startsWith("Project")
-      ? this.projectAgentsDir
-      : this.personalAgentsDir;
-
-    const targetPath = join(targetDir, `${name}.md`);
-    this.fileOps.write(targetPath, "---\nenabled: false\n---\n");
-    this.registry.reload();
-    ui.notify(`Disabled ${name} (${targetPath})`, "info");
-  }
-
-  // eslint-disable-next-line @typescript-eslint/require-await
-  private async enableAgent(ui: MenuUI, name: string): Promise<void> {
-    const file = this.fileOps.findAgentFile(name, this.agentDirs());
-    if (!file) return;
-
-    const content = this.fileOps.read(file);
-    if (!content) return;
-
-    const updated = content.replace(/^(---\n)enabled: false\n/, "$1");
-
-    if (updated.trim() === "---\n---" || updated.trim() === "---\n---\n") {
-      this.fileOps.remove(file);
-      this.registry.reload();
-      ui.notify(`Enabled ${name} (removed ${file})`, "info");
-    } else {
-      this.fileOps.write(file, updated);
-      this.registry.reload();
-      ui.notify(`Enabled ${name} (${file})`, "info");
-    }
-  }
-}

package/src/ui/agent-creation-wizard.ts

@@ -1,233 +0,0 @@
-/**
- * agent-creation-wizard.ts — AI-generation and manual-form agent creation flows.
- *
- * Extracted from agent-menu.ts to give each concern a single responsibility.
- * Receives dependencies via injection — no direct `node:fs` imports.
- */
-
-import { join } from "node:path";
-
-import { BUILTIN_TOOL_NAMES } from "#src/config/agent-types";
-import type { ParentSnapshot } from "#src/lifecycle/parent-snapshot";
-import type { Subagent } from "#src/types";
-import type { AgentFileOps } from "#src/ui/agent-file-ops";
-import { writeAgentFile } from "#src/ui/agent-file-writer";
-import type { MenuUI } from "#src/ui/agent-menu";
-
-// ---- Deps interface ----
-
-/** Narrow manager interface for agent spawning (generate wizard). */
-export interface WizardManager {
-  spawnAndWait: (
-    parentSnapshot: ParentSnapshot,
-    type: string,
-    prompt: string,
-    opts: { description: string; maxTurns: number },
-  ) => Promise<Subagent>;
-}
-
-/** Narrow registry interface for reloading after creation. */
-export interface WizardRegistry {
-  reload(): void;
-}
-
-// ---- Class ----
-
-export class AgentCreationWizard {
-  constructor(
-    private readonly fileOps: AgentFileOps,
-    private readonly manager: WizardManager,
-    private readonly registry: WizardRegistry,
-    private readonly personalAgentsDir: string,
-    private readonly projectAgentsDir: string,
-  ) {}
-
-  async showCreateWizard(ui: MenuUI, parentSnapshot: ParentSnapshot): Promise<void> {
-    const location = await ui.select("Choose location", [
-      "Project (.pi/agents/)",
-      `Personal (${this.personalAgentsDir})`,
-    ]);
-    if (!location) return;
-
-    const targetDir = location.startsWith("Project")
-      ? this.projectAgentsDir
-      : this.personalAgentsDir;
-
-    const method = await ui.select("Creation method", [
-      "Generate with Claude (recommended)",
-      "Manual configuration",
-    ]);
-    if (!method) return;
-
-    if (method.startsWith("Generate")) {
-      await this.showGenerateWizard(ui, parentSnapshot, targetDir);
-    } else {
-      await this.showManualWizard(ui, targetDir);
-    }
-  }
-
-  private async showGenerateWizard(
-    ui: MenuUI,
-    parentSnapshot: ParentSnapshot,
-    targetDir: string,
-  ): Promise<void> {
-    const description = await ui.input("Describe what this agent should do");
-    if (!description) return;
-
-    const name = await ui.input("Agent name (filename, no spaces)");
-    if (!name) return;
-
-    this.fileOps.ensureDir(targetDir);
-
-    const targetPath = join(targetDir, `${name}.md`);
-    if (this.fileOps.exists(targetPath)) {
-      const overwrite = await ui.confirm(
-        "Overwrite",
-        `${targetPath} already exists. Overwrite?`,
-      );
-      if (!overwrite) return;
-    }
-
-    ui.notify("Generating agent definition...", "info");
-
-    const generatePrompt = `Create a custom pi sub-agent definition file based on this description: "${description}"
-
-Write a markdown file to: ${targetPath}
-
-The file format is a markdown file with YAML frontmatter and a system prompt body:
-
-\`\`\`markdown
----
-description: <one-line description shown in UI>
-tools: <comma-separated built-in tools: read, bash, edit, write, grep, find, ls. Use "none" for no tools. Omit for all tools>
-model: <optional model as "provider/modelId", e.g. "anthropic/claude-haiku-4-5-20251001". Omit to inherit parent model>
-thinking: <optional thinking level: off, minimal, low, medium, high, xhigh. Omit to inherit>
-max_turns: <optional max agentic turns. 0 or omit for unlimited (default)>
-prompt_mode: <"replace" (body IS the full system prompt) or "append" (body is appended to default prompt). Default: append>
-inherit_context: <true to fork parent conversation into agent so it sees chat history. Default: false>
-run_in_background: <true to run in background by default. Default: false>
----
-
-<system prompt body — instructions for the agent>
-\`\`\`
-
-Guidelines for choosing settings:
-- For read-only tasks (review, analysis): tools: read, bash, grep, find, ls
-- For code modification tasks: include edit, write
-- Use prompt_mode: append if the agent should keep the default system prompt and add specialization on top
-- Use prompt_mode: replace for fully custom agents with their own personality/instructions
-- Set inherit_context: true if the agent needs to know what was discussed in the parent conversation
-- Only include frontmatter fields that differ from defaults — omit fields where the default is fine
-
-Write the file using the write tool. Only write the file, nothing else.`;
-
-    const record = await this.manager.spawnAndWait(
-      parentSnapshot,
-      "general-purpose",
-      generatePrompt,
-      {
-        description: `Generate ${name} agent`,
-        maxTurns: 5,
-      },
-    );
-
-    if (record.status === "error") {
-      ui.notify(`Generation failed: ${record.error}`, "warning");
-      return;
-    }
-
-    this.registry.reload();
-
-    if (this.fileOps.exists(targetPath)) {
-      ui.notify(`Created ${targetPath}`, "info");
-    } else {
-      ui.notify(
-        "Agent generation completed but file was not created. Check the agent output.",
-        "warning",
-      );
-    }
-  }
-
-  private async showManualWizard(ui: MenuUI, targetDir: string): Promise<void> {
-    const name = await ui.input("Agent name (filename, no spaces)");
-    if (!name) return;
-
-    const description = await ui.input("Description (one line)");
-    if (!description) return;
-
-    const toolChoice = await ui.select("Tools", [
-      "all",
-      "none",
-      "read-only (read, bash, grep, find, ls)",
-      "custom...",
-    ]);
-    if (!toolChoice) return;
-
-    let tools: string;
-    if (toolChoice === "all") {
-      tools = BUILTIN_TOOL_NAMES.join(", ");
-    } else if (toolChoice === "none") {
-      tools = "none";
-    } else if (toolChoice.startsWith("read-only")) {
-      tools = "read, bash, grep, find, ls";
-    } else {
-      const customTools = await ui.input(
-        "Tools (comma-separated)",
-        BUILTIN_TOOL_NAMES.join(", "),
-      );
-      if (!customTools) return;
-      tools = customTools;
-    }
-
-    const modelChoice = await ui.select("Model", [
-      "inherit (parent model)",
-      "haiku",
-      "sonnet",
-      "opus",
-      "custom...",
-    ]);
-    if (!modelChoice) return;
-
-    let modelLine = "";
-    if (modelChoice === "haiku")
-      modelLine = "\nmodel: anthropic/claude-haiku-4-5-20251001";
-    else if (modelChoice === "sonnet")
-      modelLine = "\nmodel: anthropic/claude-sonnet-4-6";
-    else if (modelChoice === "opus")
-      modelLine = "\nmodel: anthropic/claude-opus-4-6";
-    else if (modelChoice === "custom...") {
-      const customModel = await ui.input("Model (provider/modelId)");
-      if (customModel) modelLine = `\nmodel: ${customModel}`;
-    }
-
-    const thinkingChoice = await ui.select("Thinking level", [
-      "inherit",
-      "off",
-      "minimal",
-      "low",
-      "medium",
-      "high",
-      "xhigh",
-    ]);
-    if (!thinkingChoice) return;
-
-    let thinkingLine = "";
-    if (thinkingChoice !== "inherit") thinkingLine = `\nthinking: ${thinkingChoice}`;
-
-    const systemPrompt = await ui.editor("System prompt", "");
-    if (systemPrompt === undefined) return;
-
-    const content = `---
-description: ${description}
-tools: ${tools}${modelLine}${thinkingLine}
-prompt_mode: replace
----
-
-${systemPrompt}
-`;
-
-    const targetPath = join(targetDir, `${name}.md`);
-
-    await writeAgentFile(this.fileOps, ui, this.registry, targetPath, content, "Created");
-  }
-}

package/src/ui/agent-file-ops.ts

@@ -1,59 +0,0 @@
-/**
- * agent-file-ops.ts — Filesystem abstraction for agent .md file operations.
- *
- * Decouples menu sub-modules from direct `node:fs` imports, making them
- * testable via plain stub objects without `vi.mock()`.
- */
-
-import { existsSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from "node:fs";
-import { dirname, join } from "node:path";
-
-// ---- Interface ----
-
-/** Filesystem operations for agent `.md` files. */
-export interface AgentFileOps {
-  exists(filePath: string): boolean;
-  read(filePath: string): string | undefined;
-  write(filePath: string, content: string): void;
-  remove(filePath: string): void;
-  ensureDir(dirPath: string): void;
-  findAgentFile(name: string, dirs: string[]): string | undefined;
-}
-
-// ---- Production implementation ----
-
-/** Production implementation wrapping `node:fs` synchronous APIs. */
-export class FsAgentFileOps implements AgentFileOps {
-  exists(filePath: string): boolean {
-    return existsSync(filePath);
-  }
-
-  read(filePath: string): string | undefined {
-    try {
-      return readFileSync(filePath, "utf-8");
-    } catch {
-      return undefined;
-    }
-  }
-
-  write(filePath: string, content: string): void {
-    mkdirSync(dirname(filePath), { recursive: true });
-    writeFileSync(filePath, content, "utf-8");
-  }
-
-  remove(filePath: string): void {
-    unlinkSync(filePath);
-  }
-
-  ensureDir(dirPath: string): void {
-    mkdirSync(dirPath, { recursive: true });
-  }
-
-  findAgentFile(name: string, dirs: string[]): string | undefined {
-    for (const dir of dirs) {
-      const p = join(dir, `${name}.md`);
-      if (existsSync(p)) return p;
-    }
-    return undefined;
-  }
-}

package/src/ui/agent-file-writer.ts

@@ -1,55 +0,0 @@
-/**
- * agent-file-writer.ts — Shared overwrite-guard + write + reload + notify helper.
- *
- * Extracted from AgentConfigEditor.ejectAgent and AgentCreationWizard.showManualWizard
- * to eliminate the duplicated 20-line pattern. Uses narrow interfaces (ISP) so callers
- * are not forced to depend on the full AgentFileOps or MenuUI shapes.
- */
-
-// ---- Narrow interfaces ----
-
-/** Minimal file operations needed by the overwrite-guard-and-write pattern. */
-export interface FileWriter {
-	exists(filePath: string): boolean;
-	write(filePath: string, content: string): void;
-}
-
-/** Minimal UI needed by the overwrite-guard-and-write pattern. */
-export interface WriterUI {
-	confirm(title: string, message: string): Promise<boolean>;
-	notify(message: string, level: "info" | "warning" | "error"): void;
-}
-
-/** Registry that can be reloaded after file changes. */
-export interface Reloadable {
-	reload(): void;
-}
-
-// ---- Function ----
-
-/**
- * Write an agent `.md` file with an overwrite guard.
- *
- * If `targetPath` already exists, prompts the user for confirmation before writing.
- * On write: reloads the registry and notifies the user as `"${label} ${targetPath}"`.
- *
- * Returns `true` if the file was written, `false` if the user declined to overwrite.
- */
-export async function writeAgentFile(
-	fileOps: FileWriter,
-	ui: WriterUI,
-	registry: Reloadable,
-	targetPath: string,
-	content: string,
-	label: string,
-): Promise<boolean> {
-	if (fileOps.exists(targetPath)) {
-		const overwrite = await ui.confirm("Overwrite", `${targetPath} already exists. Overwrite?`);
-		if (!overwrite) return false;
-	}
-
-	fileOps.write(targetPath, content);
-	registry.reload();
-	ui.notify(`${label} ${targetPath}`, "info");
-	return true;
-}