@gotgenes/pi-subagents 17.5.0 → 18.0.0

package/docs/retro/0442-dissolve-agents-conversation-viewer.md

@@ -0,0 +1,108 @@
+---
+issue: 442
+issue_title: "pi-subagents: dissolve /agents and remove the conversation-viewer subtree"
+---
+
+# Retro: #442 — pi-subagents: dissolve /agents and remove the conversation-viewer subtree
+
+## Stage: Planning (2026-06-23T18:06:31Z)
+
+### Session summary
+
+Planned Phase 19 Step 5: dissolve the `/agents` command and delete the conversation-viewer subtree (`agent-menu.ts`, `conversation-viewer.ts`, `message-formatters.ts`, plus their three tests), dewire `index.ts`.
+Investigation surfaced a blocker the issue overlooked — a bidirectional type cycle between the hub and its leaves — and the operator chose a tidy-first resolution.
+Plan committed at `packages/pi-subagents/docs/plans/0442-dissolve-agents-conversation-viewer.md`; this is a `/build-plan` (no red→green cycles), batched for release with the tail [#441].
+
+### Observations
+
+- Key finding: `agent-creation-wizard.ts` and `agent-config-editor.ts` (which survive until [#441]) both `import type { MenuUI } from "#src/ui/agent-menu"` and use it throughout, while the hub value-imports the wizard/editor classes — a bidirectional cycle.
+  Deleting either subtree first breaks `tsc --noEmit` (type-checks `src` + `test`).
+  The issue's "pure orphans" premise holds for runtime reachability but not at the type level.
+- Flipping the [#442]/[#441] order does **not** fix it (cycle is bidirectional) — surfaced this directly when the operator asked about step ordering.
+- Operator decision via `ask_user`: keep two commits, relocate `MenuUI` to a surviving `src/ui/menu-ui.ts` first (tidy-first).
+  Rejected alternatives: merge [#441] into [#442] (one deletion commit), or inline a throwaway `MenuUI` into the doomed leaves.
+- Operator confirmed release timing: do not release until both [#442] and [#441] land — marker is `mid-batch — defer (batch "dissolve-agents")`, tail is [#441].
+- `menu-ui.ts` is intentionally transient (one issue's lifespan); it keeps two live consumers (wizard/editor) immediately, so no fallow dead-code flag; [#441] deletes it with its consumers.
+- Verified no collateral: `FsAgentFileOps` stays off the dead-code list because its own test still imports it; `subagents-settings.ts` defines its own `SubagentsSettingsUI` (no `MenuUI` coupling); `ui-stubs.ts`'s `makeMenuUI` is structurally typed; `join`/`buildParentSnapshot` become dead `index.ts` imports and are removed; deleting the consumers orphans no `display.ts` export.
+- Change is breaking (the `/agents` command disappears) → deletion commit is `feat(pi-subagents)!:` with a `BREAKING CHANGE:` footer naming `/subagents:settings`, `/subagents:sessions`, and the background widget (verified the real registered command names, not the architecture's proposed `/subagents-settings`).
+- Deferred the holistic architecture-doc refresh (Mermaid domain diagram, complexity/health tables, Phase-19-to-history migration) to the batch tail [#441] to avoid double-editing tables that [#441] also touches; [#442] keeps only the current-state file tree, the Step 5 `Outcome:` annotation, and the SKILL.md UI count accurate.
+
+[#441]: https://github.com/gotgenes/pi-packages/issues/441
+[#442]: https://github.com/gotgenes/pi-packages/issues/442
+
+## Stage: Implementation — Build (2026-06-23T19:30:00Z)
+
+### Session summary
+
+Executed both plan commits (Step 1: extract `MenuUI`; Step 2: delete hub+viewer+formatters and dewire `index.ts`).
+A mid-session diversion investigated the commitlint `#N`-in-body false positive (issue [#4099]), determined it is still present in v21.0.2 despite the issue being closed, and removed the `--strict` flag from `prek.toml` so the warning no longer blocks commits.
+Pre-completion reviewer returned PASS.
+
+### Observations
+
+- **Unplanned fallow finding:** after deleting `agent-menu.ts`, `showAgentDetail` (`agent-config-editor.ts`) and `showCreateWizard` (`agent-creation-wizard.ts`) lost their only external callers and became unused class members.
+  The plan's risk analysis covered unused *files* (`FsAgentFileOps`) but not unused class *methods*.
+  Added `// fallow-ignore-next-line unused-class-member` suppressions with a comment pointing to [#441] as the removal commit.
+  Future plans for hub-deletion steps should explicitly check whether public methods on surviving leaf classes lose their only caller.
+- **Unplanned commitlint diversion:** bodies with `#N` mid-sentence in multi-paragraph messages are still misidentified as footer tokens by commitlint v21.0.2 despite issue [#4099] being closed COMPLETED on 2026-06-02 with no linked PR.
+  Removed `--strict` from the `commit-msg` hook in `prek.toml` so the false-positive is a non-blocking warning; updated `AGENTS.md` accordingly.
+  This also required untangling a bad commit (the `git rm`'d pi-subagents files were swept into the commitlint fix commit) via `git reset HEAD~1` + selective re-staging.
+- **Commit message refinement:** learned empirically that `#N` appearing in a wrapped body line (near end of line) triggers the false positive even in a single-paragraph body; a two-paragraph body with `#N` in the second paragraph was the original failure mode.
+  Workaround before the `--strict` removal: keep `#N` out of body prose; use `Refs #N` as a true footer with a blank-line separator.
+- Pre-completion reviewer: PASS — all deterministic checks green; doc-staleness WARNs (Mermaid domain diagram, structural tables, Phase 19 history) are intentional mid-batch deferred work per the plan's Non-Goals, to be resolved at the batch tail [#441].
+
+[#4099]: https://github.com/conventional-changelog/commitlint/issues/4099
+
+## Stage: Final Retrospective (2026-06-23T20:05:13Z)
+
+### Session summary
+
+Shipped Phase 19 Step 5 across plan → build → ship: extracted `MenuUI` to break a bidirectional type cycle, deleted the `/agents` hub plus the conversation-viewer subtree, and dewired `index.ts`.
+The release was correctly deferred at ship time per the `mid-batch — defer` marker (batch tail is [#441]).
+The session's dominant friction was an unplanned commitlint diversion that produced a blunt fix, then a superseding surgical fix, a bad-commit untangle, and a new tracking issue ([#468]).
+
+### Observations
+
+#### What went well
+
+1. The Planning `ask_user` gate caught the hub↔leaf bidirectional type cycle before any code was written and produced a clean tidy-first plan (relocate `MenuUI` first), so the two implementation commits were each green — no broken-commit sequence.
+2. The commitlint claim was verified empirically by running `commitlint` against crafted test messages, not by trusting the closed-issue status — this confirmed [#4099] was closed `COMPLETED` without a shipped fix and that the false positive still fired in `v21.0.2`.
+3. Incremental verification: `pnpm run check`/`lint`/`test`/`fallow dead-code` ran after each implementation step, so the unused-class-member finding surfaced at the right step rather than at the end.
+
+#### What caused friction (agent side)
+
+1. `premature-convergence` — the first commitlint fix (`9b60c943`, remove `--strict`) was blunt: dropping `--strict` silences every warning-level rule, including the load-bearing malformed-`!`-header rejection (Refs #457).
+   The surgical fix (`40189cc4`, disable only `footer-leading-blank`, keep `--strict`) only emerged from a separate branch reconsideration.
+   Impact: one superseded `fix(commitlint):` commit now permanent in pushed history; a #457 regression was avoided only because the blunt fix was reconsidered before the batch released.
+2. `other` (git workflow) — `git rm` pre-stages its deletions, so a later `git add prek.toml AGENTS.md && git commit` for the commitlint fix swept the already-staged `/agents` deletions into the wrong commit.
+   Required `git reset HEAD~1` plus selective re-staging to untangle.
+   Impact: ~4 extra tool calls; caught immediately, no lasting damage.
+3. `missing-context` / unused-tool — determining the upstream commitlint issue state took several rounds of `web_search` + `fetch_content` until the user said "Remember you have access to the `gh` CLI, too"; `gh issue view 4099 --repo conventional-changelog/commitlint` then returned the authoritative state (`CLOSED`/`COMPLETED`, no linked PR) in one call.
+   Impact: several wasted research rounds; user-caught.
+4. `missing-context` (minor) — the plan's risk analysis covered unused *files* (`FsAgentFileOps`, kept live by its test import) but not unused class *methods*; deleting the hub orphaned `showAgentDetail` and `showCreateWizard`, tripping `fallow dead-code`.
+   Impact: low — caught by the gate, resolved with two `fallow-ignore-next-line unused-class-member` suppressions pointing at [#441].
+
+#### What caused friction (user side)
+
+1. The agent reached for `web_search`/`fetch_content` to check a GitHub issue's state instead of `gh`; the user had to point at an available tool.
+   Opportunity: reach for `gh issue view`/`gh pr view` first for GitHub issue/PR state, including upstream repos.
+2. The user supplied the steer toward a surgical fix ("prefer surgical fixes over blunt ones").
+   Opportunity: a standing rule about disabling the single offending rule rather than the enforcement mode could have produced the surgical fix on the first pass.
+
+### Diagnostic details
+
+- **Model-performance correlation** — the `pre-completion-reviewer` subagent ran on `anthropic/claude-sonnet-4-6` (per its agent frontmatter), appropriate for judgment-heavy review; the implementation ran on `claude-opus-4-8`.
+  No quality mismatch.
+  The many `model_change` entries are transient UI cycling (no assistant turn under most), not real reassignments.
+- **Escalation-delay tracking** — the upstream-issue-state investigation ran ~6 consecutive `web_search`/`fetch_content` calls before the `gh` reminder; one `gh issue view` would have resolved it immediately.
+- **Unused-tool detection** — `gh` was available throughout but not used for upstream issue state until prompted.
+- **Feedback-loop gap analysis** — no gap; verification ran incrementally after each step.
+
+[#468]: https://github.com/gotgenes/pi-packages/issues/468
+
+### Changes made
+
+1. `AGENTS.md` (`## Commits`) — tightened the `footer-leading-blank` note from ~62 words to rule + `Refs #468`, dropping the parser-variant list and the two upstream issue numbers (now here and in [#468]).
+2. `AGENTS.md` (`## Commits`) — added a single-rule-vs-mode principle: disable the single offending lint rule (`[0]`), not the `--strict` enforcement mode that gates the others.
+3. `AGENTS.md` (`## Workflow`) — added a bullet to use `gh issue view N --repo owner/repo` for GitHub issue/PR state instead of web search.
+4. `AGENTS.md` (`## Commits`, git mechanics) — added a note that staged `git rm` deletions ride along with the next `git commit` even when only unrelated paths are `git add`ed; commit with an explicit pathspec or check `git status` first.

package/docs/retro/0463-file-snapshot-source-evicted-agents.md

@@ -47,3 +47,57 @@ Test count went from 1088 to 1099 (+11); full suite, `check`, root `lint`, and `
   Both fixed and re-committed; `check` + tests confirmed green after.
 - **Transient dead code** between steps 1–2 and 3 (predicted in the plan) cleared at the step-3 tip; final `fallow dead-code` is clean.
 - **Pre-completion reviewer: PASS** — deterministic checks, code design, test artifacts, Mermaid render, and all three cross-step invariants (no inbound core call, read-only overlay, renderer parity) verified; no follow-ups deferred.
+
+## Stage: Final Retrospective (2026-06-23T17:43:05Z)
+
+### Session summary
+
+Single continuous session carried #463 from planning through ship: a 4-step plan, TDD implementation (+11 tests, 1088→1099), pre-completion PASS, and release of `pi-subagents` v17.5.0.
+The defining moment was planning: an `ask_user` design gate plus operator Socratic pushback diverged the candidate-set design from the issue's literal "directory scan" wording to manager-retained descriptors.
+Execution was notably clean — no rework, no plan deviations, two auto-fixed lint nits.
+
+### Observations
+
+#### What went well
+
+- **The `ask_user` gate caught a real design fork the issue body got wrong.**
+  The issue's "Proposed change" said "enumerate persisted child-session JSONL files" (a directory scan).
+  Exploration revealed the persisted session carries no subagent `type`/`description`, so a scan yields degraded labels.
+  The gate surfaced descriptors-vs-scan-vs-hybrid; the operator's "why are we evicting at all?"
+  and "tell me more about how the labels degrade" drove a better-grounded decision (descriptors).
+  This is the `/plan-issue` "treat Proposed change as a hypothesis" contract working as intended — novel because the divergence was the *enumeration mechanism*, not a surface ambiguity.
+- **Exploratory probe before the first TDD test.**
+  A disposable script (`explore-session.mjs`, deleted after) confirmed `buildSessionContext` auto-detects the leaf with no `leafId` and the `type !== "session"` filter drops the header — validating the `fileSnapshotSource` shape before any test was written (the `testing` skill's "inspect the actual runtime shape first" rule).
+- **The plan predicted transient dead code and sequenced to clear it.**
+  `fileSnapshotSource` and `listEvicted()` had no caller until step 3; the plan flagged this and ordered the integration step to close it, so the final `fallow dead-code` gate passed with no surprise suppressions.
+- **Pre-completion reviewer ran on `claude-sonnet-4-6`** — model appropriate for the judgment-heavy invariant/design checklist; returned PASS.
+
+#### What caused friction (agent side)
+
+- `other` — the first `ask_user` led with the enumeration mechanism (descriptors/scan/hybrid) before establishing *why eviction creates the problem*.
+  The operator's first reply was "Why are we 'evicting' subagents in the first place?", i.e. asking for the framing I already held but had not front-loaded.
+  Impact: two extra `ask_user` round-trips before the decision — but they produced a better-understood outcome, so net-positive; no rework.
+- `other` (lint nit) — four `entry?.kind` optional chains on a destructured array element tripped `@typescript-eslint/no-unnecessary-condition`, and a stray `!` tripped `no-unnecessary-type-assertion`; both surfaced via the pre-commit hook.
+  Impact: two re-commits during steps 2–3, auto-fixed, zero rework.
+
+#### What caused friction (user side)
+
+- None.
+  The operator's Socratic questions mid-`ask_user` were the session's highest-value input — they converted a plausible-but-degraded design (scan) into the right one (descriptors).
+  If anything, this is a model for how the gate should be used.
+
+### Diagnostic details
+
+- **Model-performance correlation** — the `pre-completion-reviewer` subagent ran on `anthropic/claude-sonnet-4-6` (judgment-heavy review): appropriate, no mismatch.
+  Main-thread `model_change` events included a `deepseek-v4-flash` variant; no quality degradation was observed in any artifact (plan, code, tests all clean), so no actionable correlation.
+- **Escalation-delay tracking** — no `rabbit-hole` points; longest same-error streak was the two lint auto-fixes, each resolved in one re-commit.
+- **Unused-tool detection** — exploration used `colgrep`, `grep`, and a disposable runtime probe; no missed-tool opportunities.
+- **Feedback-loop gap analysis** — verification ran incrementally: `pnpm run check` after the shared-interface steps (2 and 3), per-file `vitest` on each red/green cycle, and the full suite + lint + `fallow` before the docs commit.
+  No end-only verification.
+
+### Changes made
+
+1. Appended this Final Retrospective stage entry to `packages/pi-subagents/docs/retro/0463-file-snapshot-source-evicted-agents.md`.
+
+No `AGENTS.md` or prompt changes — the session's friction was net-positive (the `ask_user` round-trips) or auto-fixed with zero rework (the lint nits).
+Two candidate changes were considered and rejected as noise (a `code-design` note on `entry?.kind` optional chaining; an `ask-user` "why-before-mechanism" guidance already covered by the skill).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-subagents",
-  "version": "17.5.0",
+  "version": "18.0.0",
   "type": "module",
   "exports": {
     ".": {

package/src/index.ts

@@ -8,11 +8,9 @@
  *   steer_subagent       — LLM-callable: send a steering message to a running agent
  *
  * Commands:
- *   /agents                 — Interactive agent management menu
  */
 
 import { readFileSync } from "node:fs";
-import { join } from "node:path";
 import {
   createAgentSession,
   DefaultResourceLoader,
@@ -27,7 +25,6 @@ import { InterruptHandler, SessionLifecycleHandler, ToolStartHandler } from "#sr
 import { createChildLifecyclePublisher } from "#src/lifecycle/child-lifecycle";
 import { ConcurrencyLimiter } from "#src/lifecycle/concurrency-limiter";
 import { createSubagentSession, type SubagentSessionDeps } from "#src/lifecycle/create-subagent-session";
-import { buildParentSnapshot } from "#src/lifecycle/parent-snapshot";
 import { SubagentManager } from "#src/lifecycle/subagent-manager";
 import { CompositeSubagentObserver } from "#src/observation/composite-subagent-observer";
 import { type NotificationDetails, NotificationManager } from "#src/observation/notification";
@@ -45,8 +42,6 @@ import { SettingsManager } from "#src/settings";
 import { AgentTool } from "#src/tools/agent-tool";
 import { GetResultTool } from "#src/tools/get-result-tool";
 import { SteerTool } from "#src/tools/steer-tool";
-import { FsAgentFileOps } from "#src/ui/agent-file-ops";
-import { AgentsMenuHandler } from "#src/ui/agent-menu";
 import { AgentWidget } from "#src/ui/agent-widget";
 import { SessionNavigatorHandler } from "#src/ui/session-navigator";
 import { SubagentsSettingsHandler } from "#src/ui/subagents-settings";
@@ -162,44 +157,22 @@ export default function (pi: ExtensionAPI) {
 
   pi.registerTool(new SteerTool(manager, pi.events).toToolDefinition());
 
-  // ---- /agents interactive menu ----
-
-  const agentsMenu = new AgentsMenuHandler(
-    manager,
-    registry,
-    settings,
-    new FsAgentFileOps(),
-    join(getAgentDir(), "agents"),
-    join(process.cwd(), ".pi", "agents"),
-  );
-
-  pi.registerCommand("agents", {
-    description: "Manage agents",
-    handler: async (_args, ctx) => {
-      await agentsMenu.handle({
-        ui: ctx.ui,
-        modelRegistry: ctx.modelRegistry,
-        parentSnapshot: buildParentSnapshot(ctx),
-      });
-    },
-  });
-
-  // ---- /subagents-settings command ----
+  // ---- /subagents:settings command ----
 
   const subagentsSettings = new SubagentsSettingsHandler(settings);
 
-  pi.registerCommand("subagents-settings", {
+  pi.registerCommand("subagents:settings", {
     description: "Configure subagent settings (concurrency, turn limits)",
     handler: async (_args, ctx) => {
       await subagentsSettings.handle({ ui: ctx.ui });
     },
   });
 
-  // ---- /subagent-sessions command ----
+  // ---- /subagents:sessions command ----
 
   const sessionNavigator = new SessionNavigatorHandler();
 
-  pi.registerCommand("subagent-sessions", {
+  pi.registerCommand("subagents:sessions", {
     description: "View a subagent's session transcript (read-only)",
     handler: async (_args, ctx) => {
       await sessionNavigator.handle({

package/src/ui/session-navigation.ts

@@ -1,7 +1,7 @@
 /**
  * session-navigation.ts — Pure selection and transcript-sourcing for native session navigation.
  *
- * Splits the unit-testable core of the `/subagent-sessions` command from its TUI
+ * Splits the unit-testable core of the `/subagents:sessions` command from its TUI
  * wiring (`session-navigator.ts`): which subagents are navigable and how a picked
  * agent's transcript is sourced (live, in this slice).
  *

package/src/ui/session-navigator.ts

@@ -1,5 +1,5 @@
 /**
- * session-navigator.ts — The `/subagent-sessions` command: pick a subagent and
+ * session-navigator.ts — The `/subagents:sessions` command: pick a subagent and
  * read its transcript through Pi's own per-entry session components.
  *
  * SDK/TUI consumer half of native session navigation. The unit-testable core
@@ -65,7 +65,7 @@ export interface SessionNavigatorUI {
   custom<R>(component: OverlayComponentFactory<R>, options?: unknown): Promise<R>;
 }
 
-/** Parameters for one `/subagent-sessions` invocation. */
+/** Parameters for one `/subagents:sessions` invocation. */
 export interface SessionNavigatorParams {
   ui: SessionNavigatorUI;
   agents: readonly NavigableSubagent[];
@@ -89,7 +89,7 @@ export interface TranscriptOverlayOptions {
 }
 
 /**
- * Handler for the `/subagent-sessions` slash command.
+ * Handler for the `/subagents:sessions` slash command.
  *
  * Lists navigable subagents, lets the operator pick one, and opens its transcript
  * read-only. Receives the agent snapshot (`manager.listAgents()`) rather than the

package/src/ui/subagents-settings.ts

@@ -1,6 +1,6 @@
 // ---- Narrow interfaces ----
 
-/** Narrow settings interface required by the subagents-settings command. */
+/** Narrow settings interface required by the subagents:settings command. */
 export interface SubagentsSettingsManager {
   readonly maxConcurrent: number;
   readonly defaultMaxTurns: number | undefined;
@@ -20,7 +20,7 @@ export interface SubagentsSettingsUI {
 // ---- Class ----
 
 /**
- * Handler for the `/subagents-settings` slash command.
+ * Handler for the `/subagents:settings` slash command.
  *
  * Call `handle({ ui })` from the Pi command registration to open the interactive
  * settings list. Lifted from `AgentsMenuHandler.showSettings`.

package/src/ui/agent-config-editor.ts

@@ -1,199 +0,0 @@
-/**
- * agent-config-editor.ts — Agent detail view with edit/delete/eject/disable/enable transitions.
- *
- * Extracted from agent-menu.ts to give each concern a single responsibility.
- * Receives dependencies via injection — no direct `node:fs` imports.
- */
-
-import { join } from "node:path";
-
-import type { AgentTypeRegistry } from "#src/config/agent-types";
-import type { AgentConfig } from "#src/types";
-import type { AgentFileOps } from "#src/ui/agent-file-ops";
-import { writeAgentFile } from "#src/ui/agent-file-writer";
-import type { MenuUI } from "#src/ui/agent-menu";
-
-// ---- Pure helpers ----
-
-/** Compute the menu option list for the agent detail view. */
-export function buildMenuOptions(
-  cfg: { isDefault?: boolean; enabled?: boolean },
-  file: string | undefined,
-): string[] {
-  const isDefault = cfg.isDefault === true;
-  const disabled = cfg.enabled === false;
-
-  if (disabled && file) {
-    return isDefault
-      ? ["Enable", "Edit", "Reset to default", "Delete", "Back"]
-      : ["Enable", "Edit", "Delete", "Back"];
-  }
-  if (isDefault && !file) {
-    return ["Eject (export as .md)", "Disable", "Back"];
-  }
-  if (isDefault && file) {
-    return ["Edit", "Disable", "Reset to default", "Delete", "Back"];
-  }
-  return ["Edit", "Disable", "Delete", "Back"];
-}
-
-/** Build the `.md` file content (frontmatter + system prompt) for an ejected agent. */
-export function buildEjectContent(cfg: AgentConfig): string {
-  const fmFields: string[] = [];
-  fmFields.push(`description: ${cfg.description}`);
-  if (cfg.displayName) fmFields.push(`display_name: ${cfg.displayName}`);
-  fmFields.push(`tools: ${cfg.builtinToolNames?.join(", ") ?? "all"}`);
-  if (cfg.model) fmFields.push(`model: ${cfg.model}`);
-  if (cfg.thinking) fmFields.push(`thinking: ${cfg.thinking}`);
-  if (cfg.maxTurns) fmFields.push(`max_turns: ${cfg.maxTurns}`);
-  fmFields.push(`prompt_mode: ${cfg.promptMode}`);
-  if (cfg.inheritContext) fmFields.push("inherit_context: true");
-  if (cfg.runInBackground) fmFields.push("run_in_background: true");
-  return `---\n${fmFields.join("\n")}\n---\n\n${cfg.systemPrompt}\n`;
-}
-
-// ---- Class ----
-
-export class AgentConfigEditor {
-  constructor(
-    private readonly fileOps: AgentFileOps,
-    private readonly registry: AgentTypeRegistry,
-    private readonly personalAgentsDir: string,
-    private readonly projectAgentsDir: string,
-  ) {}
-
-  private agentDirs(): string[] {
-    return [this.projectAgentsDir, this.personalAgentsDir];
-  }
-
-  async showAgentDetail(ui: MenuUI, name: string): Promise<void> {
-    if (this.registry.resolveType(name) == null) {
-      ui.notify(`Agent config not found for "${name}".`, "warning");
-      return;
-    }
-    const cfg = this.registry.resolveAgentConfig(name);
-    const file = this.fileOps.findAgentFile(name, this.agentDirs());
-
-    const choice = await ui.select(name, buildMenuOptions(cfg, file));
-    if (!choice || choice === "Back") return;
-
-    if (choice === "Edit" && file) await this.handleEdit(ui, name, file);
-    else if (choice === "Delete" && file) await this.handleDelete(ui, name, file);
-    else if (choice === "Reset to default" && file)
-      await this.handleReset(ui, name, file);
-    else if (choice.startsWith("Eject")) await this.ejectAgent(ui, name, cfg);
-    else if (choice === "Disable") await this.disableAgent(ui, name);
-    else if (choice === "Enable") await this.enableAgent(ui, name);
-  }
-
-  private async handleEdit(ui: MenuUI, name: string, file: string): Promise<void> {
-    const content = this.fileOps.read(file);
-    if (content === undefined) return;
-    const edited = await ui.editor(`Edit ${name}`, content);
-    if (edited !== undefined && edited !== content) {
-      this.fileOps.write(file, edited);
-      this.registry.reload();
-      ui.notify(`Updated ${file}`, "info");
-    }
-  }
-
-  private async handleDelete(ui: MenuUI, name: string, file: string): Promise<void> {
-    const confirmed = await ui.confirm(
-      "Delete agent",
-      `Delete ${name} (${file})?`,
-    );
-    if (confirmed) {
-      this.fileOps.remove(file);
-      this.registry.reload();
-      ui.notify(`Deleted ${file}`, "info");
-    }
-  }
-
-  private async handleReset(ui: MenuUI, name: string, file: string): Promise<void> {
-    const confirmed = await ui.confirm(
-      "Reset to default",
-      `Delete override ${file} and restore embedded default?`,
-    );
-    if (confirmed) {
-      this.fileOps.remove(file);
-      this.registry.reload();
-      ui.notify(`Restored default ${name}`, "info");
-    }
-  }
-
-  private async ejectAgent(ui: MenuUI, name: string, cfg: AgentConfig): Promise<void> {
-    const location = await ui.select("Choose location", [
-      "Project (.pi/agents/)",
-      `Personal (${this.personalAgentsDir})`,
-    ]);
-    if (!location) return;
-
-    const targetDir = location.startsWith("Project")
-      ? this.projectAgentsDir
-      : this.personalAgentsDir;
-
-    const targetPath = join(targetDir, `${name}.md`);
-    await writeAgentFile(
-      this.fileOps,
-      ui,
-      this.registry,
-      targetPath,
-      buildEjectContent(cfg),
-      `Ejected ${name} to`,
-    );
-  }
-
-  private async disableAgent(ui: MenuUI, name: string): Promise<void> {
-    const file = this.fileOps.findAgentFile(name, this.agentDirs());
-    if (file) {
-      const content = this.fileOps.read(file);
-      if (content?.includes("\nenabled: false\n")) {
-        ui.notify(`${name} is already disabled.`, "info");
-        return;
-      }
-      if (content) {
-        const updated = content.replace(/^---\n/, "---\nenabled: false\n");
-        this.fileOps.write(file, updated);
-        this.registry.reload();
-        ui.notify(`Disabled ${name} (${file})`, "info");
-      }
-      return;
-    }
-
-    const location = await ui.select("Choose location", [
-      "Project (.pi/agents/)",
-      `Personal (${this.personalAgentsDir})`,
-    ]);
-    if (!location) return;
-
-    const targetDir = location.startsWith("Project")
-      ? this.projectAgentsDir
-      : this.personalAgentsDir;
-
-    const targetPath = join(targetDir, `${name}.md`);
-    this.fileOps.write(targetPath, "---\nenabled: false\n---\n");
-    this.registry.reload();
-    ui.notify(`Disabled ${name} (${targetPath})`, "info");
-  }
-
-  // eslint-disable-next-line @typescript-eslint/require-await
-  private async enableAgent(ui: MenuUI, name: string): Promise<void> {
-    const file = this.fileOps.findAgentFile(name, this.agentDirs());
-    if (!file) return;
-
-    const content = this.fileOps.read(file);
-    if (!content) return;
-
-    const updated = content.replace(/^(---\n)enabled: false\n/, "$1");
-
-    if (updated.trim() === "---\n---" || updated.trim() === "---\n---\n") {
-      this.fileOps.remove(file);
-      this.registry.reload();
-      ui.notify(`Enabled ${name} (removed ${file})`, "info");
-    } else {
-      this.fileOps.write(file, updated);
-      this.registry.reload();
-      ui.notify(`Enabled ${name} (${file})`, "info");
-    }
-  }
-}