@gotgenes/pi-subagents 11.0.0 → 11.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md
CHANGED
|
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
|
|
|
5
5
|
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
|
|
6
6
|
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
7
7
|
|
|
8
|
+
## [11.0.1](https://github.com/gotgenes/pi-packages/compare/pi-subagents-v11.0.0...pi-subagents-v11.0.1) (2026-05-28)
|
|
9
|
+
|
|
10
|
+
|
|
11
|
+
### Documentation
|
|
12
|
+
|
|
13
|
+
* **retro:** add retro notes for issue [#229](https://github.com/gotgenes/pi-packages/issues/229) ([13e9873](https://github.com/gotgenes/pi-packages/commit/13e9873f6dc3e8522cd6359085f86c99507e9db9))
|
|
14
|
+
|
|
8
15
|
## [11.0.0](https://github.com/gotgenes/pi-packages/compare/pi-subagents-v10.2.1...pi-subagents-v11.0.0) (2026-05-28)
|
|
9
16
|
|
|
10
17
|
|
|
@@ -45,3 +45,45 @@ Test count went from 1005 to 1020 (+15 tests).
|
|
|
45
45
|
- **Worktree error surface confirmed async:** The `agent-manager.test.ts` test for synchronous worktree throw was rewritten to verify the error surfaces on `record.error` after awaiting the promise.
|
|
46
46
|
`background-spawner.ts` try/catch around `spawn()` retained for robustness.
|
|
47
47
|
- **Pre-completion reviewer:** WARN — 3 non-blocking findings: `setupWorktree` not marked private, `isBackground` dead field on `AgentInit`, and `package-pi-subagents` SKILL.md Phase 15 description referencing deleted `startAgent`.
|
|
48
|
+
|
|
49
|
+
## Stage: Final Retrospective (2026-05-28T01:30:00Z)
|
|
50
|
+
|
|
51
|
+
### Session summary
|
|
52
|
+
|
|
53
|
+
Planned, implemented (9 TDD steps), shipped, and released `pi-subagents-v11.0.0` in a single session spanning planning → TDD → ship → retro.
|
|
54
|
+
Test count: 1005 → 1020 (+15).
|
|
55
|
+
Also filed #249 (`pi-permission-system` bash external-directory gate bug) discovered during the pre-completion review.
|
|
56
|
+
|
|
57
|
+
### Observations
|
|
58
|
+
|
|
59
|
+
#### What went well
|
|
60
|
+
|
|
61
|
+
- The lift-and-shift TDD strategy (steps 1–5 incrementally preparing, step 6 adding `Agent.run()`, step 7 rewriting `spawn()`) kept every commit compilable and green.
|
|
62
|
+
No step required backtracking.
|
|
63
|
+
- The `ask-user` call during planning (observer pattern vs callbacks, sync vs async error surface) front-loaded design decisions that would have caused rework if deferred.
|
|
64
|
+
- Pre-commit hooks caught both lint failures (`no-unnecessary-condition` on `abortController?.abort()`, `unbound-method` on observer forwarding) before they reached CI.
|
|
65
|
+
|
|
66
|
+
#### What caused friction (agent side)
|
|
67
|
+
|
|
68
|
+
- `wrong-abstraction` — The plan separated step 7 (remove `onSessionCreated` from `AgentSpawnConfig`) and step 8 (update tool-layer consumers) as distinct commits.
|
|
69
|
+
Removing the field immediately broke `background-spawner.ts` and `foreground-runner.ts` at compilation, forcing a merge.
|
|
70
|
+
Impact: added friction but no rework — the merge was straightforward since both files needed the same `onSessionCreated` → `observer` transformation.
|
|
71
|
+
Added a testing skill rule to catch this pattern in future plans.
|
|
72
|
+
|
|
73
|
+
#### What caused friction (user side)
|
|
74
|
+
|
|
75
|
+
- The pre-completion reviewer's Mermaid validation (`mmdc -o /tmp/mermaid-check.svg`) triggered a permission prompt from `pi-permission-system` despite `/tmp/*` being configured as `"allow"` in the global config.
|
|
76
|
+
This was a genuine bug (#249) in the bash external-directory gate, not a config mistake.
|
|
77
|
+
The prompt interrupted the automated review flow, requiring manual approval.
|
|
78
|
+
|
|
79
|
+
### Diagnostic details
|
|
80
|
+
|
|
81
|
+
- **Model-performance correlation** — Pre-completion reviewer ran on `claude-sonnet-4-6-20260526`; appropriate for judgment-heavy review work (code design, acceptance criteria, mermaid validation).
|
|
82
|
+
No mismatches detected.
|
|
83
|
+
- **Feedback-loop gap analysis** — `pnpm run check` and `pnpm run test` were run after every TDD step commit, not just at the end.
|
|
84
|
+
`pnpm run lint` ran at the end (post-TDD checks) and at pre-push, which is correct since lint is slower and pre-commit hooks catch most issues incrementally.
|
|
85
|
+
|
|
86
|
+
### Changes made
|
|
87
|
+
|
|
88
|
+
1. `.pi/skills/testing/SKILL.md` — added TDD planning rule: when a step removes a field from a shared interface, all downstream readers must update in the same step.
|
|
89
|
+
2. `packages/pi-subagents/docs/retro/0229-agent-born-complete.md` — appended Final Retrospective stage entry.
|