@gotgenes/pi-permission-system 8.2.0 → 8.2.1

package/test/handlers/input-events.test.ts

@@ -1,99 +1,28 @@
 /**
  * Tests that handleInput emits permissions:decision events for skill input gates.
  */
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { describe, expect, it, vi } from "vitest";
 
-import { PermissionGateHandler } from "#src/handlers/permission-gate-handler";
-import type { PermissionDecisionEvent } from "#src/permission-events";
-import { PERMISSIONS_DECISION_CHANNEL } from "#src/permission-events";
-import type { PermissionSession } from "#src/permission-session";
-import type { ToolRegistry } from "#src/tool-registry";
+import {
+  getDecisionEvents,
+  makeCheckResult,
+  makeCtx,
+  makeHandler,
+} from "#test/helpers/handler-fixtures";
 
 // ── helpers ────────────────────────────────────────────────────────────────
 
-function makeEvents() {
-  return {
-    emit: vi.fn(),
-    on: vi.fn().mockReturnValue(() => undefined),
-  };
-}
-
-function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
-  return {
-    cwd: "/test/project",
-    hasUI: true,
-    ui: {
-      setStatus: vi.fn(),
-      notify: vi.fn(),
-      select: vi.fn(),
-      input: vi.fn(),
-    },
-    sessionManager: {
-      getEntries: vi.fn().mockReturnValue([]),
-      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
-      addEntry: vi.fn(),
-    },
-    ...overrides,
-  } as unknown as ExtensionContext;
-}
-
-function makeSession(
-  state: "allow" | "deny" | "ask" = "allow",
-  overrides: Partial<Record<keyof PermissionSession, unknown>> = {},
-): PermissionSession {
-  return {
-    logger: { debug: vi.fn(), review: vi.fn(), warn: vi.fn() },
-    activate: vi.fn(),
-    resolveAgentName: vi.fn().mockReturnValue(null),
-    checkPermission: vi.fn().mockReturnValue({
+/** Build a checkPermission mock returning a skill-surface result. */
+function makeSkillCheckPermission(state: "allow" | "deny" | "ask") {
+  return vi.fn().mockReturnValue(
+    makeCheckResult({
       state,
       toolName: "skill",
       source: "skill",
       origin: "global",
       matchedPattern: "*",
     }),
-    getToolPermission: vi.fn().mockReturnValue("allow"),
-    getSessionRuleset: vi.fn().mockReturnValue([]),
-    recordSessionApproval: vi.fn(),
-    canPrompt: vi.fn().mockReturnValue(true),
-    prompt: vi.fn().mockResolvedValue({ approved: true, state: "approved" }),
-    createPermissionRequestId: vi.fn().mockReturnValue("req-id"),
-    ...overrides,
-  } as unknown as PermissionSession;
-}
-
-function makeToolRegistry(): ToolRegistry {
-  return {
-    getAll: vi.fn().mockReturnValue([]),
-    setActive: vi.fn(),
-  };
-}
-
-function makeHandler(
-  state: "allow" | "deny" | "ask" = "allow",
-  sessionOverrides: Partial<Record<keyof PermissionSession, unknown>> = {},
-): {
-  handler: PermissionGateHandler;
-  events: ReturnType<typeof makeEvents>;
-} {
-  const session = makeSession(state, sessionOverrides);
-  const events = makeEvents();
-  const handler = new PermissionGateHandler(
-    session,
-    events,
-    makeToolRegistry(),
   );
-  return { handler, events };
-}
-
-/** Extract all permissions:decision payloads from the events.emit mock. */
-function getDecisionEvents(
-  events: ReturnType<typeof makeEvents>,
-): PermissionDecisionEvent[] {
-  return events.emit.mock.calls
-    .filter(([channel]) => channel === PERMISSIONS_DECISION_CHANNEL)
-    .map(([, payload]) => payload as PermissionDecisionEvent);
 }
 
 // ── tests ──────────────────────────────────────────────────────────────────
@@ -106,7 +35,9 @@ describe("handleInput decision events — skill gate", () => {
   });
 
   it("emits allow with policy_allow for an allowed skill", async () => {
-    const { handler, events } = makeHandler("allow");
+    const { handler, events } = makeHandler({
+      session: { checkPermission: makeSkillCheckPermission("allow") },
+    });
     await handler.handleInput({ text: "/skill:librarian" }, makeCtx());
 
     const decisions = getDecisionEvents(events);
@@ -120,7 +51,9 @@ describe("handleInput decision events — skill gate", () => {
   });
 
   it("emits deny with policy_deny for a denied skill", async () => {
-    const { handler, events } = makeHandler("deny");
+    const { handler, events } = makeHandler({
+      session: { checkPermission: makeSkillCheckPermission("deny") },
+    });
     await handler.handleInput({ text: "/skill:restricted" }, makeCtx());
 
     const decisions = getDecisionEvents(events);
@@ -134,8 +67,13 @@ describe("handleInput decision events — skill gate", () => {
   });
 
   it("emits allow with user_approved when state=ask and user approves", async () => {
-    const { handler, events } = makeHandler("ask", {
-      prompt: vi.fn().mockResolvedValue({ approved: true, state: "approved" }),
+    const { handler, events } = makeHandler({
+      session: {
+        checkPermission: makeSkillCheckPermission("ask"),
+        prompt: vi
+          .fn()
+          .mockResolvedValue({ approved: true, state: "approved" }),
+      },
     });
     await handler.handleInput({ text: "/skill:explorer" }, makeCtx());
 
@@ -150,8 +88,11 @@ describe("handleInput decision events — skill gate", () => {
   });
 
   it("emits deny with user_denied when state=ask and user denies", async () => {
-    const { handler, events } = makeHandler("ask", {
-      prompt: vi.fn().mockResolvedValue({ approved: false, state: "denied" }),
+    const { handler, events } = makeHandler({
+      session: {
+        checkPermission: makeSkillCheckPermission("ask"),
+        prompt: vi.fn().mockResolvedValue({ approved: false, state: "denied" }),
+      },
     });
     await handler.handleInput({ text: "/skill:explorer" }, makeCtx());
 
@@ -166,8 +107,11 @@ describe("handleInput decision events — skill gate", () => {
   });
 
   it("emits deny with confirmation_unavailable when state=ask but no UI", async () => {
-    const { handler, events } = makeHandler("ask", {
-      canPrompt: vi.fn().mockReturnValue(false),
+    const { handler, events } = makeHandler({
+      session: {
+        checkPermission: makeSkillCheckPermission("ask"),
+        canPrompt: vi.fn().mockReturnValue(false),
+      },
     });
     await handler.handleInput(
       { text: "/skill:explorer" },
@@ -185,12 +129,15 @@ describe("handleInput decision events — skill gate", () => {
   });
 
   it("emits allow with auto_approved when prompt returns autoApproved:true", async () => {
-    const { handler, events } = makeHandler("ask", {
-      prompt: vi.fn().mockResolvedValue({
-        approved: true,
-        state: "approved",
-        autoApproved: true,
-      }),
+    const { handler, events } = makeHandler({
+      session: {
+        checkPermission: makeSkillCheckPermission("ask"),
+        prompt: vi.fn().mockResolvedValue({
+          approved: true,
+          state: "approved",
+          autoApproved: true,
+        }),
+      },
     });
     await handler.handleInput({ text: "/skill:explorer" }, makeCtx());
 

package/test/handlers/input.test.ts

@@ -1,83 +1,15 @@
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { describe, expect, it, vi } from "vitest";
 
-import {
-  extractSkillNameFromInput,
-  PermissionGateHandler,
-} from "#src/handlers/permission-gate-handler";
-import type { PermissionSession } from "#src/permission-session";
-import type { ToolRegistry } from "#src/tool-registry";
+import { extractSkillNameFromInput } from "#src/handlers/permission-gate-handler";
 
-// ── helpers ────────────────────────────────────────────────────────────────
+import { makeCtx, makeHandler } from "#test/helpers/handler-fixtures";
 
-function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
-  return {
-    cwd: "/test/project",
-    hasUI: true,
-    ui: {
-      setStatus: vi.fn(),
-      notify: vi.fn(),
-      select: vi.fn(),
-      input: vi.fn(),
-    },
-    sessionManager: {
-      getEntries: vi.fn().mockReturnValue([]),
-      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
-      addEntry: vi.fn(),
-    },
-    ...overrides,
-  } as unknown as ExtensionContext;
-}
+// ── helpers ────────────────────────────────────────────────────────────────
 
 function makeInputEvent(text: string) {
   return { text };
 }
 
-function makeSession(
-  overrides: Partial<Record<keyof PermissionSession, unknown>> = {},
-): PermissionSession {
-  return {
-    logger: { debug: vi.fn(), review: vi.fn(), warn: vi.fn() },
-    activate: vi.fn(),
-    resolveAgentName: vi.fn().mockReturnValue(null),
-    checkPermission: vi.fn().mockReturnValue({ state: "allow" }),
-    getToolPermission: vi.fn().mockReturnValue("allow"),
-    getSessionRuleset: vi.fn().mockReturnValue([]),
-    recordSessionApproval: vi.fn(),
-    canPrompt: vi.fn().mockReturnValue(true),
-    prompt: vi.fn().mockResolvedValue({ approved: true, state: "approved" }),
-    createPermissionRequestId: vi.fn().mockReturnValue("req-id"),
-    ...overrides,
-  } as unknown as PermissionSession;
-}
-
-function makeEvents() {
-  return {
-    emit: vi.fn(),
-    on: vi.fn().mockReturnValue(() => undefined),
-  };
-}
-
-function makeToolRegistry(): ToolRegistry {
-  return {
-    getAll: vi.fn().mockReturnValue([]),
-    setActive: vi.fn(),
-  };
-}
-
-function makeHandler(overrides?: {
-  session?: Partial<Record<keyof PermissionSession, unknown>>;
-}): {
-  handler: PermissionGateHandler;
-  session: PermissionSession;
-} {
-  const session = makeSession(overrides?.session);
-  const events = makeEvents();
-  const toolRegistry = makeToolRegistry();
-  const handler = new PermissionGateHandler(session, events, toolRegistry);
-  return { handler, session };
-}
-
 // ── extractSkillNameFromInput ──────────────────────────────────────────────
 
 describe("extractSkillNameFromInput", () => {

package/test/handlers/lifecycle.test.ts

@@ -1,8 +1,10 @@
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { describe, expect, it, vi } from "vitest";
+
 import { SessionLifecycleHandler } from "#src/handlers/lifecycle";
 import type { PermissionSession } from "#src/permission-session";
 
+import { makeCtx } from "#test/helpers/handler-fixtures";
+
 // ── status stub ────────────────────────────────────────────────────────────
 vi.mock("../../src/status", () => ({
   PERMISSION_SYSTEM_STATUS_KEY: "permission-system",
@@ -12,25 +14,6 @@ vi.mock("../../src/status", () => ({
 
 // ── helpers ────────────────────────────────────────────────────────────────
 
-function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
-  return {
-    cwd: "/test/project",
-    hasUI: true,
-    ui: {
-      setStatus: vi.fn(),
-      notify: vi.fn(),
-      select: vi.fn(),
-      input: vi.fn(),
-    },
-    sessionManager: {
-      getEntries: vi.fn().mockReturnValue([]),
-      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
-      addEntry: vi.fn(),
-    },
-    ...overrides,
-  } as unknown as ExtensionContext;
-}
-
 function makeSession(
   overrides: Partial<Record<keyof PermissionSession, unknown>> = {},
 ): PermissionSession {

package/test/handlers/tool-call-events.test.ts

@@ -2,125 +2,15 @@
  * Tests that handleToolCall emits permissions:decision events at every
  * gate resolution and fast-path site.
  */
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { describe, expect, it, vi } from "vitest";
-import { DEFAULT_EXTENSION_CONFIG } from "#src/extension-config";
-import { PermissionGateHandler } from "#src/handlers/permission-gate-handler";
-import type { PermissionDecisionEvent } from "#src/permission-events";
-import { PERMISSIONS_DECISION_CHANNEL } from "#src/permission-events";
-import type { PermissionSession } from "#src/permission-session";
-import type { ToolRegistry } from "#src/tool-registry";
-import type { PermissionCheckResult } from "#src/types";
-
-// ── helpers ────────────────────────────────────────────────────────────────
-
-function makeEvents() {
-  return {
-    emit: vi.fn(),
-    on: vi.fn().mockReturnValue(() => undefined),
-  };
-}
-
-function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
-  return {
-    cwd: "/test/project",
-    hasUI: true,
-    ui: {
-      setStatus: vi.fn(),
-      notify: vi.fn(),
-      select: vi.fn(),
-      input: vi.fn(),
-    },
-    sessionManager: {
-      getEntries: vi.fn().mockReturnValue([]),
-      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
-      addEntry: vi.fn(),
-    },
-    ...overrides,
-  } as unknown as ExtensionContext;
-}
-
-function makeToolCallEvent(
-  toolName: string,
-  extraFields: Record<string, unknown> = {},
-) {
-  return {
-    type: "tool_call",
-    toolCallId: "tc-1",
-    name: toolName,
-    input: {},
-    ...extraFields,
-  };
-}
-
-function makeCheckResult(
-  state: "allow" | "deny" | "ask",
-  overrides: Partial<PermissionCheckResult> = {},
-): PermissionCheckResult {
-  return {
-    state,
-    toolName: "read",
-    source: "tool",
-    origin: "builtin",
-    matchedPattern: "*",
-    ...overrides,
-  };
-}
-
-function makeSession(
-  overrides: Partial<Record<keyof PermissionSession, unknown>> = {},
-): PermissionSession {
-  return {
-    logger: { debug: vi.fn(), review: vi.fn(), warn: vi.fn() },
-    activate: vi.fn(),
-    resolveAgentName: vi.fn().mockReturnValue(null),
-    checkPermission: vi.fn().mockReturnValue(makeCheckResult("allow")),
-    getToolPermission: vi.fn().mockReturnValue("allow"),
-    getSessionRuleset: vi.fn().mockReturnValue([]),
-    recordSessionApproval: vi.fn(),
-    getActiveSkillEntries: vi.fn().mockReturnValue([]),
-    getInfrastructureDirs: vi
-      .fn()
-      .mockReturnValue(["/test/agent", "/test/agent/git"]),
-    getInfrastructureReadPaths: vi.fn().mockReturnValue([]),
-    config: DEFAULT_EXTENSION_CONFIG,
-    canPrompt: vi.fn().mockReturnValue(true),
-    prompt: vi.fn().mockResolvedValue({ approved: true, state: "approved" }),
-    ...overrides,
-  } as unknown as PermissionSession;
-}
-
-function makeToolRegistry(overrides: Partial<ToolRegistry> = {}): ToolRegistry {
-  return {
-    getAll: vi.fn().mockReturnValue([{ name: "read" }, { name: "bash" }]),
-    setActive: vi.fn(),
-    ...overrides,
-  };
-}
-
-function makeHandler(overrides?: {
-  session?: Partial<Record<keyof PermissionSession, unknown>>;
-  toolRegistry?: Partial<ToolRegistry>;
-}): {
-  handler: PermissionGateHandler;
-  events: ReturnType<typeof makeEvents>;
-  session: PermissionSession;
-} {
-  const session = makeSession(overrides?.session);
-  const events = makeEvents();
-  const toolRegistry = makeToolRegistry(overrides?.toolRegistry);
-  const handler = new PermissionGateHandler(session, events, toolRegistry);
-  return { handler, events, session };
-}
-
-/** Extract all permissions:decision payloads from the events.emit mock. */
-function getDecisionEvents(
-  events: ReturnType<typeof makeEvents>,
-): PermissionDecisionEvent[] {
-  return events.emit.mock.calls
-    .filter(([channel]) => channel === PERMISSIONS_DECISION_CHANNEL)
-    .map(([, payload]) => payload as PermissionDecisionEvent);
-}
+
+import {
+  getDecisionEvents,
+  makeCheckResult,
+  makeCtx,
+  makeHandler,
+  makeToolCallEvent,
+} from "#test/helpers/handler-fixtures";
 
 // ── policy_allow path ──────────────────────────────────────────────────────
 
@@ -129,7 +19,8 @@ describe("handleToolCall decision events — policy_allow", () => {
     const { handler, events } = makeHandler({
       session: {
         checkPermission: vi.fn().mockReturnValue(
-          makeCheckResult("allow", {
+          makeCheckResult({
+            state: "allow",
             origin: "global",
             matchedPattern: "*",
           }),
@@ -158,7 +49,8 @@ describe("handleToolCall decision events — policy_deny", () => {
     const { handler, events } = makeHandler({
       session: {
         checkPermission: vi.fn().mockReturnValue(
-          makeCheckResult("deny", {
+          makeCheckResult({
+            state: "deny",
             origin: "project",
             matchedPattern: "read",
           }),
@@ -185,7 +77,8 @@ describe("handleToolCall decision events — session_approved", () => {
     const { handler, events } = makeHandler({
       session: {
         checkPermission: vi.fn().mockReturnValue(
-          makeCheckResult("allow", {
+          makeCheckResult({
+            state: "allow",
             source: "session",
             matchedPattern: "git *",
           }),
@@ -214,7 +107,9 @@ describe("handleToolCall decision events — user_approved", () => {
   it("emits allow with user_approved when state=ask and user approves once", async () => {
     const { handler, events } = makeHandler({
       session: {
-        checkPermission: vi.fn().mockReturnValue(makeCheckResult("ask")),
+        checkPermission: vi
+          .fn()
+          .mockReturnValue(makeCheckResult({ state: "ask" })),
         prompt: vi
           .fn()
           .mockResolvedValue({ approved: true, state: "approved" }),
@@ -234,7 +129,9 @@ describe("handleToolCall decision events — user_approved", () => {
   it("emits allow with user_approved_for_session when user approves for session", async () => {
     const { handler, events } = makeHandler({
       session: {
-        checkPermission: vi.fn().mockReturnValue(makeCheckResult("ask")),
+        checkPermission: vi
+          .fn()
+          .mockReturnValue(makeCheckResult({ state: "ask" })),
         prompt: vi.fn().mockResolvedValue({
           approved: true,
           state: "approved_for_session",
@@ -259,7 +156,9 @@ describe("handleToolCall decision events — user_denied", () => {
   it("emits deny with user_denied when state=ask and user denies", async () => {
     const { handler, events } = makeHandler({
       session: {
-        checkPermission: vi.fn().mockReturnValue(makeCheckResult("ask")),
+        checkPermission: vi
+          .fn()
+          .mockReturnValue(makeCheckResult({ state: "ask" })),
         prompt: vi.fn().mockResolvedValue({ approved: false, state: "denied" }),
       },
     });
@@ -281,7 +180,9 @@ describe("handleToolCall decision events — confirmation_unavailable", () => {
   it("emits deny with confirmation_unavailable when state=ask but no UI", async () => {
     const { handler, events } = makeHandler({
       session: {
-        checkPermission: vi.fn().mockReturnValue(makeCheckResult("ask")),
+        checkPermission: vi
+          .fn()
+          .mockReturnValue(makeCheckResult({ state: "ask" })),
         canPrompt: vi.fn().mockReturnValue(false),
       },
     });
@@ -307,7 +208,7 @@ describe("handleToolCall decision events — infrastructure_auto_allowed", () =>
     const infraDir = "/test/agent";
     const { handler, events } = makeHandler({
       session: {
-        checkPermission: vi.fn().mockReturnValue(makeCheckResult("allow")),
+        checkPermission: vi.fn().mockReturnValue(makeCheckResult()),
         getInfrastructureDirs: vi.fn().mockReturnValue([infraDir]),
       },
     });
@@ -335,7 +236,9 @@ describe("handleToolCall decision events — auto_approved", () => {
   it("emits allow with auto_approved when prompt returns autoApproved:true", async () => {
     const { handler, events } = makeHandler({
       session: {
-        checkPermission: vi.fn().mockReturnValue(makeCheckResult("ask")),
+        checkPermission: vi
+          .fn()
+          .mockReturnValue(makeCheckResult({ state: "ask" })),
         prompt: vi.fn().mockResolvedValue({
           approved: true,
           state: "approved",