@gotgenes/pi-permission-system 7.4.1 → 8.0.0

package/CHANGELOG.md

@@ -5,6 +5,22 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [8.0.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v7.4.1...pi-permission-system-v8.0.0) (2026-05-30)
+
+
+### ⚠ BREAKING CHANGES
+
+* `registerSubagentSession` and `unregisterSubagentSession` are removed from the `PermissionsService` interface and its implementation. The `SubagentSessionInfo` type is no longer re-exported from the public service module.
+
+### Features
+
+* remove inbound subagent-registration methods from PermissionsService ([#267](https://github.com/gotgenes/pi-packages/issues/267)) ([552735a](https://github.com/gotgenes/pi-packages/commit/552735a97eec939fc06130bce059c78f03eb8e58))
+
+
+### Documentation
+
+* **pi-permission-system:** describe event-driven subagent registration ([#267](https://github.com/gotgenes/pi-packages/issues/267)) ([8c39b87](https://github.com/gotgenes/pi-packages/commit/8c39b8785aa389d96b5f38996711d8aa3dbeb284))
+
 ## [7.4.1](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v7.4.0...pi-permission-system-v7.4.1) (2026-05-30)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "7.4.1",
+  "version": "8.0.0",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "exports": {

package/src/index.ts

@@ -118,12 +118,6 @@ export default function piPermissionSystemExtension(pi: ExtensionAPI): void {
         sessionRules,
       );
     },
-    registerSubagentSession(sessionKey, info) {
-      subagentRegistry.register(sessionKey, info);
-    },
-    unregisterSubagentSession(sessionKey) {
-      subagentRegistry.unregister(sessionKey);
-    },
     getToolPermission(toolName, agentName) {
       return runtime.permissionManager.getToolPermission(toolName, agentName);
     },

package/src/service.ts

@@ -11,10 +11,9 @@
  * reference — this ensures resilience across `/reload` and load-order edge cases.
  */
 
-import type { SubagentSessionInfo } from "./subagent-registry";
 import type { PermissionCheckResult, PermissionState } from "./types";
 
-export type { PermissionCheckResult, PermissionState, SubagentSessionInfo };
+export type { PermissionCheckResult, PermissionState };
 
 /** Process-global key for the service slot. */
 const SERVICE_KEY = Symbol.for("@gotgenes/pi-permission-system:service");
@@ -44,27 +43,6 @@ export interface PermissionsService {
     agentName?: string,
   ): PermissionCheckResult;
 
-  /**
-   * Register an in-process subagent session.
-   *
-   * Call this before `bindExtensions()` so that `isSubagentExecutionContext()`
-   * and permission-forwarding target resolution can detect the child session.
-   * Always pair with `unregisterSubagentSession()` in a `finally` block.
-   *
-   * @param sessionKey - Unique session identifier (use the session directory path).
-   * @param info       - Agent name and optional parent session ID.
-   */
-  registerSubagentSession(sessionKey: string, info: SubagentSessionInfo): void;
-
-  /**
-   * Remove a previously registered in-process subagent session.
-   *
-   * Safe to call even if `registerSubagentSession` was never called for this key.
-   *
-   * @param sessionKey - The same key passed to `registerSubagentSession`.
-   */
-  unregisterSubagentSession(sessionKey: string): void;
-
   /**
    * Query the tool-level permission state for pre-filtering tools before
    * creating a child session.

package/src/subagent-registry.ts

@@ -23,9 +23,9 @@ export interface SubagentSessionInfo {
 /**
  * Registry of active in-process subagent sessions.
  *
- * Owned by `ExtensionRuntime`; exposed to external callers through the
- * `PermissionsService` interface (`registerSubagentSession` /
- * `unregisterSubagentSession`).
+ * Owned by `ExtensionRuntime`; written exclusively by `subscribeSubagentLifecycle`
+ * via the `subagents:child:session-created` / `subagents:child:disposed` event
+ * subscription (ADR 0002 — the core publishes, consumers observe).
  *
  * Concurrent background agents are safe because each session has a unique
  * directory path as its key — no scalar global flag is needed.

package/test/service.test.ts

@@ -6,7 +6,6 @@ import {
   publishPermissionsService,
   unpublishPermissionsService,
 } from "#src/service";
-import { SubagentSessionRegistry } from "#src/subagent-registry";
 import type { PermissionCheckResult } from "#src/types";
 
 // ── helpers ────────────────────────────────────────────────────────────────
@@ -16,8 +15,6 @@ function makeService(
 ): PermissionsService {
   return {
     checkPermission: vi.fn(),
-    registerSubagentSession: vi.fn(),
-    unregisterSubagentSession: vi.fn(),
     getToolPermission: vi.fn(),
     ...overrides,
   };
@@ -130,61 +127,12 @@ describe("service adapter delegation", () => {
     );
   });
 
-  it("registerSubagentSession delegates to the registry", () => {
-    const registry = new SubagentSessionRegistry();
-    const service: PermissionsService = {
-      checkPermission: vi.fn(),
-      registerSubagentSession(key, info) {
-        registry.register(key, info);
-      },
-      unregisterSubagentSession(key) {
-        registry.unregister(key);
-      },
-      getToolPermission: vi.fn((): "allow" => "allow"),
-    };
-
-    publishPermissionsService(service);
-    getPermissionsService()!.registerSubagentSession("/sessions/task-1", {
-      agentName: "Explore",
-      parentSessionId: "parent-abc",
-    });
-
-    expect(registry.has("/sessions/task-1")).toBe(true);
-    expect(registry.get("/sessions/task-1")).toEqual({
-      agentName: "Explore",
-      parentSessionId: "parent-abc",
-    });
-  });
-
-  it("unregisterSubagentSession delegates to the registry", () => {
-    const registry = new SubagentSessionRegistry();
-    const service: PermissionsService = {
-      checkPermission: vi.fn(),
-      registerSubagentSession(key, info) {
-        registry.register(key, info);
-      },
-      unregisterSubagentSession(key) {
-        registry.unregister(key);
-      },
-      getToolPermission: vi.fn((): "allow" => "allow"),
-    };
-
-    publishPermissionsService(service);
-    const svc = getPermissionsService()!;
-    svc.registerSubagentSession("/sessions/task-1", { agentName: "Explore" });
-    svc.unregisterSubagentSession("/sessions/task-1");
-
-    expect(registry.has("/sessions/task-1")).toBe(false);
-  });
-
   it("getToolPermission delegates to the permission manager", () => {
     const getToolPermissionFn = vi.fn(
       (_t: string, _a?: string): "deny" => "deny",
     );
     const service: PermissionsService = {
       checkPermission: vi.fn(),
-      registerSubagentSession: vi.fn(),
-      unregisterSubagentSession: vi.fn(),
       getToolPermission(toolName, agentName) {
         return getToolPermissionFn(toolName, agentName);
       },
@@ -206,8 +154,6 @@ describe("service adapter delegation", () => {
     );
     const service: PermissionsService = {
       checkPermission: vi.fn(),
-      registerSubagentSession: vi.fn(),
-      unregisterSubagentSession: vi.fn(),
       getToolPermission(toolName, agentName) {
         return getToolPermissionFn(toolName, agentName);
       },