@gotgenes/pi-permission-system 7.1.3 → 7.2.0

package/src/permission-prompts.ts

@@ -38,7 +38,7 @@ export function formatAskPrompt(
     const patternInfo = result.matchedPattern
       ? ` (matched '${result.matchedPattern}')`
       : "";
-    return `${subject} requested bash command '${result.command || ""}'${patternInfo}. Allow this command?`;
+    return `${subject} requested bash command '${result.command ?? ""}'${patternInfo}. Allow this command?`;
   }
 
   if ((result.source === "mcp" || result.toolName === "mcp") && result.target) {

package/src/policy-loader.ts

@@ -169,12 +169,12 @@ export class FilePolicyLoader implements PolicyLoader {
 
   constructor(options: PolicyLoaderOptions = {}) {
     this.globalConfigPath =
-      options.globalConfigPath || defaultGlobalConfigPath();
-    this.agentsDir = options.agentsDir || defaultAgentsDir();
-    this.projectGlobalConfigPath = options.projectGlobalConfigPath || null;
-    this.projectAgentsDir = options.projectAgentsDir || null;
+      options.globalConfigPath ?? defaultGlobalConfigPath();
+    this.agentsDir = options.agentsDir ?? defaultAgentsDir();
+    this.projectGlobalConfigPath = options.projectGlobalConfigPath ?? null;
+    this.projectAgentsDir = options.projectAgentsDir ?? null;
     this.globalMcpConfigPath =
-      options.globalMcpConfigPath || defaultGlobalMcpConfigPath();
+      options.globalMcpConfigPath ?? defaultGlobalMcpConfigPath();
     this.configuredMcpServerNamesOverride = options.mcpServerNames
       ? [
           ...new Set(

package/src/service.ts

@@ -71,5 +71,6 @@ export function getPermissionsService(): PermissionsService | undefined {
  * extension is torn down.
  */
 export function unpublishPermissionsService(): void {
+  // eslint-disable-next-line @typescript-eslint/no-dynamic-delete -- Symbol-keyed global property; Map.delete() is not applicable
   delete (globalThis as Record<symbol, unknown>)[SERVICE_KEY];
 }

package/src/skill-prompt-sanitizer.ts

@@ -70,9 +70,9 @@ function parseSkillEntries(sectionBody: string): ParsedSkillPromptEntry[] {
 
   for (const match of sectionBody.matchAll(skillBlockRegex)) {
     const block = match[1];
-    const nameMatch = block.match(SKILL_NAME_REGEX);
-    const descriptionMatch = block.match(SKILL_DESCRIPTION_REGEX);
-    const locationMatch = block.match(SKILL_LOCATION_REGEX);
+    const nameMatch = SKILL_NAME_REGEX.exec(block);
+    const descriptionMatch = SKILL_DESCRIPTION_REGEX.exec(block);
+    const locationMatch = SKILL_LOCATION_REGEX.exec(block);
 
     if (!nameMatch || !descriptionMatch || !locationMatch) {
       continue;

package/src/tool-registry.ts

@@ -35,7 +35,7 @@ function buildReverseAliases(
   const reverse = new Map<string, string[]>();
 
   for (const [alias, canonical] of Object.entries(aliases)) {
-    const existing = reverse.get(canonical) || [];
+    const existing = reverse.get(canonical) ?? [];
     if (!existing.includes(alias)) {
       existing.push(alias);
     }

package/src/wildcard-matcher.ts

@@ -30,7 +30,7 @@ export function compileWildcardPattern<TState>(
   // space-and-arguments portion optional so that e.g. "git *" matches both
   // "git status" and bare "git". Mirrors OpenCode wildcard semantics.
   if (escaped.endsWith(" .*")) {
-    escaped = escaped.slice(0, -3) + "( .*)?";
+    escaped = `${escaped.slice(0, -3)}( .*)?`;
   }
 
   return {
@@ -48,7 +48,7 @@ export function compileWildcardPatternEntries<TState>(
   );
 }
 
-function compileWildcardPatterns<TState>(
+function _compileWildcardPatterns<TState>(
   patterns: Record<string, TState>,
 ): CompiledWildcardPattern<TState>[] {
   return compileWildcardPatternEntries(Object.entries(patterns));

package/src/yolo-mode.ts

@@ -10,7 +10,8 @@ export interface AskPermissionResolutionOptions {
 export function isYoloModeEnabled(
   config: PermissionSystemExtensionConfig,
 ): boolean {
-  return config.yoloMode === true;
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-conversion -- typed as boolean but may be undefined at runtime (untyped callers); Boolean() guards against that
+  return Boolean(config.yoloMode);
 }
 
 export function shouldAutoApprovePermissionState(

package/{tests → test}/active-agent.test.ts

@@ -5,7 +5,7 @@ import {
   getActiveAgentName,
   getActiveAgentNameFromSystemPrompt,
   normalizeAgentName,
-} from "../src/active-agent";
+} from "#src/active-agent";
 
 afterEach(() => {
   vi.restoreAllMocks();

package/{tests → test}/bash-arity.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { ARITY, prefix } from "../src/bash-arity";
+import { ARITY, prefix } from "#src/bash-arity";
 
 describe("ARITY dictionary", () => {
   it("is exported as a plain object", () => {
@@ -7,7 +7,7 @@ describe("ARITY dictionary", () => {
   });
 
   it("maps 'git' to arity 2", () => {
-    expect(ARITY["git"]).toBe(2);
+    expect(ARITY.git).toBe(2);
   });
 
   it("maps 'npm run' to arity 3", () => {
@@ -15,7 +15,7 @@ describe("ARITY dictionary", () => {
   });
 
   it("maps 'npm' to arity 2 (fallback when 'npm run' does not match)", () => {
-    expect(ARITY["npm"]).toBe(2);
+    expect(ARITY.npm).toBe(2);
   });
 
   it("maps 'docker compose' to arity 3", () => {
@@ -23,7 +23,7 @@ describe("ARITY dictionary", () => {
   });
 
   it("maps 'docker' to arity 2 (fallback)", () => {
-    expect(ARITY["docker"]).toBe(2);
+    expect(ARITY.docker).toBe(2);
   });
 });
 

package/{tests → test}/bash-external-directory.test.ts

@@ -9,12 +9,12 @@ vi.mock("node:os", () => {
   };
 });
 
-import { formatDenyReason } from "../src/denial-messages";
+import { formatDenyReason } from "#src/denial-messages";
 import {
   extractExternalPathsFromBashCommand,
   extractTokensForPathRules,
-} from "../src/handlers/gates/bash-path-extractor";
-import { formatBashExternalDirectoryAskPrompt } from "../src/handlers/gates/external-directory-messages";
+} from "#src/handlers/gates/bash-path-extractor";
+import { formatBashExternalDirectoryAskPrompt } from "#src/handlers/gates/external-directory-messages";
 
 afterEach(() => {
   vi.restoreAllMocks();

package/{tests → test}/common.test.ts

@@ -6,7 +6,7 @@ import {
   isPermissionState,
   parseSimpleYamlMap,
   toRecord,
-} from "../src/common";
+} from "#src/common";
 
 afterEach(() => {
   vi.restoreAllMocks();

package/{tests → test}/config-loader.test.ts

@@ -7,7 +7,7 @@ import {
   loadAndMergeConfigs,
   loadUnifiedConfig,
   mergeUnifiedConfigs,
-} from "../src/config-loader";
+} from "#src/config-loader";
 
 describe("loadUnifiedConfig", () => {
   let tempDir: string;

package/{tests → test}/config-modal.test.ts

@@ -2,13 +2,13 @@ import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { expect, test, vi } from "vitest";
-import { registerPermissionSystemCommand } from "../src/config-modal";
+import { registerPermissionSystemCommand } from "#src/config-modal";
 import {
   DEFAULT_EXTENSION_CONFIG,
   normalizePermissionSystemConfig,
   type PermissionSystemExtensionConfig,
-} from "../src/extension-config";
-import type { Rule } from "../src/rule";
+} from "#src/extension-config";
+import type { Rule } from "#src/rule";
 
 vi.mock("@earendil-works/pi-coding-agent", () => ({
   getSettingsListTheme: () => ({}),
@@ -68,7 +68,7 @@ function createCommandContext(hasUI: boolean): {
 }
 
 function lastNotification(notifications: Notification[]): Notification {
-  return notifications[notifications.length - 1] as Notification;
+  return notifications[notifications.length - 1];
 }
 
 test("permission-system command completions expose top-level config actions", () => {
@@ -101,7 +101,7 @@ test("permission-system command completions expose top-level config actions", ()
           definition = nextDefinition;
         },
       } as never,
-      controller as never,
+      controller,
     );
 
     expect(definition!.getArgumentCompletions).toBeTypeOf("function");
@@ -172,13 +172,11 @@ test("permission-system command handlers manage config summary, persistence, and
           definition = nextDefinition;
         },
       } as never,
-      controller as never,
+      controller,
     );
 
     expect(registeredName).toBe("permission-system");
-    expect(definition!.description ?? "").toContain(
-      "Configure pi-permission-system",
-    );
+    expect(definition!.description).toContain("Configure pi-permission-system");
 
     const infoCtx = createCommandContext(true);
     await definition!.handler("show", infoCtx.ctx);
@@ -267,7 +265,7 @@ test("show output includes rule origins when getComposedRules is provided", asyn
         definition = nextDef;
       },
     } as never,
-    controller as never,
+    controller,
   );
 
   const ctx = createCommandContext(true);
@@ -300,7 +298,7 @@ test("show output omits rule summary when getComposedRules is not provided", asy
         definition = nextDef;
       },
     } as never,
-    controller as never,
+    controller,
   );
 
   const ctx = createCommandContext(true);

package/{tests → test}/config-paths.test.ts

@@ -11,7 +11,7 @@ import {
   getLegacyProjectPolicyPath,
   getProjectConfigPath,
   REVIEW_LOG_FILENAME,
-} from "../src/config-paths";
+} from "#src/config-paths";
 
 describe("config-paths", () => {
   const agentDir = "/home/user/.pi/agent";

package/{tests → test}/config-reporter.test.ts

@@ -8,10 +8,10 @@ import {
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { expect, test } from "vitest";
-import { buildResolvedConfigLogEntry } from "../src/config-reporter";
-import { createPermissionSystemLogger } from "../src/logging";
-import type { ResolvedPolicyPaths } from "../src/permission-manager";
-import { PermissionManager } from "../src/permission-manager";
+import { buildResolvedConfigLogEntry } from "#src/config-reporter";
+import { createPermissionSystemLogger } from "#src/logging";
+import type { ResolvedPolicyPaths } from "#src/permission-manager";
+import { PermissionManager } from "#src/permission-manager";
 
 test("buildResolvedConfigLogEntry includes policy paths and legacy detection flags", () => {
   const policyPaths: ResolvedPolicyPaths = {

package/{tests → test}/denial-messages.test.ts

@@ -6,8 +6,8 @@ import {
   formatDenyReason,
   formatUnavailableReason,
   formatUserDeniedReason,
-} from "../src/denial-messages";
-import type { PermissionCheckResult } from "../src/types";
+} from "#src/denial-messages";
+import type { PermissionCheckResult } from "#src/types";
 
 // ── Helpers ────────────────────────────────────────────────────────────────
 

package/{tests → test}/expand-home.test.ts

@@ -8,7 +8,7 @@ vi.mock("node:os", () => ({
   default: { homedir: mockHomedir },
 }));
 
-import { expandHomePath } from "../src/expand-home";
+import { expandHomePath } from "#src/expand-home";
 
 const FAKE_HOME = "/home/testuser";
 

package/{tests → test}/extension-config.test.ts

@@ -3,7 +3,7 @@ import { describe, expect, it } from "vitest";
 import {
   detectMisplacedPermissionKeys,
   normalizePermissionSystemConfig,
-} from "../src/extension-config";
+} from "#src/extension-config";
 
 describe("detectMisplacedPermissionKeys", () => {
   it("returns an empty array for a record with only valid extension keys", () => {

package/{tests → test}/extension-paths.test.ts

@@ -9,8 +9,8 @@ vi.mock("../src/node-modules-discovery", () => ({
   discoverGlobalNodeModulesRoot: mockDiscoverGlobalNodeModulesRoot,
 }));
 
-import { getGlobalLogsDir } from "../src/config-paths";
-import { computeExtensionPaths } from "../src/extension-paths";
+import { getGlobalLogsDir } from "#src/config-paths";
+import { computeExtensionPaths } from "#src/extension-paths";
 
 describe("computeExtensionPaths", () => {
   beforeEach(() => {

package/{tests → test}/forwarded-permissions/io.test.ts

@@ -1,12 +1,12 @@
 import { describe, expect, it, vi } from "vitest";
 
-import type { ForwardedPermissionLogger } from "../../src/forwarded-permissions/io";
+import type { ForwardedPermissionLogger } from "#src/forwarded-permissions/io";
 import {
   formatUnknownErrorMessage,
   isErrnoCode,
   logPermissionForwardingError,
   logPermissionForwardingWarning,
-} from "../../src/forwarded-permissions/io";
+} from "#src/forwarded-permissions/io";
 
 // ── helpers ────────────────────────────────────────────────────────────────
 

package/{tests → test}/forwarding-manager.test.ts

@@ -1,6 +1,6 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
-import { ForwardingManager } from "../src/forwarding-manager";
+import { ForwardingManager } from "#src/forwarding-manager";
 
 // ── Mocks ─────────────────────────────────────────────────────────────────
 

package/{tests → test}/handlers/before-agent-start.test.ts

@@ -4,10 +4,10 @@ import { describe, expect, it, vi } from "vitest";
 import {
   AgentPrepHandler,
   shouldExposeTool,
-} from "../../src/handlers/before-agent-start";
-import type { PermissionSession } from "../../src/permission-session";
-import type { ToolRegistry } from "../../src/tool-registry";
-import type { PermissionState } from "../../src/types";
+} from "#src/handlers/before-agent-start";
+import type { PermissionSession } from "#src/permission-session";
+import type { ToolRegistry } from "#src/tool-registry";
+import type { PermissionState } from "#src/types";
 
 // ── SDK stubs ──────────────────────────────────────────────────────────────
 vi.mock("@earendil-works/pi-coding-agent", async (importOriginal) => {
@@ -52,7 +52,7 @@ function makeSession(
     activate: vi.fn(),
     refreshConfig: vi.fn(),
     resolveAgentName: vi.fn().mockReturnValue(null),
-    getToolPermission: vi.fn().mockReturnValue("allow" as PermissionState),
+    getToolPermission: vi.fn().mockReturnValue("allow"),
     checkPermission: vi.fn().mockReturnValue({ state: "allow" }),
     shouldUpdateActiveTools: vi.fn().mockReturnValue(true),
     commitActiveToolsCacheKey: vi.fn(),

package/{tests → test}/handlers/external-directory-integration.test.ts

@@ -11,16 +11,16 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { describe, expect, it, vi } from "vitest";
 
-import { EXTENSION_TAG } from "../../src/denial-messages";
-import { formatExternalDirectoryAskPrompt } from "../../src/handlers/gates/external-directory-messages";
-import { PermissionGateHandler } from "../../src/handlers/permission-gate-handler";
+import { EXTENSION_TAG } from "#src/denial-messages";
+import { formatExternalDirectoryAskPrompt } from "#src/handlers/gates/external-directory-messages";
+import { PermissionGateHandler } from "#src/handlers/permission-gate-handler";
 import {
   PERMISSIONS_DECISION_CHANNEL,
   type PermissionDecisionEvent,
-} from "../../src/permission-events";
-import type { PermissionSession } from "../../src/permission-session";
-import type { ToolRegistry } from "../../src/tool-registry";
-import type { PermissionCheckResult, PermissionState } from "../../src/types";
+} from "#src/permission-events";
+import type { PermissionSession } from "#src/permission-session";
+import type { ToolRegistry } from "#src/tool-registry";
+import type { PermissionCheckResult, PermissionState } from "#src/types";
 
 // ── SDK stubs ──────────────────────────────────────────────────────────────
 vi.mock("@earendil-works/pi-coding-agent", async (importOriginal) => {
@@ -110,7 +110,7 @@ function makeSession(
     activate: vi.fn(),
     resolveAgentName: vi.fn().mockReturnValue(null),
     checkPermission: makeCheckPermission("deny"),
-    getToolPermission: vi.fn().mockReturnValue("allow" as PermissionState),
+    getToolPermission: vi.fn().mockReturnValue("allow"),
     getSessionRuleset: vi.fn().mockReturnValue([]),
     approveSessionRule: vi.fn(),
     getActiveSkillEntries: vi.fn().mockReturnValue([]),

package/{tests → test}/handlers/external-directory-session-dedup.test.ts

@@ -11,12 +11,12 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { describe, expect, it, vi } from "vitest";
 
-import { PermissionGateHandler } from "../../src/handlers/permission-gate-handler";
-import type { PermissionSession } from "../../src/permission-session";
-import type { Rule } from "../../src/rule";
-import type { ToolRegistry } from "../../src/tool-registry";
-import type { PermissionCheckResult } from "../../src/types";
-import { wildcardMatch } from "../../src/wildcard-matcher";
+import { PermissionGateHandler } from "#src/handlers/permission-gate-handler";
+import type { PermissionSession } from "#src/permission-session";
+import type { Rule } from "#src/rule";
+import type { ToolRegistry } from "#src/tool-registry";
+import type { PermissionCheckResult } from "#src/types";
+import { wildcardMatch } from "#src/wildcard-matcher";
 
 // ── SDK stub ───────────────────────────────────────────────────────────────
 vi.mock("@earendil-works/pi-coding-agent", async (importOriginal) => {

package/{tests → test}/handlers/gates/bash-external-directory.test.ts

@@ -1,15 +1,12 @@
 import { describe, expect, it, vi } from "vitest";
-import { describeBashExternalDirectoryGate } from "../../../src/handlers/gates/bash-external-directory";
+import { describeBashExternalDirectoryGate } from "#src/handlers/gates/bash-external-directory";
 import type {
   GateBypass,
   GateDescriptor,
-} from "../../../src/handlers/gates/descriptor";
-import {
-  isGateBypass,
-  isGateDescriptor,
-} from "../../../src/handlers/gates/descriptor";
-import type { ToolCallContext } from "../../../src/handlers/gates/types";
-import type { PermissionCheckResult } from "../../../src/types";
+} from "#src/handlers/gates/descriptor";
+import { isGateBypass, isGateDescriptor } from "#src/handlers/gates/descriptor";
+import type { ToolCallContext } from "#src/handlers/gates/types";
+import type { PermissionCheckResult } from "#src/types";
 
 // ── helpers ────────────────────────────────────────────────────────────────
 

package/{tests → test}/handlers/gates/bash-path.test.ts

@@ -9,18 +9,15 @@ vi.mock("node:os", () => {
   };
 });
 
-import { describeBashPathGate } from "../../../src/handlers/gates/bash-path";
+import { describeBashPathGate } from "#src/handlers/gates/bash-path";
 import type {
   GateBypass,
   GateDescriptor,
-} from "../../../src/handlers/gates/descriptor";
-import {
-  isGateBypass,
-  isGateDescriptor,
-} from "../../../src/handlers/gates/descriptor";
-import type { ToolCallContext } from "../../../src/handlers/gates/types";
-import type { Rule } from "../../../src/rule";
-import type { PermissionCheckResult } from "../../../src/types";
+} from "#src/handlers/gates/descriptor";
+import { isGateBypass, isGateDescriptor } from "#src/handlers/gates/descriptor";
+import type { ToolCallContext } from "#src/handlers/gates/types";
+import type { Rule } from "#src/rule";
+import type { PermissionCheckResult } from "#src/types";
 
 afterEach(() => {
   vi.restoreAllMocks();

package/{tests → test}/handlers/gates/external-directory-messages.test.ts

@@ -3,7 +3,7 @@ import { describe, expect, test } from "vitest";
 import {
   formatBashExternalDirectoryAskPrompt,
   formatExternalDirectoryAskPrompt,
-} from "../../../src/handlers/gates/external-directory-messages";
+} from "#src/handlers/gates/external-directory-messages";
 
 // Denial message functions (formatExternalDirectoryDenyReason,
 // formatExternalDirectoryUserDeniedReason, formatExternalDirectoryHardStopHint,

package/{tests → test}/handlers/gates/external-directory.test.ts

@@ -3,13 +3,10 @@ import { describe, expect, it } from "vitest";
 import type {
   GateBypass,
   GateDescriptor,
-} from "../../../src/handlers/gates/descriptor";
-import {
-  isGateBypass,
-  isGateDescriptor,
-} from "../../../src/handlers/gates/descriptor";
-import { describeExternalDirectoryGate } from "../../../src/handlers/gates/external-directory";
-import type { ToolCallContext } from "../../../src/handlers/gates/types";
+} from "#src/handlers/gates/descriptor";
+import { isGateBypass, isGateDescriptor } from "#src/handlers/gates/descriptor";
+import { describeExternalDirectoryGate } from "#src/handlers/gates/external-directory";
+import type { ToolCallContext } from "#src/handlers/gates/types";
 
 // ── helpers ───────────────────────────��────────────────────────────��───────
 

package/{tests → test}/handlers/gates/helpers.test.ts

@@ -3,7 +3,7 @@ import { describe, expect, it } from "vitest";
 import {
   deriveDecisionValue,
   deriveResolution,
-} from "../../../src/handlers/gates/helpers";
+} from "#src/handlers/gates/helpers";
 
 describe("deriveDecisionValue", () => {
   it("returns command for bash", () => {

package/{tests → test}/handlers/gates/path.test.ts

@@ -1,11 +1,11 @@
 import { describe, expect, it, vi } from "vitest";
 
-import type { GateDescriptor } from "../../../src/handlers/gates/descriptor";
-import { isGateDescriptor } from "../../../src/handlers/gates/descriptor";
-import { describePathGate } from "../../../src/handlers/gates/path";
-import type { ToolCallContext } from "../../../src/handlers/gates/types";
-import type { Rule } from "../../../src/rule";
-import type { PermissionCheckResult } from "../../../src/types";
+import type { GateDescriptor } from "#src/handlers/gates/descriptor";
+import { isGateDescriptor } from "#src/handlers/gates/descriptor";
+import { describePathGate } from "#src/handlers/gates/path";
+import type { ToolCallContext } from "#src/handlers/gates/types";
+import type { Rule } from "#src/rule";
+import type { PermissionCheckResult } from "#src/types";
 
 // ── helpers ────────────────────────────────────────────────────────────────
 

package/{tests → test}/handlers/gates/runner.test.ts

@@ -1,13 +1,13 @@
 import { describe, expect, it, vi } from "vitest";
 
-import type { DenialContext } from "../../../src/denial-messages";
-import { EXTENSION_TAG } from "../../../src/denial-messages";
+import type { DenialContext } from "#src/denial-messages";
+import { EXTENSION_TAG } from "#src/denial-messages";
 import type {
   GateDescriptor,
   GateRunnerDeps,
-} from "../../../src/handlers/gates/descriptor";
-import { runGateCheck } from "../../../src/handlers/gates/runner";
-import type { PermissionCheckResult } from "../../../src/types";
+} from "#src/handlers/gates/descriptor";
+import { runGateCheck } from "#src/handlers/gates/runner";
+import type { PermissionCheckResult } from "#src/types";
 
 // ── helpers ────────────────────────────────────────────────────────────────
 

package/{tests → test}/handlers/gates/skill-read.test.ts

@@ -1,9 +1,9 @@
 import { describe, expect, it, vi } from "vitest";
 
-import type { GateDescriptor } from "../../../src/handlers/gates/descriptor";
-import { describeSkillReadGate } from "../../../src/handlers/gates/skill-read";
-import type { ToolCallContext } from "../../../src/handlers/gates/types";
-import type { SkillPromptEntry } from "../../../src/skill-prompt-sanitizer";
+import type { GateDescriptor } from "#src/handlers/gates/descriptor";
+import { describeSkillReadGate } from "#src/handlers/gates/skill-read";
+import type { ToolCallContext } from "#src/handlers/gates/types";
+import type { SkillPromptEntry } from "#src/skill-prompt-sanitizer";
 
 // ── SDK stubs ──────────────────────────────────────────────────────────────
 vi.mock("@earendil-works/pi-coding-agent", async (importOriginal) => {
@@ -74,7 +74,7 @@ describe("describeSkillReadGate", () => {
       makeSkillEntry({ state: "ask" }),
     ]);
     expect(result).not.toBeNull();
-    const desc = result as GateDescriptor;
+    const desc = result!;
     expect(desc.preResolved).toEqual({ state: "ask" });
   });
 
@@ -83,7 +83,7 @@ describe("describeSkillReadGate", () => {
       makeSkillEntry({ state: "allow" }),
     ]);
     expect(result).not.toBeNull();
-    const desc = result as GateDescriptor;
+    const desc = result!;
     expect(desc.preResolved).toEqual({ state: "allow" });
   });
 
@@ -92,14 +92,14 @@ describe("describeSkillReadGate", () => {
       makeSkillEntry({ state: "deny" }),
     ]);
     expect(result).not.toBeNull();
-    const desc = result as GateDescriptor;
+    const desc = result!;
     expect(desc.preResolved).toEqual({ state: "deny" });
   });
 
   it("decision surface is 'skill' and decision value is the skill name", () => {
     const result = describeSkillReadGate(makeTcc(), () => [
       makeSkillEntry({ name: "my-skill" }),
-    ]) as GateDescriptor;
+    ])!;
     expect(result.decision.surface).toBe("skill");
     expect(result.decision.value).toBe("my-skill");
   });
@@ -107,7 +107,7 @@ describe("describeSkillReadGate", () => {
   it("denialContext contains the skill name and read path", () => {
     const result = describeSkillReadGate(makeTcc(), () => [
       makeSkillEntry({ name: "librarian" }),
-    ]) as GateDescriptor;
+    ])!;
     expect(result.denialContext).toEqual({
       kind: "skill_read",
       skillName: "librarian",
@@ -120,7 +120,7 @@ describe("describeSkillReadGate", () => {
     const result = describeSkillReadGate(
       makeTcc({ agentName: "test-agent", toolCallId: "tc-42" }),
       () => [makeSkillEntry({ name: "my-skill" })],
-    ) as GateDescriptor;
+    )!;
     expect(result.promptDetails).toMatchObject({
       source: "skill_read",
       agentName: "test-agent",
@@ -135,7 +135,7 @@ describe("describeSkillReadGate", () => {
     const result = describeSkillReadGate(
       makeTcc({ agentName: "agent-1" }),
       () => [makeSkillEntry({ name: "librarian" })],
-    ) as GateDescriptor;
+    )!;
     expect(result.logContext).toMatchObject({
       source: "skill_read",
       skillName: "librarian",
@@ -144,9 +144,7 @@ describe("describeSkillReadGate", () => {
   });
 
   it("surface is 'skill' on the descriptor", () => {
-    const result = describeSkillReadGate(makeTcc(), () => [
-      makeSkillEntry(),
-    ]) as GateDescriptor;
+    const result = describeSkillReadGate(makeTcc(), () => [makeSkillEntry()])!;
     expect(result.surface).toBe("skill");
   });
 });