@gotgenes/pi-permission-system 5.9.0 → 5.11.0

package/tests/runtime.test.ts

@@ -8,8 +8,6 @@ const {
   mockCreateLogger,
   mockLoadAndMergeConfigs,
   mockSyncPermissionSystemStatus,
-  mockGetActiveAgentName,
-  mockGetActiveAgentNameFromSystemPrompt,
   mockBuildResolvedConfigLogEntry,
   mockDiscoverGlobalNodeModulesRoot,
 } = vi.hoisted(() => ({
@@ -24,9 +22,6 @@ const {
   mockCreateLogger: vi.fn(),
   mockLoadAndMergeConfigs: vi.fn(),
   mockSyncPermissionSystemStatus: vi.fn(),
-  mockGetActiveAgentName: vi.fn<() => string | null>(),
-  mockGetActiveAgentNameFromSystemPrompt:
-    vi.fn<(prompt?: string) => string | null>(),
   mockBuildResolvedConfigLogEntry: vi.fn(),
   mockDiscoverGlobalNodeModulesRoot: vi.fn<() => string | null>(),
 }));
@@ -50,11 +45,6 @@ vi.mock("../src/status", () => ({
   getPermissionSystemStatus: vi.fn(),
 }));
 
-vi.mock("../src/active-agent", () => ({
-  getActiveAgentName: mockGetActiveAgentName,
-  getActiveAgentNameFromSystemPrompt: mockGetActiveAgentNameFromSystemPrompt,
-}));
-
 vi.mock("../src/config-reporter", () => ({
   buildResolvedConfigLogEntry: mockBuildResolvedConfigLogEntry,
 }));
@@ -89,7 +79,6 @@ import {
   createPermissionManagerForCwd,
   derivePiProjectPaths,
   refreshExtensionConfig,
-  resolveAgentName,
 } from "../src/runtime";
 
 // ── test suite ─────────────────────────────────────────────────────────────
@@ -578,69 +567,5 @@ describe("refreshExtensionConfig", () => {
   });
 });
 
-// ── resolveAgentName ──────────────────────────────────────────────────────
-
-describe("resolveAgentName", () => {
-  function makeRuntime() {
-    mockCreateLogger.mockReturnValue({
-      debug: mockLoggerDebug,
-      review: mockLoggerReview,
-    });
-    return createExtensionRuntime({ agentDir: "/test/agent" });
-  }
-
-  function makeCtx(): ExtensionContext {
-    return {
-      cwd: "/test/project",
-      hasUI: false,
-      ui: {},
-      sessionManager: { getEntries: vi.fn(), addEntry: vi.fn() },
-    } as unknown as ExtensionContext;
-  }
-
-  beforeEach(() => {
-    mockLoggerDebug.mockReset().mockReturnValue(undefined);
-    mockGetActiveAgentName.mockReset().mockReturnValue(null);
-    mockGetActiveAgentNameFromSystemPrompt.mockReset().mockReturnValue(null);
-  });
-
-  it("returns and stores name from getActiveAgentName when available", () => {
-    const runtime = makeRuntime();
-    mockGetActiveAgentName.mockReturnValue("session-agent");
-    const result = resolveAgentName(runtime, makeCtx());
-    expect(result).toBe("session-agent");
-    expect(runtime.lastKnownActiveAgentName).toBe("session-agent");
-  });
-
-  it("falls back to getActiveAgentNameFromSystemPrompt when session name is null", () => {
-    const runtime = makeRuntime();
-    mockGetActiveAgentName.mockReturnValue(null);
-    mockGetActiveAgentNameFromSystemPrompt.mockReturnValue("prompt-agent");
-    const result = resolveAgentName(runtime, makeCtx(), "system prompt text");
-    expect(result).toBe("prompt-agent");
-    expect(runtime.lastKnownActiveAgentName).toBe("prompt-agent");
-  });
-
-  it("falls back to lastKnownActiveAgentName when both sources return null", () => {
-    const runtime = makeRuntime();
-    runtime.lastKnownActiveAgentName = "remembered-agent";
-    mockGetActiveAgentName.mockReturnValue(null);
-    mockGetActiveAgentNameFromSystemPrompt.mockReturnValue(null);
-    const result = resolveAgentName(runtime, makeCtx());
-    expect(result).toBe("remembered-agent");
-  });
-
-  it("returns null when all sources are null and no prior name", () => {
-    const runtime = makeRuntime();
-    const result = resolveAgentName(runtime, makeCtx());
-    expect(result).toBeNull();
-  });
-
-  it("does not update lastKnownActiveAgentName when falling back to stored value", () => {
-    const runtime = makeRuntime();
-    runtime.lastKnownActiveAgentName = "remembered-agent";
-    resolveAgentName(runtime, makeCtx());
-    // Value unchanged — not overwritten with null
-    expect(runtime.lastKnownActiveAgentName).toBe("remembered-agent");
-  });
-});
+// resolveAgentName was moved to PermissionSession (#129)
+// Tests live in tests/permission-session.test.ts

package/src/handlers/input.ts

@@ -1,126 +0,0 @@
-import type {
-  ExtensionContext,
-  InputEventResult,
-} from "@mariozechner/pi-coding-agent";
-
-/** Minimal subset of InputEvent used by this handler. */
-interface InputPayload {
-  text: string;
-}
-
-import { emitDecisionEvent } from "../permission-events";
-import { applyPermissionGate } from "../permission-gate";
-import { formatSkillAskPrompt } from "../permission-prompts";
-import type { HandlerDeps } from "./types";
-
-/**
- * Parse a `/skill:<name>` prefix from user input.
- * Returns the skill name, or null if the text is not a skill invocation.
- */
-export function extractSkillNameFromInput(text: string): string | null {
-  const trimmed = text.trim();
-  if (!trimmed.startsWith("/skill:")) {
-    return null;
-  }
-
-  const afterPrefix = trimmed.slice("/skill:".length);
-  if (!afterPrefix) {
-    return null;
-  }
-
-  const firstWhitespace = afterPrefix.search(/\s/);
-  const skillName = (
-    firstWhitespace === -1 ? afterPrefix : afterPrefix.slice(0, firstWhitespace)
-  ).trim();
-  return skillName || null;
-}
-
-export async function handleInput(
-  deps: HandlerDeps,
-  event: InputPayload,
-  ctx: ExtensionContext,
-): Promise<InputEventResult> {
-  deps.session.runtimeContext = ctx;
-  deps.forwarding.start(ctx);
-
-  const skillName = extractSkillNameFromInput(event.text);
-  if (!skillName) {
-    return { action: "continue" };
-  }
-
-  const agentName = deps.resolveAgentName(ctx);
-  const check = deps.session.permissionManager.checkPermission(
-    "skill",
-    { name: skillName },
-    agentName ?? undefined,
-  );
-
-  if (check.state === "deny" && ctx.hasUI) {
-    const notifyMessage = agentName
-      ? `Skill '${skillName}' is not permitted for agent '${agentName}'.`
-      : `Skill '${skillName}' is not permitted by the current skill policy.`;
-    ctx.ui.notify(notifyMessage, "warning");
-  }
-
-  const skillInputMessage = formatSkillAskPrompt(
-    skillName,
-    agentName ?? undefined,
-  );
-  const skillInputCanConfirm = deps.canRequestPermissionConfirmation(ctx);
-  let skillInputAutoApproved = false;
-  const skillInputGate = await applyPermissionGate({
-    state: check.state,
-    canConfirm: skillInputCanConfirm,
-    promptForApproval: async () => {
-      const decision = await deps.promptPermission(ctx, {
-        requestId: deps.createPermissionRequestId("skill-input"),
-        source: "skill_input",
-        agentName,
-        message: skillInputMessage,
-        skillName,
-      });
-      skillInputAutoApproved = decision.autoApproved === true;
-      return decision;
-    },
-    writeLog: deps.logger.review,
-    logContext: {
-      source: "skill_input",
-      skillName,
-      agentName,
-      message: skillInputMessage,
-    },
-    messages: {
-      denyReason: skillInputMessage,
-      unavailableReason:
-        "Skill requires approval, but no interactive UI is available.",
-      userDeniedReason: () => "User denied skill.",
-    },
-  });
-
-  emitDecisionEvent(deps.events, {
-    surface: "skill",
-    value: skillName,
-    result: skillInputGate.action === "allow" ? "allow" : "deny",
-    resolution:
-      check.state === "allow"
-        ? "policy_allow"
-        : check.state === "deny"
-          ? "policy_deny"
-          : skillInputGate.action === "allow"
-            ? skillInputAutoApproved
-              ? "auto_approved"
-              : "user_approved"
-            : skillInputCanConfirm
-              ? "user_denied"
-              : "confirmation_unavailable",
-    origin: check.origin ?? null,
-    agentName: agentName ?? null,
-    matchedPattern: check.matchedPattern ?? null,
-  });
-
-  if (skillInputGate.action === "block") {
-    return { action: "handled" };
-  }
-
-  return { action: "continue" };
-}

package/src/handlers/tool-call.ts

@@ -1,210 +0,0 @@
-import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
-
-import { toRecord } from "../common";
-import { emitDecisionEvent } from "../permission-events";
-import {
-  formatMissingToolNameReason,
-  formatUnknownToolReason,
-} from "../permission-prompts";
-import {
-  checkRequestedToolRegistration,
-  getToolNameFromValue,
-} from "../tool-registry";
-import { describeBashExternalDirectoryGate } from "./gates/bash-external-directory";
-import type { GateRunnerDeps } from "./gates/descriptor";
-import { isGateBypass } from "./gates/descriptor";
-import { describeExternalDirectoryGate } from "./gates/external-directory";
-import { runGateCheck } from "./gates/runner";
-import { describeSkillReadGate } from "./gates/skill-read";
-import { describeToolGate } from "./gates/tool";
-import type { ToolCallContext } from "./gates/types";
-import type { HandlerDeps, PromptPermissionDetails } from "./types";
-
-/**
- * Extract the tool input from an event, checking both `input` and `arguments`
- * fields (different Pi SDK versions use different names).
- */
-export function getEventInput(event: unknown): unknown {
-  const record = toRecord(event);
-
-  if (record.input !== undefined) {
-    return record.input;
-  }
-
-  if (record.arguments !== undefined) {
-    return record.arguments;
-  }
-
-  return {};
-}
-
-export async function handleToolCall(
-  deps: HandlerDeps,
-  event: unknown,
-  ctx: ExtensionContext,
-): Promise<{ block?: true; reason?: string }> {
-  deps.session.runtimeContext = ctx;
-  deps.forwarding.start(ctx);
-
-  const agentName = deps.resolveAgentName(ctx);
-  const toolName = getToolNameFromValue(event);
-
-  if (!toolName) {
-    return { block: true, reason: formatMissingToolNameReason() };
-  }
-
-  const registrationCheck = checkRequestedToolRegistration(
-    toolName,
-    deps.getAllTools(),
-  );
-  if (registrationCheck.status === "missing-tool-name") {
-    return { block: true, reason: formatMissingToolNameReason() };
-  }
-
-  if (registrationCheck.status === "unregistered") {
-    return {
-      block: true,
-      reason: formatUnknownToolReason(
-        registrationCheck.requestedToolName,
-        registrationCheck.availableToolNames,
-      ),
-    };
-  }
-
-  const input = getEventInput(event);
-  const toolCallId =
-    typeof (event as Record<string, unknown>).toolCallId === "string"
-      ? ((event as Record<string, unknown>).toolCallId as string)
-      : "";
-
-  const tcc: ToolCallContext = {
-    toolName,
-    agentName,
-    input,
-    toolCallId,
-    cwd: ctx.cwd,
-  };
-
-  // ── Shared gate adapter closures ───────────────────────────────────────
-  const canConfirm = () => deps.canRequestPermissionConfirmation(ctx);
-  const promptPermission = (details: PromptPermissionDetails) =>
-    deps.promptPermission(ctx, details);
-  const emitDecision: GateRunnerDeps["emitDecision"] = (e) =>
-    emitDecisionEvent(deps.events, e);
-  const { review: writeReviewLog } = deps.logger;
-  const checkPermission: GateRunnerDeps["checkPermission"] = (
-    surface,
-    input,
-    agent,
-    sessionRules,
-  ) =>
-    deps.session.permissionManager.checkPermission(
-      surface,
-      input,
-      agent,
-      sessionRules,
-    );
-  const getSessionRuleset = () => deps.session.sessionRules.getRuleset();
-  const approveSessionRule = (surface: string, pattern: string) =>
-    deps.session.sessionRules.approve(surface, pattern);
-
-  // ── Shared runner deps (built once, reused for all gates) ─────────────
-  const runnerDeps: GateRunnerDeps = {
-    checkPermission,
-    getSessionRuleset,
-    approveSessionRule,
-    writeReviewLog,
-    emitDecision,
-    canConfirm,
-    promptPermission,
-  };
-
-  // ── Skill-read gate (descriptor + runner) ────────────────────────────────
-  const skillDescriptor = describeSkillReadGate(
-    tcc,
-    () => deps.session.activeSkillEntries,
-  );
-  if (skillDescriptor) {
-    const skillResult = await runGateCheck(
-      skillDescriptor,
-      tcc.agentName,
-      tcc.toolCallId,
-      runnerDeps,
-    );
-    if (skillResult.action === "block") {
-      return { block: true, reason: skillResult.reason };
-    }
-  }
-
-  // ── External-directory gate (descriptor + runner) ─────────────────────────
-  const infraDirs = [
-    ...deps.piInfrastructureDirs,
-    ...deps.getPiInfrastructureReadPaths(),
-  ];
-  const extDirDesc = describeExternalDirectoryGate(tcc, infraDirs);
-  if (extDirDesc) {
-    if (isGateBypass(extDirDesc)) {
-      if (extDirDesc.log) {
-        writeReviewLog(extDirDesc.log.event, extDirDesc.log.details);
-      }
-      if (extDirDesc.decision) {
-        emitDecision(extDirDesc.decision);
-      }
-    } else {
-      const extDirResult = await runGateCheck(
-        extDirDesc,
-        tcc.agentName,
-        tcc.toolCallId,
-        runnerDeps,
-      );
-      if (extDirResult.action === "block") {
-        return { block: true, reason: extDirResult.reason };
-      }
-    }
-  }
-
-  // ── Bash external-directory gate (descriptor + runner) ─────────────────────
-  const bashExtDesc = await describeBashExternalDirectoryGate(
-    tcc,
-    checkPermission,
-    getSessionRuleset,
-  );
-  if (bashExtDesc) {
-    if (isGateBypass(bashExtDesc)) {
-      if (bashExtDesc.log) {
-        writeReviewLog(bashExtDesc.log.event, bashExtDesc.log.details);
-      }
-    } else {
-      const bashExtResult = await runGateCheck(
-        bashExtDesc,
-        tcc.agentName,
-        tcc.toolCallId,
-        runnerDeps,
-      );
-      if (bashExtResult.action === "block") {
-        return { block: true, reason: bashExtResult.reason };
-      }
-    }
-  }
-
-  // ── Normal tool permission gate (descriptor + runner) ───────────────────────────
-  const toolCheck = checkPermission(
-    tcc.toolName,
-    tcc.input,
-    tcc.agentName ?? undefined,
-    getSessionRuleset(),
-  );
-  const toolDescriptor = describeToolGate(tcc, toolCheck);
-  toolDescriptor.preCheck = toolCheck;
-  const toolResult = await runGateCheck(
-    toolDescriptor,
-    tcc.agentName,
-    tcc.toolCallId,
-    runnerDeps,
-  );
-  if (toolResult.action === "block") {
-    return { block: true, reason: toolResult.reason };
-  }
-
-  return {};
-}

package/src/handlers/types.ts

@@ -1,90 +0,0 @@
-import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
-
-import type { ForwardingController } from "../forwarding-manager";
-import type { PermissionPromptDecision } from "../permission-dialog";
-import type { PermissionEventBus } from "../permission-events";
-import type { PermissionManager } from "../permission-manager";
-import type { SessionState } from "../runtime";
-import type { SessionLogger } from "../session-logger";
-
-export type PermissionReviewSource = "tool_call" | "skill_input" | "skill_read";
-
-/** Details passed when prompting the user for a permission decision. */
-export interface PromptPermissionDetails {
-  requestId: string;
-  source: PermissionReviewSource;
-  agentName: string | null;
-  message: string;
-  toolCallId?: string;
-  toolName?: string;
-  skillName?: string;
-  path?: string;
-  command?: string;
-  target?: string;
-  toolInputPreview?: string;
-  /** Override label for the "for this session" dialog option. */
-  sessionLabel?: string;
-}
-
-/**
- * Explicit dependency bag passed to each extracted event handler.
- *
- * Mutable session state lives in `session`; handlers read and write
- * `deps.session.*` directly. Logging, infrastructure paths, and the
- * event bus are promoted to top-level fields so handlers and gate
- * adapters never reach through nested objects for leaf operations.
- */
-export interface HandlerDeps {
-  // ── Session state ─────────────────────────────────────────────────────
-  /** Mutable session state: permissionManager, sessionRules, cache keys. */
-  readonly session: SessionState;
-
-  // ── Logging ────────────────────────────────────────────────────────────
-  readonly logger: SessionLogger;
-
-  // ── Immutable infrastructure paths ───────────────────────────────────
-  readonly piInfrastructureDirs: readonly string[];
-  /** Returns config-derived infrastructure read paths (current at call time). */
-  getPiInfrastructureReadPaths(): string[];
-
-  // ── Event bus ────────────────────────────────────────────────────────
-  /** Event bus for emitting permissions:decision broadcast events. */
-  readonly events: PermissionEventBus;
-
-  // ── Factories ──────────────────────────────────────────────────────────
-  /** Create a new PermissionManager scoped to cwd's config hierarchy. */
-  createPermissionManagerForCwd(
-    cwd: string | undefined | null,
-  ): PermissionManager;
-
-  // ── Config & lifecycle helpers ─────────────────────────────────────────
-  /** Reload merged config from disk; optionally update the stored runtime context. */
-  refreshExtensionConfig(ctx?: ExtensionContext): void;
-  /** Write the resolved config path set to the review and debug logs. */
-  logResolvedConfigPaths(): void;
-
-  // ── Permission helpers ─────────────────────────────────────────────────
-  /**
-   * Resolve the active agent name from the session context or system prompt.
-   * Updates session.lastKnownActiveAgentName as a side effect.
-   */
-  resolveAgentName(ctx: ExtensionContext, systemPrompt?: string): string | null;
-  /** Whether the current context can show an interactive permission prompt. */
-  canRequestPermissionConfirmation(ctx: ExtensionContext): boolean;
-  /** Prompt the user for a permission decision, log the outcome, and return it. */
-  promptPermission(
-    ctx: ExtensionContext,
-    details: PromptPermissionDetails,
-  ): Promise<PermissionPromptDecision>;
-  /** Generate a unique ID for a permission request. */
-  createPermissionRequestId(prefix: string): string;
-
-  // ── Forwarding ─────────────────────────────────────────────────────────
-  readonly forwarding: ForwardingController;
-  /** Unsubscribe the permissions:rpc:check and permissions:rpc:prompt handlers. */
-  stopPermissionRpcHandlers(): void;
-
-  // ── Pi API subset ──────────────────────────────────────────────────────
-  getAllTools(): unknown[];
-  setActiveTools(names: string[]): void;
-}