@gotgenes/pi-permission-system 5.14.0 → 5.14.1

package/CHANGELOG.md

@@ -5,6 +5,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.14.1](https://github.com/gotgenes/pi-permission-system/compare/v5.14.0...v5.14.1) (2026-05-11)
+
+
+### Bug Fixes
+
+* show tool name instead of bare wildcard in session-approval label ([1a65c30](https://github.com/gotgenes/pi-permission-system/commit/1a65c3017f25012c3a7ced63f26d40fcecea81d3))
+* surface-prefixed session-approval labels for all permission surfaces ([759da03](https://github.com/gotgenes/pi-permission-system/commit/759da03be9c0d847ec6de58e161ef2e7cbbc70b8))
+
+
+### Documentation
+
+* **retro:** add retro notes for issue [#122](https://github.com/gotgenes/pi-permission-system/issues/122) ([7867db2](https://github.com/gotgenes/pi-permission-system/commit/7867db22054df00e13aa6c88347238dadaa63166))
+
 ## [5.14.0](https://github.com/gotgenes/pi-permission-system/compare/v5.13.0...v5.14.0) (2026-05-09)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "5.14.0",
+  "version": "5.14.1",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "files": [

package/src/pattern-suggest.ts

@@ -57,8 +57,21 @@ export function suggestMcpPattern(target: string): string {
   return "*";
 }
 
-function buildLabel(pattern: string): string {
-  return `Yes, allow "${pattern}" for this session`;
+/** Surface-aware human-readable labels for the session-approval option. */
+function buildLabel(pattern: string, surface: string): string {
+  switch (surface) {
+    case "bash":
+      return `Yes, allow bash "${pattern}" for this session`;
+    case "mcp":
+      return `Yes, allow mcp tool "${pattern}" for this session`;
+    case "skill":
+      return `Yes, allow skill "${pattern}" for this session`;
+    case "external_directory":
+      return `Yes, allow access to external directory "${pattern}" for this session`;
+    default:
+      // Tool surfaces (read, write, edit, grep, find, ls, extension tools)
+      return `Yes, allow tool "${surface}" for this session`;
+  }
 }
 
 /**
@@ -92,5 +105,5 @@ export function suggestSessionPattern(
       break;
   }
 
-  return { surface, pattern, label: buildLabel(pattern) };
+  return { surface, pattern, label: buildLabel(pattern, surface) };
 }

package/tests/pattern-suggest.test.ts

@@ -136,23 +136,46 @@ describe("suggestSessionPattern", () => {
       const result = suggestSessionPattern("edit", "*");
       expect(result).toMatchObject({ surface: "edit", pattern: "*" });
     });
+
+    it("label shows tool name instead of bare wildcard", () => {
+      const result = suggestSessionPattern("find", "*");
+      expect(result.label).toBe('Yes, allow tool "find" for this session');
+    });
   });
 
   describe("label field", () => {
-    it("includes the suggested pattern in the label", () => {
-      // git arity=2, "git status" has 2 tokens → trailing wildcard.
+    it("bash label includes surface prefix and pattern", () => {
       const result = suggestSessionPattern("bash", "git status");
-      expect(result.label).toContain("git status*");
+      expect(result.label).toBe(
+        'Yes, allow bash "git status*" for this session',
+      );
     });
 
-    it("wraps the pattern in quotes in the label", () => {
+    it("mcp label includes surface prefix and pattern", () => {
       const result = suggestSessionPattern("mcp", "exa:search");
-      expect(result.label).toContain('"exa:*"');
+      expect(result.label).toBe('Yes, allow mcp tool "exa:*" for this session');
     });
 
-    it("label reads as a natural session-approval option", () => {
+    it("skill label includes surface prefix", () => {
       const result = suggestSessionPattern("skill", "librarian");
-      expect(result.label).toBe('Yes, allow "librarian" for this session');
+      expect(result.label).toBe(
+        'Yes, allow skill "librarian" for this session',
+      );
+    });
+
+    it("external_directory label includes surface prefix", () => {
+      const result = suggestSessionPattern(
+        "external_directory",
+        "/tmp/foo.txt",
+      );
+      expect(result.label).toBe(
+        'Yes, allow access to external directory "/tmp/*" for this session',
+      );
+    });
+
+    it("tool label shows tool name, not wildcard pattern", () => {
+      const result = suggestSessionPattern("edit", "*");
+      expect(result.label).toBe('Yes, allow tool "edit" for this session');
     });
   });
 });