@gotgenes/pi-permission-system 4.7.0 → 4.9.0

package/tests/runtime.test.ts

@@ -11,6 +11,7 @@ const {
   mockGetActiveAgentName,
   mockGetActiveAgentNameFromSystemPrompt,
   mockBuildResolvedConfigLogEntry,
+  mockDiscoverGlobalNodeModulesRoot,
 } = vi.hoisted(() => ({
   mockLoggerDebug:
     vi.fn<
@@ -27,6 +28,7 @@ const {
   mockGetActiveAgentNameFromSystemPrompt:
     vi.fn<(prompt?: string) => string | null>(),
   mockBuildResolvedConfigLogEntry: vi.fn(),
+  mockDiscoverGlobalNodeModulesRoot: vi.fn<() => string | null>(),
 }));
 
 vi.mock("../src/logging", () => ({
@@ -65,6 +67,10 @@ vi.mock("../src/subagent-context", () => ({
   isSubagentExecutionContext: vi.fn().mockReturnValue(false),
 }));
 
+vi.mock("../src/external-directory", () => ({
+  discoverGlobalNodeModulesRoot: mockDiscoverGlobalNodeModulesRoot,
+}));
+
 vi.mock("../src/session-rules", () => ({
   SessionRules: vi.fn(),
   deriveApprovalPattern: vi.fn(),
@@ -99,6 +105,10 @@ describe("createExtensionRuntime", () => {
       debug: mockLoggerDebug,
       review: mockLoggerReview,
     });
+    mockDiscoverGlobalNodeModulesRoot.mockReset();
+    mockDiscoverGlobalNodeModulesRoot.mockReturnValue(
+      "/mock/global/node_modules",
+    );
   });
 
   // ── Path derivation ──────────────────────────────────────────────────────
@@ -130,6 +140,41 @@ describe("createExtensionRuntime", () => {
     expect(runtime.globalLogsDir).toBe(getGlobalLogsDir("/test/agent"));
   });
 
+  // ── piInfrastructureDirs ─────────────────────────────────────────────────
+
+  it("includes agentDir in piInfrastructureDirs", () => {
+    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
+    expect(runtime.piInfrastructureDirs).toContain("/test/agent");
+  });
+
+  it("includes agentDir/git in piInfrastructureDirs", () => {
+    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
+    expect(runtime.piInfrastructureDirs).toContain("/test/agent/git");
+  });
+
+  it("includes discovered global node_modules root in piInfrastructureDirs", () => {
+    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
+    expect(runtime.piInfrastructureDirs).toContain("/mock/global/node_modules");
+  });
+
+  it("excludes null when discoverGlobalNodeModulesRoot returns null", () => {
+    mockDiscoverGlobalNodeModulesRoot.mockReturnValue(null);
+    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
+    for (const dir of runtime.piInfrastructureDirs) {
+      expect(dir).not.toBeNull();
+      expect(typeof dir).toBe("string");
+    }
+  });
+
+  it("omits global node_modules from piInfrastructureDirs when discovery returns null", () => {
+    mockDiscoverGlobalNodeModulesRoot.mockReturnValue(null);
+    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
+    // Only agentDir and agentDir/git should be present.
+    expect(runtime.piInfrastructureDirs).toHaveLength(2);
+    expect(runtime.piInfrastructureDirs).toContain("/test/agent");
+    expect(runtime.piInfrastructureDirs).toContain("/test/agent/git");
+  });
+
   // ── Default mutable state ────────────────────────────────────────────────
 
   it("initializes config to DEFAULT_EXTENSION_CONFIG", () => {

package/tests/wildcard-matcher.test.ts

@@ -1,5 +1,15 @@
+import { join } from "node:path";
 import { afterEach, describe, expect, test, vi } from "vitest";
 
+const mockHomedir = vi.hoisted(() => vi.fn(() => "/home/testuser"));
+
+vi.mock("node:os", () => ({
+  homedir: mockHomedir,
+  default: { homedir: mockHomedir },
+}));
+
+const FAKE_HOME = "/home/testuser";
+
 import {
   compileWildcardPattern,
   compileWildcardPatternEntries,
@@ -9,6 +19,7 @@ import {
 } from "../src/wildcard-matcher";
 
 afterEach(() => {
+  mockHomedir.mockClear();
   vi.restoreAllMocks();
 });
 
@@ -233,3 +244,50 @@ describe("wildcardMatch", () => {
     expect(wildcardMatch("tool.name", "toolXname")).toBe(false);
   });
 });
+
+describe("home path expansion in patterns", () => {
+  test("wildcardMatch expands ~ prefix in pattern before matching", () => {
+    const expandedPath = join(FAKE_HOME, "dev/project");
+    expect(wildcardMatch("~/dev/project", expandedPath)).toBe(true);
+  });
+
+  test("wildcardMatch expands ~/glob in pattern", () => {
+    const expandedFile = join(FAKE_HOME, "dev/project/file.ts");
+    expect(wildcardMatch("~/dev/*", expandedFile)).toBe(true);
+  });
+
+  test("wildcardMatch ~/glob does not match a different home directory", () => {
+    expect(wildcardMatch("~/dev/*", "/other/user/dev/file.ts")).toBe(false);
+  });
+
+  test("wildcardMatch expands $HOME prefix in pattern before matching", () => {
+    const expandedPath = join(FAKE_HOME, "dev/project");
+    expect(wildcardMatch("$HOME/dev/project", expandedPath)).toBe(true);
+  });
+
+  test("wildcardMatch expands $HOME/glob in pattern", () => {
+    const expandedFile = join(FAKE_HOME, "work/file.ts");
+    expect(wildcardMatch("$HOME/work/*", expandedFile)).toBe(true);
+  });
+
+  test("compileWildcardPattern retains original ~ pattern in .pattern field", () => {
+    const compiled = compileWildcardPattern("~/dev/*", "allow");
+    expect(compiled.pattern).toBe("~/dev/*");
+  });
+
+  test("compileWildcardPattern retains original $HOME pattern in .pattern field", () => {
+    const compiled = compileWildcardPattern("$HOME/dev/*", "allow");
+    expect(compiled.pattern).toBe("$HOME/dev/*");
+  });
+
+  test("compileWildcardPattern expanded regex matches the expanded path", () => {
+    const compiled = compileWildcardPattern("~/dev/*", "allow");
+    const expandedFile = join(FAKE_HOME, "dev/file.ts");
+    expect(compiled.regex.test(expandedFile)).toBe(true);
+  });
+
+  test("non-home pattern is unaffected", () => {
+    expect(wildcardMatch("/absolute/path/*", "/absolute/path/file")).toBe(true);
+    expect(wildcardMatch("/absolute/path/*", "/other/file")).toBe(false);
+  });
+});