@gotgenes/pi-permission-system 4.3.0 → 4.4.0

package/CHANGELOG.md

@@ -5,6 +5,24 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.4.0](https://github.com/gotgenes/pi-permission-system/compare/v4.3.0...v4.4.0) (2026-05-05)
+
+
+### Features
+
+* wire PermissionPrompter and remove runtime promptPermission ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([8e0980a](https://github.com/gotgenes/pi-permission-system/commit/8e0980a207f9f665ad2af3ad635d73e28d313c91))
+
+
+### Documentation
+
+* add permission-prompter architecture note ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([6cc1b60](https://github.com/gotgenes/pi-permission-system/commit/6cc1b6089a332f262919d20ad27d5ca7a69b0b6d))
+* add permission-prompter to target architecture module map ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([c5cf101](https://github.com/gotgenes/pi-permission-system/commit/c5cf101af827dc108c66c5dffff94e05d4234e4c))
+* add permission-prompter to v3 architecture module map ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([94be5b5](https://github.com/gotgenes/pi-permission-system/commit/94be5b58b9018b1918102089bb2fff8401d8bad5))
+* plan extract PermissionPrompter class ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([50fcf34](https://github.com/gotgenes/pi-permission-system/commit/50fcf3400ed8574b036cacd2afc1b9e2161d41c6))
+* remove interim permission-prompter from target architecture map ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([f300f08](https://github.com/gotgenes/pi-permission-system/commit/f300f086b42d9d52ff0668b63a191addebe3140e))
+* **retro:** add retro notes for issue [#51](https://github.com/gotgenes/pi-permission-system/issues/51) ([79a564d](https://github.com/gotgenes/pi-permission-system/commit/79a564d24977da7cffa3d9d65391a75dd0d7e99c))
+* update target architecture for completed work and new issues ([#80](https://github.com/gotgenes/pi-permission-system/issues/80)) ([e661345](https://github.com/gotgenes/pi-permission-system/commit/e661345c8a699e702cbaa9adb7d61c80a25010d2))
+
 ## [4.3.0](https://github.com/gotgenes/pi-permission-system/compare/v4.2.0...v4.3.0) (2026-05-04)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "4.3.0",
+  "version": "4.4.0",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "files": [

package/src/index.ts

@@ -12,11 +12,11 @@ import {
   handleToolCall,
 } from "./handlers";
 import { requestPermissionDecisionFromUi } from "./permission-dialog";
+import { PermissionPrompter } from "./permission-prompter";
 import {
   createExtensionRuntime,
   createPermissionManagerForCwd,
   logResolvedConfigPaths,
-  promptPermission,
   refreshExtensionConfig,
   resolveAgentName,
   saveExtensionConfig,
@@ -32,6 +32,14 @@ import {
 export default function piPermissionSystemExtension(pi: ExtensionAPI): void {
   const runtime = createExtensionRuntime();
 
+  const prompter = new PermissionPrompter({
+    getConfig: () => runtime.config,
+    writeReviewLog: runtime.writeReviewLog.bind(runtime),
+    subagentSessionsDir: runtime.subagentSessionsDir,
+    forwardingDir: runtime.forwardingDir,
+    requestPermissionDecisionFromUi,
+  });
+
   const forwardingDeps: PermissionForwardingDeps = {
     forwardingDir: runtime.forwardingDir,
     subagentSessionsDir: runtime.subagentSessionsDir,
@@ -74,8 +82,7 @@ export default function piPermissionSystemExtension(pi: ExtensionAPI): void {
           runtime.subagentSessionsDir,
         ),
       }),
-    promptPermission: (ctx, details) =>
-      promptPermission(runtime, forwardingDeps, ctx, details),
+    promptPermission: (ctx, details) => prompter.prompt(ctx, details),
     createPermissionRequestId,
     startForwardedPermissionPolling: (ctx) =>
       startForwardedPermissionPolling(runtime, forwardingDeps, ctx),

package/src/permission-prompter.ts

@@ -0,0 +1,146 @@
+import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
+import type { PermissionSystemExtensionConfig } from "./extension-config";
+import type { ForwardedPermissionLogger } from "./forwarded-permissions/io";
+import {
+  confirmPermission,
+  type PermissionForwardingDeps,
+} from "./forwarded-permissions/polling";
+import type { PromptPermissionDetails } from "./handlers/types";
+import type {
+  PermissionPromptDecision,
+  RequestPermissionOptions,
+} from "./permission-dialog";
+import { shouldAutoApprovePermissionState } from "./yolo-mode";
+
+/** Mockable contract exposed to handlers via HandlerDeps. */
+export interface PermissionPrompterApi {
+  prompt(
+    ctx: ExtensionContext,
+    details: PromptPermissionDetails,
+  ): Promise<PermissionPromptDecision>;
+}
+
+/**
+ * Dependencies required by PermissionPrompter.
+ *
+ * Keeps the prompter's external surface narrow: callers provide config
+ * access, review-log writing, path constants, and the UI dialog function.
+ * The prompter synthesises the PermissionForwardingDeps it needs internally.
+ */
+export interface PermissionPrompterDeps {
+  /** Read current config for yolo-mode check (called at prompt time). */
+  getConfig(): PermissionSystemExtensionConfig;
+  /** Write structured entries to the permission review log. */
+  writeReviewLog(event: string, details: Record<string, unknown>): void;
+  /** Directory containing subagent session state. */
+  subagentSessionsDir: string;
+  /** Directory used for file-based permission forwarding requests/responses. */
+  forwardingDir: string;
+  /** Show the interactive permission dialog in the UI. */
+  requestPermissionDecisionFromUi(
+    ui: ExtensionContext["ui"],
+    title: string,
+    message: string,
+    options?: RequestPermissionOptions,
+  ): Promise<PermissionPromptDecision>;
+}
+
+/**
+ * Encapsulates the full permission-prompt flow:
+ *   1. Yolo-mode auto-approval check.
+ *   2. Review-log "waiting" entry.
+ *   3. UI-present vs. subagent-forwarding branching (via confirmPermission).
+ *   4. Review-log "approved" / "denied" entry.
+ *
+ * Injecting a single PermissionPrompter instance into HandlerDeps means
+ * adding a new prompt parameter (e.g. a future sessionLabel variant) only
+ * requires changing PromptPermissionDetails and this class — not the full
+ * 4-file threading chain.
+ */
+export class PermissionPrompter implements PermissionPrompterApi {
+  constructor(private readonly deps: PermissionPrompterDeps) {}
+
+  async prompt(
+    ctx: ExtensionContext,
+    details: PromptPermissionDetails,
+  ): Promise<PermissionPromptDecision> {
+    if (shouldAutoApprovePermissionState("ask", this.deps.getConfig())) {
+      this.writeReviewEntry("permission_request.auto_approved", details);
+      return { approved: true, state: "approved" };
+    }
+
+    this.writeReviewEntry("permission_request.waiting", details);
+
+    const decision = await confirmPermission(
+      ctx,
+      details.message,
+      this.buildForwardingDeps(),
+      details.sessionLabel ? { sessionLabel: details.sessionLabel } : undefined,
+    );
+
+    this.writeReviewEntry(
+      decision.approved
+        ? "permission_request.approved"
+        : "permission_request.denied",
+      {
+        ...details,
+        resolution: decision.state,
+        denialReason: decision.denialReason,
+      },
+    );
+
+    return decision;
+  }
+
+  // ── Private helpers ──────────────────────────────────────────────────────
+
+  private writeReviewEntry(
+    event: string,
+    details: PromptPermissionDetails & {
+      resolution?: string;
+      denialReason?: string;
+    },
+  ): void {
+    this.deps.writeReviewLog(event, {
+      requestId: details.requestId,
+      source: details.source,
+      agentName: details.agentName,
+      message: details.message,
+      toolCallId: details.toolCallId ?? null,
+      toolName: details.toolName ?? null,
+      skillName: details.skillName ?? null,
+      path: details.path ?? null,
+      command: details.command ?? null,
+      target: details.target ?? null,
+      toolInputPreview: details.toolInputPreview ?? null,
+      resolution: details.resolution ?? null,
+      denialReason: details.denialReason ?? null,
+    });
+  }
+
+  /**
+   * Build a PermissionForwardingDeps to pass to confirmPermission.
+   *
+   * Yolo-mode is already handled at the prompter level, so shouldAutoApprove
+   * returns false here (confirmPermission does not call it; only
+   * processForwardedPermissionRequests does, and that has its own deps).
+   *
+   * The logger delegates writeReviewLog to deps and uses a no-op writeDebugLog
+   * (trace-level forwarding debug is deferred — see open question in the plan).
+   */
+  private buildForwardingDeps(): PermissionForwardingDeps {
+    const { deps } = this;
+    const logger: ForwardedPermissionLogger = {
+      writeReviewLog: deps.writeReviewLog,
+      writeDebugLog: () => undefined,
+    };
+    return {
+      forwardingDir: deps.forwardingDir,
+      subagentSessionsDir: deps.subagentSessionsDir,
+      logger,
+      writeReviewLog: deps.writeReviewLog,
+      requestPermissionDecisionFromUi: deps.requestPermissionDecisionFromUi,
+      shouldAutoApprove: () => false,
+    };
+  }
+}

package/src/runtime.ts

@@ -35,20 +35,16 @@ import {
   type PermissionSystemExtensionConfig,
 } from "./extension-config";
 import {
-  confirmPermission,
   type PermissionForwardingDeps,
   processForwardedPermissionRequests,
 } from "./forwarded-permissions/polling";
-import type { PromptPermissionDetails } from "./handlers/types";
 import { createPermissionSystemLogger } from "./logging";
-import type { PermissionPromptDecision } from "./permission-dialog";
 import { PERMISSION_FORWARDING_POLL_INTERVAL_MS } from "./permission-forwarding";
 import { PermissionManager } from "./permission-manager";
 import { SessionRules } from "./session-rules";
 import type { SkillPromptEntry } from "./skill-prompt-sanitizer";
 import { syncPermissionSystemStatus } from "./status";
 import { isSubagentExecutionContext } from "./subagent-context";
-import { shouldAutoApprovePermissionState } from "./yolo-mode";
 
 /**
  * Runtime context object created once inside `piPermissionSystemExtension()`.
@@ -276,78 +272,6 @@ export function logResolvedConfigPaths(runtime: ExtensionRuntime): void {
   );
 }
 
-// ── Permission helpers ─────────────────────────────────────────────────────
-
-/** Internal: write a structured permission decision entry to the review log. */
-function reviewPermissionDecision(
-  writeReviewLog: (event: string, details: Record<string, unknown>) => void,
-  event: string,
-  details: PromptPermissionDetails & {
-    resolution?: string;
-    denialReason?: string;
-  },
-): void {
-  writeReviewLog(event, {
-    requestId: details.requestId,
-    source: details.source,
-    agentName: details.agentName,
-    message: details.message,
-    toolCallId: details.toolCallId ?? null,
-    toolName: details.toolName ?? null,
-    skillName: details.skillName ?? null,
-    path: details.path ?? null,
-    command: details.command ?? null,
-    target: details.target ?? null,
-    toolInputPreview: details.toolInputPreview ?? null,
-    resolution: details.resolution ?? null,
-    denialReason: details.denialReason ?? null,
-  });
-}
-
-/**
- * Prompt the user for a permission decision using the forwarding flow,
- * log the waiting / approved / denied outcome, and return the decision.
- * In yolo mode, auto-approves without prompting.
- */
-export async function promptPermission(
-  runtime: ExtensionRuntime,
-  forwardingDeps: PermissionForwardingDeps,
-  ctx: ExtensionContext,
-  details: PromptPermissionDetails,
-): Promise<PermissionPromptDecision> {
-  if (shouldAutoApprovePermissionState("ask", runtime.config)) {
-    reviewPermissionDecision(
-      runtime.writeReviewLog,
-      "permission_request.auto_approved",
-      details,
-    );
-    return { approved: true, state: "approved" };
-  }
-  reviewPermissionDecision(
-    runtime.writeReviewLog,
-    "permission_request.waiting",
-    details,
-  );
-  const decision = await confirmPermission(
-    ctx,
-    details.message,
-    forwardingDeps,
-    details.sessionLabel ? { sessionLabel: details.sessionLabel } : undefined,
-  );
-  reviewPermissionDecision(
-    runtime.writeReviewLog,
-    decision.approved
-      ? "permission_request.approved"
-      : "permission_request.denied",
-    {
-      ...details,
-      resolution: decision.state,
-      denialReason: decision.denialReason,
-    },
-  );
-  return decision;
-}
-
 // ── Forwarding polling lifecycle ───────────────────────────────────────────
 
 /** Stop the forwarded-permission polling interval and clear related state. */

package/tests/permission-prompter.test.ts

@@ -0,0 +1,398 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+// ── Module mocks ────────────────────────────────────────────────────────────
+
+const { mockConfirmPermission } = vi.hoisted(() => ({
+  mockConfirmPermission: vi.fn(),
+}));
+
+vi.mock("../src/forwarded-permissions/polling", () => ({
+  confirmPermission: mockConfirmPermission,
+  processForwardedPermissionRequests: vi.fn().mockResolvedValue(undefined),
+}));
+
+// ── Imports (after mocks) ───────────────────────────────────────────────────
+
+import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { DEFAULT_EXTENSION_CONFIG } from "../src/extension-config";
+import type { PromptPermissionDetails } from "../src/handlers/types";
+import type { PermissionPromptDecision } from "../src/permission-dialog";
+import {
+  PermissionPrompter,
+  type PermissionPrompterDeps,
+} from "../src/permission-prompter";
+
+// ── Helpers ─────────────────────────────────────────────────────────────────
+
+function makeCtx(hasUI: boolean): ExtensionContext {
+  return {
+    hasUI,
+    ui: { select: vi.fn(), input: vi.fn() },
+    sessionManager: { getSessionDir: vi.fn().mockReturnValue(null) },
+  } as unknown as ExtensionContext;
+}
+
+function makeDetails(
+  overrides?: Partial<PromptPermissionDetails>,
+): PromptPermissionDetails {
+  return {
+    requestId: "req-123",
+    source: "tool_call",
+    agentName: "test-agent",
+    message: "Allow read?",
+    toolName: "read",
+    ...overrides,
+  };
+}
+
+function makeDeps(
+  overrides?: Partial<PermissionPrompterDeps>,
+): PermissionPrompterDeps {
+  return {
+    getConfig: () => ({ ...DEFAULT_EXTENSION_CONFIG, yoloMode: false }),
+    writeReviewLog: vi.fn(),
+    subagentSessionsDir: "/sessions/subagents",
+    forwardingDir: "/sessions/permission-forwarding",
+    requestPermissionDecisionFromUi: vi
+      .fn()
+      .mockResolvedValue({ approved: true, state: "approved" }),
+    ...overrides,
+  };
+}
+
+// ── Tests ────────────────────────────────────────────────────────────────────
+
+describe("PermissionPrompter", () => {
+  beforeEach(() => {
+    mockConfirmPermission.mockReset();
+  });
+
+  // ── Yolo-mode auto-approve ───────────────────────────────────────────────
+
+  describe("yolo-mode auto-approve", () => {
+    it("returns approved without calling confirmPermission when yoloMode is true", async () => {
+      const deps = makeDeps({
+        getConfig: () => ({ ...DEFAULT_EXTENSION_CONFIG, yoloMode: true }),
+      });
+      const prompter = new PermissionPrompter(deps);
+
+      const decision = await prompter.prompt(makeCtx(false), makeDetails());
+
+      expect(decision).toEqual({ approved: true, state: "approved" });
+      expect(mockConfirmPermission).not.toHaveBeenCalled();
+    });
+
+    it("logs permission_request.auto_approved in yolo mode", async () => {
+      const writeReviewLog = vi.fn();
+      const deps = makeDeps({
+        getConfig: () => ({ ...DEFAULT_EXTENSION_CONFIG, yoloMode: true }),
+        writeReviewLog,
+      });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(false), makeDetails());
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.auto_approved",
+        expect.objectContaining({ requestId: "req-123" }),
+      );
+    });
+
+    it("does not log permission_request.waiting in yolo mode", async () => {
+      const writeReviewLog = vi.fn();
+      const deps = makeDeps({
+        getConfig: () => ({ ...DEFAULT_EXTENSION_CONFIG, yoloMode: true }),
+        writeReviewLog,
+      });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(false), makeDetails());
+
+      expect(writeReviewLog).not.toHaveBeenCalledWith(
+        "permission_request.waiting",
+        expect.anything(),
+      );
+    });
+
+    it("does not call confirmPermission with yoloMode even when ctx has UI", async () => {
+      const deps = makeDeps({
+        getConfig: () => ({ ...DEFAULT_EXTENSION_CONFIG, yoloMode: true }),
+      });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(mockConfirmPermission).not.toHaveBeenCalled();
+    });
+  });
+
+  // ── Non-yolo path ────────────────────────────────────────────────────────
+
+  describe("non-yolo path (UI present)", () => {
+    it("logs permission_request.waiting before calling confirmPermission", async () => {
+      const writeReviewLog = vi.fn();
+      const approved: PermissionPromptDecision = {
+        approved: true,
+        state: "approved",
+      };
+      mockConfirmPermission.mockResolvedValue(approved);
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      const calls = writeReviewLog.mock.calls.map((c) => c[0] as string);
+      expect(
+        calls.indexOf("permission_request.waiting"),
+      ).toBeGreaterThanOrEqual(0);
+      expect(calls.indexOf("permission_request.waiting")).toBeLessThan(
+        calls.indexOf("permission_request.approved"),
+      );
+    });
+
+    it("logs permission_request.approved when confirmPermission returns approved", async () => {
+      const writeReviewLog = vi.fn();
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.approved",
+        expect.objectContaining({
+          requestId: "req-123",
+          resolution: "approved",
+        }),
+      );
+    });
+
+    it("logs permission_request.denied when confirmPermission returns denied", async () => {
+      const writeReviewLog = vi.fn();
+      mockConfirmPermission.mockResolvedValue({
+        approved: false,
+        state: "denied",
+      });
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.denied",
+        expect.objectContaining({
+          requestId: "req-123",
+          resolution: "denied",
+        }),
+      );
+    });
+
+    it("logs permission_request.denied with denialReason when present", async () => {
+      const writeReviewLog = vi.fn();
+      mockConfirmPermission.mockResolvedValue({
+        approved: false,
+        state: "denied_with_reason",
+        denialReason: "too sensitive",
+      });
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.denied",
+        expect.objectContaining({
+          denialReason: "too sensitive",
+        }),
+      );
+    });
+
+    it("returns the decision from confirmPermission", async () => {
+      const decision: PermissionPromptDecision = {
+        approved: false,
+        state: "denied_with_reason",
+        denialReason: "sensitive",
+      };
+      mockConfirmPermission.mockResolvedValue(decision);
+      const deps = makeDeps();
+      const prompter = new PermissionPrompter(deps);
+
+      const result = await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(result).toEqual(decision);
+    });
+
+    it("passes sessionLabel option to confirmPermission when present", async () => {
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps();
+      const prompter = new PermissionPrompter(deps);
+      const details = makeDetails({ sessionLabel: "Yes, for 'read' tool" });
+
+      await prompter.prompt(makeCtx(true), details);
+
+      expect(mockConfirmPermission).toHaveBeenCalledWith(
+        expect.anything(),
+        expect.any(String),
+        expect.anything(),
+        { sessionLabel: "Yes, for 'read' tool" },
+      );
+    });
+
+    it("passes undefined options to confirmPermission when sessionLabel is absent", async () => {
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps();
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(mockConfirmPermission).toHaveBeenCalledWith(
+        expect.anything(),
+        expect.any(String),
+        expect.anything(),
+        undefined,
+      );
+    });
+
+    it("passes the message from details to confirmPermission", async () => {
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps();
+      const prompter = new PermissionPrompter(deps);
+      const details = makeDetails({ message: "Allow bash: git status?" });
+
+      await prompter.prompt(makeCtx(true), details);
+
+      expect(mockConfirmPermission).toHaveBeenCalledWith(
+        expect.anything(),
+        "Allow bash: git status?",
+        expect.anything(),
+        undefined,
+      );
+    });
+  });
+
+  // ── Review log field coverage ────────────────────────────────────────────
+
+  describe("review log fields", () => {
+    it("includes all standard fields in the waiting log entry", async () => {
+      const writeReviewLog = vi.fn();
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+      const details = makeDetails({
+        toolCallId: "tc-1",
+        skillName: "librarian",
+        path: "/src/foo.ts",
+        command: "git status",
+        target: "server:tool",
+        toolInputPreview: "{ path: '...' }",
+      });
+
+      await prompter.prompt(makeCtx(true), details);
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.waiting",
+        expect.objectContaining({
+          requestId: "req-123",
+          source: "tool_call",
+          agentName: "test-agent",
+          message: "Allow read?",
+          toolCallId: "tc-1",
+          toolName: "read",
+          skillName: "librarian",
+          path: "/src/foo.ts",
+          command: "git status",
+          target: "server:tool",
+          toolInputPreview: "{ path: '...' }",
+        }),
+      );
+    });
+
+    it("uses null for optional fields not present in details", async () => {
+      const writeReviewLog = vi.fn();
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(true), makeDetails());
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.waiting",
+        expect.objectContaining({
+          toolCallId: null,
+          skillName: null,
+          path: null,
+          command: null,
+          target: null,
+          toolInputPreview: null,
+        }),
+      );
+    });
+  });
+
+  // ── Subagent forwarding path ─────────────────────────────────────────────
+
+  describe("subagent forwarding path", () => {
+    it("calls confirmPermission even when ctx has no UI", async () => {
+      const forwarded: PermissionPromptDecision = {
+        approved: true,
+        state: "approved",
+      };
+      mockConfirmPermission.mockResolvedValue(forwarded);
+      const deps = makeDeps();
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(false), makeDetails());
+
+      expect(mockConfirmPermission).toHaveBeenCalled();
+    });
+
+    it("returns the decision from confirmPermission in the subagent path", async () => {
+      const forwarded: PermissionPromptDecision = {
+        approved: false,
+        state: "denied",
+      };
+      mockConfirmPermission.mockResolvedValue(forwarded);
+      const deps = makeDeps();
+      const prompter = new PermissionPrompter(deps);
+
+      const result = await prompter.prompt(makeCtx(false), makeDetails());
+
+      expect(result).toEqual(forwarded);
+    });
+
+    it("logs the outcome when confirmPermission resolves via forwarding", async () => {
+      const writeReviewLog = vi.fn();
+      mockConfirmPermission.mockResolvedValue({
+        approved: true,
+        state: "approved",
+      });
+      const deps = makeDeps({ writeReviewLog });
+      const prompter = new PermissionPrompter(deps);
+
+      await prompter.prompt(makeCtx(false), makeDetails());
+
+      expect(writeReviewLog).toHaveBeenCalledWith(
+        "permission_request.approved",
+        expect.objectContaining({ requestId: "req-123" }),
+      );
+    });
+  });
+});

package/tests/runtime.test.ts

@@ -59,9 +59,6 @@ vi.mock("../src/config-reporter", () => ({
 
 vi.mock("../src/forwarded-permissions/polling", () => ({
   processForwardedPermissionRequests: vi.fn().mockResolvedValue(undefined),
-  confirmPermission: vi
-    .fn()
-    .mockResolvedValue({ approved: true, state: "approved" }),
 }));
 
 vi.mock("../src/subagent-context", () => ({