@gotgenes/pi-permission-system 3.6.0 → 3.7.0

package/tests/handlers/before-agent-start.test.ts

@@ -0,0 +1,274 @@
+import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+import {
+  handleBeforeAgentStart,
+  shouldExposeTool,
+} from "../../src/handlers/before-agent-start";
+import type { HandlerDeps } from "../../src/handlers/types";
+import type { PermissionManager } from "../../src/permission-manager";
+import type { SkillPromptEntry } from "../../src/skill-prompt-sanitizer";
+
+// ── SDK stubs ──────────────────────────────────────────────────────────────
+vi.mock("@mariozechner/pi-coding-agent", async (importOriginal) => {
+  const original =
+    await importOriginal<typeof import("@mariozechner/pi-coding-agent")>();
+  return {
+    ...original,
+    isToolCallEventType: vi.fn().mockReturnValue(false),
+  };
+});
+
+// ── helpers ────────────────────────────────────────────────────────────────
+
+function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
+  return {
+    cwd: "/test/project",
+    hasUI: true,
+    ui: {
+      setStatus: vi.fn(),
+      notify: vi.fn(),
+      select: vi.fn(),
+      input: vi.fn(),
+    },
+    sessionManager: {
+      getEntries: vi.fn().mockReturnValue([]),
+      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
+      addEntry: vi.fn(),
+    },
+    ...overrides,
+  } as unknown as ExtensionContext;
+}
+
+function makeEvent(systemPrompt = "You are an assistant.") {
+  return { systemPrompt };
+}
+
+/** Minimal PermissionManager stub for shouldExposeTool / policy-cache tests. */
+function makePm(
+  toolPermission: "allow" | "deny" | "ask" = "allow",
+): PermissionManager {
+  return {
+    getToolPermission: vi.fn().mockReturnValue(toolPermission),
+    getPolicyCacheStamp: vi.fn().mockReturnValue("stamp-1"),
+    getConfigIssues: vi.fn().mockReturnValue([]),
+    checkPermission: vi.fn().mockReturnValue({ state: "allow" }),
+  } as unknown as PermissionManager;
+}
+
+function makeDeps(overrides: Partial<HandlerDeps> = {}): HandlerDeps {
+  const pm = makePm();
+  return {
+    getPermissionManager: vi.fn().mockReturnValue(pm),
+    setPermissionManager: vi.fn(),
+    getRuntimeContext: vi.fn().mockReturnValue(null),
+    setRuntimeContext: vi.fn(),
+    getActiveSkillEntries: vi.fn().mockReturnValue([] as SkillPromptEntry[]),
+    setActiveSkillEntries: vi.fn(),
+    getLastKnownActiveAgentName: vi.fn().mockReturnValue(null),
+    setLastKnownActiveAgentName: vi.fn(),
+    getLastActiveToolsCacheKey: vi.fn().mockReturnValue(null),
+    setLastActiveToolsCacheKey: vi.fn(),
+    getLastPromptStateCacheKey: vi.fn().mockReturnValue(null),
+    setLastPromptStateCacheKey: vi.fn(),
+    sessionApprovalCache: {
+      approve: vi.fn(),
+      has: vi.fn(),
+      findMatchingPrefix: vi.fn(),
+      clear: vi.fn(),
+    } as unknown as HandlerDeps["sessionApprovalCache"],
+    createPermissionManagerForCwd: vi.fn().mockReturnValue(makePm()),
+    refreshExtensionConfig: vi.fn(),
+    notifyWarning: vi.fn(),
+    logResolvedConfigPaths: vi.fn(),
+    resolveAgentName: vi.fn().mockReturnValue(null),
+    canRequestPermissionConfirmation: vi.fn().mockReturnValue(false),
+    promptPermission: vi
+      .fn()
+      .mockResolvedValue({ approved: true, state: "approved" }),
+    createPermissionRequestId: vi.fn().mockReturnValue("test-id"),
+    startForwardedPermissionPolling: vi.fn(),
+    stopForwardedPermissionPolling: vi.fn(),
+    writeReviewLog: vi.fn(),
+    writeDebugLog: vi.fn(),
+    getAllTools: vi.fn().mockReturnValue([]),
+    setActiveTools: vi.fn(),
+    ...overrides,
+  };
+}
+
+// ── shouldExposeTool (pure helper) ─────────────────────────────────────────
+
+describe("shouldExposeTool", () => {
+  it("returns true when tool permission is allow", () => {
+    const pm = makePm("allow");
+    expect(shouldExposeTool("read", null, pm)).toBe(true);
+  });
+
+  it("returns true when tool permission is ask", () => {
+    const pm = makePm("ask");
+    expect(shouldExposeTool("bash", "agent-x", pm)).toBe(true);
+  });
+
+  it("returns false when tool permission is deny", () => {
+    const pm = makePm("deny");
+    expect(shouldExposeTool("write", null, pm)).toBe(false);
+  });
+
+  it("passes agentName through to getToolPermission", () => {
+    const pm = makePm("allow");
+    shouldExposeTool("read", "my-agent", pm);
+    expect(pm.getToolPermission).toHaveBeenCalledWith("read", "my-agent");
+  });
+
+  it("converts null agentName to undefined for getToolPermission", () => {
+    const pm = makePm("allow");
+    shouldExposeTool("read", null, pm);
+    expect(pm.getToolPermission).toHaveBeenCalledWith("read", undefined);
+  });
+});
+
+// ── handleBeforeAgentStart ─────────────────────────────────────────────────
+
+describe("handleBeforeAgentStart", () => {
+  it("refreshes extension config with ctx", async () => {
+    const ctx = makeCtx();
+    const deps = makeDeps();
+    await handleBeforeAgentStart(deps, makeEvent(), ctx);
+    expect(deps.refreshExtensionConfig).toHaveBeenCalledWith(ctx);
+  });
+
+  it("starts forwarded permission polling", async () => {
+    const ctx = makeCtx();
+    const deps = makeDeps();
+    await handleBeforeAgentStart(deps, makeEvent(), ctx);
+    expect(deps.startForwardedPermissionPolling).toHaveBeenCalledWith(ctx);
+  });
+
+  it("resolves agent name using systemPrompt", async () => {
+    const ctx = makeCtx();
+    const deps = makeDeps();
+    await handleBeforeAgentStart(
+      deps,
+      makeEvent("<active_agent name='x'>"),
+      ctx,
+    );
+    expect(deps.resolveAgentName).toHaveBeenCalledWith(
+      ctx,
+      "<active_agent name='x'>",
+    );
+  });
+
+  it("filters out denied tools from allowed list", async () => {
+    const pm = makePm("deny");
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue(pm),
+      getAllTools: vi
+        .fn()
+        .mockReturnValue([{ name: "write" }, { name: "read" }]),
+    });
+    // write is deny, read is deny (same pm stub — both denied)
+    await handleBeforeAgentStart(deps, makeEvent(), makeCtx());
+    expect(deps.setActiveTools).toHaveBeenCalledWith([]);
+  });
+
+  it("includes allowed and ask tools in the active list", async () => {
+    const pm = makePm("allow");
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue(pm),
+      getAllTools: vi
+        .fn()
+        .mockReturnValue([{ name: "read" }, { name: "write" }]),
+    });
+    await handleBeforeAgentStart(deps, makeEvent(), makeCtx());
+    expect(deps.setActiveTools).toHaveBeenCalledWith(["read", "write"]);
+  });
+
+  it("updates the active-tools cache key after applying", async () => {
+    const deps = makeDeps({
+      getAllTools: vi.fn().mockReturnValue([{ name: "read" }]),
+      getLastActiveToolsCacheKey: vi.fn().mockReturnValue(null),
+    });
+    await handleBeforeAgentStart(deps, makeEvent(), makeCtx());
+    expect(deps.setLastActiveToolsCacheKey).toHaveBeenCalledOnce();
+  });
+
+  it("skips setActiveTools when cache key is unchanged", async () => {
+    // Pre-populate the cache key to match what would be computed for ["read"]
+    const { createActiveToolsCacheKey } = await import(
+      "../../src/before-agent-start-cache"
+    );
+    const key = createActiveToolsCacheKey(["read"]);
+    const deps = makeDeps({
+      getAllTools: vi.fn().mockReturnValue([{ name: "read" }]),
+      getLastActiveToolsCacheKey: vi.fn().mockReturnValue(key),
+    });
+    await handleBeforeAgentStart(deps, makeEvent(), makeCtx());
+    expect(deps.setActiveTools).not.toHaveBeenCalled();
+  });
+
+  it("updates the prompt-state cache key and returns modified systemPrompt", async () => {
+    // Provide a systemPrompt that sanitizeAvailableToolsSection will modify:
+    // it strips denied tools from the "Available tools:" section.
+    const systemPrompt = `You are an assistant.\n\nAvailable tools:\n- read\n- write\n`;
+    const deps = makeDeps({
+      getAllTools: vi.fn().mockReturnValue([]),
+      getLastPromptStateCacheKey: vi.fn().mockReturnValue(null),
+    });
+    const result = await handleBeforeAgentStart(
+      deps,
+      makeEvent(systemPrompt),
+      makeCtx(),
+    );
+    // The prompt was modified, so systemPrompt should be returned
+    expect(result).toHaveProperty("systemPrompt");
+    expect(deps.setLastPromptStateCacheKey).toHaveBeenCalledOnce();
+  });
+
+  it("returns empty object when systemPrompt is unchanged", async () => {
+    const prompt = "No tools section here.";
+    const deps = makeDeps({
+      getAllTools: vi.fn().mockReturnValue([]),
+      getLastPromptStateCacheKey: vi.fn().mockReturnValue(null),
+    });
+    const result = await handleBeforeAgentStart(
+      deps,
+      makeEvent(prompt),
+      makeCtx(),
+    );
+    expect(result).toEqual({});
+  });
+
+  it("stores resolved skill entries on deps", async () => {
+    const deps = makeDeps({
+      getAllTools: vi.fn().mockReturnValue([]),
+      getLastPromptStateCacheKey: vi.fn().mockReturnValue(null),
+    });
+    await handleBeforeAgentStart(deps, makeEvent(), makeCtx());
+    expect(deps.setActiveSkillEntries).toHaveBeenCalledOnce();
+  });
+
+  it("returns empty object and skips prompt work when prompt cache key is unchanged", async () => {
+    const { createBeforeAgentStartPromptStateKey } = await import(
+      "../../src/before-agent-start-cache"
+    );
+    const pm = makePm("allow");
+    const ctx = makeCtx({ cwd: "/proj" });
+    const allowedTools: string[] = ["read"];
+    const key = createBeforeAgentStartPromptStateKey({
+      agentName: null,
+      cwd: "/proj",
+      permissionStamp: "stamp-1",
+      systemPrompt: "hello",
+      allowedToolNames: allowedTools,
+    });
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue(pm),
+      getAllTools: vi.fn().mockReturnValue([{ name: "read" }]),
+      getLastPromptStateCacheKey: vi.fn().mockReturnValue(key),
+    });
+    const result = await handleBeforeAgentStart(deps, makeEvent("hello"), ctx);
+    expect(result).toEqual({});
+    expect(deps.setActiveSkillEntries).not.toHaveBeenCalled();
+  });
+});

package/tests/handlers/input.test.ts

@@ -0,0 +1,271 @@
+import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { describe, expect, it, vi } from "vitest";
+
+import {
+  extractSkillNameFromInput,
+  handleInput,
+} from "../../src/handlers/input";
+import type { HandlerDeps } from "../../src/handlers/types";
+import type { SkillPromptEntry } from "../../src/skill-prompt-sanitizer";
+
+// ── helpers ────────────────────────────────────────────────────────────────
+
+function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
+  return {
+    cwd: "/test/project",
+    hasUI: true,
+    ui: {
+      setStatus: vi.fn(),
+      notify: vi.fn(),
+      select: vi.fn(),
+      input: vi.fn(),
+    },
+    sessionManager: {
+      getEntries: vi.fn().mockReturnValue([]),
+      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
+      addEntry: vi.fn(),
+    },
+    ...overrides,
+  } as unknown as ExtensionContext;
+}
+
+function makeInputEvent(text: string) {
+  return { text };
+}
+
+function makeDeps(overrides: Partial<HandlerDeps> = {}): HandlerDeps {
+  return {
+    getPermissionManager: vi.fn().mockReturnValue({
+      checkPermission: vi.fn().mockReturnValue({ state: "allow" }),
+      getConfigIssues: vi.fn().mockReturnValue([]),
+    }),
+    setPermissionManager: vi.fn(),
+    getRuntimeContext: vi.fn().mockReturnValue(null),
+    setRuntimeContext: vi.fn(),
+    getActiveSkillEntries: vi.fn().mockReturnValue([] as SkillPromptEntry[]),
+    setActiveSkillEntries: vi.fn(),
+    getLastKnownActiveAgentName: vi.fn().mockReturnValue(null),
+    setLastKnownActiveAgentName: vi.fn(),
+    getLastActiveToolsCacheKey: vi.fn().mockReturnValue(null),
+    setLastActiveToolsCacheKey: vi.fn(),
+    getLastPromptStateCacheKey: vi.fn().mockReturnValue(null),
+    setLastPromptStateCacheKey: vi.fn(),
+    sessionApprovalCache: {
+      approve: vi.fn(),
+      has: vi.fn(),
+      findMatchingPrefix: vi.fn(),
+      clear: vi.fn(),
+    } as unknown as HandlerDeps["sessionApprovalCache"],
+    createPermissionManagerForCwd: vi.fn(),
+    refreshExtensionConfig: vi.fn(),
+    notifyWarning: vi.fn(),
+    logResolvedConfigPaths: vi.fn(),
+    resolveAgentName: vi.fn().mockReturnValue(null),
+    canRequestPermissionConfirmation: vi.fn().mockReturnValue(true),
+    promptPermission: vi
+      .fn()
+      .mockResolvedValue({ approved: true, state: "approved" }),
+    createPermissionRequestId: vi.fn().mockReturnValue("req-id"),
+    startForwardedPermissionPolling: vi.fn(),
+    stopForwardedPermissionPolling: vi.fn(),
+    writeReviewLog: vi.fn(),
+    writeDebugLog: vi.fn(),
+    getAllTools: vi.fn().mockReturnValue([]),
+    setActiveTools: vi.fn(),
+    ...overrides,
+  };
+}
+
+// ── extractSkillNameFromInput ──────────────────────────────────────────────
+
+describe("extractSkillNameFromInput", () => {
+  it("returns null for plain text", () => {
+    expect(extractSkillNameFromInput("hello world")).toBeNull();
+  });
+
+  it("returns null for empty string", () => {
+    expect(extractSkillNameFromInput("")).toBeNull();
+  });
+
+  it("returns null for bare /skill: with no name", () => {
+    expect(extractSkillNameFromInput("/skill:")).toBeNull();
+  });
+
+  it("extracts skill name from /skill:<name>", () => {
+    expect(extractSkillNameFromInput("/skill:librarian")).toBe("librarian");
+  });
+
+  it("extracts skill name stopping at whitespace", () => {
+    expect(extractSkillNameFromInput("/skill:librarian some extra")).toBe(
+      "librarian",
+    );
+  });
+
+  it("trims leading whitespace before the prefix", () => {
+    expect(extractSkillNameFromInput("  /skill:my-skill")).toBe("my-skill");
+  });
+
+  it("returns null when the skill name after trimming is empty", () => {
+    expect(extractSkillNameFromInput("/skill: ")).toBeNull();
+  });
+});
+
+// ── handleInput ───────────────────────────────────────────────────────────
+
+describe("handleInput", () => {
+  it("sets runtime context", async () => {
+    const ctx = makeCtx();
+    const deps = makeDeps();
+    await handleInput(deps, makeInputEvent("hello"), ctx);
+    expect(deps.setRuntimeContext).toHaveBeenCalledWith(ctx);
+  });
+
+  it("starts forwarded permission polling", async () => {
+    const ctx = makeCtx();
+    const deps = makeDeps();
+    await handleInput(deps, makeInputEvent("hello"), ctx);
+    expect(deps.startForwardedPermissionPolling).toHaveBeenCalledWith(ctx);
+  });
+
+  it("returns continue for non-skill input", async () => {
+    const deps = makeDeps();
+    const result = await handleInput(
+      deps,
+      makeInputEvent("just a message"),
+      makeCtx(),
+    );
+    expect(result).toEqual({ action: "continue" });
+  });
+
+  it("does not check permissions for non-skill input", async () => {
+    const deps = makeDeps();
+    await handleInput(deps, makeInputEvent("just a message"), makeCtx());
+    expect(deps.getPermissionManager().checkPermission).not.toHaveBeenCalled();
+  });
+
+  it("returns continue when skill is allowed", async () => {
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "allow" }),
+      }),
+    });
+    const result = await handleInput(
+      deps,
+      makeInputEvent("/skill:librarian"),
+      makeCtx(),
+    );
+    expect(result).toEqual({ action: "continue" });
+  });
+
+  it("returns handled when skill is denied", async () => {
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "deny" }),
+      }),
+    });
+    const result = await handleInput(
+      deps,
+      makeInputEvent("/skill:librarian"),
+      makeCtx(),
+    );
+    expect(result).toEqual({ action: "handled" });
+  });
+
+  it("shows a warning notification when skill is denied and UI is available", async () => {
+    const ctx = makeCtx({ hasUI: true });
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "deny" }),
+      }),
+    });
+    await handleInput(deps, makeInputEvent("/skill:librarian"), ctx);
+    expect(ctx.ui.notify).toHaveBeenCalledWith(
+      expect.stringContaining("librarian"),
+      "warning",
+    );
+  });
+
+  it("does not show a warning notification when skill is denied and UI is absent", async () => {
+    const ctx = makeCtx({ hasUI: false });
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "deny" }),
+      }),
+    });
+    await handleInput(deps, makeInputEvent("/skill:librarian"), ctx);
+    expect(ctx.ui.notify).not.toHaveBeenCalled();
+  });
+
+  it("returns handled when skill requires approval but no UI is available", async () => {
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "ask" }),
+      }),
+      canRequestPermissionConfirmation: vi.fn().mockReturnValue(false),
+    });
+    const result = await handleInput(
+      deps,
+      makeInputEvent("/skill:librarian"),
+      makeCtx(),
+    );
+    expect(result).toEqual({ action: "handled" });
+  });
+
+  it("prompts and returns continue when skill ask is approved", async () => {
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "ask" }),
+      }),
+      canRequestPermissionConfirmation: vi.fn().mockReturnValue(true),
+      promptPermission: vi
+        .fn()
+        .mockResolvedValue({ approved: true, state: "approved" }),
+    });
+    const result = await handleInput(
+      deps,
+      makeInputEvent("/skill:librarian"),
+      makeCtx(),
+    );
+    expect(result).toEqual({ action: "continue" });
+    expect(deps.promptPermission).toHaveBeenCalledOnce();
+  });
+
+  it("returns handled when skill ask is denied by user", async () => {
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "ask" }),
+      }),
+      canRequestPermissionConfirmation: vi.fn().mockReturnValue(true),
+      promptPermission: vi
+        .fn()
+        .mockResolvedValue({ approved: false, state: "denied" }),
+    });
+    const result = await handleInput(
+      deps,
+      makeInputEvent("/skill:librarian"),
+      makeCtx(),
+    );
+    expect(result).toEqual({ action: "handled" });
+  });
+
+  it("passes agentName in the prompt permission request", async () => {
+    const deps = makeDeps({
+      getPermissionManager: vi.fn().mockReturnValue({
+        checkPermission: vi.fn().mockReturnValue({ state: "ask" }),
+      }),
+      resolveAgentName: vi.fn().mockReturnValue("code-agent"),
+      canRequestPermissionConfirmation: vi.fn().mockReturnValue(true),
+      promptPermission: vi
+        .fn()
+        .mockResolvedValue({ approved: true, state: "approved" }),
+    });
+    await handleInput(deps, makeInputEvent("/skill:librarian"), makeCtx());
+    expect(deps.promptPermission).toHaveBeenCalledWith(
+      expect.anything(),
+      expect.objectContaining({
+        agentName: "code-agent",
+        skillName: "librarian",
+      }),
+    );
+  });
+});