@gotgenes/pi-permission-system 3.0.1 → 3.0.3

package/CHANGELOG.md

@@ -5,6 +5,27 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.0.3](https://github.com/gotgenes/pi-permission-system/compare/v3.0.2...v3.0.3) (2026-05-03)
+
+
+### Bug Fixes
+
+* stop findSection at first non-body line instead of EOF ([#33](https://github.com/gotgenes/pi-permission-system/issues/33)) ([15c178e](https://github.com/gotgenes/pi-permission-system/commit/15c178ea1aa42c091885f0aeacd87ba5b298ce24))
+
+
+### Documentation
+
+* plan fix for findSection greedy end boundary ([#33](https://github.com/gotgenes/pi-permission-system/issues/33)) ([72a5f9e](https://github.com/gotgenes/pi-permission-system/commit/72a5f9e4ab14cc9959781994cdc7dc52f1dfa657))
+* **retro:** add retro notes for issue [#35](https://github.com/gotgenes/pi-permission-system/issues/35) ([89830cb](https://github.com/gotgenes/pi-permission-system/commit/89830cb7c562ed092d4f08031584f0e0855326de))
+
+## [3.0.2](https://github.com/gotgenes/pi-permission-system/compare/v3.0.1...v3.0.2) (2026-05-03)
+
+
+### Documentation
+
+* plan align test mock-cleanup and node:* default-export rules ([#35](https://github.com/gotgenes/pi-permission-system/issues/35)) ([480aa02](https://github.com/gotgenes/pi-permission-system/commit/480aa02183009a6693a6699948563345871f198d))
+* **retro:** add retro notes for issue [#21](https://github.com/gotgenes/pi-permission-system/issues/21) ([c7aae09](https://github.com/gotgenes/pi-permission-system/commit/c7aae099a48e58506195d843de797a1ae45b723a))
+
 ## [3.0.1](https://github.com/gotgenes/pi-permission-system/compare/v3.0.0...v3.0.1) (2026-05-03)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "3.0.1",
+  "version": "3.0.3",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "main": "./index.ts",

package/src/system-prompt-sanitizer.ts

@@ -94,6 +94,14 @@ function isTopLevelSectionHeader(line: string): boolean {
   );
 }
 
+function isSectionBodyLine(line: string): boolean {
+  const trimmed = line.trim();
+  if (trimmed.length === 0) return true; // blank line
+  if (trimmed.startsWith("- ")) return true; // bullet
+  if (line !== line.trimStart()) return true; // indented
+  return false;
+}
+
 function findSection(
   lines: readonly string[],
   header: string,
@@ -103,12 +111,25 @@ function findSection(
     return null;
   }
 
-  let end = lines.length;
+  // If a subsequent recognised section header exists, use it as the boundary.
+  // This preserves the original behaviour for the common case where sections
+  // are adjacent (e.g. "Available tools:" followed by "Guidelines:") and
+  // ensures any prose continuation between the two headers is also removed.
   for (let index = start + 1; index < lines.length; index += 1) {
     if (isTopLevelSectionHeader(lines[index])) {
+      return { start, end: index };
+    }
+  }
+
+  // No subsequent section header — stop at the first non-body line so that
+  // content after the section (e.g. custom user notes) is not silently deleted.
+  let end = start + 1;
+  for (let index = start + 1; index < lines.length; index += 1) {
+    if (!isSectionBodyLine(lines[index])) {
       end = index;
       break;
     }
+    end = index + 1;
   }
 
   return { start, end };

package/tests/bash-filter.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, describe, expect, test, vi } from "vitest";
+import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
 
 import type { PermissionState } from "../src/types.js";
 
@@ -20,10 +20,15 @@ import {
   findCompiledWildcardMatch,
 } from "../src/wildcard-matcher.js";
 
+const mockedCompilePatterns = vi.mocked(compileWildcardPatterns);
 const mockedFindMatch = vi.mocked(findCompiledWildcardMatch);
 
+beforeEach(() => {
+  mockedCompilePatterns.mockClear();
+  mockedFindMatch.mockReset();
+});
+
 afterEach(() => {
-  vi.clearAllMocks();
   vi.restoreAllMocks();
 });
 

package/tests/external-directory.test.ts

@@ -2,9 +2,13 @@ import { join } from "node:path";
 import { afterEach, describe, expect, test, vi } from "vitest";
 
 // Mock node:os so tilde-expansion is deterministic across platforms.
-vi.mock("node:os", () => ({
-  homedir: vi.fn(() => "/mock/home"),
-}));
+vi.mock("node:os", () => {
+  const homedir = vi.fn(() => "/mock/home");
+  return {
+    homedir,
+    default: { homedir },
+  };
+});
 
 import {
   formatExternalDirectoryAskPrompt,

package/tests/permission-prompts.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, describe, expect, test, vi } from "vitest";
+import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
 
 // Mock tool-input-preview collaborator before importing the module under test.
 vi.mock("../src/tool-input-preview.js", () => ({
@@ -22,8 +22,11 @@ import type { PermissionCheckResult } from "../src/types.js";
 
 const mockedFormatToolInput = vi.mocked(formatToolInputForPrompt);
 
+beforeEach(() => {
+  mockedFormatToolInput.mockReset();
+});
+
 afterEach(() => {
-  vi.clearAllMocks();
   vi.restoreAllMocks();
 });
 

package/tests/system-prompt-sanitizer.test.ts

@@ -32,7 +32,7 @@ describe("sanitizeAvailableToolsSection — Available tools section", () => {
 
   // Bug #33: findSection extends to lines.length when no subsequent recognised
   // header follows, so content after the last section is silently deleted.
-  test.fails("preserves content that follows the Available tools section (bug #33)", () => {
+  test("preserves content that follows the Available tools section (bug #33)", () => {
     const input = prompt(
       availableToolsSection(["bash", "read"]),
       "Other content",
@@ -184,3 +184,44 @@ describe("sanitizeAvailableToolsSection — multi-section prompt", () => {
     expect(result.prompt).not.toMatch(/\n{3,}/);
   });
 });
+
+describe("sanitizeAvailableToolsSection — findSection boundary edge cases", () => {
+  test("preserves content after Guidelines when Guidelines is the last recognised section", () => {
+    const input = prompt(
+      guidelinesSection(["use bash for file operations like ls, rg, find"]),
+      "Trailing custom instructions",
+    );
+    const result = sanitizeAvailableToolsSection(input, []);
+    expect(result.prompt).toContain("Trailing custom instructions");
+  });
+
+  test("preserves trailing prose when both sections are removed", () => {
+    const input = prompt(
+      availableToolsSection(["bash"]),
+      guidelinesSection(["use bash for file operations like ls, rg, find"]),
+      "Important user note",
+    );
+    const result = sanitizeAvailableToolsSection(input, []);
+    expect(result.removed).toBe(true);
+    expect(result.prompt).not.toContain("Available tools:");
+    expect(result.prompt).not.toContain("Guidelines:");
+    expect(result.prompt).toContain("Important user note");
+  });
+
+  test("section at EOF with no trailing content still works", () => {
+    const input = availableToolsSection(["bash", "read"]);
+    const result = sanitizeAvailableToolsSection(input, ["bash", "read"]);
+    expect(result.removed).toBe(true);
+    expect(result.prompt).toBe("");
+  });
+
+  test("section followed by blank lines then prose — prose survives", () => {
+    const input = ["Available tools:", "- bash", "", "", "Custom note"].join(
+      "\n",
+    );
+    const result = sanitizeAvailableToolsSection(input, ["bash"]);
+    expect(result.removed).toBe(true);
+    expect(result.prompt).toContain("Custom note");
+    expect(result.prompt).not.toContain("Available tools:");
+  });
+});

package/tests/tool-input-preview.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, describe, expect, test, vi } from "vitest";
+import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
 
 // Mock logging collaborator before importing the module under test.
 vi.mock("../src/logging.js", () => ({
@@ -29,8 +29,11 @@ import type { PermissionCheckResult } from "../src/types.js";
 
 const mockedStringify = vi.mocked(safeJsonStringify);
 
+beforeEach(() => {
+  mockedStringify.mockReset();
+});
+
 afterEach(() => {
-  vi.clearAllMocks();
   vi.restoreAllMocks();
 });