@gotgenes/pi-permission-system 25.1.0 → 25.2.0

package/CHANGELOG.md

@@ -5,6 +5,23 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [25.2.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v25.1.0...pi-permission-system-v25.2.0) (2026-08-14)
+
+
+### Features
+
+* **pi-permission-system:** record which chain links were consulted on each ask ([8bb52ff](https://github.com/gotgenes/pi-packages/commit/8bb52ffe26cfb0c995e8299ebe737a09f1717c57)), closes [#727](https://github.com/gotgenes/pi-packages/issues/727)
+
+
+### Bug Fixes
+
+* **pi-permission-system:** stop reporting a delegated subagent chain as unregistered links ([2a1c082](https://github.com/gotgenes/pi-packages/commit/2a1c08292131e9f7dd71adeac380a997ccc0069a)), closes [#727](https://github.com/gotgenes/pi-packages/issues/727)
+
+
+### Documentation
+
+* **pi-permission-system:** document one-chain-per-node adjudication semantics ([c36980a](https://github.com/gotgenes/pi-packages/commit/c36980ae2cf6d1b115b4b3f20e9513dac61c3d1b)), closes [#727](https://github.com/gotgenes/pi-packages/issues/727)
+
 ## [25.1.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v25.0.0...pi-permission-system-v25.1.0) (2026-08-13)
 
 

package/README.md

@@ -116,6 +116,7 @@ The optional `shellTools` field records which non-`bash` tools carry shell seman
 
 The optional `authorizerChain` field names registered case-by-case decision links (e.g. a light model judge) to consult when a request lands on `ask`, ahead of the interactive prompt.
 A downstream extension registers a link via `getPermissionsService().registerAuthorizer(name, authorize)`; it decides nothing until you name it here (opt-in), config order fixes the chain order, and the chain owner caps any link's `allow` on `external_directory`/`path` to keep it within your policy — see [docs/configuration.md](docs/configuration.md#authorizer-chain--case-by-case-decision-links).
+A subagent's ask is reviewed by the chain of the session serving it, one hop up, rather than inside the subagent — see the same section.
 [`@gotgenes/pi-permission-model-judge`](https://github.com/gotgenes/pi-packages/tree/main/packages/pi-permission-model-judge) is a first-party reference implementation of such a link — a deny-first reviewer that auto-denies mistyped out-of-directory paths.
 
 For the full reference — all surfaces, runtime knobs, per-agent overrides, merge semantics, and common recipes — see [docs/configuration.md](docs/configuration.md).

package/docs/configuration.md

@@ -215,6 +215,18 @@ The excluded surface is the **gate** surface the rule fired on, not the tool nam
 This holds for an ask forwarded up from a subagent exactly as it does for a local one.
 See [migration/0635-forwarded-ask-delegation-envelope.md](migration/0635-forwarded-ask-delegation-envelope.md).
 
+When a **subagent** raises the ask, the chain runs one hop up.
+The subagent forwards the request to the session serving it, and that session resolves it against its own rules and then runs *its* chain over the same evidence — so your configured links do review a subagent's asks, in the session you are watching.
+The subagent itself resolves no links (an extension cannot register one in a child session at all), and records `authorizer_chain_delegated` in the review log to say so.
+
+Three review-log records make the chain observable, all keyed by the ask's `requestId`:
+
+| Record                               | Meaning                                                                                                  |
+| ------------------------------------ | -------------------------------------------------------------------------------------------------------- |
+| `authorizer_chain_resolved`          | the links consulted on this ask, recorded before they run — a link that defers otherwise leaves no trace |
+| `authorizer_chain_delegated`         | the ask came from a relaying subagent node; the named links were deliberately not run here               |
+| `authorizer_chain_unregistered_link` | a configured name had no registered link — a real misconfiguration; the ask still reaches the terminal   |
+
 Extension authors: register a link from a `permissions:ready` handler via `getPermissionsService().registerAuthorizer(name, authorize)`; the callback receives the ask details and a narrow, session-scoped `PermissionQuery` (`checkPermission` / `getToolPermission`) so it can consult the deterministic engine at gate parity.
 Registration returns a disposer, and only one link may hold a given name.
 For a complete working example, see [`@gotgenes/pi-permission-model-judge`](https://github.com/gotgenes/pi-packages/tree/main/packages/pi-permission-model-judge): it registers a `model-judge` link on `permissions:ready` that reviews `external_directory` asks and auto-denies mistyped paths with a corrective reason.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "25.1.0",
+  "version": "25.2.0",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "exports": {

package/src/authority/authorizer-selection.ts

@@ -4,8 +4,8 @@ import type { PermissionQuery } from "#src/service";
 import {
   type Authorizer,
   type AuthorizerSelectionDeps,
+  type SelectedAuthority,
   selectAuthorizer,
-  type TerminalAuthorizer,
 } from "./authorizer";
 import { composeAuthorizerChain } from "./authorizer-chain";
 import type { AuthorizerLookup } from "./authorizer-registry";
@@ -54,7 +54,7 @@ export interface AskEscalator {
 export class AuthorizerSelection
   implements AskEscalator, AuthorizerSelectionLifecycle
 {
-  private terminal: TerminalAuthorizer | null = null;
+  private authority: SelectedAuthority | null = null;
 
   constructor(
     private readonly deps: AuthorizerSelectionDeps & {
@@ -69,13 +69,43 @@ export class AuthorizerSelection
   ) {}
 
   /**
-   * Select the terminal Authorizer for `ctx` and store it. The non-terminal
+   * Select the live authority for `ctx` and store it. The non-terminal
    * chain is composed per ask in {@link escalate}, not here: ADR 0007 §4 lets a
    * link register in a `permissions:ready` handler that may fire after
    * activation, so link resolution is deferred to the session's first ask.
    */
   activate(ctx: ExtensionContext): void {
-    this.terminal = selectAuthorizer(ctx, this.deps);
+    this.authority = selectAuthorizer(ctx, this.deps);
+  }
+
+  /**
+   * The chain links for this ask.
+   *
+   * A node that adjudicates locally resolves its configured names; a relaying
+   * node resolves none. Its terminal hands the ask to a serving node, which
+   * resolves the request against its own recorded authority and escalates it
+   * through *its* chain over the same child-fixed facts (#635) — so running
+   * links here would adjudicate one ask twice, and a relaying node cannot host
+   * a link in the first place (#699). The delegation is recorded rather than
+   * reported as a fail-safe skip: an absent link is the design here, not the
+   * misconfiguration `authorizer_chain_unregistered_link` exists to surface.
+   */
+  private linksFor(
+    authority: SelectedAuthority,
+    requestId: string,
+  ): Authorizer[] {
+    const configured = this.deps.getAuthorizerChain();
+    if (configured.length === 0) {
+      return [];
+    }
+    if (!authority.adjudicatesLocally) {
+      this.deps.logger.review("authorizer_chain_delegated", {
+        requestId,
+        links: configured,
+      });
+      return [];
+    }
+    return this.resolveConfiguredLinks(configured, requestId);
   }
 
   /**
@@ -84,32 +114,52 @@ export class AuthorizerSelection
    * warning (invariant 2 — more prompting, never less); each resolved link is
    * wrapped in the bounded-delegation envelope so an `allow` on an excluded
    * surface cannot exceed the operator's policy.
+   *
+   * The resolved names are recorded against the ask before any link runs — a
+   * link that defers decides nothing and would otherwise leave no evidence it
+   * was consulted at all, which is what makes "the judge never ran" and "the
+   * judge ran and deferred" indistinguishable in the review log.
    */
-  private resolveConfiguredLinks(): Authorizer[] {
+  private resolveConfiguredLinks(
+    configured: readonly string[],
+    requestId: string,
+  ): Authorizer[] {
     const links: Authorizer[] = [];
-    for (const name of this.deps.getAuthorizerChain()) {
+    const resolved: string[] = [];
+    for (const name of configured) {
       const authorize = this.deps.authorizerRegistry.get(name);
       if (authorize === undefined) {
-        this.deps.logger.review("authorizer_chain_unregistered_link", { name });
+        this.deps.logger.review("authorizer_chain_unregistered_link", {
+          requestId,
+          name,
+        });
         continue;
       }
+      resolved.push(name);
       links.push({ authorize: encloseInDelegationEnvelope(authorize) });
     }
+    if (resolved.length > 0) {
+      this.deps.logger.review("authorizer_chain_resolved", {
+        requestId,
+        links: resolved,
+      });
+    }
     return links;
   }
 
   /** Clear the stored selection. */
   deactivate(): void {
-    this.terminal = null;
+    this.authority = null;
   }
 
   /**
    * Escalate an ask through the composed chain and return its decision.
    *
-   * Resolves the configured links freshly (so a link registered any time before
+   * Resolves this ask's links freshly (so a link registered any time before
    * this first ask is honored) and composes them ahead of the selected
-   * terminal. With zero links the composed value **is** the terminal instance,
-   * so behavior is identical to a bare terminal escalation.
+   * terminal. With zero links — no chain configured, or a relaying node that
+   * delegates adjudication to the serving node — the composed value **is** the
+   * terminal instance, so behavior is identical to a bare terminal escalation.
    *
    * Rejects if no terminal has been selected — i.e. before the session was
    * activated. Implements {@link AskEscalator}.
@@ -117,14 +167,15 @@ export class AuthorizerSelection
   escalate(
     details: PromptPermissionDetails,
   ): Promise<PermissionPromptDecision> {
-    if (this.terminal === null) {
+    const authority = this.authority;
+    if (authority === null) {
       return Promise.reject(
         new Error("escalate called before the session was activated"),
       );
     }
     const chain = composeAuthorizerChain(
-      this.resolveConfiguredLinks(),
-      this.terminal,
+      this.linksFor(authority, details.requestId),
+      authority.terminal,
       this.deps.getPermissionQuery(),
       this.deps.logger,
     );

package/src/authority/authorizer.ts

@@ -59,6 +59,28 @@ export interface TerminalAuthorizer {
   ): Promise<PermissionPromptDecision>;
 }
 
+/**
+ * The node's live-authority selection: who decides this node's asks, and
+ * whether this node adjudicates them with its own chain.
+ *
+ * The chain role is the selection's product, not a discriminator a consumer
+ * re-derives: `selectAuthorizer` tests `hasUI` before `isSubagent`, so a
+ * subagent that has its own UI decides locally, and re-deriving the role from
+ * `detection.isSubagent(ctx)` alone would get that case wrong.
+ */
+export interface SelectedAuthority {
+  /** The terminal that decides this node's asks, or relays them upward. */
+  readonly terminal: TerminalAuthorizer;
+  /**
+   * False when the terminal relays the ask to a serving node
+   * (`ParentAuthorizer`): that node resolves the request against its own
+   * recorded authority and escalates it through *its* chain over the same
+   * child-fixed facts (#635), so resolving links here would adjudicate one ask
+   * twice.
+   */
+  readonly adjudicatesLocally: boolean;
+}
+
 /** Construction inputs for {@link selectAuthorizer}. */
 export interface AuthorizerSelectionDeps {
   /** Single owner of subagent detection; the ParentAuthorizer-selection predicate. */
@@ -81,8 +103,9 @@ export interface AuthorizerSelectionDeps {
 }
 
 /**
- * Select the `Authorizer` for the current context: the single owner of the
- * three-way `hasUI` / `isSubagent` / deny dispatch.
+ * Select the live authority for the current context: the single owner of the
+ * three-way `hasUI` / `isSubagent` / deny dispatch, and of the chain role that
+ * dispatch implies.
  *
  * Evaluated once per session activation (`AuthorizerSelection.activate`),
  * replacing the re-derivation of the same predicates across
@@ -91,24 +114,30 @@ export interface AuthorizerSelectionDeps {
 export function selectAuthorizer(
   ctx: ExtensionContext,
   deps: AuthorizerSelectionDeps,
-): TerminalAuthorizer {
+): SelectedAuthority {
   if (ctx.hasUI) {
-    return new LocalUserAuthorizer({
-      ui: ctx.ui,
-      mode: ctx.mode,
-      events: deps.events,
-      getPromptPreferences: deps.getPromptPreferences,
-      requestPermissionDecision: deps.requestPermissionDecision,
-    });
+    return {
+      terminal: new LocalUserAuthorizer({
+        ui: ctx.ui,
+        mode: ctx.mode,
+        events: deps.events,
+        getPromptPreferences: deps.getPromptPreferences,
+        requestPermissionDecision: deps.requestPermissionDecision,
+      }),
+      adjudicatesLocally: true,
+    };
   }
   if (deps.detection.isSubagent(ctx)) {
-    return new ParentAuthorizer(ctx, {
-      forwardingDir: deps.forwardingDir,
-      registry: deps.registry,
-      serving: deps.servingRegistry,
-      getTimeoutMs: deps.getForwardingTimeoutMs,
-      logger: deps.logger,
-    });
+    return {
+      terminal: new ParentAuthorizer(ctx, {
+        forwardingDir: deps.forwardingDir,
+        registry: deps.registry,
+        serving: deps.servingRegistry,
+        getTimeoutMs: deps.getForwardingTimeoutMs,
+        logger: deps.logger,
+      }),
+      adjudicatesLocally: false,
+    };
   }
-  return new DenyingAuthorizer();
+  return { terminal: new DenyingAuthorizer(), adjudicatesLocally: true };
 }