@gotgenes/pi-permission-system 19.0.1 → 20.1.0

package/src/permission-manager.ts

@@ -34,7 +34,7 @@ import type {
   PermissionCheckResult,
   PermissionState,
 } from "./types";
-import { isPermissionState } from "./value-guards";
+import { isPermissionState } from "./types";
 import { wildcardMatch } from "./wildcard-matcher";
 
 const BUILT_IN_TOOL_PERMISSION_NAMES = new Set([

package/src/permission-session.ts

@@ -3,7 +3,7 @@ import {
   getActiveAgentName,
   getActiveAgentNameFromSystemPrompt,
 } from "./active-agent";
-
+import type { AuthorizerSelectionLifecycle } from "./authority/authorizer-selection";
 import type { SessionConfigStore } from "./config-store";
 import type { PermissionSystemExtensionConfig } from "./extension-config";
 import type { ExtensionPaths } from "./extension-paths";
@@ -11,7 +11,6 @@ import type { ForwardingController } from "./forwarding-manager";
 import type { ToolCallGateInputs } from "./handlers/gates/tool-call-gate-pipeline";
 import { PathNormalizer } from "./path-normalizer";
 import type { ScopedPermissionManager } from "./permission-manager";
-import type { PromptingGatewayLifecycle } from "./prompting-gateway";
 
 import type { SessionRules } from "./session-rules";
 import type { SkillPromptEntry } from "./skill-prompt-sanitizer";
@@ -33,7 +32,7 @@ import type { PathRuleTokenMatcher } from "./types";
  * - `ExtensionPaths` — immutable path constants
  * - `ForwardingController` — polling lifecycle
  * - `SessionConfigStore` — owns extension config; provides refresh, log, read
- * - `PromptingGatewayLifecycle` — prompting lifecycle forwarded via activate/deactivate
+ * - `AuthorizerSelectionLifecycle` — authorizer-selection lifecycle forwarded via activate/deactivate
  */
 export class PermissionSession implements ToolCallGateInputs {
   private context: ExtensionContext | null = null;
@@ -47,7 +46,7 @@ export class PermissionSession implements ToolCallGateInputs {
     private readonly permissionManager: ScopedPermissionManager,
     private readonly sessionRules: SessionRules,
     private readonly configStore: SessionConfigStore,
-    private readonly gateway: PromptingGatewayLifecycle,
+    private readonly authorizerSelection: AuthorizerSelectionLifecycle,
     private readonly platform: NodeJS.Platform,
   ) {
     // Placeholder until the first activate(ctx) binds the real cwd; every gate
@@ -71,14 +70,14 @@ export class PermissionSession implements ToolCallGateInputs {
     this.context = ctx;
     this.pathNormalizer = new PathNormalizer(this.platform, ctx.cwd);
     this.forwarding.start(ctx);
-    this.gateway.activate(ctx);
+    this.authorizerSelection.activate(ctx);
   }
 
-  /** Clear the context, stop forwarding, and deactivate the gateway. */
+  /** Clear the context, stop forwarding, and deactivate the authorizer selection. */
   deactivate(): void {
     this.context = null;
     this.forwarding.stop();
-    this.gateway.deactivate();
+    this.authorizerSelection.deactivate();
   }
 
   /** Return the current runtime context, or null if not activated. */

package/src/permission-ui-prompt.ts

@@ -7,7 +7,7 @@
  *
  * This module is a leaf: it owns narrow input types that each call site's
  * domain object satisfies structurally, so it imports nothing from the
- * prompter, RPC, or forwarding modules (no import cycles, correct layering).
+ * prompter or forwarding modules (no import cycles, correct layering).
  */
 
 import type {
@@ -28,15 +28,6 @@ export interface DirectPromptInput {
   target?: string;
 }
 
-/** Input for a `permissions:rpc:prompt` forwarded UI prompt. */
-export interface RpcPromptInput {
-  requestId: string;
-  surface?: string | null;
-  value?: string | null;
-  agentName?: string | null;
-  message: string;
-}
-
 /** Input for a file-forwarded subagent prompt shown by the parent UI. */
 export interface ForwardedPromptInput {
   requestId: string;
@@ -86,21 +77,6 @@ export function buildDirectUiPrompt(
   };
 }
 
-/** Build the UI prompt event for an RPC-forwarded prompt. */
-export function buildRpcUiPrompt(
-  input: RpcPromptInput,
-): PermissionUiPromptEvent {
-  return {
-    requestId: input.requestId,
-    source: "rpc_prompt",
-    surface: input.surface ?? null,
-    value: input.value ?? null,
-    agentName: input.agentName ?? null,
-    message: input.message,
-    forwarding: null,
-  };
-}
-
 /**
  * Build the UI prompt event for a file-forwarded subagent prompt.
  *

package/src/service.ts

@@ -18,18 +18,13 @@ import type { PermissionCheckResult, PermissionState } from "./types";
 export type {
   ForwardedPromptContext,
   PermissionDecisionEvent,
-  PermissionsPromptReplyData,
-  PermissionsPromptRequest,
   PermissionsReadyEvent,
-  PermissionsRpcReply,
   PermissionUiPromptEvent,
   PermissionUiPromptSource,
 } from "./permission-events";
 export {
   PERMISSIONS_DECISION_CHANNEL,
-  PERMISSIONS_PROTOCOL_VERSION,
   PERMISSIONS_READY_CHANNEL,
-  PERMISSIONS_RPC_PROMPT_CHANNEL,
   PERMISSIONS_UI_PROMPT_CHANNEL,
 } from "./permission-events";
 export type { PermissionCheckResult, PermissionState, ToolInputFormatter };
@@ -40,9 +35,9 @@ const SERVICE_KEY = Symbol.for("@gotgenes/pi-permission-system:service");
 /**
  * Public interface exposed to other extensions via `getPermissionsService()`.
  *
- * Mirrors the simplified RPC signature — surface + optional value + optional
- * agent name — and delegates to `PermissionManager.checkPermission()` with
- * current session rules internally.
+ * `checkPermission` takes a surface + optional value + optional agent name,
+ * and delegates to `PermissionManager.checkPermission()` with current session
+ * rules internally.
  */
 export interface PermissionsService {
   /**

package/src/session-logger.ts

@@ -19,7 +19,7 @@ export interface ReviewLogger {
 
 /**
  * Logging seam for consumers that write both debug and review entries.
- * Injected into `ConfigStore`, `ApprovalEscalator`, and `ForwardedRequestServer`.
+ * Injected into `ConfigStore`, `ParentAuthorizer`, and `ForwardedRequestServer`.
  */
 export interface DebugReviewLogger extends ReviewLogger {
   debug(event: string, details?: Record<string, unknown>): void;

package/src/types.ts

@@ -63,3 +63,23 @@ export interface PermissionCheckResult {
    */
   commandContext?: BashCommandContext;
 }
+
+export function isPermissionState(value: unknown): value is PermissionState {
+  return value === "allow" || value === "deny" || value === "ask";
+}
+
+/**
+ * Narrow type guard: a raw value representing a DenyWithReason object.
+ * Accepts `{ action: "deny" }` and `{ action: "deny", reason: "…" }`.
+ * Rejects a non-string `reason` to keep malformed config out of the rule set.
+ */
+export function isDenyWithReason(value: unknown): value is DenyWithReason {
+  if (typeof value !== "object" || value === null || Array.isArray(value)) {
+    return false;
+  }
+  const record = value as Record<string, unknown>;
+  return (
+    record.action === "deny" &&
+    (record.reason === undefined || typeof record.reason === "string")
+  );
+}

package/src/value-guards.ts

@@ -1,5 +1,3 @@
-import type { DenyWithReason, PermissionState } from "./types";
-
 export function toRecord(value: unknown): Record<string, unknown> {
   if (!value || typeof value !== "object" || Array.isArray(value)) {
     return {};
@@ -16,23 +14,3 @@ export function getNonEmptyString(value: unknown): string | null {
   const trimmed = value.trim();
   return trimmed.length > 0 ? trimmed : null;
 }
-
-export function isPermissionState(value: unknown): value is PermissionState {
-  return value === "allow" || value === "deny" || value === "ask";
-}
-
-/**
- * Narrow type guard: a raw value representing a DenyWithReason object.
- * Accepts `{ action: "deny" }` and `{ action: "deny", reason: "…" }`.
- * Rejects a non-string `reason` to keep malformed config out of the rule set.
- */
-export function isDenyWithReason(value: unknown): value is DenyWithReason {
-  if (typeof value !== "object" || value === null || Array.isArray(value)) {
-    return false;
-  }
-  const record = value as Record<string, unknown>;
-  return (
-    record.action === "deny" &&
-    (record.reason === undefined || typeof record.reason === "string")
-  );
-}

package/src/permission-event-rpc.ts

@@ -1,227 +0,0 @@
-/* eslint-disable @typescript-eslint/no-deprecated -- this module implements the deprecated event-bus RPC channel; references to its own deprecated symbols are intentional */
-/**
- * Permission event bus RPC handlers.
- *
- * Registers `permissions:rpc:check` and `permissions:rpc:prompt` handlers on
- * the Pi event bus so other extensions can query our policy and forward
- * permission prompts without importing this package.
- */
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { buildAccessIntentForSurface } from "./input-normalizer";
-import type { PathNormalizer } from "./path-normalizer";
-import type {
-  PermissionPromptDecision,
-  RequestPermissionOptions,
-} from "./permission-dialog";
-import type {
-  PermissionEventBus,
-  PermissionsCheckReplyData,
-  PermissionsCheckRequest,
-  PermissionsPromptReplyData,
-  PermissionsPromptRequest,
-  PermissionsRpcReply,
-} from "./permission-events";
-import {
-  emitUiPromptEvent,
-  PERMISSIONS_PROTOCOL_VERSION,
-  PERMISSIONS_RPC_CHECK_CHANNEL,
-  PERMISSIONS_RPC_PROMPT_CHANNEL,
-} from "./permission-events";
-import type { ScopedPermissionResolver } from "./permission-resolver";
-import { buildRpcUiPrompt } from "./permission-ui-prompt";
-import type { ReviewLogger } from "./session-logger";
-
-/** Dependencies injected into the RPC handler registry. */
-export interface PermissionRpcDeps {
-  /**
-   * The shared resolver: answers an access intent, composing the session
-   * ruleset and unwrapping `access-path` → `path-values` internally so the
-   * RPC check matches the same lexical ∪ canonical set the gates do (#503).
-   */
-  resolver: Pick<ScopedPermissionResolver, "resolve">;
-  /**
-   * Narrow session view: runtime context for the prompt handler (hasUI / UI
-   * dialog) and the cwd-bound path normalizer for path-surface check queries.
-   */
-  session: {
-    getRuntimeContext(): ExtensionContext | null;
-    getPathNormalizer(): PathNormalizer;
-  };
-  /** Show the interactive permission dialog in the parent session UI. */
-  requestPermissionDecisionFromUi(
-    ui: ExtensionContext["ui"],
-    title: string,
-    message: string,
-    options?: RequestPermissionOptions,
-  ): Promise<PermissionPromptDecision>;
-  /** Write review-log entries for prompted decisions. */
-  logger: ReviewLogger;
-}
-
-/** Unsubscribe handles returned from registerPermissionRpcHandlers. */
-export interface PermissionRpcHandles {
-  /** Stop the permissions:rpc:check handler. */
-  unsubCheck: () => void;
-  /** Stop the permissions:rpc:prompt handler. */
-  unsubPrompt: () => void;
-}
-
-// ── Internal helpers ───────────────────────────────────────────────────────
-
-/** Build a success reply envelope. */
-function successReply<T>(data?: T): PermissionsRpcReply<T> {
-  if (data !== undefined) {
-    return {
-      success: true,
-      protocolVersion: PERMISSIONS_PROTOCOL_VERSION,
-      data,
-    };
-  }
-  return { success: true, protocolVersion: PERMISSIONS_PROTOCOL_VERSION };
-}
-
-/** Build an error reply envelope. */
-function errorReply(error: string): PermissionsRpcReply {
-  return {
-    success: false,
-    protocolVersion: PERMISSIONS_PROTOCOL_VERSION,
-    error,
-  };
-}
-
-// ── RPC handler: permissions:rpc:check ────────────────────────────────────
-
-function handleCheckRpc(
-  raw: unknown,
-  events: PermissionEventBus,
-  deps: PermissionRpcDeps,
-): void {
-  const req = raw as Partial<PermissionsCheckRequest>;
-  const { requestId, surface, value, agentName } = req;
-
-  if (typeof requestId !== "string" || !requestId) {
-    // Cannot reply without a requestId — silently discard.
-    return;
-  }
-
-  const replyChannel = `${PERMISSIONS_RPC_CHECK_CHANNEL}:reply:${requestId}`;
-
-  try {
-    if (typeof surface !== "string" || !surface) {
-      events.emit(replyChannel, errorReply("surface is required"));
-      return;
-    }
-
-    const intent = buildAccessIntentForSurface(
-      surface,
-      value,
-      deps.session.getPathNormalizer(),
-      agentName ?? undefined,
-    );
-    const result = deps.resolver.resolve(intent);
-
-    const data: PermissionsCheckReplyData = {
-      result: result.state,
-      matchedPattern: result.matchedPattern ?? null,
-      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- ?? null normalises undefined to null for the reply record
-      origin: result.origin ?? null,
-    };
-    events.emit(replyChannel, successReply(data));
-  } catch (err) {
-    const message = err instanceof Error ? err.message : String(err);
-    events.emit(replyChannel, errorReply(message));
-  }
-}
-
-// ── RPC handler: permissions:rpc:prompt ───────────────────────────────────
-
-async function handlePromptRpc(
-  raw: unknown,
-  events: PermissionEventBus,
-  deps: PermissionRpcDeps,
-): Promise<void> {
-  const req = raw as Partial<PermissionsPromptRequest>;
-  const { requestId, surface, value, agentName, message, sessionLabel } = req;
-
-  if (typeof requestId !== "string" || !requestId) {
-    return;
-  }
-
-  const replyChannel = `${PERMISSIONS_RPC_PROMPT_CHANNEL}:reply:${requestId}`;
-
-  const ctx = deps.session.getRuntimeContext();
-  if (!ctx?.hasUI) {
-    events.emit(replyChannel, errorReply("no_ui"));
-    return;
-  }
-
-  if (typeof message !== "string" || !message) {
-    events.emit(replyChannel, errorReply("message is required"));
-    return;
-  }
-
-  try {
-    const title = surface
-      ? `Permission request${agentName ? ` from ${agentName}` : ""}`
-      : "Permission request";
-
-    emitUiPromptEvent(
-      events,
-      buildRpcUiPrompt({ requestId, surface, value, agentName, message }),
-    );
-
-    const decision = await deps.requestPermissionDecisionFromUi(
-      ctx.ui,
-      title,
-      message,
-      sessionLabel ? { sessionLabel } : undefined,
-    );
-
-    deps.logger.review("permission_request.rpc_prompt", {
-      requestId,
-      surface: surface ?? null,
-      value: value ?? null,
-      agentName: agentName ?? null,
-      message,
-      approved: decision.approved,
-      resolution: decision.state,
-      denialReason: decision.denialReason ?? null,
-    });
-
-    const data: PermissionsPromptReplyData = {
-      approved: decision.approved,
-      state: decision.state,
-      ...(decision.denialReason !== undefined
-        ? { denialReason: decision.denialReason }
-        : {}),
-    };
-    events.emit(replyChannel, successReply(data));
-  } catch (err) {
-    const message_ = err instanceof Error ? err.message : String(err);
-    events.emit(replyChannel, errorReply(message_));
-  }
-}
-
-// ── Public API ─────────────────────────────────────────────────────────────
-
-/**
- * Register `permissions:rpc:check` and `permissions:rpc:prompt` handlers on
- * the event bus.
- *
- * Returns unsubscribe handles — call them in session_shutdown to stop the
- * handlers and prevent memory leaks.
- */
-export function registerPermissionRpcHandlers(
-  events: PermissionEventBus,
-  deps: PermissionRpcDeps,
-): PermissionRpcHandles {
-  const unsubCheck = events.on(PERMISSIONS_RPC_CHECK_CHANNEL, (raw) => {
-    handleCheckRpc(raw, events, deps);
-  });
-
-  const unsubPrompt = events.on(PERMISSIONS_RPC_PROMPT_CHANNEL, (raw) => {
-    void handlePromptRpc(raw, events, deps);
-  });
-
-  return { unsubCheck, unsubPrompt };
-}

package/src/prompting-gateway.ts

@@ -1,89 +0,0 @@
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import type { SubagentDetector } from "./authority/subagent-detection";
-import type { GatePrompter } from "./gate-prompter";
-import type { PermissionPromptDecision } from "./permission-dialog";
-import type {
-  PermissionPrompterApi,
-  PromptPermissionDetails,
-} from "./permission-prompter";
-
-/**
- * Dependencies required by PromptingGateway.
- *
- * All fields are actively consumed:
- * - `detection` drives `canConfirm()`.
- * - `prompter` is called by `prompt()`.
- */
-export interface PromptingGatewayDeps {
-  /** Single owner of subagent detection; drives `canConfirm()`. */
-  detection: SubagentDetector;
-  /** Resolves the permission decision: direct UI dialog or forwarded to parent. */
-  prompter: PermissionPrompterApi;
-}
-
-/**
- * The lifecycle slice of the gateway that PermissionSession drives.
- *
- * PermissionSession calls activate/deactivate to keep the gateway's stored
- * context in sync with its own — the same pattern used for ForwardingController.
- */
-export interface PromptingGatewayLifecycle {
-  activate(ctx: ExtensionContext): void;
-  deactivate(): void;
-}
-
-/**
- * Context-owning implementation of the GatePrompter role.
- *
- * Owns the stored ExtensionContext and the "can we prompt?" policy
- * (UI / subagent), replacing the four twin methods that previously
- * lived on PermissionSession.
- *
- * Lifecycle: PermissionSession drives activate/deactivate so the stored
- * context mirrors the session context without independent call-site changes.
- */
-export class PromptingGateway
-  implements GatePrompter, PromptingGatewayLifecycle
-{
-  private context: ExtensionContext | null = null;
-
-  constructor(private readonly deps: PromptingGatewayDeps) {}
-
-  /** Store the current extension context. */
-  activate(ctx: ExtensionContext): void {
-    this.context = ctx;
-  }
-
-  /** Clear the stored context. */
-  deactivate(): void {
-    this.context = null;
-  }
-
-  /**
-   * Whether an interactive permission prompt can be shown.
-   *
-   * Returns false when no context is active. Otherwise true when the
-   * context has UI or is a forwarding subagent — the two Authorizer-
-   * selection predicates the Phase 9 spine will consume. Yolo-mode never
-   * reaches this policy: it is resolved upstream at the composition stage.
-   */
-  canConfirm(): boolean {
-    if (this.context === null) return false;
-    return this.context.hasUI || this.deps.detection.isSubagent(this.context);
-  }
-
-  /**
-   * Prompt the user for a permission decision using the stored context.
-   *
-   * Rejects if no context is active — canConfirm() guards this in normal use.
-   * Implements {@link GatePrompter}.
-   */
-  prompt(details: PromptPermissionDetails): Promise<PermissionPromptDecision> {
-    if (this.context === null) {
-      return Promise.reject(
-        new Error("prompt called before the session was activated"),
-      );
-    }
-    return this.deps.prompter.prompt(this.context, details);
-  }
-}