@gotgenes/pi-permission-system 18.2.0 → 19.0.1

package/src/{forwarded-permissions/permission-forwarder.ts → authority/approval-escalator.ts}

@@ -3,86 +3,53 @@ import { join } from "node:path";
 import {
   getActiveAgentName,
   getActiveAgentNameFromSystemPrompt,
-  type SessionEntryView,
 } from "#src/active-agent";
-import type { ConfigReader } from "#src/config-store";
-import { isYoloModeEnabled } from "#src/extension-config";
+import {
+  type ForwarderContext,
+  getSessionId,
+} from "#src/authority/forwarder-context";
+import {
+  cleanupPermissionForwardingLocationIfEmpty,
+  ensurePermissionForwardingLocation,
+  logPermissionForwardingError,
+  logPermissionForwardingWarning,
+  readForwardedPermissionResponse,
+  safeDeleteFile,
+  sleep,
+  writeJsonFileAtomic,
+} from "#src/authority/forwarding-io";
+import type { SubagentDetector } from "#src/authority/subagent-detection";
 import type {
   PermissionDecisionUi,
   PermissionPromptDecision,
   RequestPermissionOptions,
 } from "#src/permission-dialog";
-import {
-  emitUiPromptEvent,
-  type PermissionEventBus,
-} from "#src/permission-events";
 import {
   type ForwardedPermissionRequest,
-  type ForwardedPermissionResponse,
   type ForwardedPromptDisplay,
-  isForwardedPermissionRequestForSession,
   PERMISSION_FORWARDING_POLL_INTERVAL_MS,
   PERMISSION_FORWARDING_TIMEOUT_MS,
   type PermissionForwardingLocation,
   resolvePermissionForwardingTargetSessionId,
   SUBAGENT_PARENT_SESSION_ENV_CANDIDATES,
 } from "#src/permission-forwarding";
-import { buildForwardedUiPrompt } from "#src/permission-ui-prompt";
 import type { DebugReviewLogger } from "#src/session-logger";
-import { isSubagentExecutionContext } from "#src/subagent-context";
 import type { SubagentSessionRegistry } from "#src/subagent-registry";
 import { toRecord } from "#src/value-guards";
 
-import {
-  cleanupPermissionForwardingLocationIfEmpty,
-  ensureDirectoryExists,
-  ensurePermissionForwardingLocation,
-  getExistingPermissionForwardingLocation,
-  listRequestFiles,
-  logPermissionForwardingError,
-  logPermissionForwardingWarning,
-  readForwardedPermissionRequest,
-  readForwardedPermissionResponse,
-  safeDeleteFile,
-  sleep,
-  writeJsonFileAtomic,
-} from "./io";
-
-/**
- * Narrow context the forwarder reads: the UI gate (`hasUI`), the dialog UI
- * surface, and the three session-manager readers it uses directly or via
- * {@link isSubagentExecutionContext} / {@link getActiveAgentName}.
- *
- * `getSystemPrompt` is read reflectively (see `getContextSystemPrompt`), so it
- * is intentionally not a typed member. A full `ExtensionContext` satisfies this
- * structurally, so production callers pass `ctx` unchanged.
- */
-export interface ForwarderContext {
-  hasUI: boolean;
-  ui: PermissionDecisionUi;
-  sessionManager: {
-    getSessionId(): string;
-    getSessionDir(): string;
-    getEntries(): readonly SessionEntryView[];
-  };
-}
-
 /**
- * Constructor config for `PermissionForwarder`.
+ * Constructor config for `ApprovalEscalator`.
  *
  * Replaces the `PermissionForwardingDeps` interface that was previously
- * threaded into free functions in `polling.ts`.  The forwarder consumes it
+ * threaded into free functions in `polling.ts`.  The escalator consumes it
  * once at construction and stores each member as a private readonly field.
  */
-export interface PermissionForwarderDeps {
+export interface ApprovalEscalatorDeps {
   forwardingDir: string;
-  subagentSessionsDir: string;
-  /** Host platform, injected from the composition root, for subagent-context path detection. */
-  platform: NodeJS.Platform;
-  /** In-process subagent session registry for detection and forwarding target resolution. */
+  /** Single owner of subagent detection; gates the forward-vs-deny decision. */
+  detection: SubagentDetector;
+  /** In-process subagent session registry for forwarding target resolution. */
   registry?: SubagentSessionRegistry;
-  /** Event bus used for UI prompt broadcasts. */
-  events?: PermissionEventBus;
   logger: DebugReviewLogger;
   requestPermissionDecisionFromUi: (
     ui: PermissionDecisionUi,
@@ -90,23 +57,10 @@ export interface PermissionForwarderDeps {
     message: string,
     options?: RequestPermissionOptions,
   ) => Promise<PermissionPromptDecision>;
-  /** Read current config for the retained forwarded-inbox yolo auto-approve check. */
-  config: ConfigReader;
 }
 
 // ── Module-private helpers ────────────────────────────────────────────────
 
-function getSessionId(ctx: ForwarderContext): string {
-  try {
-    const sessionId = ctx.sessionManager.getSessionId();
-    if (typeof sessionId === "string" && sessionId.trim()) {
-      return sessionId.trim();
-    }
-  } catch {}
-
-  return "unknown";
-}
-
 function getContextSystemPrompt(ctx: ForwarderContext): string | undefined {
   const getSystemPrompt = toRecord(ctx).getSystemPrompt;
   if (typeof getSystemPrompt !== "function") {
@@ -128,27 +82,14 @@ function getContextSystemPrompt(ctx: ForwarderContext): string | undefined {
   }
 }
 
-function formatForwardedPermissionPrompt(
-  request: ForwardedPermissionRequest,
-): string {
-  const agentName = request.requesterAgentName || "unknown";
-  const sessionId = request.requesterSessionId || "unknown";
-  return [
-    `Subagent '${agentName}' requested permission.`,
-    `Session ID: ${sessionId}`,
-    "",
-    request.message,
-  ].join("\n");
-}
-
 // ── Public seam interfaces ────────────────────────────────────────────────
 
 /**
- * Narrow seam describing what `PermissionPrompter` needs from the forwarder:
+ * Narrow seam describing what `PermissionPrompter` needs from the escalator:
  * a single method that resolves a permission decision for the current context
  * (prompt directly when the session has UI, otherwise forward to the parent).
  *
- * Depending on the interface (not the concrete `PermissionForwarder`) keeps
+ * Depending on the interface (not the concrete `ApprovalEscalator`) keeps
  * the prompter's unit tests free of casts — they inject a plain
  * `{ requestApproval: vi.fn() }` mock.
  */
@@ -161,35 +102,20 @@ export interface ApprovalRequester {
   ): Promise<PermissionPromptDecision>;
 }
 
-/**
- * Narrow seam describing what `ForwardingManager` needs from the forwarder:
- * a single method that drains this session's forwarded-permission inbox.
- *
- * Depending on the interface (not the concrete `PermissionForwarder`) keeps
- * the manager's unit tests free of casts — they inject a plain
- * `{ processInbox: vi.fn() }` mock.
- */
-export interface InboxProcessor {
-  processInbox(ctx: ForwarderContext): Promise<void>;
-}
-
-// ── PermissionForwarder ───────────────────────────────────────────────────
+// ── ApprovalEscalator ────────────────────────────────────────────────
 
 /**
- * Owner of the forwarded-permission behavior.
+ * Owner of the escalation-up role of the forwarded-permission behavior.
  *
- * Holds all forwarding state as private readonly fields and provides two
- * public methods (`requestApproval`, `processInbox`) that together encapsulate
- * the full forwarding lifecycle: deciding whether to prompt directly or
- * forward to the parent, building and persisting request files, polling for
- * responses, and processing the parent-session inbox.
+ * Holds all forwarding state as private readonly fields and provides the
+ * public `requestApproval` method: deciding whether to prompt directly or
+ * forward to the parent, building and persisting request files, and polling
+ * for responses.
  */
-export class PermissionForwarder implements ApprovalRequester, InboxProcessor {
+export class ApprovalEscalator implements ApprovalRequester {
   private readonly forwardingDir: string;
-  private readonly subagentSessionsDir: string;
-  private readonly platform: NodeJS.Platform;
+  private readonly detection: SubagentDetector;
   private readonly registry: SubagentSessionRegistry | undefined;
-  private readonly events: PermissionEventBus | undefined;
   private readonly logger: DebugReviewLogger;
   private readonly requestPermissionDecisionFromUi: (
     ui: PermissionDecisionUi,
@@ -197,17 +123,13 @@ export class PermissionForwarder implements ApprovalRequester, InboxProcessor {
     message: string,
     options?: RequestPermissionOptions,
   ) => Promise<PermissionPromptDecision>;
-  private readonly config: ConfigReader;
 
-  constructor(deps: PermissionForwarderDeps) {
+  constructor(deps: ApprovalEscalatorDeps) {
     this.forwardingDir = deps.forwardingDir;
-    this.subagentSessionsDir = deps.subagentSessionsDir;
-    this.platform = deps.platform;
+    this.detection = deps.detection;
     this.registry = deps.registry;
-    this.events = deps.events;
     this.logger = deps.logger;
     this.requestPermissionDecisionFromUi = deps.requestPermissionDecisionFromUi;
-    this.config = deps.config;
   }
 
   // ── Public seam methods ────────────────────────────────────────────────
@@ -231,78 +153,13 @@ export class PermissionForwarder implements ApprovalRequester, InboxProcessor {
       );
     }
 
-    if (
-      !isSubagentExecutionContext(
-        ctx,
-        this.subagentSessionsDir,
-        this.platform,
-        this.registry,
-      )
-    ) {
+    if (!this.detection.isSubagent(ctx)) {
       return Promise.resolve({ approved: false, state: "denied" });
     }
 
     return this.waitForForwardedApproval(ctx, message, forwarded);
   }
 
-  /** Drain and respond to this session's forwarded-permission inbox. */
-  async processInbox(ctx: ForwarderContext): Promise<void> {
-    if (!ctx.hasUI) {
-      return;
-    }
-
-    const currentSessionId = getSessionId(ctx);
-    const location = getExistingPermissionForwardingLocation(
-      this.forwardingDir,
-      currentSessionId,
-    );
-    if (!location) {
-      return;
-    }
-
-    const requestFiles = listRequestFiles(this.logger, location.requestsDir);
-    if (requestFiles.length === 0) {
-      return;
-    }
-
-    // Defensively recreate responses/ before writing any response — a
-    // concurrent cleanup pass may have removed it between the requestsDir
-    // existence check above and the write inside processSingleForwardedRequest
-    // (the ENOENT write loop reported in issue #398).
-    if (
-      !ensureDirectoryExists(
-        this.logger,
-        location.responsesDir,
-        "permission forwarding responses",
-      )
-    ) {
-      return;
-    }
-
-    for (const fileName of requestFiles) {
-      const requestPath = join(location.requestsDir, fileName);
-      const request = readForwardedPermissionRequest(this.logger, requestPath);
-      if (!request) {
-        safeDeleteFile(
-          this.logger,
-          requestPath,
-          `${location.label} forwarded permission request`,
-        );
-        continue;
-      }
-
-      await this.processSingleForwardedRequest(
-        ctx,
-        request,
-        location,
-        requestPath,
-        currentSessionId,
-      );
-    }
-
-    cleanupPermissionForwardingLocationIfEmpty(this.logger, location);
-  }
-
   // ── Private methods ────────────────────────────────────────────────────
 
   private async waitForForwardedApproval(
@@ -313,12 +170,7 @@ export class PermissionForwarder implements ApprovalRequester, InboxProcessor {
     const requesterSessionId = getSessionId(ctx);
     const targetSessionId = resolvePermissionForwardingTargetSessionId({
       hasUI: ctx.hasUI,
-      isSubagent: isSubagentExecutionContext(
-        ctx,
-        this.subagentSessionsDir,
-        this.platform,
-        this.registry,
-      ),
+      isSubagent: this.detection.isSubagent(ctx),
       currentSessionId: requesterSessionId,
       env: process.env,
       sessionId: requesterSessionId,
@@ -472,122 +324,4 @@ export class PermissionForwarder implements ApprovalRequester, InboxProcessor {
     cleanupPermissionForwardingLocationIfEmpty(this.logger, location);
     return { approved: false, state: "denied" };
   }
-
-  private async processSingleForwardedRequest(
-    ctx: ForwarderContext,
-    request: ForwardedPermissionRequest,
-    location: PermissionForwardingLocation,
-    requestPath: string,
-    currentSessionId: string,
-  ): Promise<void> {
-    if (!isForwardedPermissionRequestForSession(request, currentSessionId)) {
-      logPermissionForwardingWarning(
-        this.logger,
-        `Ignoring forwarded permission request '${request.id}' because it targets session '${request.targetSessionId}' instead of '${currentSessionId}'`,
-      );
-      safeDeleteFile(
-        this.logger,
-        requestPath,
-        `${location.label} forwarded permission request`,
-      );
-      return;
-    }
-
-    const forwardedPermissionLogDetails = {
-      requestId: request.id,
-      source: location.label,
-      requesterAgentName: request.requesterAgentName,
-      requesterSessionId: request.requesterSessionId,
-      targetSessionId: request.targetSessionId,
-      requestPath,
-    };
-
-    let decision: PermissionPromptDecision = {
-      approved: false,
-      state: "denied",
-    };
-    // Last yolo check outside the composed ruleset: dissolves when
-    // processInbox is refactored onto evaluate() + Authorizer selection in
-    // the Phase 9 spine work.
-    if (isYoloModeEnabled(this.config.current())) {
-      this.logger.review(
-        "forwarded_permission.auto_approved",
-        forwardedPermissionLogDetails,
-      );
-      decision = { approved: true, state: "approved" };
-    } else {
-      this.logger.review(
-        "forwarded_permission.prompted",
-        forwardedPermissionLogDetails,
-      );
-      try {
-        const forwardedMessage = formatForwardedPermissionPrompt(request);
-        if (this.events) {
-          emitUiPromptEvent(
-            this.events,
-            buildForwardedUiPrompt({
-              requestId: request.id,
-              message: forwardedMessage,
-              requesterAgentName: request.requesterAgentName || null,
-              requesterSessionId: request.requesterSessionId || null,
-              source: request.source ?? null,
-              surface: request.surface ?? null,
-              value: request.value ?? null,
-            }),
-          );
-        }
-        decision = await this.requestPermissionDecisionFromUi(
-          ctx.ui,
-          "Permission Required (Subagent)",
-          forwardedMessage,
-        );
-      } catch (error) {
-        logPermissionForwardingError(
-          this.logger,
-          "Failed to show forwarded permission confirmation dialog",
-          error,
-        );
-        decision = { approved: false, state: "denied" };
-      }
-    }
-
-    const responsePath = join(location.responsesDir, `${request.id}.json`);
-    this.logger.review(
-      decision.approved
-        ? "forwarded_permission.approved"
-        : "forwarded_permission.denied",
-      {
-        requestId: request.id,
-        source: location.label,
-        requesterAgentName: request.requesterAgentName,
-        requesterSessionId: request.requesterSessionId,
-        targetSessionId: request.targetSessionId,
-        responsePath,
-        resolution: decision.state,
-        denialReason: decision.denialReason ?? null,
-      },
-    );
-    try {
-      writeJsonFileAtomic(this.logger, responsePath, {
-        approved: decision.approved,
-        state: decision.state,
-        denialReason: decision.denialReason,
-        responderSessionId: currentSessionId,
-        respondedAt: Date.now(),
-      } satisfies ForwardedPermissionResponse);
-    } catch (error) {
-      logPermissionForwardingError(
-        this.logger,
-        `Failed to write ${location.label} forwarded permission response '${responsePath}'`,
-        error,
-      );
-      return;
-    }
-
-    safeDeleteFile(
-      this.logger,
-      requestPath,
-      `${location.label} forwarded permission request`,
-    );
-  }
 }