@gotgenes/pi-permission-system 13.2.0 → 14.0.0

package/CHANGELOG.md

@@ -5,6 +5,23 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [14.0.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v13.2.0...pi-permission-system-v14.0.0) (2026-06-17)
+
+
+### ⚠ BREAKING CHANGES
+
+* project agents' `permission:` frontmatter at `<cwd>/.pi/agents/<name>.md` is now read and enforced. Previously the wrong directory (`<cwd>/.pi/agent/agents`) was checked and the frontmatter was silently ignored, so a session may become more restrictive on upgrade.
+
+### Bug Fixes
+
+* correct project agents directory path to &lt;cwd&gt;/.pi/agents ([#428](https://github.com/gotgenes/pi-packages/issues/428)) ([eb5af78](https://github.com/gotgenes/pi-packages/commit/eb5af78193fa3cc574da6b8d80efd643ebce0ef9))
+
+
+### Documentation
+
+* correct project agent override path to &lt;cwd&gt;/.pi/agents ([#428](https://github.com/gotgenes/pi-packages/issues/428)) ([d193d6a](https://github.com/gotgenes/pi-packages/commit/d193d6a61155fb4e4a064800509cdbbd84b0ceb9))
+* fix stale project agents path in troubleshooting and ADR-0001 ([#428](https://github.com/gotgenes/pi-packages/issues/428)) ([95effeb](https://github.com/gotgenes/pi-packages/commit/95effebfd0b2e87db4512c91adc134b2470f26a3))
+
 ## [13.2.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v13.1.2...pi-permission-system-v13.2.0) (2026-06-17)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "13.2.0",
+  "version": "14.0.0",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "exports": {

package/src/config-paths.ts

@@ -21,6 +21,19 @@ export function getProjectConfigPath(cwd: string): string {
   return join(cwd, ".pi", "extensions", EXTENSION_ID, "config.json");
 }
 
+/**
+ * Directory holding project-scoped custom agent definition files.
+ *
+ * `<cwd>/.pi/agents` is a Pi platform convention, also encoded by
+ * `@gotgenes/pi-subagents`' `loadCustomAgents` (`config/custom-agents.ts`).
+ * The two packages encode it independently — pi-permission-system has no
+ * dependency on pi-subagents (ADR-0002) — so this is this package's
+ * authoritative copy.
+ */
+export function getProjectAgentsDir(cwd: string): string {
+  return join(cwd, ".pi", "agents");
+}
+
 export function getLegacyGlobalPolicyPath(agentDir: string): string {
   return join(agentDir, "pi-permissions.jsonc");
 }

package/src/permission-manager.ts

@@ -1,6 +1,10 @@
 import { join } from "node:path";
 import { isPermissionState } from "./common";
-import { getGlobalConfigPath, getProjectConfigPath } from "./config-paths";
+import {
+  getGlobalConfigPath,
+  getProjectAgentsDir,
+  getProjectConfigPath,
+} from "./config-paths";
 import { normalizeInput } from "./input-normalizer";
 import { normalizeFlatConfig } from "./normalize";
 import { PATH_SURFACES } from "./path-utils";
@@ -350,7 +354,7 @@ function derivePolicyLoaderOptions(
     globalConfigPath: getGlobalConfigPath(agentDir),
     agentsDir: join(agentDir, "agents"),
     projectGlobalConfigPath: cwd ? getProjectConfigPath(cwd) : undefined,
-    projectAgentsDir: cwd ? join(cwd, ".pi", "agent", "agents") : undefined,
+    projectAgentsDir: cwd ? getProjectAgentsDir(cwd) : undefined,
   };
 }
 

package/test/config-paths.test.ts

@@ -9,6 +9,7 @@ import {
   getLegacyExtensionConfigPath,
   getLegacyGlobalPolicyPath,
   getLegacyProjectPolicyPath,
+  getProjectAgentsDir,
   getProjectConfigPath,
   REVIEW_LOG_FILENAME,
 } from "#src/config-paths";
@@ -42,6 +43,10 @@ describe("config-paths", () => {
         join(cwd, ".pi", "extensions", "pi-permission-system", "config.json"),
       );
     });
+
+    it("getProjectAgentsDir returns .pi/agents under cwd", () => {
+      expect(getProjectAgentsDir(cwd)).toBe(join(cwd, ".pi", "agents"));
+    });
   });
 
   describe("legacy paths", () => {

package/test/permission-manager-unified.test.ts

@@ -8,7 +8,11 @@ import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { homedir, tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import { describe, expect, it, test } from "vitest";
-import { getGlobalConfigPath, getProjectConfigPath } from "#src/config-paths";
+import {
+  getGlobalConfigPath,
+  getProjectAgentsDir,
+  getProjectConfigPath,
+} from "#src/config-paths";
 import {
   PermissionManager,
   type ScopedPermissionManager,
@@ -1669,6 +1673,53 @@ describe("PermissionManager — configureForCwd and agentDir option", () => {
       cleanup();
     }
   });
+
+  it("configureForCwd(cwd) derives projectAgentsDir at <cwd>/.pi/agents (regression: #428)", () => {
+    // Bug: old code derived <cwd>/.pi/agent/agents instead of <cwd>/.pi/agents.
+    // This test pins the correct path and verifies agentsDir is unchanged.
+    const { agentDir, cwd, cleanup } = makeAgentDirSetup({
+      globalPermission: { read: "allow" },
+    });
+    try {
+      const manager = new PermissionManager({ agentDir });
+      manager.configureForCwd(cwd);
+      const paths = manager.getResolvedPolicyPaths();
+      expect(paths.projectAgentsDir).toBe(getProjectAgentsDir(cwd));
+      expect(paths.agentsDir).toBe(join(agentDir, "agents"));
+    } finally {
+      cleanup();
+    }
+  });
+
+  it("configureForCwd(cwd) enforces permission: frontmatter from <cwd>/.pi/agents/<agent>.md (regression: #428)", () => {
+    // Bug: wrong directory meant project-agent frontmatter was never loaded.
+    const { agentDir, cwd, cleanup } = makeAgentDirSetup({
+      globalPermission: { read: "allow" },
+    });
+    try {
+      // Write a project agent definition with a deny override.
+      const projectAgentsDir = getProjectAgentsDir(cwd);
+      mkdirSync(projectAgentsDir, { recursive: true });
+      writeFileSync(
+        join(projectAgentsDir, "coder.md"),
+        "---\npermission:\n  read: deny\n---\n# Coder\n",
+      );
+
+      const manager = new PermissionManager({ agentDir });
+      manager.configureForCwd(cwd);
+
+      // Without an agent name: global allow applies.
+      expect(manager.checkPermission("read", { path: "foo.txt" }).state).toBe(
+        "allow",
+      );
+      // With the "coder" agent: project-agent deny overrides global allow.
+      expect(
+        manager.checkPermission("read", { path: "foo.txt" }, "coder").state,
+      ).toBe("deny");
+    } finally {
+      cleanup();
+    }
+  });
 });
 
 // ---------------------------------------------------------------------------